[{"id":25227,"web_url":"https://patchwork.libcamera.org/comment/25227/","msgid":"","date":"2022-10-03T08:56:54","subject":"Re: [libcamera-devel] [PATCH v3 0/7] Raspberry Pi AGC digital gain\n\tfixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nAny chance of another review for this one please?\n\nThanks,\nNaush\n\nOn Mon, 26 Sept 2022 at 10:57, Naushir Patuck wrote:\n\n> Hi,\n>\n> Version 3 of this series addresses the comments from Umang and David -\n> mostly\n> minor typos, and a simplification to the new Metadata:mergeCopy() function.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (7):\n> delayed_controls: Template the ControlRingBuffer class\n> delayed_controls: Add user cookie to DelayedControls\n> tests: delayed_controls: Add cookie value test\n> ipa: raspberrypi: Add RPiController::Metadata::mergeCopy\n> ipa: raspberrypi: Use an array of RPiController::Metadata objects\n> pipeline: ipa: raspberrypi: Use IPA cookies\n> ipa: raspberrypi: agc: Fix digital gain calculation for manual mode\n>\n> include/libcamera/internal/delayed_controls.h | 21 +++--\n> include/libcamera/ipa/raspberrypi.mojom | 3 +-\n> src/ipa/raspberrypi/controller/metadata.h | 10 +++\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 ++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 82 ++++++++++++-------\n> src/libcamera/delayed_controls.cpp | 20 +++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 12 +--\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +-\n> test/delayed_controls.cpp | 52 +++++++++++-\n> 10 files changed, 156 insertions(+), 60 deletions(-)\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B104BD16B\n\tfor ;\n\tMon, 3 Oct 2022 08:57:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F06FC62CD8;\n\tMon, 3 Oct 2022 10:57:12 +0200 (CEST)","from mail-lf1-x136.google.com (mail-lf1-x136.google.com\n\t[IPv6:2a00:1450:4864:20::136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CACB61F74\n\tfor ;\n\tMon, 3 Oct 2022 10:57:11 +0200 (CEST)","by mail-lf1-x136.google.com with SMTP id 25so5330179lft.9\n\tfor ;\n\tMon, 03 Oct 2022 01:57:11 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664787433;\n\tbh=c8cfRlaETK2WbBsYfA2Sovncf8tl3XS4wzJcQWxtBnA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YVRBcVFGg0SQrvWQs8ZOge7jWY5SZFWY5+t64KCdJz1FPtVzSLds8Tm8N83W19w3T\n\texIhRVks1IfluYBcfzttLJ7vmIjAVQyVkRsT1+o2ZkutCTXD2bHeoS1bUSxaxL1sj5\n\teISPUxuUOKpxH6SI6SC3tGli9EC0Ue+bYwN8LjJV8kHNiCk/PUBERlEO7uzIeQYyRf\n\tNj3bw71kK24gNxG+U78okqArMNOQgKdBDbVYPxNhWr7/qwVmS4G4x8lKKCc0QpkBJY\n\tHEfugM1SL5zSyolQSW8nGIreo3Clj9grZf8vUUsLbnQEcPMDN1Jj9Vy0Sdh6XyitMo\n\tVf4a+LHAgG+Uw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date;\n\tbh=uQkqUdpFlmpq+XnNNvHb4uCqXAJQDG/HPo4NeterGbg=;\n\tb=BqTcFfSnuc6l0QGXpYh3VHA9e2LLBMhLDOvEuxcrkOyePk/z+H8u3o42QwpBpBqToS\n\t498hxDVm2v1sScSS63SUyX2yRE4IxT6wXKo4D7P883Bd56+zMYSC6YuDj3d2kaOxLz9y\n\tLrXbAiGjYvFUAUDl/jrY7KqonrOrScJyZQQ1K5MZhLfep/osOAwB+lhBVG5xCCoQ8bPP\n\t5NKGmeL7kHdDo1tu9qzy8I3z3Pduj6PJGlhNrWHLqrEXVq+A24Kf1G38waa/klMgANtv\n\ti7TPeFvDvRKwOI1cDp3z5cTiLqExh+2pvaYRvOFjkrzO5ZmL26eNffDhv3rvUL6XleZb\n\tuEEw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"BqTcFfSn\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date;\n\tbh=uQkqUdpFlmpq+XnNNvHb4uCqXAJQDG/HPo4NeterGbg=;\n\tb=GjakYtaJ7wGRQXbxBRsDxUX5+2HT3DPauN0MJo55cZ0+zl4qpjq8BoqDm0wC1cYi3K\n\t+Z6WuVF7/2G8D5Umn/ofahUCWqzhuBQvbFHPc9iLDvadGyDbPukmpq0GYS1WDblFjIZv\n\tuCMa4Y+8p9AHe3PCgoun6t3NVBSiI1gdoO5z/4retddGrPc7k7ejmI40OSJWbnJCE/yD\n\tFU5vQcWOQbQmvn3CkvIFn/i4gz4MN0WnSAxn8S724Lj7hTpyduJ3XMM4xUohkNRhmQ5X\n\tqSIqFJIjxvXqypkOIxh/8cPm4cO9zOMPm0NhyA4kBgX1lyMwnR5b4puSqA1PNVbjAFst\n\tQMIg==","X-Gm-Message-State":"ACrzQf3I66e75t68rp3i4YfK7TQiajqobp71vJmIXMfX9KvQswyao2Lr\n\tfA4ixoNm2H+7rZK6FAdeVzpOOdQvlZynJYGYIi4qANgs9R/Tgg==","X-Google-Smtp-Source":"AMsMyM4YBRMOENELJb2weBxeYy21agWdcjMe049VuPDBCHrKJsdBF89wcWr3pbRl2QbszBbPXYxnlLAVMRybBfo1OgQ=","X-Received":"by 2002:ac2:4c03:0:b0:4a2:2273:89c6 with SMTP id\n\tt3-20020ac24c03000000b004a2227389c6mr2950664lfq.245.1664787430063;\n\tMon, 03 Oct 2022 01:57:10 -0700 (PDT)","MIME-Version":"1.0","References":"<20220926095737.30506-1-naush@raspberrypi.com>","In-Reply-To":"<20220926095737.30506-1-naush@raspberrypi.com>","Date":"Mon, 3 Oct 2022 09:56:54 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000655a8605ea1d871c\"","Subject":"Re: [libcamera-devel] [PATCH v3 0/7] Raspberry Pi AGC digital gain\n\tfixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]