[{"id":25108,"web_url":"https://patchwork.libcamera.org/comment/25108/","msgid":"","date":"2022-09-23T08:15:21","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Raspberry Pi: Timeout error\n\thandling","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nAny chance I can get a second review on this change please?\n\nregards,\nNaush\n\nOn Wed, 21 Sept 2022 at 09:03, Naushir Patuck wrote:\n\n> Hi,\n>\n> Minor changes in version 2:\n> - Fixed a typo.\n> - Added an isRunning() helper to check the pipeline handler state.\n>\n> Regards,\n> Naush\n>\n> Naushir Patuck (2):\n> pipeline: raspberrypi: Add an error state\n> pipeline: raspberrypi: Improve Unicam timeout handling\n>\n> .../pipeline/raspberrypi/raspberrypi.cpp | 33 ++++++++++++++-----\n> 1 file changed, 25 insertions(+), 8 deletions(-)\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2859CBD16B\n\tfor ;\n\tFri, 23 Sep 2022 08:15:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C7E96222A;\n\tFri, 23 Sep 2022 10:15:40 +0200 (CEST)","from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com\n\t[IPv6:2a00:1450:4864:20::12b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A838621BC\n\tfor ;\n\tFri, 23 Sep 2022 10:15:38 +0200 (CEST)","by mail-lf1-x12b.google.com with SMTP id o2so18579370lfc.10\n\tfor ;\n\tFri, 23 Sep 2022 01:15:38 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663920940;\n\tbh=y2T40uwgZ5e5lrrGdJH8Xa0wTMq40yTQqhTb5rd+Hv4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=2Ak9vTwkcQiGAfwJHdi3iBzHRFi5MSJN37Cx4F5ccGIanko8ByVRoz6KypOiAuKXx\n\taxuSfXJQfi6MPSOGcNITI8pwom6In+lORt+N/O6mCWLWO2wxHCFSkOBvnnSM4B+CNi\n\tXwsnevaiEZLU+X6QECei3uydySHdhpEzaObCRMVXmkYHiWPWzFCXH1AbED3g4nm7cG\n\txA5lxSMn0clqxF4DcNnJQ8wFss/7NEubQTZc6Z6VEP8Xzt/XYFZYwA3EgAsz7UooHr\n\tl5+XtjNippKXfazqKKSSXcrL0v8BmGmivzz9pGhwUcovm76MDHMzyjfN7Lf5QEA+tk\n\tQH6/CdXpjxiWw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date;\n\tbh=9aaPsc//u4t4m9QL8XuIsDowcIEScA/FXM+0B7taZRM=;\n\tb=ODcObWiJS2bk9dU4JkSDGCDzEzyD9IG5TZQttoUwD2P4dCNjOsTDJ0qzfdj2jT/47a\n\tlPVhzrOwQzL7INB+XsVIcj+y9kyAwhy+R1tUmnOoWGyHZZfaZsg3jdyJIskstoX4RNGA\n\tsypa0WUY2xiGhwB9aWiPn+A9uNSheLjLPWU7DyiE8tXf7u979UNFVW9HTnnG+ZKZ1cKt\n\tFXfe7pVtW/x+WMvE9IDjtocLKZXralJXe8Qj/67lATux6Nw/f8PItDUZYBr7JI/InDKR\n\tjiH6COZmyXAzaj2eFYcbJM//PLWD/CpnaFtaouiFs8O6KRC6Cyai9sleyHMWLmGehInA\n\tOFjQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"ODcObWiJ\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date;\n\tbh=9aaPsc//u4t4m9QL8XuIsDowcIEScA/FXM+0B7taZRM=;\n\tb=K2CvNUfZBcA10WdSNg40oZqqjRsuPGD6OLnEEFHy0wo3Inme/zBRGyD91+cZTXzgzB\n\toUJvAApo5i7nn3FpOJBtpttttsQYLRyQwder/YZqbMWZWg4ivkCn09Ha2G0Vwp6f85At\n\tjzlzbnLo34tQarPE6PLCogvfdYDzCDlR+4LP9y7p7evfFDMANf+XTEf1x+iT3ysMA4pn\n\t6zKAglEHxEKt41HCgw9IrAT8zZY9eCKNSQbNkzxq27BPqI5ehTV1nLk9PiE9ZxiQ5rlN\n\te8qbG210InbsZXH5Zmeb3+xFXnKDFSXoFO5nyujhwFwAalAh+2j1YQLWMv3W5ZHL/+/4\n\t3pjw==","X-Gm-Message-State":"ACrzQf0/KPqN7zGum46lK71EHWinFIGfL5QTB1noIC3Wr1WCO3drcuPc\n\tlrG7P/+RL0hshOtxQtYRTJoWCbGX0Wwl0iqAJysOTCZBNLWz8w==","X-Google-Smtp-Source":"AMsMyM4OGF2UqJWLNSDxUVAVAkxyt0Scur3UWJLjN3ME5U5nckF8fFfDX4RtiejOgr978d3ZsSqsQptGsylfksFPbF8=","X-Received":"by 2002:a05:6512:3409:b0:499:faa6:edb0 with SMTP id\n\ti9-20020a056512340900b00499faa6edb0mr2571979lfr.682.1663920937219;\n\tFri, 23 Sep 2022 01:15:37 -0700 (PDT)","MIME-Version":"1.0","References":"<20220921080258.5268-1-naush@raspberrypi.com>","In-Reply-To":"<20220921080258.5268-1-naush@raspberrypi.com>","Date":"Fri, 23 Sep 2022 09:15:21 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"00000000000065d21005e953c876\"","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Raspberry Pi: Timeout error\n\thandling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25120,"web_url":"https://patchwork.libcamera.org/comment/25120/","msgid":"<166393463705.3974115.10864567456188423257@Monstersaurus>","date":"2022-09-23T12:03:57","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Raspberry Pi: Timeout error\n\thandling","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-09-23 09:15:21)\n> Hi all,\n> \n> Any chance I can get a second review on this change please?\n\nPushed with David's review.\n\nThanks\n\nKieran\n\n\n> \n> regards,\n> Naush\n> \n> On Wed, 21 Sept 2022 at 09:03, Naushir Patuck wrote:\n> \n> > Hi,\n> >\n> > Minor changes in version 2:\n> > - Fixed a typo.\n> > - Added an isRunning() helper to check the pipeline handler state.\n> >\n> > Regards,\n> > Naush\n> >\n> > Naushir Patuck (2):\n> > pipeline: raspberrypi: Add an error state\n> > pipeline: raspberrypi: Improve Unicam timeout handling\n> >\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 33 ++++++++++++++-----\n> > 1 file changed, 25 insertions(+), 8 deletions(-)\n> >\n> > --\n> > 2.25.1\n> >\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E9F8BD16B\n\tfor ;\n\tFri, 23 Sep 2022 12:04:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5E646223D;\n\tFri, 23 Sep 2022 14:04:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CD7A62239\n\tfor ;\n\tFri, 23 Sep 2022 14:04:00 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A24294F7;\n\tFri, 23 Sep 2022 14:03:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663934641;\n\tbh=uQiZ7uechZqVHnAnhdnS6wvWzCqi1uXMxfKarex7isY=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YPBuvsWfPi59IlqrOXNQSxNdK9+WiOMNJnkiPuFstGacDnb8iw7yUAWSQf32svLpW\n\tjzbmwy4BeI1Cm8S9CSQHo/WjxcffRElhHrArWLxcVStMnbTee/TociiC7ocEac8KbV\n\trkVgyazgefS0Nr67BpcEtkisR0BfPhWkcvdtgBIj42mNZKWW6+VipnuQrM0SJRwx/d\n\tw3rqKKfZZqiaypbRkwkB4GyQv4zGb9OqK2ZyE3mh8GKIQ7xM2oYU49Kg0n1LmrxH+J\n\tVk4g6fvw2ObCt/AbrwXofLKxnaKUQ1UE2y76iaHEkbKJyWGTkM02H9ebLuvH9HCC2X\n\tw945srKx/SbMg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663934639;\n\tbh=uQiZ7uechZqVHnAnhdnS6wvWzCqi1uXMxfKarex7isY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=J3Fanr2q6Om+04cAcPJ+wjyDUwCe6M7iMUwEVDZ9p+VLxjOuvrz34Xd6m8mqyp3j8\n\t0d3X3gi9lTfuo73ChGTiVhFRoqndIxYbe634869Q1f7lyKK7HVovXIXwb3Wl/IvM3Y\n\t0d/TJH583Jwi7c3f10wcAvL2Szz8+EPaHVPtg5Qs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"J3Fanr2q\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220921080258.5268-1-naush@raspberrypi.com>\n\t","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 23 Sep 2022 13:03:57 +0100","Message-ID":"<166393463705.3974115.10864567456188423257@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Raspberry Pi: Timeout error\n\thandling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]