{"id":17371,"url":"https://patchwork.libcamera.org/api/covers/17371/?format=json","web_url":"https://patchwork.libcamera.org/cover/17371/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220916100517.12446-1-naush@raspberrypi.com>","date":"2022-09-16T10:05:15","name":"[libcamera-devel,v1,0/2] Raspberry Pi: Timeout error handling","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/17371/mbox/","series":[{"id":3488,"url":"https://patchwork.libcamera.org/api/series/3488/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3488","date":"2022-09-16T10:05:15","name":"Raspberry Pi: Timeout error handling","version":1,"mbox":"https://patchwork.libcamera.org/series/3488/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/17371/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42E1EC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Sep 2022 10:05:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AE7B61FB3;\n\tFri, 16 Sep 2022 12:05:26 +0200 (CEST)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6D1D6099B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Sep 2022 12:05:24 +0200 (CEST)","by mail-wr1-x42c.google.com with SMTP id t14so35213418wrx.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Sep 2022 03:05:24 -0700 (PDT)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\te13-20020adfa74d000000b002286231f479sm4632026wrd.50.2022.09.16.03.05.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 16 Sep 2022 03:05:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663322726;\n\tbh=vWlhtmXIUqazqzyQj+ma7XXUuopD884dKAV4nw7FSGA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=uVwB2UYJ8Q6TaV/tVg8vSV48PFttoNOM9WtsbFqvVUxvwZt+2zhvgu7wbohyky43K\n\tROwMlXxDJT/Yqd0JfIyJ8L5Jip8OtqJSoC3N5JS/4gEUwLVrLSQYBsLdx5/kNPczQc\n\tJ701LhIfYN3TBIPKt+4jyfGNN9CZjvyUoF9LbJXcrd3QDBXbrm6jzVJ+qXb3xU8/qg\n\td1NnUP1zEfalLhA0qoP0TGDjNsy0YSLRIZ7ufAsaaYPOjWex0otAck8WTMGCFL22Ny\n\tKEEhwArJ4h5Y2Do7+lbhvFJyOYf/QiZthhdrBvd5f1pgHQWUEEcXxzQ53boJfyD4f2\n\tcja8yRzb58Y5A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date;\n\tbh=Dsc486lb2iXB294yQN1TDBIb5h9BpjC4YRl/8ZRBmnA=;\n\tb=tSJTczV0WDlQ/w7oiMMScOIBR3maXol6BU/AFC2HTrjzqhb6kr3Jdswzxx6C/EYCg6\n\tNaS5/PbKsTJz7S0VGVhOx09lTs9nW9ytvl4po9LCfE0X1ukAgvrLnTjUCe9vKNqVa9Tu\n\tpf7thWY+oKGjQbEE3JzkW8vOOEhL9k+c0h2uJ8HYOvKBi1YfjhyMavwBG6h7xDcHTVXN\n\tcCueuivKk9GHV7nr0Z5srT2DMjPlYwAX8pcclO1ttFuhmYconXY0oYZJBi1EyTOqzEmM\n\tjX3HgsTdRJ8qcf9VH3p2bjwtBzrZOFrAkQ5dp0BkzKGfo4wXJ/nVWklKoe/l2d6ia5FW\n\tbU5Q=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"tSJTczV0\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date;\n\tbh=Dsc486lb2iXB294yQN1TDBIb5h9BpjC4YRl/8ZRBmnA=;\n\tb=dPqoXGmOI0MLdICwyFonJCHoSe1YUYqfsWiSSQorbvXw4DLTGxAOTGKai2yfC1roqD\n\t518wFaR2f6jotq9a7JHotMaj5e1X/ksL5tcPwdIcVz8GLaorH+3LJr0kgopjv920raTJ\n\t6yc0wvceOm2abPi3EJcpdTuKGuKJiQdj8HmsIbMpqDtNTmM/hbxBL+cq1SXEWMk8HLn5\n\t/PkPkzI1XYpXSTg0i013BsEE5sISoM8eZXgQzBNtcgSLrAECutmti9p2XdlzwkYGNAKD\n\tzUQWElIpyXLB0oEVzrJ6MLV50mKVs1BYYupjGyKfx7go2fpZFT3QJO89QgaRVDegqhE1\n\tP0+w==","X-Gm-Message-State":"ACrzQf3d5XHR0fOkYxBipUjdBAMut1tlaFnSfwRb+ZphBB6WMW1/U/Uu\n\tXH0aQC6LFRoDPyYux9SU8xb4h+ow9jJ1IsR1","X-Google-Smtp-Source":"AMsMyM4CxLwU0zyWXnEn4/6LbqaGQdrjpMslnCJQpH3iVpqQSVe+Eg/xAPNcIRC9VS2PnsYdtKKOdA==","X-Received":"by 2002:a5d:64e5:0:b0:22a:43a7:b9df with SMTP id\n\tg5-20020a5d64e5000000b0022a43a7b9dfmr2362589wri.79.1663322724322; \n\tFri, 16 Sep 2022 03:05:24 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 16 Sep 2022 11:05:15 +0100","Message-Id":"<20220916100517.12446-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 0/2] Raspberry Pi: Timeout error\n\thandling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi,\n\nThis small series attempts to improve our timeout handling.  We have been getting\nmore and more reports of ov5647 seemingly hitting the Unicam timeout condition,\nlikely due to a sensor fault. There is no error handling as such, simply a log\nmessage indicating a timeout occurred, then an application gets stalled.\n\nThis series improves the timeout handling by putting the pipeline handler in\nan error state, and cancelling any outstanding/future requests. The application\ncan then make a decision on what to do (either close down or attempt a restart)\nwhen these requests come back as cancelled when it was not expecting this.\n\nThanks,\nNaush\n\nNaushir Patuck (2):\n  pipeline: raspberrypi: Add an error state\n  pipeline: raspberrypi: Improve Unicam timeout handling\n\n .../pipeline/raspberrypi/raspberrypi.cpp      | 29 ++++++++++++++-----\n 1 file changed, 21 insertions(+), 8 deletions(-)"}