[{"id":24926,"web_url":"https://patchwork.libcamera.org/comment/24926/","msgid":"","date":"2022-09-05T10:56:37","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC\n\tcameras that expose no supported format","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the series,\n\nOn 9/3/22 11:40 PM, Laurent Pinchart via libcamera-devel wrote:\n> Hello,\n>\n> This patch series fixes a crash in the uvcvideo pipeline handler with\n> cameras that exposes only formats that are not supported by libcamera.\n> Patches 1/3 and 2/3 perform small refactoring, to prepare for patch 3/3\n> that fixes the crash by rejecting those cameras.\n>\n> Laurent Pinchart (3):\n> pipeline: uvcvideo: Move camera ID generation to UVCCameraData class\n> pipeline: uvcvideo: Cache supported formats in UVCCameraData\n> pipeline: uvcvideo: Fail match() if the camera has no supported format\n\nFor all the above patches,\n\nReviewed-by: Umang Jain \n\n>\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 200 ++++++++++---------\n> 1 file changed, 107 insertions(+), 93 deletions(-)\n>\n>\n> base-commit: 251f0534b74bcb46c777aa0df34b1b4142b664f5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D52F2C3272\n\tfor ;\n\tMon, 5 Sep 2022 05:31:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 587526204D;\n\tMon, 5 Sep 2022 07:31:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 140286041F\n\tfor ;\n\tMon, 5 Sep 2022 07:30:58 +0200 (CEST)","from [IPV6:2401:4900:1f3f:3b55:213a:3c32:c7d0:be1e] (unknown\n\t[IPv6:2401:4900:1f3f:3b55:213a:3c32:c7d0:be1e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBDD24A8;\n\tMon, 5 Sep 2022 07:30:56 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662355860;\n\tbh=Qi0JVTc0DDIq/nxQVHFYmsC1kQvOoBDK8uOLW0czfkE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=W1jqCNflLmsuLZnCZPYvYxb2bs+m/24CV0RVmSTKkf+obk/mSNi4Et5hZxvEM1eXz\n\tgGZU7x3pf029vPG9LMuQeXDrTpkAjMNieSwTKcc2oY973osvImfgmS58CScjYNVsZc\n\twKFCeTc47FP4ejIbldZthMdh8auSr1JEwfKBnCh+ov/uh5/7gQvZyGoKGCzPJT3Wvg\n\tF6IfpgiTcHh1rFoWGjnYDnPSYd4/BDtYluzi2riBMWebCwMW+tcz+304KpeP4szrd9\n\tEbCF1Fb6jSBK4JDLc/WNTJhruq+Rijl48xCSxZBg07nR3ktcSETuKHOsFU0USU7D6D\n\tFkj9JYfA2DKiw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662355857;\n\tbh=Qi0JVTc0DDIq/nxQVHFYmsC1kQvOoBDK8uOLW0czfkE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Vzjeq4YCfVL46+L//nQEeqaxfcauLITUx5a9xSna1gq0OuXwlB2jwCBAsDpZ971LR\n\tiH2UsFPq72G0oj/PZVKDTdtNL/lq33n4cpIC0dQ4HniVBSig++UF6sWFhRTmbHrQ74\n\t0psVcPxPxudRX3eDsvii7K9sklsyPjD7K3muh9+M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Vzjeq4YC\"; dkim-atps=neutral","Message-ID":"","Date":"Mon, 5 Sep 2022 16:26:37 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220903181037.1406-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220903181037.1406-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC\n\tcameras that expose no supported format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24945,"web_url":"https://patchwork.libcamera.org/comment/24945/","msgid":"","date":"2022-09-05T22:31:19","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC\n\tcameras that expose no supported format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Christian,\n\nWould you be able to test that this series fixes the issue you're\nexperiencing ? If so, can I add your Tested-by ?\n\nOn Sat, Sep 03, 2022 at 09:10:34PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Hello,\n> \n> This patch series fixes a crash in the uvcvideo pipeline handler with\n> cameras that exposes only formats that are not supported by libcamera.\n> Patches 1/3 and 2/3 perform small refactoring, to prepare for patch 3/3\n> that fixes the crash by rejecting those cameras.\n> \n> Laurent Pinchart (3):\n> pipeline: uvcvideo: Move camera ID generation to UVCCameraData class\n> pipeline: uvcvideo: Cache supported formats in UVCCameraData\n> pipeline: uvcvideo: Fail match() if the camera has no supported format\n> \n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 200 ++++++++++---------\n> 1 file changed, 107 insertions(+), 93 deletions(-)\n> \n> \n> base-commit: 251f0534b74bcb46c777aa0df34b1b4142b664f5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80010C0DA4\n\tfor ;\n\tMon, 5 Sep 2022 22:31:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 828126207A;\n\tTue, 6 Sep 2022 00:31:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E00D762072\n\tfor ;\n\tTue, 6 Sep 2022 00:31:34 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 366526BC;\n\tTue, 6 Sep 2022 00:31:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662417096;\n\tbh=ayGida/0EMXFTDNZENAUIU3JcHkd1uWWPP7am8NAGFs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=o0XdvUBVtSxjdCW2oBbNSZXd5TPSg0Ysi4foCXQlWauWD4VWLhDYAC5xHN8dpRtKG\n\tRhrUYbaXUIxlYbJtQYoclSfGvcdnDG/ut+ehWYzhnKXG1H2BHmdqH9F5NfAmgAMjuu\n\tgE3lxC0f7x8P8uOP91T4NSxNnPqN5RQCU+WviO5lhEmfy6Xo9YyIK10SEzlD0jHYPb\n\tVWhn2yFdcxuzzCle5ib7n34luN7B7JQijNLSekcXW9LgQIuI0QUKf4f9D7cD0VnXhN\n\tqp3hc3k1HCvvVldXdWvbfeVxQdYKzw5NZYnMlDydTyi7g3/YGS8ZJ7Ikr8hE23+S6y\n\tMTlLlFcGdS/wA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662417094;\n\tbh=ayGida/0EMXFTDNZENAUIU3JcHkd1uWWPP7am8NAGFs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jV2uBP33bMGeSI1EggFPY5uWb0uP6sn0S9ag9E82uh6qzD0r/kGYkAB2ZX2WokhfP\n\tjhFGttmNTlujj2T/X1wx9Tl9kkaA9aK8AwRZ8+TqqGywDm9lneKljskvE94ZrfHYnD\n\teWZDApyQ3MTzg9uK9A+fuduyQA/HRG+BdYpDvYWg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jV2uBP33\"; dkim-atps=neutral","Date":"Tue, 6 Sep 2022 01:31:19 +0300","To":"Christian Rauch ","Message-ID":"","References":"<20220903181037.1406-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220903181037.1406-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC\n\tcameras that expose no supported format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24951,"web_url":"https://patchwork.libcamera.org/comment/24951/","msgid":"","date":"2022-09-06T18:10:06","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC\n\tcameras that expose no supported format","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi Laurent,\n\n\nAm 06.09.22 um 00:31 schrieb Laurent Pinchart:\n> Christian,\n>\n> Would you be able to test that this series fixes the issue you're\n> experiencing ? If so, can I add your Tested-by ?\n\nYour patch series works. For \"cam\" I get:\n\nERROR UVC uvcvideo.cpp:461 Camera [...] doesn't expose any supported format\nCamera 1 not found\nFailed to create camera session\n\nHowever, I found the message \"Camera 1 not found\" somehow misleading,\nsince the camera was found, but it just did not expose any supported format.\n\nCan I insert the \"Tested-by\" just here in the email?\n\nTested-by: Christian Rauch \n\nBest,\nChristian\n\n\n> On Sat, Sep 03, 2022 at 09:10:34PM +0300, Laurent Pinchart via libcamera-devel wrote:\n>> Hello,\n>>\n>> This patch series fixes a crash in the uvcvideo pipeline handler with\n>> cameras that exposes only formats that are not supported by libcamera.\n>> Patches 1/3 and 2/3 perform small refactoring, to prepare for patch 3/3\n>> that fixes the crash by rejecting those cameras.\n>>\n>> Laurent Pinchart (3):\n>> pipeline: uvcvideo: Move camera ID generation to UVCCameraData class\n>> pipeline: uvcvideo: Cache supported formats in UVCCameraData\n>> pipeline: uvcvideo: Fail match() if the camera has no supported format\n>>\n>> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 200 ++++++++++---------\n>> 1 file changed, 107 insertions(+), 93 deletions(-)\n>>\n>>\n>> base-commit: 251f0534b74bcb46c777aa0df34b1b4142b664f5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E1F5C0DA4\n\tfor ;\n\tTue, 6 Sep 2022 18:10:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A787E62085;\n\tTue, 6 Sep 2022 20:10:09 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE8DB6041F\n\tfor ;\n\tTue, 6 Sep 2022 20:10:07 +0200 (CEST)","from [192.168.0.158] ([88.152.184.103]) by mail.gmx.net (mrgmx105\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1Mt757-1pOGyU0snJ-00tV08 for\n\t; Tue, 06 Sep 2022 20:10:07 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662487809;\n\tbh=JpnGSmAym3NxGJv8jTmxE+Ed6y/ZhcHAUtTS9ENzvyI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vjIsIj1iHwjdVT1TZjNZFAEyv02iqqJJDLDLuwLrJDOn09170wf/862fINlJG6dFY\n\tcBL+loZ29oOqFZ5TRHAbNLEZ1RiVsyUuoVmhpvVF9wK66VqAy67fzemrec9c51YvNP\n\t1R8+fQUW2XgYpM3CAnbXP32OBWlWbxD0Sow1n5zO0zE/JTamHnU4jJXOz1OjUfGdaG\n\t5ZLTGJYyTGZ1OJ2uJ4/hHy3KsNUyxz+v6gyTgnpKa/7zmq0AqP4byV/v64gYbgwY91\n\tLTuDOwxcMV7gu2UtsDTeB/y/nFmG0TiO7F6E6VuOQqW8leirlxucbZbqRVnzc38zsF\n\t/vlp1s7bBZgow==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1662487807;\n\tbh=JpnGSmAym3NxGJv8jTmxE+Ed6y/ZhcHAUtTS9ENzvyI=;\n\th=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;\n\tb=OI1ekqejqNdpRKs1csBk0c9278xsSxRiajQL0BAP7G0YoTh8GKi7cEFAreaHq99pY\n\tBOuwy81J4zn+3ReXSoLNX5zex1i+47OW+K220KTi4r9/omjhZ9Ghl3czGeYLCva91z\n\tEzp0oySLrTQ14JeZ1iYCaUMQPJ+YE7xaw80Ayys0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"OI1ekqej\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Message-ID":"","Date":"Tue, 6 Sep 2022 20:10:06 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.11.0","Content-Language":"en-GB","To":"libcamera-devel@lists.libcamera.org","References":"<20220903181037.1406-1-laurent.pinchart@ideasonboard.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:swwUnuKVU+m6x2gymIR994Nuh6uLYtJsEwt4oc5sMn4i971VLxM\n\tBlBKWK0jx3TDxl3l7eRNce42Em5eVbSoyA4L0yWKU3RstSvjxZPbDGl/9pKquhkEVmTIfoz\n\tg4VdDwOllo5A65FLgS5SQTrt+AWeMM+tBbRTTpiEXMNc5I/8KloKjOT9X8STKMCfME2Pjni\n\t8OMqiSEURTP8AqQIOLWlw==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:QadjT/ZUqv0=:zK1QhFD4p5iqN6oJ0SlRLm\n\trDj9vq6suSwGjdYqofXcQ4MpycLabZzP7BIE2Wa+rzvqXcrXSlNYJIat4ATvrXjO2LZcgM1kI\n\tiMTY1Y44Y6jePgL/gYOmL0rZCJw4HPhLKV/nPsiY6u1nV0wYXszpogbcCwpoch+fQz+lPSHZ6\n\tfWv+PB33/8aNj1dC4F0ycQLv2SJ2VyjzGbNAZfmJRwT8fEDzzmJLF95NuBcp9y8UnqVFllSzI\n\tNrAxD7hNn2pdCObWujLk9Kyb+8LJrGuTd8A/1f6Gb4pQYFmprI4aU4mPaVsmzr6ZeO54Joz4o\n\tJOm7WKFFl9K+Vu/ZYc73A23NZvgzNteSV+SLPhKTHIldstZD2OXNtaxN8f9kHx+7hyWZPxJ8w\n\t8Q+VHLTw31XJmAs/6EVzbF55jNvz18vNTiZZfBLVxIpxsNqVgGrKI6qb4mk5SYRSmykMBDlro\n\t+lXZBYFX9GkNCfAz5ZTTbvDT43+ugj45JaclbyusUN9phI6PPWyiwdd193s5lg82J2FWVSv1/\n\tgQY0YmeMOGblzfwZacbLJ+/AwX7hHMKNKUtGEMaQhZ9f4+xRuUQvMVpzfgajR9WyBrklmwPq/\n\tKz2FLouiAOtLJy8KdXzR1R8xWuQ6kd0Kr8A2FmLtAUW7+jwh9BCz6t7hRxAtdolAmUZlAdNF6\n\tUqIZG5m5GGEHQovkDciBC6/J/lteSUGufBhPFQkc6cd5U1u0k6nYOVCyb6s9ARMGg1T+xH5Vh\n\thhIB7ig0Sat/BHiqxpUEpIc1Q/iDjV7afjjtG4DvfMA2qVJYD5UDmkswCAcNblXEZpf+gC2a0\n\thhikpBJpRR9MfaNCAV9b1rRKPVCLuFE0LOWEk41y5oAyEmC/Nb8vyoe26ynpx+fSFc+KtBl+L\n\tK4306hk254h0cUC1r52MwuYwyH7E7tacAh40ChYSg3yS2mzeOZXze0bdhJnzwcL2UgP38y3v1\n\takR/a8/LOzm9MTiUalBauz/t0jAJQCK9enQwXOnokwSP8HTGAgDugkukof5+cs+pJE64ztyZr\n\tIkX7ostVqJaZhKg9498zqn3imf83HIhuACL2I9wanuxJ7/aAUCpaPwQI30Wl9TWn/VmZaxWSy\n\tcZREAqrAinqeQUSomNlXSHLSu9oRTaH+lLYMCu+8JoOtU3gh6cYvShzh+IN0TrshjTyz63JY4\n\tB0XRY6i8sBS61KDiEu0qFYOzIh","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC\n\tcameras that expose no supported format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24952,"web_url":"https://patchwork.libcamera.org/comment/24952/","msgid":"","date":"2022-09-06T21:31:58","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC\n\tcameras that expose no supported format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nOn Tue, Sep 06, 2022 at 08:10:06PM +0200, Christian Rauch via libcamera-devel wrote:\n> Am 06.09.22 um 00:31 schrieb Laurent Pinchart:\n> > Christian,\n> >\n> > Would you be able to test that this series fixes the issue you're\n> > experiencing ? If so, can I add your Tested-by ?\n> \n> Your patch series works. For \"cam\" I get:\n> \n> ERROR UVC uvcvideo.cpp:461 Camera [...] doesn't expose any supported format\n> Camera 1 not found\n> Failed to create camera session\n> \n> However, I found the message \"Camera 1 not found\" somehow misleading,\n> since the camera was found, but it just did not expose any supported format.\n\nIt's two different layers. For libcamera, it has indeed found a UVC\ncamera, and figured out that it doesn't know how to use it, so libcamera\nhasn't created a Camera instance for it. From the point of view of the\napplication, there is thus no camera. I don't think exposing unusable\ncameras to applications would be a good idea.\n\n> Can I insert the \"Tested-by\" just here in the email?\n> \n> Tested-by: Christian Rauch \n\nYes, that's perfect. I'll add it to the commit messages and then push.\nThank you for testing.\n\n> > On Sat, Sep 03, 2022 at 09:10:34PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> >> Hello,\n> >>\n> >> This patch series fixes a crash in the uvcvideo pipeline handler with\n> >> cameras that exposes only formats that are not supported by libcamera.\n> >> Patches 1/3 and 2/3 perform small refactoring, to prepare for patch 3/3\n> >> that fixes the crash by rejecting those cameras.\n> >>\n> >> Laurent Pinchart (3):\n> >> pipeline: uvcvideo: Move camera ID generation to UVCCameraData class\n> >> pipeline: uvcvideo: Cache supported formats in UVCCameraData\n> >> pipeline: uvcvideo: Fail match() if the camera has no supported format\n> >>\n> >> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 200 ++++++++++---------\n> >> 1 file changed, 107 insertions(+), 93 deletions(-)\n> >>\n> >>\n> >> base-commit: 251f0534b74bcb46c777aa0df34b1b4142b664f5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EFECC3272\n\tfor ;\n\tTue, 6 Sep 2022 21:32:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D95A662086;\n\tTue, 6 Sep 2022 23:32:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 564096041F\n\tfor ;\n\tTue, 6 Sep 2022 23:32:14 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CD70478;\n\tTue, 6 Sep 2022 23:32:13 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662499935;\n\tbh=WpOmZkb5qQzYa+4vEwYqMTL5jlZuF3ThljNBBtIo1M4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MydTqv4zl/6YK5Ocwt3EKWLRnSxKql9N1QhODNr0Ao2iVmGtljqV9oEbXl7NSLLHR\n\tU3ongzBI/36Y5v3+KmrdTuopvR6RJ+hfV/sYfzOMhUugvh+vdMaxsuxt//JtK+FW1/\n\t1LLOAeTokkuExVighmsRaNDYobrjZawRot4KYdV0vaKlQbpOj8BdhuUtPkXX8e5kRN\n\ty3NOeXud+MeXv3QNTT77KCtp4LvjsU83XBG91dwKC3DaAIym0YjFSJIf+vobCzeSPu\n\trP4/bK8xVBJGhENpsu263lSI3tXy5k/4x4nG3o6qDiPk4DjvHdYk6NKRfaNG9aM2gx\n\t6rsOujBivhldg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662499933;\n\tbh=WpOmZkb5qQzYa+4vEwYqMTL5jlZuF3ThljNBBtIo1M4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=T3G5D72b1vOkwG7NKrvYgESBIFSky6GAuHbGZkkfKvsOLc85zqyLfsbwV6LppQpI4\n\to4lvaT3teyQXx5BbWn5z6s8AuQU5UzrKVZYeZXZmsTDvp+H//fCJgjyL7afx0RuiPj\n\tLdJ2Sx+gyjXKHYrvujKXOEMgb20l760zNEzbz+nw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"T3G5D72b\"; dkim-atps=neutral","Date":"Wed, 7 Sep 2022 00:31:58 +0300","To":"Christian Rauch ","Message-ID":"","References":"<20220903181037.1406-1-laurent.pinchart@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC\n\tcameras that expose no supported format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]