[{"id":24826,"web_url":"https://patchwork.libcamera.org/comment/24826/","msgid":"","date":"2022-08-30T01:13:08","subject":"Re: [libcamera-devel] [PATCH 0/3] Remove redundant calls to\n\tstd::string::c_str()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Marvin,\n\nThank you for the patch.\n\nOn Mon, Aug 29, 2022 at 08:58:46PM +0200, Marvin Schmidt via libcamera-devel wrote:\n> This is just a small series fixing three locations where std::string::c_str() is\n> used in a function call taking a std::string argument\n> \n> Marvin Schmidt (3):\n> test: camera: Remove redundant call of std::string::c_str()\n> ipa: ipu3: Remove redundant call of std::string::c_str()\n> ipa: rkisp1: Remove redundant call of std::string::c_str()\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> test/camera/camera_reconfigure.cpp | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 748CFC3272\n\tfor ;\n\tTue, 30 Aug 2022 01:13:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD77761FC0;\n\tTue, 30 Aug 2022 03:13:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F0E761F9C\n\tfor ;\n\tTue, 30 Aug 2022 03:13:18 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90B1B481;\n\tTue, 30 Aug 2022 03:13:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661821999;\n\tbh=qm5I6pxrdbxE+23X6TqpdOtzIoREKgjrw7Rj6AaqbWM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=IVQaJyDLrVt2BVufxxbClUmIi00lwlPBIjK9XlUfYVVY+JnabJucpatQD9Do/rlk7\n\tnJ+71HwzfC8vhVdLzvhzzORx2IgosU1U7i8GrpxCJUEqZYexci8lpyLommYgVcpFLJ\n\tBCNIIlI3P7UfCVuMSwE9waYynKs/gevnVXeU8E76p64oTjGwcA5U/yBSCxalls/g33\n\teyr9aKui5oOEnW6LFX11eRMXG1kAHIb4jAN1vvBLGOXZiHONVxSuNutOXZRCFTO761\n\tH/dLnIh6wYixVxGhb0DAStdzTaiOv7KIwccmZSAHHmOSY5D+N+2EhT5rr2dWBWLYZV\n\tcwAyZmompAo7g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661821997;\n\tbh=qm5I6pxrdbxE+23X6TqpdOtzIoREKgjrw7Rj6AaqbWM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MvRG1Tf7YCM+bW9OlGjuJxXV/NPWT2vI4AIttTeMFaSofVn1MvOorS6OApoQjAnEd\n\tdJzFkjew2qDdMnGf+X9aEVzclrbJQMU8BFWM4PkxpmzuDCUwtmXhaMowedOL2pPe9T\n\ticeL/yqWMYQF89/HdSQP9uTMhBpM+9MOl/f/rU0A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MvRG1Tf7\"; dkim-atps=neutral","Date":"Tue, 30 Aug 2022 04:13:08 +0300","To":"Marvin Schmidt ","Message-ID":"","References":"<20220829185849.1884517-1-marvin.schmidt1987@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220829185849.1884517-1-marvin.schmidt1987@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 0/3] Remove redundant calls to\n\tstd::string::c_str()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24832,"web_url":"https://patchwork.libcamera.org/comment/24832/","msgid":"<4bb1e9ab-c53b-751f-c985-0bb8b8dbea02@ideasonboard.com>","date":"2022-08-30T10:30:53","subject":"Re: [libcamera-devel] [PATCH 0/3] Remove redundant calls to\n\tstd::string::c_str()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nOn 8/30/22 6:43 AM, Laurent Pinchart via libcamera-devel wrote:\n> Hi Marvin,\n>\n> Thank you for the patch.\n>\n> On Mon, Aug 29, 2022 at 08:58:46PM +0200, Marvin Schmidt via libcamera-devel wrote:\n>> This is just a small series fixing three locations where std::string::c_str() is\n>> used in a function call taking a std::string argument\n>>\n>> Marvin Schmidt (3):\n>> test: camera: Remove redundant call of std::string::c_str()\n>> ipa: ipu3: Remove redundant call of std::string::c_str()\n>> ipa: rkisp1: Remove redundant call of std::string::c_str()\n> For the whole series,\n>\n> Reviewed-by: Laurent Pinchart \n\nSame,\n\nReviewed-by: Umang Jain \n>\n>> src/ipa/ipu3/ipu3.cpp | 2 +-\n>> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n>> test/camera/camera_reconfigure.cpp | 2 +-\n>> 3 files changed, 3 insertions(+), 3 deletions(-)\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34DACC0DA4\n\tfor ;\n\tTue, 30 Aug 2022 10:31:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62E8D61FBD;\n\tTue, 30 Aug 2022 12:31:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B94361F9C\n\tfor ;\n\tTue, 30 Aug 2022 12:31:02 +0200 (CEST)","from [IPV6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a] (unknown\n\t[IPv6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 50F5D481;\n\tTue, 30 Aug 2022 12:31:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661855463;\n\tbh=Gv0JQO2YsjlsrOUidTh96BS8lEGrEa1HZLbN/PhmwqI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dalKWVrUBzbw5TkzuadILBQwonX+q3YQp9s8GrntJV7UMT13sGDs2ROl9xCW25v5H\n\twnIhmJBI4hbi/RaogesCzh8W4S/fodFoL8rbYZooTgMQ0l7qOw8wqp4adis056v8VV\n\tKsW+hcDXujaPgX4vlj9oO4Ajq4m2g1bjuqme5D6NfLy2zumGx6/ujq5BhbOsZTrXPW\n\tE+E4q4vAIidrEisejSVN1mi+Br/saakQM2g4xn4AqNwDiHZSNWD+7EwxuAfHd3N8Zg\n\taspg/wovwbgs4bRG3Wa0d4KXgikhtDy9Ahywh9VYWcIYEg9Gj4Stb+gzg+23FGE5YA\n\tDyMXiK5BOq7bg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661855461;\n\tbh=Gv0JQO2YsjlsrOUidTh96BS8lEGrEa1HZLbN/PhmwqI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=N4IDJIG5pBL9KMz3cZkpxiVg35xICSVNXSmMCTJUkh4ck24xy34xs8CDunICurL6T\n\t7t44rm9TtnrSiLO9ghKbptB1vnUzCRTGYJT266xPaCK6/4irSuc85YRISoMkImGgWd\n\tC1qZg2dqb+of4e/lBCQ4wPx+Ij6rBgEZmAtR2CE0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"N4IDJIG5\"; dkim-atps=neutral","Message-ID":"<4bb1e9ab-c53b-751f-c985-0bb8b8dbea02@ideasonboard.com>","Date":"Tue, 30 Aug 2022 16:00:53 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tMarvin Schmidt ","References":"<20220829185849.1884517-1-marvin.schmidt1987@gmail.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/3] Remove redundant calls to\n\tstd::string::c_str()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]