[{"id":24700,"web_url":"https://patchwork.libcamera.org/comment/24700/","msgid":"","date":"2022-08-19T01:50:13","subject":"Re: [libcamera-devel] [PATCH v2 0/6] AEGC controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Thu, Aug 11, 2022 at 05:02:13PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Hello\n> this series collects patch 1/3 from Paul's\n> https://patchwork.libcamera.org/project/libcamera/list/?series=3123\n> \n> with fixups proposed in-reply to that series applied on top.\n\nThanks for this consolidated version. I'm however a bit worried that\nleaving patches 2/3 and 3/3 from Paul's series out will mean we'll\nforget about them forever. Is there anything that blocks their inclusion\nin this series ?\n\n> The rest of the series ports the existing users in the code base to the\n> new controls.\n> \n> Particularly relevant is the RPi conversion (with Naush and David in Cc)\n> as it's the only pipeline that actually handles the AEGC controls.\n> The RPi changes have been compiled-tested only, hence they certainly\n> require more attention, but that's a start to check if the direction is\n> the desired one.\n> \n> Thanks\n> j\n> \n> Jacopo Mondi (5):\n> libcamera: uvcvideo: Register ExposureTimeMode control\n> test: ipa_data_serialization: Use ExposureTimeMode\n> ipa: raspberry: Port to the new AEGC controls\n> ipa: rkisp1: Remove AE-related controls\n> controls: Remove AeEnable and AeLocked\n> \n> Paul Elder (1):\n> controls: Introduce AEGC-related controls\n> \n> .../raspberrypi/controller/agc_algorithm.h | 6 +\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 24 +-\n> src/ipa/raspberrypi/controller/rpi/agc.h | 8 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 76 ++++-\n> src/ipa/rkisp1/rkisp1.cpp | 19 +-\n> src/libcamera/control_ids.yaml | 279 ++++++++++++++----\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 54 +++-\n> .../ipa_data_serializer_test.cpp | 2 +-\n> 8 files changed, 370 insertions(+), 98 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6BA6C3272\n\tfor ;\n\tFri, 19 Aug 2022 01:50:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4001F61FC0;\n\tFri, 19 Aug 2022 03:50:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F47F603E2\n\tfor ;\n\tFri, 19 Aug 2022 03:50:17 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A97C3576;\n\tFri, 19 Aug 2022 03:50:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660873818;\n\tbh=ZEmpbBh90MJUZB21Cfaw74KQ4S1eEmqyPXNdpYRCK/0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4XrkVh4Ddta8Xy8BBcIt5wpz/x2pb58sNuoWVkPaZC/XQrpX5rnLhfJtj/hoxBQiC\n\teVP3vADn0jRcSUd/NLa1Tk5ufzb/f2LoG5tOmf/0IU6xmYr7P2moti+pzZTuuXdLJd\n\t2FpS8UNuait1JCOW6I4eZ8lufpokbIyvxAhJ7I3ABQ6LFQk8m1Hv4UjTaLOVEJnevo\n\tPgtRrmlQOIt67H+Cp9ETdP3cHK/j9C1IjJbr/kFvDFPrDBlfaQkkUIiaVn79SPxgRk\n\t1eouee40ilm/1E+IdFyKU0ccWSnMbUm7i7v/GFkJzjHu34My7GEFffj+57AXi71azV\n\t2HHr8aKNgmKTA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660873816;\n\tbh=ZEmpbBh90MJUZB21Cfaw74KQ4S1eEmqyPXNdpYRCK/0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BGJ9T60QZ89eO41c8evHOUL7u4d5lRICRskc+4Za8cU5gnMRQTYowvXbtVKb45mcU\n\tupZvBYPpLrQbKjoFXSTe2R7BOPko2Hi9VYoB9JWaUGnvWa07NG2jai8m0T1EjtmUao\n\t2xO0S02UV/FnxiHckz+ZueRhv69TF/JJtmEp9iHg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BGJ9T60Q\"; dkim-atps=neutral","Date":"Fri, 19 Aug 2022 04:50:13 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220811150219.62066-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220811150219.62066-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] AEGC controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25109,"web_url":"https://patchwork.libcamera.org/comment/25109/","msgid":"<20220923084947.n6x5rlynrbfgo7qm@uno.localdomain>","date":"2022-09-23T08:49:47","subject":"Re: [libcamera-devel] [PATCH v2 0/6] AEGC controls","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Aug 19, 2022 at 04:50:13AM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Thu, Aug 11, 2022 at 05:02:13PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> > Hello\n> > this series collects patch 1/3 from Paul's\n> > https://patchwork.libcamera.org/project/libcamera/list/?series=3123\n> >\n> > with fixups proposed in-reply to that series applied on top.\n>\n> Thanks for this consolidated version. I'm however a bit worried that\n> leaving patches 2/3 and 3/3 from Paul's series out will mean we'll\n> forget about them forever. Is there anything that blocks their inclusion\n> in this series ?\n>\n\nYou're right, it would be a shame if those documents get lost.\nI have rebased them will send them in reply to this series.\n\nThis series is the latest version of the AEGC controls documentation,\nI'm not re-sending it as there's a discussion with David here that\nmight be helpful to provide more context to reviewers.\n\nTL;DR please review this version :)\n\nThanks\n j\n\n\n> > The rest of the series ports the existing users in the code base to the\n> > new controls.\n> >\n> > Particularly relevant is the RPi conversion (with Naush and David in Cc)\n> > as it's the only pipeline that actually handles the AEGC controls.\n> > The RPi changes have been compiled-tested only, hence they certainly\n> > require more attention, but that's a start to check if the direction is\n> > the desired one.\n> >\n> > Thanks\n> > j\n> >\n> > Jacopo Mondi (5):\n> > libcamera: uvcvideo: Register ExposureTimeMode control\n> > test: ipa_data_serialization: Use ExposureTimeMode\n> > ipa: raspberry: Port to the new AEGC controls\n> > ipa: rkisp1: Remove AE-related controls\n> > controls: Remove AeEnable and AeLocked\n> >\n> > Paul Elder (1):\n> > controls: Introduce AEGC-related controls\n> >\n> > .../raspberrypi/controller/agc_algorithm.h | 6 +\n> > src/ipa/raspberrypi/controller/rpi/agc.cpp | 24 +-\n> > src/ipa/raspberrypi/controller/rpi/agc.h | 8 +-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 76 ++++-\n> > src/ipa/rkisp1/rkisp1.cpp | 19 +-\n> > src/libcamera/control_ids.yaml | 279 ++++++++++++++----\n> > src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 54 +++-\n> > .../ipa_data_serializer_test.cpp | 2 +-\n> > 8 files changed, 370 insertions(+), 98 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40E5DC0DA4\n\tfor ;\n\tFri, 23 Sep 2022 08:49:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 860796222C;\n\tFri, 23 Sep 2022 10:49:51 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2A8E621BC\n\tfor ;\n\tFri, 23 Sep 2022 10:49:49 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id DAE85C000E;\n\tFri, 23 Sep 2022 08:49:48 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663922991;\n\tbh=2ynOqIbmRqBxmo5gOVlfziUHDcHaHGEV3yHMurgM4R8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=N63c6K5Hl8wKcX6jStU/FYwz0xOQNkhHUoqhitdqVjKZqiPktge6/v7Gn3ecXHBC2\n\thCjJgPRuR2Y+8JlhhIMNogO71diH3vZY1/nxpaA/1qJ5l3oxJSrDbLyQmDFuJ7lkfZ\n\tXlIqUGRjZrQhJxVx3tQyVz6ckuZQ3Gc9l3aCsmJYmdnM2nAlHZqFmKZEffNx0PW7A6\n\t0l8ha0m9h9iaFqUUMRDhJDl2XlABTmhCCd1+PKqzRgjh1oS3RfbbYdob7rINEFKW2Q\n\tlBTdJa33IkL7OqZheWXiRNLNbd38YxlHo6h0JMDcmBghGiq6aeOkGuAUz02QZ0Y/Z/\n\tV8ywVteusxCsQ==","Date":"Fri, 23 Sep 2022 10:49:47 +0200","To":"Laurent Pinchart ","Message-ID":"<20220923084947.n6x5rlynrbfgo7qm@uno.localdomain>","References":"<20220811150219.62066-1-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] AEGC controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]