[{"id":24522,"web_url":"https://patchwork.libcamera.org/comment/24522/","msgid":"","date":"2022-08-10T15:35:08","subject":"Re: [libcamera-devel] [PATCH v8 0/8] Introduce capture scripts to\n\tqcam","submitter":{"id":114,"url":"https://patchwork.libcamera.org/api/people/114/","name":"Utkarsh Tiwari","email":"utkarsh02t@gmail.com"},"content":"On Wed, 10 Aug, 2022, 20:33 Utkarsh Tiwari, wrote:\n\n> Difference from v8:\n>\nTypo :\nDifference from v7:\n\n> 1. Fixes the commit message in 1/8\n> 2. Removes various useless headers in cam_select_dialog.h\n> 3. The cameraSelectDialog_ is now only created once in 6/8\n> 4. scriptPathLabel_ now has permanent parent captureWidget\n>\n> Each patch include their differences from previous versions.\n>\n> Difference from v6 :\n> 1. This series now merges\n> https://lists.libcamera.org/pipermail/libcamera-devel/2022-August/033137.html\n> 2. The capture script button now lives in the CameraSelectorDialog\n> 3. We now show the capture selected scripts path\n> 4. Now the implementation of CameraSelectorDialog lives in it .cpp\n>\n> Normal Introduction:\n> Hi,\n>\n> This series aims to add a Dialog box which can be used to select\n> camera while at startup and trying to switch cameras.\n>\n> The series first adds the dialog to be used just for selection of\n> camera at startup and then moves on to replace the current QCombBox\n> in favour of the dialog box.\n>\n> We already got the ability to load capture scripts to run the\n> capture sessions in cam.\n>\n> This is patch series introduces both a GUI way and a cmdline way to\n> load the capture script in qcam.\n>\n> With this we get the ability to load a capture script and\n> to stop a running one.\n>\n> It utilizes the parser in cam.\n>\n> A Screenshot :\n> https://pasteboard.co/mO811IF3RQtk.png\n>\n> Utkarsh Tiwari (8):\n> qcam: Use QDialog for selection of cameras at startup\n> qcam: Support Hotplug for Camera Selection Dialog\n> qcam: MainWindow: Replace cameraCombo_ with CameraSelectorDialog\n> qcam: CamSelectDialog: Display Location and Model propety of camera\n> qcam: Queue requests only through MainWindow::queueRequest()\n> qcam: CamSelectDialog: Add capture script button\n> qcam: CamSelectDialog: Display Capture script path\n> qcam: Add --script to load capture script\n>\n> src/qcam/cam_select_dialog.cpp | 205 +++++++++++++++++++++++++++++++++\n> src/qcam/cam_select_dialog.h | 71 ++++++++++++\n> src/qcam/main.cpp | 3 +\n> src/qcam/main_window.cpp | 161 ++++++++++++++++++--------\n> src/qcam/main_window.h | 20 +++-\n> src/qcam/meson.build | 4 +\n> 6 files changed, 413 insertions(+), 51 deletions(-)\n> create mode 100644 src/qcam/cam_select_dialog.cpp\n> create mode 100644 src/qcam/cam_select_dialog.h\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04353C3272\n\tfor ;\n\tWed, 10 Aug 2022 15:35:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56E38600EA;\n\tWed, 10 Aug 2022 17:35:25 +0200 (CEST)","from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com\n\t[IPv6:2607:f8b0:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0412D600EA\n\tfor ;\n\tWed, 10 Aug 2022 17:35:23 +0200 (CEST)","by mail-pf1-x42e.google.com with SMTP id f30so13660678pfq.4\n\tfor ;\n\tWed, 10 Aug 2022 08:35:22 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660145725;\n\tbh=F3fV/aTMrRi8YWhK2QX4OkG07feQUPmYkXRYHE6GZAo=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=2QcMTVjzio3Vns0KAKcrn02QAGPJJ45oYD/Lvi+d09HGwPuFCClMv5VMXRNV/NK3C\n\tENnXHFw5iTNGA8lOUaYI7xIqfxSOEg9iaYiqEq7J1yq1JWn+G6/Rf5op9b0LI8l+sn\n\tznWQdHUgxCjQ4cDyeSUtk+yQGTKBx9Si3/lXltBgeBcuOJKRZmRk0AIHnMIoW8qV1z\n\tI8n9uNumA0ytLkhW3QISc/mKzT1YVl+/55+Fu8mO0mR99fDiyfg/8lKTlJn2pSKWhG\n\tqIn5od0RDhHS12vPvh/PqT81PSj2IMmSefI0EWLjzHZ7ELYKU2c4p+1UJLfwZLQvfM\n\tAC1acTUnmbaxA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc; bh=f87yMsZS/TdirGIfCu7wYTQ6Ke7oeuItVOVFRZ7NEFo=;\n\tb=UzXHPr3U8Er+gwHLRKgn1vM/KFM3XP+FRtIbzaoFycpCwgpQ7t6iQX5zovuYeccqvo\n\tfM9C9O4qWcHM6WEqTx5bSLKu2Mt2+rmEVeLCiO0GLBh+yBUeR6Zi60dQkeMk0f2kGsdL\n\ty+aDyThOnK3OTC2RaeXMoO7yhJ2kv+OpbA9926IkHtSiAv2hm4ikM1INRmXiQTX1uQbZ\n\tVapzWzjx7a/7Q4hdEuUZVrKoMVyT021Lb4zyYhG/EkcLGSPHlF3HPVd0zIYMg7crynTV\n\t/CBWHkUuMOt0DyptNqBO/AJ18rT4LZenj1MP0AaABOWzQEp6ua+Wchr2AgxRwmgeudkn\n\t6MRQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UzXHPr3U\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc;\n\tbh=f87yMsZS/TdirGIfCu7wYTQ6Ke7oeuItVOVFRZ7NEFo=;\n\tb=RfVaSrvGR6JvQ8zTf3avBVickRR94+66MmrKWV0mEz2DXdqiuP9exEj7JK9aftoQkn\n\tdR4ga+0Yr2MvkEzm8bK1QfqaumnJKBwdisQdRHkbw47A2tVKCdscKZkWmJxAr0OIE0p2\n\tKV5y4LlrlrMt6pF6Ot6DTK68KtijJj+wfb9Cickv2TDS/AVbIAHJRpiGU4aJxOuiKaw2\n\tWyMXkqxWvx5jOIIFxnozyrgZhjpvzLTD8XwwIhoECjQy0wGro+yrgtd3Xu01v7FqTUHk\n\t7UCG/rn6WtiYpaD8/dooNgTTu6F8iuYH3FYXJP4Eys80f4m3L0JRZAz4uabzL9necXPj\n\tiWfw==","X-Gm-Message-State":"ACgBeo2qxDrzmCj0UaLcfBWKwWUJVjQywnsg5HR5VmzZTQrZTv//aVZN\n\tz8g8Ln6KleTSa47weFFhqtNL7T4ZngDKrvYgl/Nj8gh0","X-Google-Smtp-Source":"AA6agR7Ak8o74ghOEiBXZcq8UkELaZ1Cy4Pr5tE//0Ay/DZBslxtPgNLCfa9vy20v2mpV1WPYAt+Dwc8k/aiAXdRiUI=","X-Received":"by 2002:a63:43c2:0:b0:41a:9dea:5dac with SMTP id\n\tq185-20020a6343c2000000b0041a9dea5dacmr23048136pga.585.1660145721143;\n\tWed, 10 Aug 2022 08:35:21 -0700 (PDT)","MIME-Version":"1.0","References":"<20220810150349.414043-1-utkarsh02t@gmail.com>","In-Reply-To":"<20220810150349.414043-1-utkarsh02t@gmail.com>","Date":"Wed, 10 Aug 2022 21:05:08 +0530","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000fbf63905e5e4cbfd\"","Subject":"Re: [libcamera-devel] [PATCH v8 0/8] Introduce capture scripts to\n\tqcam","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Utkarsh Tiwari via libcamera-devel\n\t","Reply-To":"Utkarsh Tiwari ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]