[{"id":24458,"web_url":"https://patchwork.libcamera.org/comment/24458/","msgid":"<CAOgh=Fy3gPq4DhnFVwAAkZY5wa-PDpay5Z7zAVA+=+_QQknAQQ@mail.gmail.com>","date":"2022-08-09T10:40:50","subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Tue, 9 Aug 2022 at 00:08, Laurent Pinchart\n<laurent.pinchart@ideasonboard.com> wrote:\n>\n> Hello,\n>\n> This small patch series adds support for openssl as an alternative to\n> gnutls to verify the signature of IPA modules.\n>\n> Compared to v1, I have reorganized the series to move the most\n> controversial part - making the dependency on crypto libraries optional\n> - on top, in patch 4/4 (previously 1/5 and 2/5, squashed together) to\n> allow discussions to continue without blocking the other patches. Patch\n> 4/4, which add libcrypto support, has been modified to not use APIs that\n> are deprecated in OpenSSL 3.0, to support Fedora 36.\n>\n> The dependency on crypto libraries was optional, before we realized that\n> missing IPA protocol serialization made it effectively required in\n> practice. Serialization is now there, so module signature support can be\n> made optional again. This could possibly cause issues for some users who\n> may not notice the missing dependency and wonder why IPA modules run\n> isolated (although that should be a fully supported configuration).\n>\n> To address this, I've documented module signing as recommended in\n> README.md (patch 4/4), and emit a warning at meson setup time when the\n> dependencies are not found. We however all know how often both\n> documentation and warnings are overlooked. If anyone thinks this is a\n> bad idea, I can drop (or modify) patch 4/4.\n>\n> For the rest of the series, please see individual patches.\n>\n> Eric, would you be able to test this on Fedora 36 to check if it fixes\n> the compilation issues you've reported ?\n\nYes, although I notice it found libcrypto, although I don't see\n-DHAVE_CRYPTO in the compile line or anything like that, although that\ncould be my misunderstanding of the build scripts.\n\n\n\n>\n> Laurent Pinchart (4):\n>   libcamera: meson: Use dependency() to find gnutls\n>   libcamera: pub_key: Gracefully handle failures to load public key\n>   libcamera: pub_key: Support openssl as an alternative to gnutls\n>   libcamera: Make IPA module signing recommended instead of mandatory\n>\n>  README.rst                           |  7 ++--\n>  include/libcamera/internal/pub_key.h |  8 +++--\n>  src/libcamera/ipa_manager.cpp        |  3 ++\n>  src/libcamera/meson.build            | 16 +++++++--\n>  src/libcamera/pub_key.cpp            | 50 +++++++++++++++++++++++++---\n>  src/meson.build                      |  3 +-\n>  6 files changed, 75 insertions(+), 12 deletions(-)\n>\n>\n> base-commit: fe8941d7d61bd22ed66e5b5615e931c68fdf9bfa\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A49ABE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  9 Aug 2022 10:41:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98F7F603EA;\n\tTue,  9 Aug 2022 12:41:11 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97578600EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  9 Aug 2022 12:41:09 +0200 (CEST)","from mail-qt1-f200.google.com (mail-qt1-f200.google.com\n\t[209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-401--pu2keS8O6WdfIarYRdyAw-1; Tue, 09 Aug 2022 06:41:07 -0400","by mail-qt1-f200.google.com with SMTP id\n\ta18-20020a05622a02d200b0031ed7ae9abeso8662775qtx.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Aug 2022 03:41:07 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660041671;\n\tbh=ANjrIVMXK1lUseLg5AefLXU5JblLtN/eI4b/Dff8lkM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=lehwe3I5Lw+vzmhtUZc5HXhiuoMRh8sK7Bdp3bQMG4IposJdnT0+DIBVMZBG1w/rd\n\tfUKa0LaNycvDzxDhjX7vxK8GwJDefTipAddxXZFFVTw7ndKuNVhqjHPZLUB0FhKKUR\n\tBHIOsa3q3cOgVgQ4HtnzfWhq+dbgE4iFY/+4ESOFBRQVsLQlZq4ObAkNrDlWOjJ4QZ\n\tlgncU58opzxxfP0i2aU9L3YTY8h6n3nQlFwPK+owMLfHM4jEIb12QozhWye0PG9ViA\n\tpHXcN0Yk6JNHFP8v/mPrlBQnnONQr4CSsPNeI14n0EPywCGB25Fp0B27VjvcGXBtZM\n\tNOtj3XUEab5lA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1660041668;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=SzNeigpUOllodrjfEJuHqLrQecMwkRBe+25CkbIUrbo=;\n\tb=Szzh+cfR7UmP5bRR3mUTOFcK0pw46GbRyzrP7A8K/aW3nKLepg9YBUNX8GInlW2HYYs2A4\n\tZairAmM5b3FCK3LZMedz4/STEDqPPkgtBkYE90PPHmkf5benM1nXtRnCyz9SGyWYLAMIX5\n\t9h3o3wtTs+RivDpHBbtyUGUajxrBH2o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"Szzh+cfR\"; \n\tdkim-atps=neutral","X-MC-Unique":"-pu2keS8O6WdfIarYRdyAw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=SzNeigpUOllodrjfEJuHqLrQecMwkRBe+25CkbIUrbo=;\n\tb=UCF8rw4mKv6aplIOekTrjIRD22DEn+mbgdlxKDiJfO1C1zUav7aDQ9NR4myXsoJZfs\n\tUaSKvZuSlTJDjFoKqoRXZ5AEAd+LZgNKFHtHOB9zhzXmhz/VQtf3Niyov9BCWlHYsTqT\n\tQM7sXOeDdoEhMA7RopBOleypJKPFwntmsncbaBv8/J/58hDQLp0rl4i01ZIi5KZvO4rq\n\te6EPYpQ3U/2tUOPLVGr4RkGdnnJJGAkj7VaRwaZyna1OUwuMeOvtEIadY9m0IZkvNaa6\n\tpOw7pNKURsV3kHIdyCuDVv2OjTL9ZjmOt59k904tk+t5tfJ+GEp7EUWtxmGR4gB58QbE\n\tpFkg==","X-Gm-Message-State":"ACgBeo2CNxzQ30BB46YI9umhv7eoRSCATQr6c89LCy/6MsGMLt4Z9jAk\n\tgn7sfI1+wfnW0jNSMPi7I5Gi6xhquoVJ7Kh/zNhzPN9MSUN0qKnc0tR65cw6wxlNlwbWMErAZqt\n\t0ntOgOvJfoxGknNoZMS250Fyac3JSkWsiU5XQNDGGpacy36On4A==","X-Received":["by 2002:a05:620a:1792:b0:6b6:3aae:12f2 with SMTP id\n\tay18-20020a05620a179200b006b63aae12f2mr15618306qkb.686.1660041666477; \n\tTue, 09 Aug 2022 03:41:06 -0700 (PDT)","by 2002:a05:620a:1792:b0:6b6:3aae:12f2 with SMTP id\n\tay18-20020a05620a179200b006b63aae12f2mr15618295qkb.686.1660041666219;\n\tTue, 09 Aug 2022 03:41:06 -0700 (PDT)"],"X-Google-Smtp-Source":"AA6agR5GM7IW2KUamZrbztTfclES5Z9dcN4nbgUHpwMo048AHPIfoP7hsc8gExklWyatpWy9cZgJNHYv/KxHqlLzYn4=","MIME-Version":"1.0","References":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>","Date":"Tue, 9 Aug 2022 11:40:50 +0100","Message-ID":"<CAOgh=Fy3gPq4DhnFVwAAkZY5wa-PDpay5Z7zAVA+=+_QQknAQQ@mail.gmail.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Eric Curtin via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Eric Curtin <ecurtin@redhat.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":24459,"web_url":"https://patchwork.libcamera.org/comment/24459/","msgid":"<CAOgh=Fz5V97-2Tc6_geVUCe72+WrULrs7b4wXVMV9=cks-DhHw@mail.gmail.com>","date":"2022-08-09T10:41:48","subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Tue, 9 Aug 2022 at 11:40, Eric Curtin <ecurtin@redhat.com> wrote:\n>\n> On Tue, 9 Aug 2022 at 00:08, Laurent Pinchart\n> <laurent.pinchart@ideasonboard.com> wrote:\n> >\n> > Hello,\n> >\n> > This small patch series adds support for openssl as an alternative to\n> > gnutls to verify the signature of IPA modules.\n> >\n> > Compared to v1, I have reorganized the series to move the most\n> > controversial part - making the dependency on crypto libraries optional\n> > - on top, in patch 4/4 (previously 1/5 and 2/5, squashed together) to\n> > allow discussions to continue without blocking the other patches. Patch\n> > 4/4, which add libcrypto support, has been modified to not use APIs that\n> > are deprecated in OpenSSL 3.0, to support Fedora 36.\n> >\n> > The dependency on crypto libraries was optional, before we realized that\n> > missing IPA protocol serialization made it effectively required in\n> > practice. Serialization is now there, so module signature support can be\n> > made optional again. This could possibly cause issues for some users who\n> > may not notice the missing dependency and wonder why IPA modules run\n> > isolated (although that should be a fully supported configuration).\n> >\n> > To address this, I've documented module signing as recommended in\n> > README.md (patch 4/4), and emit a warning at meson setup time when the\n> > dependencies are not found. We however all know how often both\n> > documentation and warnings are overlooked. If anyone thinks this is a\n> > bad idea, I can drop (or modify) patch 4/4.\n> >\n> > For the rest of the series, please see individual patches.\n> >\n> > Eric, would you be able to test this on Fedora 36 to check if it fixes\n> > the compilation issues you've reported ?\n>\n> Yes, although I notice it found libcrypto, although I don't see\n> -DHAVE_CRYPTO in the compile line or anything like that, although that\n> could be my misunderstanding of the build scripts.\n\nShould have clarified, it builds on Fedora 36.\n\n>\n>\n>\n> >\n> > Laurent Pinchart (4):\n> >   libcamera: meson: Use dependency() to find gnutls\n> >   libcamera: pub_key: Gracefully handle failures to load public key\n> >   libcamera: pub_key: Support openssl as an alternative to gnutls\n> >   libcamera: Make IPA module signing recommended instead of mandatory\n> >\n> >  README.rst                           |  7 ++--\n> >  include/libcamera/internal/pub_key.h |  8 +++--\n> >  src/libcamera/ipa_manager.cpp        |  3 ++\n> >  src/libcamera/meson.build            | 16 +++++++--\n> >  src/libcamera/pub_key.cpp            | 50 +++++++++++++++++++++++++---\n> >  src/meson.build                      |  3 +-\n> >  6 files changed, 75 insertions(+), 12 deletions(-)\n> >\n> >\n> > base-commit: fe8941d7d61bd22ed66e5b5615e931c68fdf9bfa\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F882BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  9 Aug 2022 10:42:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 156FF63328;\n\tTue,  9 Aug 2022 12:42:08 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EABDE600EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  9 Aug 2022 12:42:06 +0200 (CEST)","from mail-qv1-f69.google.com (mail-qv1-f69.google.com\n\t[209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-617-SNA4bsdkN9qD4CToZrMQfQ-1; Tue, 09 Aug 2022 06:42:04 -0400","by mail-qv1-f69.google.com with SMTP id\n\tea7-20020ad458a7000000b00476b8d9bfdcso5969949qvb.18\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Aug 2022 03:42:04 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660041728;\n\tbh=KRMPO4xg1y9t1deJq13cLVSF0VVxaaf4yVcrTnNXX8Y=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yMrkLwInSfr/yFKB/EGUjwlqK1OBtInSrUzP3qvzYllRbx524TToKFhw9GDvb22Wk\n\thJIuh5cwQtNnwhVzkr48wZuQyipvvdf+YZNXHa5yjCM2RwguKJdiu4pE9lUmAugv1S\n\tk/hdhk5/aBysbp2mOBfw4nDvnpU4C+QS2jd0eoEixoIjaZMeldxPl6d7yRHF/JHqUi\n\tX49Sb2ItquL/0uBMcD4wOMkO++65bvJOm7knOkdBcQKff9VvME3D/alLnN+iagEGMN\n\tYKq4mJLJ6a1wRHI0BiF20eT8IHsGp/7kNY8depB7h2hJAP9WuH/TydpuW4kREHApiE\n\tBKHTfsiP8TrJg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1660041725;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Fh4byrF4x0hnynNK1zKLE0TsS+ArrgBGOnOHL3DYv/g=;\n\tb=M4a3yXTk3GkJfpSDAYunu5F0F7skQGBMl5RRR88Fjn3m5e9AgVzUcqW2tFyree731b7MlN\n\tqHMqWr5iHP6oGn04eXO1NekzWQH3ADog7fuxWxtXBPAk2GnN6XMZfiGQbbQkpxWKahZ+15\n\tqrIbTFi3+RM7hEDVnJdR4bEiNRiTPIc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"M4a3yXTk\"; \n\tdkim-atps=neutral","X-MC-Unique":"SNA4bsdkN9qD4CToZrMQfQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Fh4byrF4x0hnynNK1zKLE0TsS+ArrgBGOnOHL3DYv/g=;\n\tb=xIFNvXUAwcWaQtAM3Pz0N8ehYqWtR1sX5878mKnEK7gji6akBFg/CYZngaaoeZsu9/\n\tEWjPPvcRkn9EIMXzi668ge9Ecd+MW9t1QLZTZtIVnl3cLthn16zeD3mCmpbeUYiZFQc6\n\t2iQCvJJwPpiMBDw6wlWCBTrQaYoZ/tDyuHbVfHT6n6wxTK504F9mMuXD4XJPDe+JGgoo\n\tzaLVqP0jc3EUz6Uh3vL1r5+6mugExIEwyc5PNxqkQPC+tsf8IFSrbL5EwurBFd2K0Fdu\n\tuUndSIr0ZMlWD7P5Kkrbp0f9zrUV2w3Du8LsGukAv8axSAxtc8tzvXOsrt9q9AjQbrhm\n\tdhnQ==","X-Gm-Message-State":"ACgBeo157o0422aiFLoZZ965Lm9UItkA2BxEXINzjnzFBfCSVOnUB+De\n\tFQmA81PpSuwKx2q7akDEymG2sfVa6T3gI7pKfyV6Yjjqf4gfb8Fvi2u1dz/Mgthx5r4JsnSAibm\n\tc/G235wGuIy/hLOfHNyDlfZ5xnv2vLz9ZacRWO84/u/X2A+kIAQ==","X-Received":["by 2002:ac8:7d07:0:b0:31e:e094:ef12 with SMTP id\n\tg7-20020ac87d07000000b0031ee094ef12mr19628557qtb.301.1660041724361; \n\tTue, 09 Aug 2022 03:42:04 -0700 (PDT)","by 2002:ac8:7d07:0:b0:31e:e094:ef12 with SMTP id\n\tg7-20020ac87d07000000b0031ee094ef12mr19628549qtb.301.1660041724164;\n\tTue, 09 Aug 2022 03:42:04 -0700 (PDT)"],"X-Google-Smtp-Source":"AA6agR59fBT3Y4pYhRWrP+g8L1AEOpgr8n2fvJ7AH5qZ85JrUhgUm+JBzFC83L/cm+zM/tDNvUii2UX8OkKVwkikKAY=","MIME-Version":"1.0","References":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>\n\t<CAOgh=Fy3gPq4DhnFVwAAkZY5wa-PDpay5Z7zAVA+=+_QQknAQQ@mail.gmail.com>","In-Reply-To":"<CAOgh=Fy3gPq4DhnFVwAAkZY5wa-PDpay5Z7zAVA+=+_QQknAQQ@mail.gmail.com>","Date":"Tue, 9 Aug 2022 11:41:48 +0100","Message-ID":"<CAOgh=Fz5V97-2Tc6_geVUCe72+WrULrs7b4wXVMV9=cks-DhHw@mail.gmail.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Eric Curtin via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Eric Curtin <ecurtin@redhat.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":24462,"web_url":"https://patchwork.libcamera.org/comment/24462/","msgid":"<YvI6OxqJDSPuYa5Q@pendragon.ideasonboard.com>","date":"2022-08-09T10:43:07","subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Eric,\n\nOn Tue, Aug 09, 2022 at 11:40:50AM +0100, Eric Curtin wrote:\n> On Tue, 9 Aug 2022 at 00:08, Laurent Pinchart wrote:\n> >\n> > Hello,\n> >\n> > This small patch series adds support for openssl as an alternative to\n> > gnutls to verify the signature of IPA modules.\n> >\n> > Compared to v1, I have reorganized the series to move the most\n> > controversial part - making the dependency on crypto libraries optional\n> > - on top, in patch 4/4 (previously 1/5 and 2/5, squashed together) to\n> > allow discussions to continue without blocking the other patches. Patch\n> > 4/4, which add libcrypto support, has been modified to not use APIs that\n> > are deprecated in OpenSSL 3.0, to support Fedora 36.\n> >\n> > The dependency on crypto libraries was optional, before we realized that\n> > missing IPA protocol serialization made it effectively required in\n> > practice. Serialization is now there, so module signature support can be\n> > made optional again. This could possibly cause issues for some users who\n> > may not notice the missing dependency and wonder why IPA modules run\n> > isolated (although that should be a fully supported configuration).\n> >\n> > To address this, I've documented module signing as recommended in\n> > README.md (patch 4/4), and emit a warning at meson setup time when the\n> > dependencies are not found. We however all know how often both\n> > documentation and warnings are overlooked. If anyone thinks this is a\n> > bad idea, I can drop (or modify) patch 4/4.\n> >\n> > For the rest of the series, please see individual patches.\n> >\n> > Eric, would you be able to test this on Fedora 36 to check if it fixes\n> > the compilation issues you've reported ?\n> \n> Yes,\n\nNice to know it now works :-) Can I add your Tested-by ? Reviews are\nalso always appreciated if you have time.\n\n> although I notice it found libcrypto, although I don't see\n> -DHAVE_CRYPTO in the compile line or anything like that, although that\n> could be my misunderstanding of the build scripts.\n\nIt's added to the auto-generated config.h in the build directory.\n\n> > Laurent Pinchart (4):\n> >   libcamera: meson: Use dependency() to find gnutls\n> >   libcamera: pub_key: Gracefully handle failures to load public key\n> >   libcamera: pub_key: Support openssl as an alternative to gnutls\n> >   libcamera: Make IPA module signing recommended instead of mandatory\n> >\n> >  README.rst                           |  7 ++--\n> >  include/libcamera/internal/pub_key.h |  8 +++--\n> >  src/libcamera/ipa_manager.cpp        |  3 ++\n> >  src/libcamera/meson.build            | 16 +++++++--\n> >  src/libcamera/pub_key.cpp            | 50 +++++++++++++++++++++++++---\n> >  src/meson.build                      |  3 +-\n> >  6 files changed, 75 insertions(+), 12 deletions(-)\n> >\n> >\n> > base-commit: fe8941d7d61bd22ed66e5b5615e931c68fdf9bfa","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0A7BC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  9 Aug 2022 10:43:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF3BF6332A;\n\tTue,  9 Aug 2022 12:43:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54641600EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  9 Aug 2022 12:43:19 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF71A481;\n\tTue,  9 Aug 2022 12:43:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660041800;\n\tbh=axS5Po1LDhu0K4e1fYXmP4o2LyA07xOTDP/Qi5A0WnY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=N0ZdqMPvrJ4nRykS+WafCgjR8UfFo2llvkooV6Nq7bqZ9ObLvVO4c6WmBCjKiPPx7\n\tJuQUcgye3rPLwxtlOEDIey3JX8UuwgkDkVo1f+dI1ap88EAQMKvFnVNdvBWHz/Wqur\n\tlPozkrYadQTiRmWV7kMLmp+9CiBYw+UNRlNkfgF1OqGJuSaQne/auKd5OGPiWWGaAf\n\t/8kur6EkKpHJUgXWHByKWJlU4M1Wj4TiwWBJuz6R0BPtPnVA0gFU9xZOWUqFOBdWuw\n\tJpZmUwtO1Bkk87yZfDrfOdYiHgwKjF8va6vygDF9MUk3RQVXppXRvxa63fuUwf2m6B\n\tFaSTakvwoXFTw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660041799;\n\tbh=axS5Po1LDhu0K4e1fYXmP4o2LyA07xOTDP/Qi5A0WnY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UlPRA9gxxx0KteyFh5RDkIJgRHJrbTRvPmwZUBboNEOfcR3l82wxYHFKdom/fG+2W\n\t+KvT9aT2z0RBnHPusbuusTvdx1ICcsW/lmWWPpdqyjgt1g8Hc/x0QH/jea2pct2i0c\n\tygWwJcCyGwYj48AeMwTwKJKgX86hlKTYky8LmnVk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UlPRA9gx\"; dkim-atps=neutral","Date":"Tue, 9 Aug 2022 13:43:07 +0300","To":"Eric Curtin <ecurtin@redhat.com>","Message-ID":"<YvI6OxqJDSPuYa5Q@pendragon.ideasonboard.com>","References":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>\n\t<CAOgh=Fy3gPq4DhnFVwAAkZY5wa-PDpay5Z7zAVA+=+_QQknAQQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<CAOgh=Fy3gPq4DhnFVwAAkZY5wa-PDpay5Z7zAVA+=+_QQknAQQ@mail.gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":24463,"web_url":"https://patchwork.libcamera.org/comment/24463/","msgid":"<CAOgh=Fw6tptUb8trgTt8Xhw1ojn6ERub29RPeL2N2peERJVEMw@mail.gmail.com>","date":"2022-08-09T10:44:26","subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Tue, 9 Aug 2022 at 11:43, Laurent Pinchart\n<laurent.pinchart@ideasonboard.com> wrote:\n>\n> Hi Eric,\n>\n> On Tue, Aug 09, 2022 at 11:40:50AM +0100, Eric Curtin wrote:\n> > On Tue, 9 Aug 2022 at 00:08, Laurent Pinchart wrote:\n> > >\n> > > Hello,\n> > >\n> > > This small patch series adds support for openssl as an alternative to\n> > > gnutls to verify the signature of IPA modules.\n> > >\n> > > Compared to v1, I have reorganized the series to move the most\n> > > controversial part - making the dependency on crypto libraries optional\n> > > - on top, in patch 4/4 (previously 1/5 and 2/5, squashed together) to\n> > > allow discussions to continue without blocking the other patches. Patch\n> > > 4/4, which add libcrypto support, has been modified to not use APIs that\n> > > are deprecated in OpenSSL 3.0, to support Fedora 36.\n> > >\n> > > The dependency on crypto libraries was optional, before we realized that\n> > > missing IPA protocol serialization made it effectively required in\n> > > practice. Serialization is now there, so module signature support can be\n> > > made optional again. This could possibly cause issues for some users who\n> > > may not notice the missing dependency and wonder why IPA modules run\n> > > isolated (although that should be a fully supported configuration).\n> > >\n> > > To address this, I've documented module signing as recommended in\n> > > README.md (patch 4/4), and emit a warning at meson setup time when the\n> > > dependencies are not found. We however all know how often both\n> > > documentation and warnings are overlooked. If anyone thinks this is a\n> > > bad idea, I can drop (or modify) patch 4/4.\n> > >\n> > > For the rest of the series, please see individual patches.\n> > >\n> > > Eric, would you be able to test this on Fedora 36 to check if it fixes\n> > > the compilation issues you've reported ?\n> >\n> > Yes,\n>\n> Nice to know it now works :-) Can I add your Tested-by ? Reviews are\n> also always appreciated if you have time.\n>\n> > although I notice it found libcrypto, although I don't see\n> > -DHAVE_CRYPTO in the compile line or anything like that, although that\n> > could be my misunderstanding of the build scripts.\n>\n> It's added to the auto-generated config.h in the build directory.\n\nYes I see now thanks.\n\n>\n> > > Laurent Pinchart (4):\n> > >   libcamera: meson: Use dependency() to find gnutls\n> > >   libcamera: pub_key: Gracefully handle failures to load public key\n> > >   libcamera: pub_key: Support openssl as an alternative to gnutls\n> > >   libcamera: Make IPA module signing recommended instead of mandatory\n> > >\n> > >  README.rst                           |  7 ++--\n> > >  include/libcamera/internal/pub_key.h |  8 +++--\n> > >  src/libcamera/ipa_manager.cpp        |  3 ++\n> > >  src/libcamera/meson.build            | 16 +++++++--\n> > >  src/libcamera/pub_key.cpp            | 50 +++++++++++++++++++++++++---\n> > >  src/meson.build                      |  3 +-\n> > >  6 files changed, 75 insertions(+), 12 deletions(-)\n> > >\n> > >\n> > > base-commit: fe8941d7d61bd22ed66e5b5615e931c68fdf9bfa\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8D00C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  9 Aug 2022 10:44:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8369863328;\n\tTue,  9 Aug 2022 12:44:46 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B504600EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  9 Aug 2022 12:44:45 +0200 (CEST)","from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n\t[209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-653-fQG4VkfYMOK36l2_WRL7aA-1; Tue, 09 Aug 2022 06:44:43 -0400","by mail-qk1-f200.google.com with SMTP id\n\tq20-20020a05620a0d9400b006b6540e8d79so9982030qkl.14\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Aug 2022 03:44:43 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660041886;\n\tbh=Mfy76EAOoNbBB+d1FbPsiIaCCisTr3Q0j0vmqg/LBCI=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1TsUdvT4gnINa1Ua5WG/XfA1PcD7W2Logztgme0O5CVvGw2I00wW1r1xxwJC73Seh\n\t2yDR8Mf+NYIVLjYhYsq5SagVZe4q2MutFwvELY6kZVBeIgajVIIu1hCiHTh8JLlDQX\n\tNKKEOmnUL3B7FYUTvOz6GydpAalQ9DB/praU1a3HiOMx0FAcw1+FyMB8D1PjK7YMl3\n\t3cCrk64vFTqmHvRiYtCnu/+h8+vM3Pht6Gw9D+GRmGUrx2d4Z4JXSsnN6ij7SZRp0P\n\tDuUo7wn6EmwHm7d94yznukjn8s5F7vXOREkeIGVHFcecKGS/BqaNBmRieewNkTrUuc\n\ts/f3v7dQdbE6w==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1660041884;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=EaL8CZk8A627xT1qV77mpUzwkO9GAmxZyhW9Nw6TSio=;\n\tb=I/UNSs/T/t9ENIM1ejZrY4Dg5dNX7zL7+GtgOYf18qKdIWcMwrA//3Tw8uokUmCuDrY+gI\n\tmCfDI9vbpOIWSN+wSGoGC2yL0plZGWs0Uu1gxaWs/tkHZGQ8CBhmTRWgWgsIWnBsPGqTDg\n\t9r4vAaqjs269mI3tB5lhjGdEPTjNvRE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"I/UNSs/T\"; \n\tdkim-atps=neutral","X-MC-Unique":"fQG4VkfYMOK36l2_WRL7aA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=EaL8CZk8A627xT1qV77mpUzwkO9GAmxZyhW9Nw6TSio=;\n\tb=5qMdKOX8Os8wr0sthiOSmDm91vyPBn9u29PuH2/GAPLYpqtFGPuLfsrQ/zfcb6vxES\n\t5Bz0ltOVEi4zgsIMaicemJorS6qn+OpOB3aINGkRWqP/iIXYBAELkmKAiJWyRUNvNrZm\n\tblH5qg8ec2JnBPKzha2fpRoXphDkvKFYaV5HA3PJI9a0oVa1x5kqrWl9k5Wt4oLXnLzN\n\t4IgfvkaXQ0v9yDywXlC0kFr5wszQlWWT7dGS9meVaGO796kvMY/voyXL0CT7rCnE5RFP\n\tNUXjcJjL5bGij+CYnstFX2jz8+oscM35IZxBcF1GZPPFldgau1GQITLJv4PPJRUB3B8J\n\tfKXg==","X-Gm-Message-State":"ACgBeo237jV+8gUNJtBM+e/EfL6oqCeHuw41igoAMwP4nGW9JEIA9O8Y\n\ttq2v03uiMkU4VMQrdM/05Ej5nEHQBTSmbW7hy//PteYOrLdQ3GcII6O0rMJV37UO+HYdBhFPNE0\n\tadUhzZWb57y3CuxeebNGBgfqkkZv3qqiW6LN7lN6j2FkTIj7ZVA==","X-Received":["by 2002:a0c:b4c9:0:b0:476:591f:d8df with SMTP id\n\th9-20020a0cb4c9000000b00476591fd8dfmr19922806qvf.81.1660041882627; \n\tTue, 09 Aug 2022 03:44:42 -0700 (PDT)","by 2002:a0c:b4c9:0:b0:476:591f:d8df with SMTP id\n\th9-20020a0cb4c9000000b00476591fd8dfmr19922793qvf.81.1660041882381;\n\tTue, 09 Aug 2022 03:44:42 -0700 (PDT)"],"X-Google-Smtp-Source":"AA6agR5etRED4409OGJT+0+wHsOv7qbQbqMpuADL27Qd1KpPvVv/LZz3J5hKlhw79Roy8EO+/LUSOaMpLYqbUxWnPx8=","MIME-Version":"1.0","References":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>\n\t<CAOgh=Fy3gPq4DhnFVwAAkZY5wa-PDpay5Z7zAVA+=+_QQknAQQ@mail.gmail.com>\n\t<YvI6OxqJDSPuYa5Q@pendragon.ideasonboard.com>","In-Reply-To":"<YvI6OxqJDSPuYa5Q@pendragon.ideasonboard.com>","Date":"Tue, 9 Aug 2022 11:44:26 +0100","Message-ID":"<CAOgh=Fw6tptUb8trgTt8Xhw1ojn6ERub29RPeL2N2peERJVEMw@mail.gmail.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Eric Curtin via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Eric Curtin <ecurtin@redhat.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":24464,"web_url":"https://patchwork.libcamera.org/comment/24464/","msgid":"<CAOgh=FzbSty8O4_rYW9s38yFP91thWcnhXLdHjDdasZxpw0yxw@mail.gmail.com>","date":"2022-08-09T10:45:28","subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Tue, 9 Aug 2022 at 11:44, Eric Curtin <ecurtin@redhat.com> wrote:\n>\n> On Tue, 9 Aug 2022 at 11:43, Laurent Pinchart\n> <laurent.pinchart@ideasonboard.com> wrote:\n> >\n> > Hi Eric,\n> >\n> > On Tue, Aug 09, 2022 at 11:40:50AM +0100, Eric Curtin wrote:\n> > > On Tue, 9 Aug 2022 at 00:08, Laurent Pinchart wrote:\n> > > >\n> > > > Hello,\n> > > >\n> > > > This small patch series adds support for openssl as an alternative to\n> > > > gnutls to verify the signature of IPA modules.\n> > > >\n> > > > Compared to v1, I have reorganized the series to move the most\n> > > > controversial part - making the dependency on crypto libraries optional\n> > > > - on top, in patch 4/4 (previously 1/5 and 2/5, squashed together) to\n> > > > allow discussions to continue without blocking the other patches. Patch\n> > > > 4/4, which add libcrypto support, has been modified to not use APIs that\n> > > > are deprecated in OpenSSL 3.0, to support Fedora 36.\n> > > >\n> > > > The dependency on crypto libraries was optional, before we realized that\n> > > > missing IPA protocol serialization made it effectively required in\n> > > > practice. Serialization is now there, so module signature support can be\n> > > > made optional again. This could possibly cause issues for some users who\n> > > > may not notice the missing dependency and wonder why IPA modules run\n> > > > isolated (although that should be a fully supported configuration).\n> > > >\n> > > > To address this, I've documented module signing as recommended in\n> > > > README.md (patch 4/4), and emit a warning at meson setup time when the\n> > > > dependencies are not found. We however all know how often both\n> > > > documentation and warnings are overlooked. If anyone thinks this is a\n> > > > bad idea, I can drop (or modify) patch 4/4.\n> > > >\n> > > > For the rest of the series, please see individual patches.\n> > > >\n> > > > Eric, would you be able to test this on Fedora 36 to check if it fixes\n> > > > the compilation issues you've reported ?\n> > >\n> > > Yes,\n> >\n> > Nice to know it now works :-) Can I add your Tested-by ? Reviews are\n> > also always appreciated if you have time.\n> >\n> > > although I notice it found libcrypto, although I don't see\n> > > -DHAVE_CRYPTO in the compile line or anything like that, although that\n> > > could be my misunderstanding of the build scripts.\n> >\n> > It's added to the auto-generated config.h in the build directory.\n>\n> Yes I see now thanks.\n\nTested-by: Eric Curtin <ecurtin@redhat.com>\n\n\n>\n> >\n> > > > Laurent Pinchart (4):\n> > > >   libcamera: meson: Use dependency() to find gnutls\n> > > >   libcamera: pub_key: Gracefully handle failures to load public key\n> > > >   libcamera: pub_key: Support openssl as an alternative to gnutls\n> > > >   libcamera: Make IPA module signing recommended instead of mandatory\n> > > >\n> > > >  README.rst                           |  7 ++--\n> > > >  include/libcamera/internal/pub_key.h |  8 +++--\n> > > >  src/libcamera/ipa_manager.cpp        |  3 ++\n> > > >  src/libcamera/meson.build            | 16 +++++++--\n> > > >  src/libcamera/pub_key.cpp            | 50 +++++++++++++++++++++++++---\n> > > >  src/meson.build                      |  3 +-\n> > > >  6 files changed, 75 insertions(+), 12 deletions(-)\n> > > >\n> > > >\n> > > > base-commit: fe8941d7d61bd22ed66e5b5615e931c68fdf9bfa\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64582C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  9 Aug 2022 10:45:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25A4E63328;\n\tTue,  9 Aug 2022 12:45:51 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07480600EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  9 Aug 2022 12:45:48 +0200 (CEST)","from mail-qt1-f197.google.com (mail-qt1-f197.google.com\n\t[209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-451-eN828YMlNOi0l4EZbLX_LA-1; Tue, 09 Aug 2022 06:45:45 -0400","by mail-qt1-f197.google.com with SMTP id\n\tbb40-20020a05622a1b2800b00342eb08cc48so6014544qtb.17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Aug 2022 03:45:44 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660041951;\n\tbh=9II6D808IGj9phjEY0SJQgGShBZl2zKXx7L5Hzuw25U=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZHx+M2Fttk9jM+gAiItsmoqdtph/3qoS9oqkvp4UUnQzHpwier9ElrxTohlXT4gRy\n\twPvlO3BHmEUkUsVqjPKGECb5KBgeYmVpq5tjIW91mVAgdrBc0Qjik6hMHgB13Yz7VI\n\tvmhROvGVakESS58u5D6DyS4svl3d66hks/mHElpKdzQhLDcJvT9npEM+YtYNcGO7lU\n\t9c1eNJxprSRjVfawDNQaR/qrQeX5SOeqXKvzMWb/qodYFeq1cP7WeZE/P7reDf3RjT\n\tL3jziVeXJZ+abherRnmK3kaNjXwoKVIb+LvqsqiyNV0EnoQiMsq4++w9lTgLl4Vd9M\n\tIB/5/LVtRMjKw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1660041948;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=LNz6gzr9dBLDzX4DPP6HaxB8xYvPURSlxxhE8KwlSXU=;\n\tb=NxaoPxYOza+oEzJHd3xEEDLQaRe6SXiyYZbvd+Mln0U9sS6ZbEhUU8phycRStEfyIptnAd\n\tZPXI5OAPXPOoKuuzuDrZue/8RwAiiMG2PxDKp2Lc8LlnD3BIFek6HqCEFdu8cbo/YHTN8X\n\t4xwOJyvVctZNi4sv1n6j6JbSLaw5bDU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"NxaoPxYO\"; \n\tdkim-atps=neutral","X-MC-Unique":"eN828YMlNOi0l4EZbLX_LA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=LNz6gzr9dBLDzX4DPP6HaxB8xYvPURSlxxhE8KwlSXU=;\n\tb=kSjqf0YRIv08CCoZ4TC2AhB8qNfHfhF5u7ID02vpEFrVZ3DfpnNDDlCWrchkwWWXzM\n\t2JPtRevShASvsjGPGJwaQb7wDeZvkQMd+wKGbRJR08luZppfLLgjrb/bTAtGVFi2F2Ib\n\tjTGpcwx2B4rhuZJYwJRHX1yVFHOaeKfAAMR8XiRzJW/Zaw6NFTTIcvEa5FH78MPAyev9\n\tjJLivqW9a+lPgavcCadARXNBZ12jJPczpu483ukYbAezrFDsC5kJcOxaKCs33H8klev1\n\tKFi0aq2FtiiKUg/9I6FPGa3VXwWkEFJeRsrSAkQV9On8wkSMkUDZl7nyX2nsWny+oNSi\n\tFAKQ==","X-Gm-Message-State":"ACgBeo3fIlOYWoz6rYHDNCJl1N279o9qveiPBFGrt7tyt3G97nVtNzYa\n\taK3m/MyuwWkOJ4HXC6RHRPxrADJEdVWQ5evDH2YPaL1bY+LPavioLKVrHCvu5y0C0e+qsqALDjz\n\txlPpCp4UYsPA5U2RT/h03jL/bBaGh2dFiMygt+bK/2IWhwpX2Mg==","X-Received":["by 2002:a0c:b2d0:0:b0:473:2c19:f1ee with SMTP id\n\td16-20020a0cb2d0000000b004732c19f1eemr19638088qvf.130.1660041944475; \n\tTue, 09 Aug 2022 03:45:44 -0700 (PDT)","by 2002:a0c:b2d0:0:b0:473:2c19:f1ee with SMTP id\n\td16-20020a0cb2d0000000b004732c19f1eemr19638078qvf.130.1660041944269;\n\tTue, 09 Aug 2022 03:45:44 -0700 (PDT)"],"X-Google-Smtp-Source":"AA6agR5h3L29E+73+Smr5EPxSLRbRvHZPlAxoHWyLEHSnr14s+sxRpmlPBXqBWa5oTyh9g4r5G+VgrpGQP/vaTEy36Q=","MIME-Version":"1.0","References":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>\n\t<CAOgh=Fy3gPq4DhnFVwAAkZY5wa-PDpay5Z7zAVA+=+_QQknAQQ@mail.gmail.com>\n\t<YvI6OxqJDSPuYa5Q@pendragon.ideasonboard.com>\n\t<CAOgh=Fw6tptUb8trgTt8Xhw1ojn6ERub29RPeL2N2peERJVEMw@mail.gmail.com>","In-Reply-To":"<CAOgh=Fw6tptUb8trgTt8Xhw1ojn6ERub29RPeL2N2peERJVEMw@mail.gmail.com>","Date":"Tue, 9 Aug 2022 11:45:28 +0100","Message-ID":"<CAOgh=FzbSty8O4_rYW9s38yFP91thWcnhXLdHjDdasZxpw0yxw@mail.gmail.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] libcamera: Support openssl as\n\tan alternative to gnutls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Eric Curtin via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Eric Curtin <ecurtin@redhat.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]