[{"id":24370,"web_url":"https://patchwork.libcamera.org/comment/24370/","msgid":"","date":"2022-08-04T14:14:25","subject":"Re: [libcamera-devel] [PATCH 0/2] Use YAML 1.1 for the time being","submitter":{"id":123,"url":"https://patchwork.libcamera.org/api/people/123/","name":"Florian Sylvestre","email":"fsylvestre@baylibre.com"},"content":"On Thu, 4 Aug 2022 at 15:21, Laurent Pinchart\n wrote:\n>\n> Hello,\n>\n> This small patch series switches all the YAML files in libcamera to use\n> YAML 1.1, in order to support the libyaml version shipped in the latest\n> Debian stable.\n>\n> YAML 1.2 support was added to libyaml on v0.2.3, and Debian stable\n> currently ships v0.2.2 (Debian testing has updated to v0.2.5, which is\n> the version libcamera uses in the libyaml wrap fallback). This causes\n> issues parsing YAML files in the RkISP1 module. To fix that, we could\n> have mandated libyaml v0.2.3 or newer, but given that we don't depend on\n> any YAML 1.2 feature, downgrading our YAML files to version 1.1 should\n> be more user-friendly.\n>\n> The main drawback I can see is that YAML 1.1 parses the unquoted string\n> literals Yes, No, On and Off as booleans, while YAML 1.2 parses them as\n> strings. None of the YAML files in libcamera use those values, but we'll\n> have to be careful not to use them in the future if we want to later\n> switch back to YAML 1.2 when distributions will have caught up.\n>\n> Patch 1/2 fixes the issue in the RkISP1 IPA module tuning data files,\n> while patch 2/2 modifies the internal YAML files used for code\n> generation. The latter isn't strictly needed as explained in the commit\n> message of the second patch, but I've included it for consistency. I'm\n> fine dropping the second patch if preferred.\n>\n> Florian, could you check if this fixes your YAML parsing issues ?\nI confirm it fixes my YAML parsing issues.\n>\n> Laurent Pinchart (2):\n> ipa: rkisp1: Use YAML 1.1 for tuning data files\n> libcamera: Switch internal YAML files to YAML 1.1\n>\n> src/ipa/rkisp1/data/imx219.yaml | 2 +-\n> src/ipa/rkisp1/data/ov5640.yaml | 2 +-\n> src/ipa/rkisp1/data/uncalibrated.yaml | 2 +-\n> src/libcamera/control_ids.yaml | 2 +-\n> src/libcamera/formats.yaml | 2 +-\n> src/libcamera/property_ids.yaml | 2 +-\n> 6 files changed, 6 insertions(+), 6 deletions(-)\n>\n>\n> base-commit: 961a6cf7cac9b788cc285a58ae1b8a480f00b633\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31E9EC3272\n\tfor ;\n\tThu, 4 Aug 2022 14:14:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E08866332B;\n\tThu, 4 Aug 2022 16:14:38 +0200 (CEST)","from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com\n\t[IPv6:2607:f8b0:4864:20::62e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93F8D6330D\n\tfor ;\n\tThu, 4 Aug 2022 16:14:37 +0200 (CEST)","by mail-pl1-x62e.google.com with SMTP id w7so19411489ply.12\n\tfor ;\n\tThu, 04 Aug 2022 07:14:37 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659622478;\n\tbh=mJ2ARtzKi1fo/iZvQyKxawKID2QKy/hFQMG8FqnXqXM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=E/6Wx9gEEvfEjWB/BPN0PN2Yof5Vtf6iLPjLJrrEzVoMHbqcN3gqJHVY85hVUMvuz\n\tFtKvldEXdtCHGOJXWrAqVJ9M6Oh8PVH+qy4VKefYUJOSKQq7cWr667qoclNAjJ96gP\n\toWtz7K0ylMT6omRZWmW81lxInGyNsCHFX9IqnLTamaXw2GXToCmQ7MeczS+YOU11tV\n\tez1hdyo3Ac5MMP7w/GRg6HN6iWntizUL3HiX23RfjgKBAhx4B/gDeFb01fMerbANeF\n\tT1L9PzITvK+3GR3yJwAv1gTFU/K7IoEq2ZclLjTvTnhzKkWKeynNrnuq5UDcJwgmfX\n\tfaBwO7jzyqSOg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=1Jn4H1bI/Nq7uY6HTZXS0EGFjwttRc3kW2V1CaRYT8Y=;\n\tb=hmDUZypOeft3BfBYq0gv1w14sWNNBhapXT5kW3anznphlHty1CyFJJv7CK+U0ErE5p\n\tD8wDF6h+opmO6aneWpYZoyGPT7/i47FneDE39guObeBsOHoT5QuyHWzyThovZ7MvvK2N\n\tUW+devX1J+g95scPgJtcSY8MewcQuUY9kYkrN64Rn6QNYztiLxy0FqMU5eufnQvialQ8\n\tod4HauaUVt27fY4iMyst/rxfzNY95fqPWtyqZkWktpLUs8azf/hTKQdpiYt56xrBKQC8\n\tHGh8Rjpqgu6mf4J6N/VkfNRfSlylYypFFU/eEuB0JtqMqi0IkvHBnB9aaQpdI5EzeHzh\n\tytyQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"hmDUZypO\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=1Jn4H1bI/Nq7uY6HTZXS0EGFjwttRc3kW2V1CaRYT8Y=;\n\tb=yA+otdH8U+vEwZRz+Am1VwCGo3LzsxkLkUgOYX8otaMUkKxIqtSVQOr7HqlYRet38r\n\taBXoD/449Ro/xydlQM+9sAFaZoVQGpWA6gWO8Y2+28WYTM/moEligojqA/seJSghQDdh\n\tmfIrLTAet8fhuGGdxVOLkPLmlbMagop3Nz78RmOAuJJ56vTAYbubHRyaGOox2eIKN4Ai\n\tu3qyO1KgS6SKjAMVjgfMPsUqJhRhueiKy4q91vIuk/n7tZqT9dHxYDptBaMOclklPdaz\n\tG67fEC6lB91T4N2TPukb0i/XmT5GmGPA9qyf3ixRXy8bF7p/mmMCkfow7VFzGF2s5XIy\n\tk6lg==","X-Gm-Message-State":"ACgBeo33cYE3RMWkGtb/6WNxraC1YvasOgevmpORi4Mh/cPbnP01lO/E\n\tjfu3kucWm1hks1w+z4/s2pHcnbK10wIcWk+pTEta5KIiJDb45w==","X-Google-Smtp-Source":"AA6agR5FHNodhCCNIvLc8GHuxH3+eDP4qRipiY4EibZhnEemv9gts/ghoC/KAOTkCv7T4b6KUkB4A17COjfXjeZkxuU=","X-Received":"by 2002:a17:90b:f85:b0:1f3:1d77:244b with SMTP id\n\tft5-20020a17090b0f8500b001f31d77244bmr10873240pjb.210.1659622475854;\n\tThu, 04 Aug 2022 07:14:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20220804132112.17604-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220804132112.17604-1-laurent.pinchart@ideasonboard.com>","Date":"Thu, 4 Aug 2022 16:14:25 +0200","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 0/2] Use YAML 1.1 for the time being","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Florian Sylvestre via libcamera-devel\n\t","Reply-To":"Florian Sylvestre ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]