[{"id":24558,"web_url":"https://patchwork.libcamera.org/comment/24558/","msgid":"<388d9564-fd7c-1b18-139f-a18cb97a2714@ideasonboard.com>","date":"2022-08-12T11:53:49","subject":"Re: [libcamera-devel] [RFC PATCH 0/4] Colorspace adjustments and\n\tgstreamer mapping","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi all,\n\nOn 8/3/22 00:27, Umang Jain wrote:\n> RFC for first three patches and v3 for gstreamer mappings.\n>\n> Mainly the first 3 patches, adjusts ColorSpace::Srgb to define\n> a sRGB colorspace space. It also accompanied with a colorspace\n> adjustment API if sRGB is used with YUV. More such adjustments\n> can be built on top using the ColorSpace::adjust(StreamConfiguration)\n> API.\n\n\nanybody interested to review the series? Perhaps David, Laurent based on \nthe previous discussions we had?\n\nThank you!\n\n--\n\nUmang\n\n> Rishikesh Donadkar (1):\n> gstreamer: Provide colorimetry <> ColorSpace mappings\n>\n> Umang Jain (3):\n> libcamera: colorspace: Rectify ColorSpace::Srgb preset\n> libcamera: colorspace: Adjust colorspace of YUV streams\n> tests: stream: Add a colorspace adjustment test\n>\n> include/libcamera/color_space.h | 6 +\n> src/gstreamer/gstlibcamera-utils.cpp | 176 +++++++++++++++++++++++++++\n> src/libcamera/camera.cpp | 11 ++\n> src/libcamera/color_space.cpp | 70 ++++++++++-\n> src/libcamera/v4l2_device.cpp | 2 -\n> test/stream/meson.build | 1 +\n> test/stream/stream_colorspace.cpp | 57 +++++++++\n> 7 files changed, 315 insertions(+), 8 deletions(-)\n> create mode 100644 test/stream/stream_colorspace.cpp\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20B10BE173\n\tfor ;\n\tFri, 12 Aug 2022 11:53:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D4336332B;\n\tFri, 12 Aug 2022 13:53:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 966D3603EA\n\tfor ;\n\tFri, 12 Aug 2022 13:53:55 +0200 (CEST)","from [IPV6:2401:4900:1f3f:c7a1:27b3:9637:38a7:6084] (unknown\n\t[IPv6:2401:4900:1f3f:c7a1:27b3:9637:38a7:6084])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A1BD30A;\n\tFri, 12 Aug 2022 13:53:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660305237;\n\tbh=t6oy10QtAa3B5sNQBz73X8FbiBhhSVJjS6nDueuOBqs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dCt/wrvDjFK/syDvft7WYLYUxhnsbZQ+kyO0nLBUkWEvAqvJnDbMgJE9Ih0DmAGym\n\tjoN+4C+bXxkqrsv5xwaegtJVtJc6k9h2RDuAopeiow8OIZWXojLesaVqMmDyQbRRbQ\n\ti0OeeEb40Nvm8v+p2R5Uaqee4T5MTD67ZgszJ/BDnDpGxKqfVYg4yTweVRg5xN87PQ\n\tqI/RBd6P+G0bPktpqoaH3sjYt/P51ih0pF6ySgRp9I6sNTRFatVE0CFRga9AxDtcKd\n\tM9mCjKEAaxPoOpyXqO/Q82WiFNF9TZzAafhvIVoHIKhGWmllo+u79canjw2DmUqEed\n\tRtF94sx1O1Z6w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660305235;\n\tbh=t6oy10QtAa3B5sNQBz73X8FbiBhhSVJjS6nDueuOBqs=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=W6yF05OEathMYK6ef2GmGIVYBartNe6IREDjGsPk8pYa4rfsSFzlhmWcGGtdYaTdr\n\tE2vxyXaWX0eGwqjlnp+1Vx4nhCcBtarxrROl58j/rcikogUsd6kGJSg8Azl6zhWMkt\n\tiBNyqztpnx+n9YaU8yNgwSGf8dXfeQWh1uE3qlFQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"W6yF05OE\"; dkim-atps=neutral","Message-ID":"<388d9564-fd7c-1b18-139f-a18cb97a2714@ideasonboard.com>","Date":"Fri, 12 Aug 2022 17:23:49 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"libcamera-devel@lists.libcamera.org","References":"<20220802185719.380855-1-umang.jain@ideasonboard.com>","In-Reply-To":"<20220802185719.380855-1-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC PATCH 0/4] Colorspace adjustments and\n\tgstreamer mapping","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"rishikeshdonadkar@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]