{"id":16848,"url":"https://patchwork.libcamera.org/api/covers/16848/?format=json","web_url":"https://patchwork.libcamera.org/cover/16848/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220727222149.30627-1-laurent.pinchart@ideasonboard.com>","date":"2022-07-27T22:21:40","name":"[libcamera-devel,v5,0/9] ipa: rkisp1: Add GSL, LSC, DPCC, Filter and CProc algorithms","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/16848/mbox/","series":[{"id":3338,"url":"https://patchwork.libcamera.org/api/series/3338/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3338","date":"2022-07-27T22:21:40","name":"ipa: rkisp1: Add GSL, LSC, DPCC, Filter and CProc algorithms","version":5,"mbox":"https://patchwork.libcamera.org/series/3338/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/16848/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91256BE173\n\tfor ;\n\tWed, 27 Jul 2022 22:21:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D451A6330E;\n\tThu, 28 Jul 2022 00:21:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2AD7E60487\n\tfor ;\n\tThu, 28 Jul 2022 00:21:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 892F16D4;\n\tThu, 28 Jul 2022 00:21:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658960513;\n\tbh=KoWKmuclHfejlGDMPrOI4la/ACRT+k8qp7zSHPqRClk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=pFH0mc6ysaWRyzWUg4uMXydse8f/WLUizprrocg1uFy+ItL7JPCltTToFMeNDZaVx\n\tX1qFsd/dEQ3tvdD7aXbsp4DIdOByXZn6cD4brTpKoPqpdxlEJfYpBDcylYC9NTyMOn\n\tpyVohd7Yb6oCUV7LxMPiiLrR0cw+ir/CCI5Sj+A6TDMCRsz1dgD80A03gHb6T3hqub\n\tV0juNR1Rc1qw+o8KkxpFgcdaK9TshomV1CULy1NDolxAdZmoNmP71byPrOZDhYMHyw\n\tdR5YdFE9rQYa3WeY4scwDUBcpXY0T/+aqmyrph/EZOHZyMezGlBH17kY9PtNS+RKsf\n\tP+Hdys3lkB51g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658960511;\n\tbh=KoWKmuclHfejlGDMPrOI4la/ACRT+k8qp7zSHPqRClk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ARdQPxhXYVFhn2Dh5cqWbhJFO7qRdx6kC88NWm2HPJOpxdzd7yphN4iv1Ho0xuksg\n\tnKgfH5zpkoBnnVDfIgYML/zzV+qbnmYDXDrYASmn9/YNxSfea05+xQdfFhkVxThQFG\n\tPsyx0xy96uxqdffOgT+mBLUWKPlVP4ELi6mAVX7A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ARdQPxhX\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 28 Jul 2022 01:21:40 +0300","Message-Id":"<20220727222149.30627-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 0/9] ipa: rkisp1: Add GSL, LSC, DPCC,\n\tFilter and CProc algorithms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series combines the series \"[PATCH v4 0/2] Add Filter and\nColor Processing control for rkisp1\" and \"[PATCH v4 0/5] Add GSL, LSC\nand DPCC tuning support for rkisp1\" previously posted by Florian (very\nconveniently both numbered v4, making this a clear v5).\n\nThe v4's were mostly fine, with just minor changes needed in \"[PATCH v4\n2/2] ipa: rkisp1: Add support of ColorProcessing control\" that could\nhave been handled when applying. However, the independently developed\n\"[PATCH v7 01/14] libcamera: yaml_parser: Replace ok flag to get() with\nstd::optional\" conflicts, and I would like to merge it first. v5 is thus\na rebase.\n\nPatch 1/9 is new and adds a new variables to the utils namespace to\nfacilitate usage of std::optional when it stores complex types. Patch\n2/9 is the YAML parser enhancement mentioned above that caused the v5,\nand patch 3/9 is Florian's YamlObject::getList() implementation rebased\non 2/9 and ported to use std::optional.\n\nAfter that, patches 4/9 to 9/9 are from Florian. Beside the rebase, the\nonly change is the minor replacement of float values with integers in\n9/9.\n\nI have left \"[RFC PATCH] ipa: rkisp1: dpcc: Generalize YAML parsing\" out\nof the series as it still needs to be reviewed. The patch can be merged\nlater on top (if we decide not to drop it).\n\nAs patch 1/9 is new, it lacks a Reviewed-by tag which thus blocks the\nrest of the series. Reviews would thus be appreciated :-) See patch 5/9\nand 6/9 for example usages of utils::defopt.\n\nFlorian Sylvestre (7):\n libcamera: yaml_parser: Add getList() function\n include: linux: Update rkisp1 kernel header for DPCC configuration\n ipa: rkisp1: Add support of Gamma Sensor Linearization control\n ipa: rkisp1: Add support of Lens Shading Correction control\n ipa: rkisp1: Add support of Defect Pixel Cluster Correction control\n ipa: rkisp1: Add support of Filter control\n ipa: rkisp1: Add support of ColorProcessing control\n\nLaurent Pinchart (2):\n libcamera: base: utils: Provide defopt to simplify\n std::optional::value_or() usage\n libcamera: yaml_parser: Replace ok flag to get() with std::optional\n\n include/libcamera/base/utils.h | 14 ++\n include/libcamera/internal/yaml_parser.h | 25 ++-\n include/linux/rkisp1-config.h | 77 +++++--\n src/ipa/rkisp1/algorithms/cproc.cpp | 97 +++++++++\n src/ipa/rkisp1/algorithms/cproc.h | 30 +++\n src/ipa/rkisp1/algorithms/dpcc.cpp | 254 +++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpcc.h | 31 +++\n src/ipa/rkisp1/algorithms/filter.cpp | 201 ++++++++++++++++++\n src/ipa/rkisp1/algorithms/filter.h | 30 +++\n src/ipa/rkisp1/algorithms/gsl.cpp | 149 +++++++++++++\n src/ipa/rkisp1/algorithms/gsl.h | 34 +++\n src/ipa/rkisp1/algorithms/lsc.cpp | 178 ++++++++++++++++\n src/ipa/rkisp1/algorithms/lsc.h | 38 ++++\n src/ipa/rkisp1/algorithms/meson.build | 5 +\n src/ipa/rkisp1/data/ov5640.yaml | 147 +++++++++++++\n src/ipa/rkisp1/ipa_context.cpp | 34 +++\n src/ipa/rkisp1/ipa_context.h | 14 ++\n src/ipa/rkisp1/rkisp1.cpp | 1 +\n src/libcamera/base/utils.cpp | 21 ++\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 20 ++\n src/libcamera/yaml_parser.cpp | 197 ++++++++++--------\n test/utils.cpp | 54 +++++\n test/yaml-parser.cpp | 77 +++----\n 23 files changed, 1587 insertions(+), 141 deletions(-)\n create mode 100644 src/ipa/rkisp1/algorithms/cproc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/cproc.h\n create mode 100644 src/ipa/rkisp1/algorithms/dpcc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/dpcc.h\n create mode 100644 src/ipa/rkisp1/algorithms/filter.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/filter.h\n create mode 100644 src/ipa/rkisp1/algorithms/gsl.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/gsl.h\n create mode 100644 src/ipa/rkisp1/algorithms/lsc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/lsc.h\n\n\nbase-commit: 22ffeae04de2e7ce6b2476a35233c790beafb67f"}