[{"id":24007,"web_url":"https://patchwork.libcamera.org/comment/24007/","msgid":"","date":"2022-07-20T14:54:07","subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart\n wrote:\n>\n> Hello,\n>\n> This patch series bundles a new version of Eric's SDL2_image replacement\n> with an additional cleanup for the cam SDL support. I've numbered it v5\n> as Eric's patch (now 1/2) was v4, but patch 2/2 is new.\n>\n> The changes in 1/2 just incorporates my review comments, I've decided to\n> send the result as I had already made the changes locally to test the\n> review recommedations.\n>\n> Eric, please feel free to disagree with any of the changes :-)\n> Otherwise, if you're OK with them, I'll apply the series.\n\nI tested and reviewed the patches, all good on my end!\n\n>\n> Eric Curtin (1):\n> cam: sdl_sink: Use libjpeg over SDL2_image\n>\n> Laurent Pinchart (1):\n> cam: sdl_sink: Pass a Span to SDLTexture::update()\n>\n> README.rst | 2 +-\n> src/cam/meson.build | 8 ++--\n> src/cam/sdl_sink.cpp | 4 +-\n> src/cam/sdl_texture.h | 2 +-\n> src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----\n> src/cam/sdl_texture_mjpg.h | 8 +++-\n> src/cam/sdl_texture_yuyv.cpp | 2 +-\n> src/cam/sdl_texture_yuyv.h | 2 +-\n> 8 files changed, 82 insertions(+), 18 deletions(-)\n>\n>\n> base-commit: 8b02645845bf404fba83910818b285b652f14f89\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5000BBE173\n\tfor ;\n\tWed, 20 Jul 2022 14:54:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8039463312;\n\tWed, 20 Jul 2022 16:54:33 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA20760489\n\tfor ;\n\tWed, 20 Jul 2022 16:54:31 +0200 (CEST)","from mail-qt1-f199.google.com (mail-qt1-f199.google.com\n\t[209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-640-UgSOxS2OOEKSfUyEyTF1XQ-1; Wed, 20 Jul 2022 10:54:23 -0400","by mail-qt1-f199.google.com with SMTP id\n\tu12-20020a05622a010c00b0031ef5b46dc0so4910289qtw.16\n\tfor ;\n\tWed, 20 Jul 2022 07:54:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658328873;\n\tbh=/0XC4kxKDApA7wbFUhVaVq7a+21XmeoRlPdp/9xDSGA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EqJyBZ9+DgwOWXSV1i67n1W1YLVyXMnrLXiohQ4sPIeYySGhuV1OPP9a2epjMtXqi\n\t4wL1fwMTamWeOznf+2tmnYikeJu79l1obwQFapffXLkWWwPTGUk3pBFo3lMe3CXs9f\n\tWs1NWQ4wUVrU/+kOicddUiCDOmzIfJNBHrn5bak0VKe5R9FWNms1jh3M6F1E5a4iin\n\tKa6mz0WtQW2Jumc7cur3g2Z519TqCnCUJKwEtuydU8XzPKptY/zmgS3ceFJVfvM2EX\n\tt4hCAxQOXP1rd/3MRM+t0jwEBLffcmdIYejoGEpoujGPXZJVneo7ckP4ukJpJbKfD+\n\tMVgszM3bswetA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658328870;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Svwzj/kzWpq4Ld30qE8PuJw1UtFjSHaXMv3Lw5DN5u0=;\n\tb=PsHDonYwFC52SXYaly6VJSG/LWIO4y16+o9In6MioTnd66e8FHRjxJszOhlGXMaFXHrF+5\n\thm/3dXDSQeV2dLAtPy7iVfTATWExRimJomh2oCCWsjyWTxfS2IR7VHtXEy7YzEe/Rxu1ue\n\tBtJpJuoGfDyu1+kzGYXLEhOXXixSZqs="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"PsHDonYw\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com"],"X-MC-Unique":"UgSOxS2OOEKSfUyEyTF1XQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Svwzj/kzWpq4Ld30qE8PuJw1UtFjSHaXMv3Lw5DN5u0=;\n\tb=JhFTvUl8WAcXCGz1kJT83T3hZMcxw/yIxMhJh/kv7nN84jLFau8TxpRx7M49rcDx/0\n\tO/1DNKvAPjYw3bfZ9Zncw5cOykWKqZu395MgiJ5Vc4/yCe6d8d+GKvgh3jwv+UM3Hvau\n\tBlIbsHGXr0Gew4tLtRjtk+z489K79qO0bDi1jM+XncJyz4eDYqB99AtOr/l6ti8l5f2A\n\tZD+NzjoafUx8JQIz9Tfss2gzG/GzGQMUr84Nye+Onf5hFZNoLU/ErKW9a+FJgl2eitag\n\tqW4uHM00WovCOxwm6scYPMTQ6IE9YxS023yWIVimXmtoO1XGxJdMCmJWwuB6AmjZEtHC\n\t7atg==","X-Gm-Message-State":"AJIora/KQedr0GlbS4KN43V5dNtFxo3bYpM0LhVE+vE5Re6A7pJOndMH\n\txO14Xny4pGoa2ERqxiGASsRMBVgwkPz0T2FuxOSZ3XZtQBb9LtGuXwHxc+9PgH6dH87+PK9laZH\n\tV2OoA4m/zgDchkq0Gn79cDT38Y7qe/Xo5XTDNegd5/W7weIkJlw==","X-Received":["by 2002:ad4:5ce8:0:b0:473:d3c0:5c2d with SMTP id\n\tiv8-20020ad45ce8000000b00473d3c05c2dmr12902379qvb.83.1658328863224; \n\tWed, 20 Jul 2022 07:54:23 -0700 (PDT)","by 2002:ad4:5ce8:0:b0:473:d3c0:5c2d with SMTP id\n\tiv8-20020ad45ce8000000b00473d3c05c2dmr12902369qvb.83.1658328862975;\n\tWed, 20 Jul 2022 07:54:22 -0700 (PDT)"],"X-Google-Smtp-Source":"AGRyM1vE4amALl+3P/C6AmBf6QPaF+q2SclCLqY0H87s6C4NwNbX3pwCEmxuYMzdyzfnYlnlcM+xUY1SYEoV752Ho8I=","MIME-Version":"1.0","References":"<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>","Date":"Wed, 20 Jul 2022 15:54:07 +0100","Message-ID":"","To":"Laurent Pinchart ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24157,"web_url":"https://patchwork.libcamera.org/comment/24157/","msgid":"","date":"2022-07-26T21:52:14","subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel\nwrong lol.\n\nJust a reminder about this patch set.\n\nOn Wed 20 Jul 2022, 15:54 Eric Curtin, wrote:\n\n> On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart\n> wrote:\n> >\n> > Hello,\n> >\n> > This patch series bundles a new version of Eric's SDL2_image replacement\n> > with an additional cleanup for the cam SDL support. I've numbered it v5\n> > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.\n> >\n> > The changes in 1/2 just incorporates my review comments, I've decided to\n> > send the result as I had already made the changes locally to test the\n> > review recommedations.\n> >\n> > Eric, please feel free to disagree with any of the changes :-)\n> > Otherwise, if you're OK with them, I'll apply the series.\n>\n> I tested and reviewed the patches, all good on my end!\n>\n> >\n> > Eric Curtin (1):\n> > cam: sdl_sink: Use libjpeg over SDL2_image\n> >\n> > Laurent Pinchart (1):\n> > cam: sdl_sink: Pass a Span to SDLTexture::update()\n> >\n> > README.rst | 2 +-\n> > src/cam/meson.build | 8 ++--\n> > src/cam/sdl_sink.cpp | 4 +-\n> > src/cam/sdl_texture.h | 2 +-\n> > src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----\n> > src/cam/sdl_texture_mjpg.h | 8 +++-\n> > src/cam/sdl_texture_yuyv.cpp | 2 +-\n> > src/cam/sdl_texture_yuyv.h | 2 +-\n> > 8 files changed, 82 insertions(+), 18 deletions(-)\n> >\n> >\n> > base-commit: 8b02645845bf404fba83910818b285b652f14f89\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 556E8C3275\n\tfor ;\n\tTue, 26 Jul 2022 21:52:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB1D463312;\n\tTue, 26 Jul 2022 23:52:31 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE1F260487\n\tfor ;\n\tTue, 26 Jul 2022 23:52:29 +0200 (CEST)","from mail-qt1-f199.google.com (mail-qt1-f199.google.com\n\t[209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-580-nXt4VmbLMt2ckUmOO9HN8Q-1; Tue, 26 Jul 2022 17:52:27 -0400","by mail-qt1-f199.google.com with SMTP id\n\tw24-20020ac843d8000000b0031ecbfedc25so8185530qtn.15\n\tfor ;\n\tTue, 26 Jul 2022 14:52:27 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658872351;\n\tbh=zX5yT0/NQebmljuzLTjx8b8+F8eK68XBxuq7u0h+SD8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=247VzSy6opbrKWXPr8JoiXNYFHPeau9DzMmDOexdaCCRJhKmG+9ciBPP7imor13PM\n\tSMC2RUvUE3bALbRUOHttIAGyIPcv5Y3KFNRbieoTnhTvDa4tSNZs22xkSzzaWcLCpR\n\tGgSklwNJ1CPblLLWSXxDaMnX+ujAJJLcYi+cZcEMXvQkP5E4tKhAX+8oaE/3IDjnk2\n\tC7xiKJhNkMUqRynjLM68Q/bIR+cXp/OzxhYxmhK4ahmbUr6fm7XtmDhZOmED7+rFKZ\n\tmoVkRm+V1oTKurjAqkT51001mqkcaeis7HmBT650w2OFIG9by/9IdVKt+iaQOo0k0i\n\tKFuM+5MQg4LUA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658872348;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=z95ecwuExdh58vJK0kgHP+TSqkZMk8ahxsMlOn4UFnc=;\n\tb=WPMqJffIdkTd0FOqxcu6DLPK2r5+sjNilcI096au7BXkAFQSTNO6fU8gXN5ZDc4gF/O7An\n\tcL+qZePYrqrfelkn9VRf6Iq8oLzPLbOErRoXUmqebH34z5Qru5jNAkrCXpgx04DjJcDxbz\n\tl+gMVxDZeOuXSpBP7AbHdphdriBO5fY="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"WPMqJffI\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com"],"X-MC-Unique":"nXt4VmbLMt2ckUmOO9HN8Q-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=z95ecwuExdh58vJK0kgHP+TSqkZMk8ahxsMlOn4UFnc=;\n\tb=dsS6qRYurgxpLYqQJ2hUYlmBv5bLRoeLSaVzhsHS0b/e/CVYWi+ZFJ/8B1AcuwG+b7\n\tEBwnnNIRAATWIUUnDtMebrHY1wMqVJvn0/7liDjjsrL1Z0J6hjwNjRrIpRIAXjH/rwH1\n\tXFap+kOYW/9XU4QIaOg8coQhkJ9Nq8rbOd/mAJPK6e7sZ4VGnDFD9SeHPbfv3nZsX2hy\n\t130KQaZ4pJt2Q5RCxnkECsujv08jApn094KA7/uVvF07oEFHFz8+tSw2/7q8voicP17q\n\tO4DRFeFl6gpbDUQg0TpS1n5eP8eCJbFhOjW/hFx4+6OiDbjG4Mz49ldIhWGAu4w7dKre\n\tswrg==","X-Gm-Message-State":"AJIora8Wrvir3DHrja+08keHmwq4HD1Y58sBD4eDzxkyrATADdTUmUWF\n\tkAmqlWQkDCaeXdGhRuTCI7eHu8p/laL7/+PisoMTM+wV97BgRALaYNhwySg5kcGGl4rYvVn5mHr\n\tkGi6zXMUxyzg6TnNfAmdKilnZHHgO4q8KZJFFF14+Q8hPnsIjNg==","X-Received":["by 2002:a37:614:0:b0:6b5:cda7:694b with SMTP id\n\t20-20020a370614000000b006b5cda7694bmr14082045qkg.532.1658872346377; \n\tTue, 26 Jul 2022 14:52:26 -0700 (PDT)","by 2002:a37:614:0:b0:6b5:cda7:694b with SMTP id\n\t20-20020a370614000000b006b5cda7694bmr14082036qkg.532.1658872346130;\n\tTue, 26 Jul 2022 14:52:26 -0700 (PDT)"],"X-Google-Smtp-Source":"AGRyM1sAfNDZtp2zw0R2UxV3OgFd7RI9I8fkKOxuDqzBvJfTPt/BWpk/HWscPVjDve561mRUp0KGIJs3Qx12cb6CssU=","MIME-Version":"1.0","References":"<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>\n\t","In-Reply-To":"","Date":"Tue, 26 Jul 2022 22:52:14 +0100","Message-ID":"","To":"Laurent Pinchart ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"multipart/alternative; boundary=\"000000000000eb519005e4bc5077\"","Subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"Ian Mullins ,\n\tlibcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24159,"web_url":"https://patchwork.libcamera.org/comment/24159/","msgid":"","date":"2022-07-26T22:13:51","subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Eric,\n\nOn Tue, Jul 26, 2022 at 10:52:14PM +0100, Eric Curtin wrote:\n> I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel\n> wrong lol.\n> \n> Just a reminder about this patch set.\n\nPing for other reviewers :-)\n\n> On Wed 20 Jul 2022, 15:54 Eric Curtin wrote:\n> \n> > On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart wrote:\n> > >\n> > > Hello,\n> > >\n> > > This patch series bundles a new version of Eric's SDL2_image replacement\n> > > with an additional cleanup for the cam SDL support. I've numbered it v5\n> > > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.\n> > >\n> > > The changes in 1/2 just incorporates my review comments, I've decided to\n> > > send the result as I had already made the changes locally to test the\n> > > review recommedations.\n> > >\n> > > Eric, please feel free to disagree with any of the changes :-)\n> > > Otherwise, if you're OK with them, I'll apply the series.\n> >\n> > I tested and reviewed the patches, all good on my end!\n> >\n> > >\n> > > Eric Curtin (1):\n> > > cam: sdl_sink: Use libjpeg over SDL2_image\n> > >\n> > > Laurent Pinchart (1):\n> > > cam: sdl_sink: Pass a Span to SDLTexture::update()\n> > >\n> > > README.rst | 2 +-\n> > > src/cam/meson.build | 8 ++--\n> > > src/cam/sdl_sink.cpp | 4 +-\n> > > src/cam/sdl_texture.h | 2 +-\n> > > src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----\n> > > src/cam/sdl_texture_mjpg.h | 8 +++-\n> > > src/cam/sdl_texture_yuyv.cpp | 2 +-\n> > > src/cam/sdl_texture_yuyv.h | 2 +-\n> > > 8 files changed, 82 insertions(+), 18 deletions(-)\n> > >\n> > >\n> > > base-commit: 8b02645845bf404fba83910818b285b652f14f89","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7DC3C3275\n\tfor ;\n\tTue, 26 Jul 2022 22:13:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BFD463312;\n\tWed, 27 Jul 2022 00:13:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5A936330A\n\tfor ;\n\tWed, 27 Jul 2022 00:13:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C996415;\n\tWed, 27 Jul 2022 00:13:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658873634;\n\tbh=2Wq6EuRqYrBZo338fAD27WcuAQHnJNX7z5IpRAyf9po=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YT7VSQn49ySHZ7PoBp7OwJWlCGnnlSiRw5vUIG5jagbM3EYRSOJDfJPq6lvcMXa/Y\n\tSaE/5dhyek0joOa3stMo0+N9vuhpuAmzOdlM6Y1Vvja/6L2XBipKQA8vUts1dYIbKE\n\t/WI8TT+FrnbcVXVUKmlsCJ+7T3pduGk5Z9gque3XNsI/Te9PHmymdO0pRRy7WQY5c/\n\tHRKm4adkcLsNZuBWFms119DeoBoUyPiTtsQzAJotkXvAyl9nJE+OM8wB5SIkuYzrfs\n\tpZ7PMAj+K3tf88L5dfWCJe4z8Nh2MonvyE5IYzH6IVZTNhmDa98aZ9hUYoyzE/x8Hl\n\tV41Z/T8kx3IAQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658873632;\n\tbh=2Wq6EuRqYrBZo338fAD27WcuAQHnJNX7z5IpRAyf9po=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UumxbtwdOXtIr9J6yqne4LtQT24I3lbJeagVlpdU4kP7QWygX0idLQPLlvt2o9fLe\n\t9HVCAIL6AoPUtDKZ40DY/Vuc075AhaiClm9qrRHwXQ+ucF89jQcvhc4QhPKF3I3SiB\n\tPueWmhn7TVp0rJ9XNXYByG6vXJg9NtfIONfKVHP8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Uumxbtwd\"; dkim-atps=neutral","Date":"Wed, 27 Jul 2022 01:13:51 +0300","To":"Eric Curtin ","Message-ID":"","References":"<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Ian Mullins ,\n\tlibcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24206,"web_url":"https://patchwork.libcamera.org/comment/24206/","msgid":"","date":"2022-07-28T07:00:11","subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"@Kieran Bingham and @Ian Mullins\n\nIf you get a spare moment, would you like to do a quick review?\n\nIs mise le meas/Regards,\n\nEric Curtin\n\n\nOn Tue, 26 Jul 2022 at 23:14, Laurent Pinchart\n wrote:\n>\n> Hi Eric,\n>\n> On Tue, Jul 26, 2022 at 10:52:14PM +0100, Eric Curtin wrote:\n> > I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel\n> > wrong lol.\n> >\n> > Just a reminder about this patch set.\n>\n> Ping for other reviewers :-)\n>\n> > On Wed 20 Jul 2022, 15:54 Eric Curtin wrote:\n> >\n> > > On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart wrote:\n> > > >\n> > > > Hello,\n> > > >\n> > > > This patch series bundles a new version of Eric's SDL2_image replacement\n> > > > with an additional cleanup for the cam SDL support. I've numbered it v5\n> > > > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.\n> > > >\n> > > > The changes in 1/2 just incorporates my review comments, I've decided to\n> > > > send the result as I had already made the changes locally to test the\n> > > > review recommedations.\n> > > >\n> > > > Eric, please feel free to disagree with any of the changes :-)\n> > > > Otherwise, if you're OK with them, I'll apply the series.\n> > >\n> > > I tested and reviewed the patches, all good on my end!\n> > >\n> > > >\n> > > > Eric Curtin (1):\n> > > > cam: sdl_sink: Use libjpeg over SDL2_image\n> > > >\n> > > > Laurent Pinchart (1):\n> > > > cam: sdl_sink: Pass a Span to SDLTexture::update()\n> > > >\n> > > > README.rst | 2 +-\n> > > > src/cam/meson.build | 8 ++--\n> > > > src/cam/sdl_sink.cpp | 4 +-\n> > > > src/cam/sdl_texture.h | 2 +-\n> > > > src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----\n> > > > src/cam/sdl_texture_mjpg.h | 8 +++-\n> > > > src/cam/sdl_texture_yuyv.cpp | 2 +-\n> > > > src/cam/sdl_texture_yuyv.h | 2 +-\n> > > > 8 files changed, 82 insertions(+), 18 deletions(-)\n> > > >\n> > > >\n> > > > base-commit: 8b02645845bf404fba83910818b285b652f14f89\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD552BE173\n\tfor ;\n\tThu, 28 Jul 2022 07:00:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C65063315;\n\tThu, 28 Jul 2022 09:00:32 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 675D763314\n\tfor ;\n\tThu, 28 Jul 2022 09:00:30 +0200 (CEST)","from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n\t[209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-594-M4V_i8VEOgWaQ8QfIaHcsA-1; Thu, 28 Jul 2022 03:00:27 -0400","by mail-qk1-f199.google.com with SMTP id\n\ty17-20020a05620a25d100b006b66293d75aso864295qko.17\n\tfor ;\n\tThu, 28 Jul 2022 00:00:27 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658991632;\n\tbh=2xDY6mczggX8IAKFcO6bYeSGAJ5U/eJdHrgzy4sM4p8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oAVf7/buEgT3v6Orn++HX5xwH6FLHdWP7UhvCWcd8kaqXkefLx//TYMrfTwTKF9qr\n\tjqOqMMSd9nye3l3gCO+l91ADq1l0Jf7z1e0MenzfH4hN7vvUTWt/3yRB18gFjuDyhp\n\tgooQXKPIY+PFfqsYQw9iN9dvfuXqzOJBZs8EqDJDJLTQ5Oa7BGVEwRniIlTHAg/M3w\n\t+q1AWgJ9uGL7kghebyFnW9njPElNBULbSNPlaiKbRIVSFMPMbqK1miPypbl2KejnQa\n\tsU67R5TgBw5sobx7O6c8Oiu6HvRgkJGcLM1oAVf7Pc8EzGDOhTL0LmEv795JQQfDeR\n\tUDRUswJ65G9hA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658991629;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=jPGwOpVNUeccLBsTrN3Dm2WA0HEMBq/8f/iCDKVIe30=;\n\tb=gUMUorMm/mjfgvP5caFc++KqLCFhDsYWa0QG5D1oN5Jw1m9lpke8QiCcoAQsHhBVUe117c\n\te9Nsw8n/OKiKtYhKKxct4KTxc3h/o8j8kB8QQHluBIx7HMaECNuiMb9EmlIeUhhFgGvv8T\n\tPyWSXcjkFdCUivUNLeevzfUyU8sDoPQ="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"gUMUorMm\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com"],"X-MC-Unique":"M4V_i8VEOgWaQ8QfIaHcsA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=jPGwOpVNUeccLBsTrN3Dm2WA0HEMBq/8f/iCDKVIe30=;\n\tb=c5cvzOTP5rR0SCZ2aao/QlqF+VRB7KIsBdvNFydaH7d8P60Pkz9G+nrNSso56ulVAw\n\t/zd18TweffleJsiVlSxBqm+kctBKEGZgztJ3r6VX0Wwy2az7gzzETxN2/PPNUyTg0xxA\n\tEyqdJLBvyHa/DaW6620o4op58wAbeUFO2oFnOOAcG5t6ZrxECtbbd7EDN3rvv79TD4H9\n\t7rzVRP02B4zThQ7/tbOVJ1S295oj/oblKfXIPReR2/GCv6mRhn6gbLh7NMOFiq/h/H/Q\n\tyizKc5O3kfvV5V6/WSbWys4ncIf8i5HEdX4p0n4yb+C5OmYyeU8Fj5i7Mg8+H8CurXAK\n\tWf3Q==","X-Gm-Message-State":"AJIora9qdGH/YMz9Iv+Cmtr1YhbGPaJRLf9HqQS9np/wlpGPNqHBiMPZ\n\tg9AR1lySF5AndAE7f7UfPpPaI/RBKjU3oz/O917lnx1Zup2FktPMfZAWO5IRmESdh+VrvZ0x19V\n\ts64wvzJrUoeUqMuJ4UBrkeohK0E7FuMfeuULSQepJgE4S4bsGjQ==","X-Received":["by 2002:a37:614:0:b0:6b5:cda7:694b with SMTP id\n\t20-20020a370614000000b006b5cda7694bmr18696813qkg.532.1658991627120; \n\tThu, 28 Jul 2022 00:00:27 -0700 (PDT)","by 2002:a37:614:0:b0:6b5:cda7:694b with SMTP id\n\t20-20020a370614000000b006b5cda7694bmr18696795qkg.532.1658991626812;\n\tThu, 28 Jul 2022 00:00:26 -0700 (PDT)"],"X-Google-Smtp-Source":"AGRyM1tXvSTzcOkmVNR2TfD3Ec7wQYFX/HL/o7iFNZpxHT7s9dG8WYaQT9cYJC77vrqWL7tM49sV7KCQ6LuNfkGOKSA=","MIME-Version":"1.0","References":"<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>\n\t\n\t\n\t","In-Reply-To":"","Date":"Thu, 28 Jul 2022 08:00:11 +0100","Message-ID":"","To":"Ian Mullins ,\n\tKieran Bingham ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24220,"web_url":"https://patchwork.libcamera.org/comment/24220/","msgid":"","date":"2022-07-28T11:32:27","subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Eric,\n\nOn Thu, Jul 28, 2022 at 08:00:11AM +0100, Eric Curtin wrote:\n> @Kieran Bingham and @Ian Mullins\n> \n> If you get a spare moment, would you like to do a quick review?\n\nJacopo has reviewed the patches (thanks !), I've now pushed them.\n\n> On Tue, 26 Jul 2022 at 23:14, Laurent Pinchart wrote:\n> > On Tue, Jul 26, 2022 at 10:52:14PM +0100, Eric Curtin wrote:\n> > > I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel\n> > > wrong lol.\n> > >\n> > > Just a reminder about this patch set.\n> >\n> > Ping for other reviewers :-)\n> >\n> > > On Wed 20 Jul 2022, 15:54 Eric Curtin wrote:\n> > >\n> > > > On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart wrote:\n> > > > >\n> > > > > Hello,\n> > > > >\n> > > > > This patch series bundles a new version of Eric's SDL2_image replacement\n> > > > > with an additional cleanup for the cam SDL support. I've numbered it v5\n> > > > > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.\n> > > > >\n> > > > > The changes in 1/2 just incorporates my review comments, I've decided to\n> > > > > send the result as I had already made the changes locally to test the\n> > > > > review recommedations.\n> > > > >\n> > > > > Eric, please feel free to disagree with any of the changes :-)\n> > > > > Otherwise, if you're OK with them, I'll apply the series.\n> > > >\n> > > > I tested and reviewed the patches, all good on my end!\n> > > >\n> > > > >\n> > > > > Eric Curtin (1):\n> > > > > cam: sdl_sink: Use libjpeg over SDL2_image\n> > > > >\n> > > > > Laurent Pinchart (1):\n> > > > > cam: sdl_sink: Pass a Span to SDLTexture::update()\n> > > > >\n> > > > > README.rst | 2 +-\n> > > > > src/cam/meson.build | 8 ++--\n> > > > > src/cam/sdl_sink.cpp | 4 +-\n> > > > > src/cam/sdl_texture.h | 2 +-\n> > > > > src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----\n> > > > > src/cam/sdl_texture_mjpg.h | 8 +++-\n> > > > > src/cam/sdl_texture_yuyv.cpp | 2 +-\n> > > > > src/cam/sdl_texture_yuyv.h | 2 +-\n> > > > > 8 files changed, 82 insertions(+), 18 deletions(-)\n> > > > >\n> > > > >\n> > > > > base-commit: 8b02645845bf404fba83910818b285b652f14f89","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBADEC3275\n\tfor ;\n\tThu, 28 Jul 2022 11:32:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3333F63312;\n\tThu, 28 Jul 2022 13:32:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADBEE6330D\n\tfor ;\n\tThu, 28 Jul 2022 13:32:30 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 129F656D;\n\tThu, 28 Jul 2022 13:32:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659007952;\n\tbh=iRF1TkFJ6G7fHE2WhfsiY6lZdiTf7/5CTVcjLLJ/3Fs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=haQWJzhwarHM+JudD/HMMndZN/JX/oVrlUVLkss9ftc9AqhO0Y1gjATL9YZQLzI+t\n\t1Q9VJByaOYYK3o9vRHOBufw5pI1fGjIeC2+WflQlw3EVwsjmnuhCvAe2EFuwA8QVWL\n\tCKBvV2nsLd0L9efWKc+o1szHSq5lIeSrXSHHn/z2GLHR4v3K79oGnPqCzp6B0TbKt0\n\tBiNpgc/q2tRA5jG9s68UZZ38/jHU6C4/IbtIeLYcWRVRoYJ9lT02RY+0uQ5vXI1WSU\n\tZ/kBDRlscM6E0rBFh2+inoCviQKxXGsDhXrcNrneuSEaUPwXp4UlYb8Ih2GcNgXfcT\n\t2QaAHGTepzpOw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659007950;\n\tbh=iRF1TkFJ6G7fHE2WhfsiY6lZdiTf7/5CTVcjLLJ/3Fs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nChRtepyxAhOVFHvEIX7wdhyUIrHU3dWoHWcqPv+DVplj9H44wGwMqKM1y2H6sWp1\n\tbQjdAbO2o6S9O+N8bAhmDNg8fX0CgapgLqW26zghv4/bno12XEnQvs4QhxhP4Fnn4M\n\txg0yNkjMBPY+7oVoGAbjli1W0onlR1/GRhCHofsE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nChRtepy\"; dkim-atps=neutral","Date":"Thu, 28 Jul 2022 14:32:27 +0300","To":"Eric Curtin ","Message-ID":"","References":"<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>\n\t\n\t\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on\n\tSDL2_image with libjpeg","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Ian Mullins ,\n\tlibcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]