[{"id":23980,"web_url":"https://patchwork.libcamera.org/comment/23980/","msgid":"","date":"2022-07-19T22:43:03","subject":"Re: [libcamera-devel] [RFC PATCH 0/2] rkisp1: Get supported formats\n\tfrom driver","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Tue, Jul 19, 2022 at 09:10:01PM +0900, Paul Elder via libcamera-devel wrote:\n> This series makes the rkisp1 pipeline get the list of supported formats\n> from the V4L2 device, as opposed to hardcoding it as before. This lets\n> us add support for, notably, UYVY without having to worry about driver\n> versions.\n> \n> The current implementation of V4L2VideoDevice prevents this from working\n> as-is, so it is massaged in patch 1.\n> \n> This series also obviously deprecates the series that I sent earlier\n> today: v3 \"pipeline: rkisp1: Support devices without self path\". That\n\nDid you mean to mention another patch here ? Supporting devices without\na self path still seems relevant to me.\n\n> series was meant to be a quick fix for the formats that we know are\n> supported for all versions of the driver.\n> \n> Paul Elder (2):\n> libcamera: v4l2_videodevice: Get formats even if no framesizes\n> pipeline: rkisp1: Query the driver for formats\n> \n> include/libcamera/internal/v4l2_videodevice.h | 2 +-\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 50 +++++++++----------\n> src/libcamera/pipeline/rkisp1/rkisp1_path.h | 6 ++-\n> src/libcamera/v4l2_videodevice.cpp | 12 +++--\n> 4 files changed, 38 insertions(+), 32 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01A70BD1F1\n\tfor ;\n\tTue, 19 Jul 2022 22:43:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72FCF63312;\n\tWed, 20 Jul 2022 00:43:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A56B6603F1\n\tfor ;\n\tWed, 20 Jul 2022 00:43:37 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17ACF6DB;\n\tWed, 20 Jul 2022 00:43:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658270619;\n\tbh=cgg6QXL/FyaVeiKQbwNxQmtRGi5as+/XYDa831Uce0g=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GJ3v8epltD5Vbrj5ZhQavQJBeqOG8WzYMtzjlnm0oa4Ubbr2vpJtYVdAhMIbtvjN1\n\tsGKUA90sb5WD07sDECELX//bS0lb86VDz5lY/zEAFvdesyCcRPcBgh9MXpDReHbTV0\n\tCoAv8892hRU+wBMPPIBT7OVTxm8/1RgVDs016H2ypQF6QQp8vfGPI3sA03LtLuNoOl\n\tBPwk5Ns9IclYJXVMEVmbKYfbV/cTHz1x3dDXumfa/0oeaU8gu9r37Jq9YD0wJr+irg\n\tX9q/PYuqX/GJVeqxOlhQIYbeiK995MJfB10zf7lTpKjAM6kin5Ru9B7CnTdttflut6\n\tsDCPtwObMJVOw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658270617;\n\tbh=cgg6QXL/FyaVeiKQbwNxQmtRGi5as+/XYDa831Uce0g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tpZLiCD9twQ2YSxOYF8i8NJaYFys3S9ep5J8TVoUZIQ7u3LtZPpOCzd2BOkKkcW/1\n\tTzydcUU8xwG8zidJmB+ezY4+rmj+eFzsI3D1CUwGMog1GPTXeoTkTuO/QspH4LEUWb\n\tWG9wLQEIE6qAP08LGVq7ZNwl3DrYJWTRT2oXeoLY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tpZLiCD9\"; dkim-atps=neutral","Date":"Wed, 20 Jul 2022 01:43:03 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220719121003.1829916-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220719121003.1829916-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 0/2] rkisp1: Get supported formats\n\tfrom driver","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24000,"web_url":"https://patchwork.libcamera.org/comment/24000/","msgid":"<20220720100517.GE3984498@pyrite.rasen.tech>","date":"2022-07-20T10:05:17","subject":"Re: [libcamera-devel] [RFC PATCH 0/2] rkisp1: Get supported formats\n\tfrom driver","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Wed, Jul 20, 2022 at 01:43:03AM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> On Tue, Jul 19, 2022 at 09:10:01PM +0900, Paul Elder via libcamera-devel wrote:\n> > This series makes the rkisp1 pipeline get the list of supported formats\n> > from the V4L2 device, as opposed to hardcoding it as before. This lets\n> > us add support for, notably, UYVY without having to worry about driver\n> > versions.\n> > \n> > The current implementation of V4L2VideoDevice prevents this from working\n> > as-is, so it is massaged in patch 1.\n> > \n> > This series also obviously deprecates the series that I sent earlier\n> > today: v3 \"pipeline: rkisp1: Support devices without self path\". That\n> \n> Did you mean to mention another patch here ? Supporting devices without\n> a self path still seems relevant to me.\n\nYeah, I meant v2 of \"pipeline: rkisp1: Add output support for YUV420 and\nYVU420\" :/\n\n\nPaul\n\n> \n> > series was meant to be a quick fix for the formats that we know are\n> > supported for all versions of the driver.\n> > \n> > Paul Elder (2):\n> > libcamera: v4l2_videodevice: Get formats even if no framesizes\n> > pipeline: rkisp1: Query the driver for formats\n> > \n> > include/libcamera/internal/v4l2_videodevice.h | 2 +-\n> > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 50 +++++++++----------\n> > src/libcamera/pipeline/rkisp1/rkisp1_path.h | 6 ++-\n> > src/libcamera/v4l2_videodevice.cpp | 12 +++--\n> > 4 files changed, 38 insertions(+), 32 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07315BD1F1\n\tfor ;\n\tWed, 20 Jul 2022 10:05:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C5D063310;\n\tWed, 20 Jul 2022 12:05:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B29F8601B8\n\tfor ;\n\tWed, 20 Jul 2022 12:05:24 +0200 (CEST)","from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A4396DB;\n\tWed, 20 Jul 2022 12:05:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658311526;\n\tbh=6To7crAIenyKEVR2x8txkEq/QHCpBbKXs+tKF0+Zzo0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BkBv3QAmYTjaRyp6IzjdMppInUOLTCDdhcuIBbIKBzN+Xq8y5bW2dZLQj0PqIE9Qz\n\tj20ZKQ/3yCChCRW0tT2rT2HReRBGtuHbG1Gs1feknI56k8VewQRLfD9UnlfAnOVFqK\n\tsoTCE8dvN25OcI8JXBXjSqY5POorphuSGlYo6DPwksv+knmmORJwjd5Vit2C3/M8qi\n\tNjo/EBQTRwXFuoxkNXjiQswhRZlGrSbII8vJd/ow5OZ/R7m+0KVYURcb7fgd/z/kKJ\n\tuQFd0iA0F0DaVpGpicAYyrRps/15jxSFYOvsYnBZoxdvxyYiv84bUJ9gJpG17W0jWQ\n\towiGH14dv7Y/Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658311524;\n\tbh=6To7crAIenyKEVR2x8txkEq/QHCpBbKXs+tKF0+Zzo0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DF3a4Zz4CmOHpH6JG5iXoGV97Ga62kKOAy0SEY7jQBT0iK4boVNtOF+AlKzRvWsqv\n\tFSPGYTD6OcEbT3E46a6W/fyEysV2myQY73O2MMAbQUDBq4dAPkFnDlRSidsNBS85yo\n\tu7wk7ViwZrKvhnFVBaEiPUPpAU/GQld16FzrkZ4c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DF3a4Zz4\"; dkim-atps=neutral","Date":"Wed, 20 Jul 2022 19:05:17 +0900","To":"Laurent Pinchart ","Message-ID":"<20220720100517.GE3984498@pyrite.rasen.tech>","References":"<20220719121003.1829916-1-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH 0/2] rkisp1: Get supported formats\n\tfrom driver","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]