[{"id":25701,"web_url":"https://patchwork.libcamera.org/comment/25701/","msgid":"","date":"2022-11-01T04:53:10","subject":"Re: [libcamera-devel] [PATCH v6 0/6] Add CrOS JEA implementation","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hello folks,\n\nIt's been a while since the last update. If there's no other dispute, may\nwe merge the series of patches recently?\nThanks!\n\n\nOn Fri, Jul 15, 2022 at 11:38 PM Harvey Yang \nwrote:\n\n> Hi all,\n>\n> Fixed thumbnail buffer issue.\n>\n> Please help review and merge them if possible :)\n> Thanks!\n>\n> BR,\n> Harvey\n>\n> Harvey Yang (6):\n> Allow inheritance of FrameBuffer\n> Add HALFrameBuffer and replace FrameBuffer in src/android\n> Add meson.build in src/android/jpeg\n> Move generateThumbnail from PostProcessorJpeg to Encoder\n> Pass StreamBuffer to Encoder::encoder\n> Add JEA implementation\n>\n> include/libcamera/framebuffer.h | 3 +-\n> src/android/camera_device.cpp | 3 +-\n> src/android/cros/camera3_hal.cpp | 2 +\n> src/android/cros_mojo_token.h | 12 ++\n> src/android/frame_buffer_allocator.h | 7 +-\n> src/android/hal_framebuffer.cpp | 23 +++\n> src/android/hal_framebuffer.h | 27 ++++\n> src/android/jpeg/encoder.h | 10 +-\n> src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n> src/android/jpeg/encoder_jea.h | 35 +++++\n> src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----\n> src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n> src/android/jpeg/meson.build | 16 +++\n> src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n> src/android/jpeg/post_processor_jpeg.h | 11 +-\n> src/android/meson.build | 6 +-\n> .../mm/cros_frame_buffer_allocator.cpp | 14 +-\n> .../mm/generic_frame_buffer_allocator.cpp | 12 +-\n> 18 files changed, 391 insertions(+), 114 deletions(-)\n> create mode 100644 src/android/cros_mojo_token.h\n> create mode 100644 src/android/hal_framebuffer.cpp\n> create mode 100644 src/android/hal_framebuffer.h\n> create mode 100644 src/android/jpeg/encoder_jea.cpp\n> create mode 100644 src/android/jpeg/encoder_jea.h\n> create mode 100644 src/android/jpeg/meson.build\n>\n> --\n> 2.37.0.170.g444d1eabd0-goog\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2B76BDB16\n\tfor ;\n\tTue, 1 Nov 2022 04:53:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 017E66303A;\n\tTue, 1 Nov 2022 05:53:23 +0100 (CET)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97FD961F44\n\tfor ;\n\tTue, 1 Nov 2022 05:53:21 +0100 (CET)","by mail-wr1-x42e.google.com with SMTP id y16so18612821wrt.12\n\tfor ;\n\tMon, 31 Oct 2022 21:53:21 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667278403;\n\tbh=QZvq5MUf7UTS3tfx8Dr3GCfZnPQ+sZHbjC39gvkdy2s=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=pV+pPfy0HKbTB8RE+3lGZ4So4YVb9HW3U7ZmNbH5V/mKjK/+szM5hPpNl/tRzh8si\n\tdRpF9ZIkv6p1rUwpW/rHSm9OACAvyK97WbtEPQmEGjrpfFpQI72T7NYbZ1msS2h/mZ\n\tMNzIi6mhB0ibiFOuRFgfWozDSt2eYqULOKyQ3h0EZpzcAOz18jn39Yq1AYTZb2T+3R\n\txfJzoc+gjcMMQLtTsNwN4+BR3moDNr7OrsbAHRKXoLqQ/7s6n6vIYCsBfjbL+IQnSR\n\t6jTKYj1pg+hK+394f3H+JyVsoAaXXKb66JqH/mBUbMUIaqNeJVdFxhh0Ybcdxe70da\n\tuywPail8FuxPw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=wjVwPehkDYFJFYuAlZYdHyjl7n+Z8hVF5cphm9uyNO8=;\n\tb=WI23idP9Efje7aN3Ci3f7p9T5x34MznYVBVIGXMn85ad4sC1OQYIERMYEgPmGltG74\n\t0lmCnFh5+3a4+bmElgjY0FzH8Ev2hrinMdrL74zDrHqe6H/QNiSiXdWrjfWqca+SaF4+\n\tBvEwRkAlLzJ6w5hrjP4vU+SK1rbvi38OTUh7w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"WI23idP9\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=wjVwPehkDYFJFYuAlZYdHyjl7n+Z8hVF5cphm9uyNO8=;\n\tb=Cm6xCMyjonmnUIAYIttnmjU9QfW/vXjZxUOxr3plBoCM6E6OUI9rvNuO7VSx26NFKi\n\tOhhJyLXw7qY1dmAaLxxJzdQTZ53ItPf4TcyFGDGhpKEpdV0A7+VykKxnEkJrjM92vV+1\n\tvsFmp/0IIHycCOfI+2uN7CiWhKXshrwEpukYzL3puOmXd051H6NRZJ8DdYTauDAZOQ8v\n\tpZMws0hALK4FypORa0m/Ffnl48FRxpF1z/UzdrfKCbH8d+uRYCvvn+RjoQ/dNoXjzjXP\n\tWt4OVrYESikMaCeQerAhmkuj0v5HdVzPsiXUAUbtR4Y5g2er6bS/6zENNu/hBBX0cujA\n\tJFTA==","X-Gm-Message-State":"ACrzQf0WnV4rFoqjo5jcpVvyzJg3ZsPOvRV4KvaIqlMgAsz/iIF+LHLA\n\tBtjyE+PFNcVOSpGSgn91XTJ9Jn2K4SOC8n+kSRX1SC5H6NY=","X-Google-Smtp-Source":"AMsMyM64qF1OOwNjyenoSl/TKZ0lMxS0IVg4hj0CYjLeLSzUqN1Nym+D//H5yH3MerkmXP7bSBYkoykRtAKrlKwh+pY=","X-Received":"by 2002:a5d:588e:0:b0:236:6fcb:f884 with SMTP id\n\tn14-20020a5d588e000000b002366fcbf884mr10572117wrf.116.1667278400820;\n\tMon, 31 Oct 2022 21:53:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20220715143822.672321-1-chenghaoyang@google.com>","In-Reply-To":"<20220715143822.672321-1-chenghaoyang@google.com>","Date":"Tue, 1 Nov 2022 13:53:10 +0900","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000d2add105ec6180dc\"","Subject":"Re: [libcamera-devel] [PATCH v6 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Cheng-Hao Yang via libcamera-devel\n\t","Reply-To":"Cheng-Hao Yang ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25897,"web_url":"https://patchwork.libcamera.org/comment/25897/","msgid":"<166929859225.2936560.9076573861936904355@Monstersaurus>","date":"2022-11-24T14:03:12","subject":"Re: [libcamera-devel] [PATCH v6 0/6] Add CrOS JEA implementation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Cheng-Hao Yang via libcamera-devel (2022-11-01 04:53:10)\n> Hello folks,\n> \n> It's been a while since the last update. If there's no other dispute, may\n> we merge the series of patches recently?\n> Thanks!\n\nAs this is the android layer - is there anyone at Google/Chromium who\ncan do a review on this series ?\n\n--\nKieran\n\n\n> On Fri, Jul 15, 2022 at 11:38 PM Harvey Yang \n> wrote:\n> \n> > Hi all,\n> >\n> > Fixed thumbnail buffer issue.\n> >\n> > Please help review and merge them if possible :)\n> > Thanks!\n> >\n> > BR,\n> > Harvey\n> >\n> > Harvey Yang (6):\n> > Allow inheritance of FrameBuffer\n> > Add HALFrameBuffer and replace FrameBuffer in src/android\n> > Add meson.build in src/android/jpeg\n> > Move generateThumbnail from PostProcessorJpeg to Encoder\n> > Pass StreamBuffer to Encoder::encoder\n> > Add JEA implementation\n> >\n> > include/libcamera/framebuffer.h | 3 +-\n> > src/android/camera_device.cpp | 3 +-\n> > src/android/cros/camera3_hal.cpp | 2 +\n> > src/android/cros_mojo_token.h | 12 ++\n> > src/android/frame_buffer_allocator.h | 7 +-\n> > src/android/hal_framebuffer.cpp | 23 +++\n> > src/android/hal_framebuffer.h | 27 ++++\n> > src/android/jpeg/encoder.h | 10 +-\n> > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n> > src/android/jpeg/encoder_jea.h | 35 +++++\n> > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----\n> > src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n> > src/android/jpeg/meson.build | 16 +++\n> > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n> > src/android/jpeg/post_processor_jpeg.h | 11 +-\n> > src/android/meson.build | 6 +-\n> > .../mm/cros_frame_buffer_allocator.cpp | 14 +-\n> > .../mm/generic_frame_buffer_allocator.cpp | 12 +-\n> > 18 files changed, 391 insertions(+), 114 deletions(-)\n> > create mode 100644 src/android/cros_mojo_token.h\n> > create mode 100644 src/android/hal_framebuffer.cpp\n> > create mode 100644 src/android/hal_framebuffer.h\n> > create mode 100644 src/android/jpeg/encoder_jea.cpp\n> > create mode 100644 src/android/jpeg/encoder_jea.h\n> > create mode 100644 src/android/jpeg/meson.build\n> >\n> > --\n> > 2.37.0.170.g444d1eabd0-goog\n> >\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD66CBDE6B\n\tfor ;\n\tThu, 24 Nov 2022 14:03:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D94D63321;\n\tThu, 24 Nov 2022 15:03:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 830B66330D\n\tfor ;\n\tThu, 24 Nov 2022 15:03:14 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19A60496;\n\tThu, 24 Nov 2022 15:03:14 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669298596;\n\tbh=rAwA28Kk5E2YxOvayf5HtzJsxDhU11sE1mkLxb4emzQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=z+I84zE9PKTk/zrlDkLKSjM9/FtDmI9SB2xqxq2gQHGjUwW/N12Kbbux/2fpKeVCy\n\tWLSxnljIfkprMRzj52kqca4ID4FgGYaDG2MVfRPanFoCTnztiopT8s/Fn7aKK0ZKoF\n\tBQQtazQ3YeOW/ricuUjMBKtcUaYQSHU7R1hcuCZJ03a2if19itJC2OvHvMPr/KrvW3\n\t1gHI0v03FVwNp0ztW0brdAhDVqq6fsVxDwRm+ujGaTjkmIAUXUCYQSOI8+sCqVyZu1\n\t9rX8s7zRit+HErAHlqKQpFsSgrVbtFjj2Rf2jR/yjFGSDa0gg4MQQ1ak7IEf/3z8oh\n\tFyjH9IBcqHPUA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669298594;\n\tbh=rAwA28Kk5E2YxOvayf5HtzJsxDhU11sE1mkLxb4emzQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=I5vClb2MXz3a9O6r+gvMAFtloeo0Jl2eol3qZtKmeTzQe+wpoDRcc5VnkNbhGYdTI\n\t537Bqtm3obWzkMluvKgz+7kAQFDGhhxkTIfwmvfuOK4Mo9mVbRxwX5OM1oE9DBuR5k\n\tDOq/21Cnx4LB3EehlPpG+H+VgRJtelKeqgyJC3kg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"I5vClb2M\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220715143822.672321-1-chenghaoyang@google.com>\n\t","To":"Cheng-Hao Yang ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 24 Nov 2022 14:03:12 +0000","Message-ID":"<166929859225.2936560.9076573861936904355@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v6 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25907,"web_url":"https://patchwork.libcamera.org/comment/25907/","msgid":"","date":"2022-11-25T05:28:13","subject":"Re: [libcamera-devel] [PATCH v6 0/6] Add CrOS JEA implementation","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Han-lin,\n\nCould you do the final review, and let Kieran or Laurent help to merge the\npatches?\nThanks!\n\nOn Thu, Nov 24, 2022 at 10:03 PM Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Quoting Cheng-Hao Yang via libcamera-devel (2022-11-01 04:53:10)\n> > Hello folks,\n> >\n> > It's been a while since the last update. If there's no other dispute, may\n> > we merge the series of patches recently?\n> > Thanks!\n>\n> As this is the android layer - is there anyone at Google/Chromium who\n> can do a review on this series ?\n>\n> --\n> Kieran\n>\n>\n> > On Fri, Jul 15, 2022 at 11:38 PM Harvey Yang \n> > wrote:\n> >\n> > > Hi all,\n> > >\n> > > Fixed thumbnail buffer issue.\n> > >\n> > > Please help review and merge them if possible :)\n> > > Thanks!\n> > >\n> > > BR,\n> > > Harvey\n> > >\n> > > Harvey Yang (6):\n> > > Allow inheritance of FrameBuffer\n> > > Add HALFrameBuffer and replace FrameBuffer in src/android\n> > > Add meson.build in src/android/jpeg\n> > > Move generateThumbnail from PostProcessorJpeg to Encoder\n> > > Pass StreamBuffer to Encoder::encoder\n> > > Add JEA implementation\n> > >\n> > > include/libcamera/framebuffer.h | 3 +-\n> > > src/android/camera_device.cpp | 3 +-\n> > > src/android/cros/camera3_hal.cpp | 2 +\n> > > src/android/cros_mojo_token.h | 12 ++\n> > > src/android/frame_buffer_allocator.h | 7 +-\n> > > src/android/hal_framebuffer.cpp | 23 +++\n> > > src/android/hal_framebuffer.h | 27 ++++\n> > > src/android/jpeg/encoder.h | 10 +-\n> > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n> > > src/android/jpeg/encoder_jea.h | 35 +++++\n> > > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----\n> > > src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n> > > src/android/jpeg/meson.build | 16 +++\n> > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n> > > src/android/jpeg/post_processor_jpeg.h | 11 +-\n> > > src/android/meson.build | 6 +-\n> > > .../mm/cros_frame_buffer_allocator.cpp | 14 +-\n> > > .../mm/generic_frame_buffer_allocator.cpp | 12 +-\n> > > 18 files changed, 391 insertions(+), 114 deletions(-)\n> > > create mode 100644 src/android/cros_mojo_token.h\n> > > create mode 100644 src/android/hal_framebuffer.cpp\n> > > create mode 100644 src/android/hal_framebuffer.h\n> > > create mode 100644 src/android/jpeg/encoder_jea.cpp\n> > > create mode 100644 src/android/jpeg/encoder_jea.h\n> > > create mode 100644 src/android/jpeg/meson.build\n> > >\n> > > --\n> > > 2.37.0.170.g444d1eabd0-goog\n> > >\n> > >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB6A2BE08B\n\tfor ;\n\tFri, 25 Nov 2022 05:28:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C69963326;\n\tFri, 25 Nov 2022 06:28:27 +0100 (CET)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7C7E61F26\n\tfor ;\n\tFri, 25 Nov 2022 06:28:24 +0100 (CET)","by mail-wm1-x32e.google.com with SMTP id\n\tt25-20020a1c7719000000b003cfa34ea516so5492101wmi.1\n\tfor ;\n\tThu, 24 Nov 2022 21:28:24 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669354107;\n\tbh=YmMPkIhI4EL3mh8rwx5cZ5tgsww7LKQu+MGBKitLsUA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=39X8UoAaNd8/bRlvUk5hjF6HihGobbYk3G04gC2clVwdPYUuenHaSfa/tDltiirRa\n\t8eNwbNO8WRKNXlAUir76nsCX0dwLIolz+HF8YPepyOJV8VUx5+ayNxhtTDgT2fgRws\n\tEu4GrLZI6KXoZJZ/l8um3UN5eVx/GAcxrqPY6NKb1PehLbPCfMZcopQOIe/Y4LZzGF\n\t539TmEhZv5gdqGcTVfZWtW3nkWDwTKLR1lRH6yTGlTq3Rg+8qW3hvKjHzZpWtvxWkU\n\tzBJS2bAOPLyTwyRgChmirLQHtBOF9gVPQPYAIWWTxg+nxtfCPkAPpZIdozv5kkbQin\n\tCHPeBr0pKLZXw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=73DH7XSWdek09JrtzFik1mN/qYxcrBZUcfwpj2YIIWM=;\n\tb=BJsfGXmcEY8HWq0EKhF/GVZovwsCmsb/HlbzkJV/xco7k+RVEuVgpft32q0lyS68jV\n\tAwlfndSEQXfJQWQI2j83sBvZioaFgANisHQtA4o4VMEKLTu5oTy5//qQ5af86Dhywnuq\n\tuscs3g5s09icMxZG1fGoB4rKWmD6CaM4r7AQI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"BJsfGXmc\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=73DH7XSWdek09JrtzFik1mN/qYxcrBZUcfwpj2YIIWM=;\n\tb=K9GXU45V6VJcMDP0AXvrAc/nV8EsmQAaHVMWEXNV//33d1Vu2cyWukFH5Lpwxv4ZXf\n\tUhFApEWkEYcClVh/YVvQwtzk50iZmM3LmSeFSo11mXK4UiNN+ltvVs0q5gRSj2vPalLj\n\tcTZoBL6yw8q0+ESzfwjI3H5GxfDaMFYdrQm0bCtNTzkt9oHMwQRAiVRYoG/I2jtwcOov\n\tEQDfMk+sRuqVje9vhH7UEakngrca+AcF6B5vpWllCixD8da4tAYVTGhQUnEscIXena20\n\t+JIC84YwTMDWUKQva7Q/q7phRj/kFfcJcD/FZA+TUv26Nimouj/SnYYVkCApD3zKDR5p\n\tlXuQ==","X-Gm-Message-State":"ANoB5pkQ9ShimCvrw3o5vTPKi+QwDgfTG8Nmipj9IYpWxHFtt7X6jFoL\n\tFfhP5SISl0RqTJXdwvtyHnusrMPzVYsNl8yDkqA5ew==","X-Google-Smtp-Source":"AA0mqf7/ELwtNCYH1XteJd0XI8kFsXKezp1fgPU8LFv+qT/P0KLcCLsbzSKZwF9P4ZqJkeKCKkB1ENz7m2W3tG1jcUk=","X-Received":"by 2002:a05:600c:5408:b0:3d0:1c3f:e3ae with SMTP id\n\the8-20020a05600c540800b003d01c3fe3aemr16846471wmb.27.1669354104498;\n\tThu, 24 Nov 2022 21:28:24 -0800 (PST)","MIME-Version":"1.0","References":"<20220715143822.672321-1-chenghaoyang@google.com>\n\t\n\t<166929859225.2936560.9076573861936904355@Monstersaurus>","In-Reply-To":"<166929859225.2936560.9076573861936904355@Monstersaurus>","Date":"Fri, 25 Nov 2022 13:28:13 +0800","Message-ID":"","To":"Hanlin Chen ","Content-Type":"multipart/alternative; boundary=\"00000000000067419105ee44ca35\"","Subject":"Re: [libcamera-devel] [PATCH v6 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Cheng-Hao Yang via libcamera-devel\n\t","Reply-To":"Cheng-Hao Yang ","Cc":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25950,"web_url":"https://patchwork.libcamera.org/comment/25950/","msgid":"","date":"2022-12-01T09:34:49","subject":"Re: [libcamera-devel] [PATCH v6 0/6] Add CrOS JEA implementation","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"content":"Sorry I missed this mail. It looks good to me :) Thanks for the patch!\nReviewed-by: Han-Lin Chen \n\nOn Fri, Nov 25, 2022 at 1:28 PM Cheng-Hao Yang\n wrote:\n>\n> Hi Han-lin,\n>\n> Could you do the final review, and let Kieran or Laurent help to merge the patches?\n> Thanks!\n>\n> On Thu, Nov 24, 2022 at 10:03 PM Kieran Bingham wrote:\n>>\n>> Quoting Cheng-Hao Yang via libcamera-devel (2022-11-01 04:53:10)\n>> > Hello folks,\n>> >\n>> > It's been a while since the last update. If there's no other dispute, may\n>> > we merge the series of patches recently?\n>> > Thanks!\n>>\n>> As this is the android layer - is there anyone at Google/Chromium who\n>> can do a review on this series ?\n>>\n>> --\n>> Kieran\n>>\n>>\n>> > On Fri, Jul 15, 2022 at 11:38 PM Harvey Yang \n>> > wrote:\n>> >\n>> > > Hi all,\n>> > >\n>> > > Fixed thumbnail buffer issue.\n>> > >\n>> > > Please help review and merge them if possible :)\n>> > > Thanks!\n>> > >\n>> > > BR,\n>> > > Harvey\n>> > >\n>> > > Harvey Yang (6):\n>> > > Allow inheritance of FrameBuffer\n>> > > Add HALFrameBuffer and replace FrameBuffer in src/android\n>> > > Add meson.build in src/android/jpeg\n>> > > Move generateThumbnail from PostProcessorJpeg to Encoder\n>> > > Pass StreamBuffer to Encoder::encoder\n>> > > Add JEA implementation\n>> > >\n>> > > include/libcamera/framebuffer.h | 3 +-\n>> > > src/android/camera_device.cpp | 3 +-\n>> > > src/android/cros/camera3_hal.cpp | 2 +\n>> > > src/android/cros_mojo_token.h | 12 ++\n>> > > src/android/frame_buffer_allocator.h | 7 +-\n>> > > src/android/hal_framebuffer.cpp | 23 +++\n>> > > src/android/hal_framebuffer.h | 27 ++++\n>> > > src/android/jpeg/encoder.h | 10 +-\n>> > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n>> > > src/android/jpeg/encoder_jea.h | 35 +++++\n>> > > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----\n>> > > src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n>> > > src/android/jpeg/meson.build | 16 +++\n>> > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n>> > > src/android/jpeg/post_processor_jpeg.h | 11 +-\n>> > > src/android/meson.build | 6 +-\n>> > > .../mm/cros_frame_buffer_allocator.cpp | 14 +-\n>> > > .../mm/generic_frame_buffer_allocator.cpp | 12 +-\n>> > > 18 files changed, 391 insertions(+), 114 deletions(-)\n>> > > create mode 100644 src/android/cros_mojo_token.h\n>> > > create mode 100644 src/android/hal_framebuffer.cpp\n>> > > create mode 100644 src/android/hal_framebuffer.h\n>> > > create mode 100644 src/android/jpeg/encoder_jea.cpp\n>> > > create mode 100644 src/android/jpeg/encoder_jea.h\n>> > > create mode 100644 src/android/jpeg/meson.build\n>> > >\n>> > > --\n>> > > 2.37.0.170.g444d1eabd0-goog\n>> > >\n>> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F6A9BE08B\n\tfor ;\n\tThu, 1 Dec 2022 09:35:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CB8563335;\n\tThu, 1 Dec 2022 10:35:03 +0100 (CET)","from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com\n\t[IPv6:2001:4860:4864:20::2a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1C9463326\n\tfor ;\n\tThu, 1 Dec 2022 10:35:01 +0100 (CET)","by mail-oa1-x2a.google.com with SMTP id\n\t586e51a60fabf-142faa7a207so1459751fac.13\n\tfor ;\n\tThu, 01 Dec 2022 01:35:01 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669887303;\n\tbh=CGiXkPNZ7Z39+3YWvSPstnlEVSKTN3ueVuheilsMUJE=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=edC1cgZEVFbrCraIbDtnJE76PNw3/phXhOY+Xg3jbwd9u5NGwOVcPLWckFC/yWTfS\n\tDTMVVlh2YqcHVDys//05EyfPjX87GmWa1CVYaNHoniV6gTEprleiQbLwf3lhSRvfeR\n\tbcKVJatef/chNFmgWQQPmBMn1ijbVIc8DjBCCFgM7xo6Q0nU3aORNrUK4ryv1mGsiA\n\tdGoxhUETeoSnp+xHncQMNcpBv3z0+4die/oXq/ZZTWIxHKr+FOM2bxpbGKsFTibRoe\n\tt9bGReATPfpIvyxfxNrRpr/w7cybyuLKtmS/pp5m7Su4KdISKw9lEPx74yLLmFEqAT\n\tQ/c437R2/7VLg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=32LtGe0a9XLMtyysmAT4ocDsgWj05TqTvIE7iOCxe2w=;\n\tb=RHOav3/f/LqKeLTm0xi0jMypFyirVxvfFMTxBW8lUlFymHxEzAIXwx4C9XtXULvgUn\n\tUiJdlIBWGkcn306O+dT79bRspcmeO/obSpPa4buRqnq7smAOsJryIeeBma7xyNZBx5Br\n\txoln1xtmf0cRx0NCKnjOdRzv5ISYjSOPxN2jE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"RHOav3/f\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=32LtGe0a9XLMtyysmAT4ocDsgWj05TqTvIE7iOCxe2w=;\n\tb=hNmmHqEwbiSfior/sXgnQTTySgwSDike8pvfK8hOoenwAUQr8n1qOrLJGy0Z5Mb8gf\n\tGOpPwbAkSOz6I2Uz6SHOaAvJiAZG3NmwmLPa0FcxNoG6y9B54KghzfeWSlZvmW38xWdD\n\t+GAXeKtwqTDJb2oEhVdN/qOmyrRw70UyYSkYg7hE4wh3gT5/HbcTSw5oBzj2z7nzcS/O\n\t9O9M2knX9xCQbpbEeDf6vc+AA9hIzU6UWLM7I84ysf4aK4D3dDxawR1jeqLrMnc1b/Nb\n\toGXPbfkZ/5V1F+fApBTmnIea3hHD8Wb3UYZNWsFBY7n/ZS/weuRjc/VTvBGRDY+ttNKk\n\tnG4g==","X-Gm-Message-State":"ANoB5plA42yGhqHQoa1bieI6ciDRHCDSTl97f1E3QiMRtWcivODY6YXj\n\tBfnTBmeHiIaEvRR1CuVu6zT2+oUjoBKYCtyBuPUjNw==","X-Google-Smtp-Source":"AA0mqf56aPxskLGjwGTCTErXVlHoYhHtf1HvBmCFGrAecAHWYl2MsY4CDGFERLYxf4eTJENuOXweEV5UgCsHjGvt7Qo=","X-Received":"by 2002:a05:6870:959e:b0:143:1c42:8896 with SMTP id\n\tk30-20020a056870959e00b001431c428896mr24529408oao.67.1669887300568;\n\tThu, 01 Dec 2022 01:35:00 -0800 (PST)","MIME-Version":"1.0","References":"<20220715143822.672321-1-chenghaoyang@google.com>\n\t\n\t<166929859225.2936560.9076573861936904355@Monstersaurus>\n\t","In-Reply-To":"","Date":"Thu, 1 Dec 2022 17:34:49 +0800","Message-ID":"","To":"Cheng-Hao Yang ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v6 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Hanlin Chen via libcamera-devel ","Reply-To":"Hanlin Chen ","Cc":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]