[{"id":23792,"web_url":"https://patchwork.libcamera.org/comment/23792/","msgid":"<02c013d43141479e55ce277d5c3bc80a783208d5.camel@collabora.com>","date":"2022-07-07T13:55:07","subject":"Re: [libcamera-devel] [PATCH v2 0/4] Add colorimetry support to\n\tlibcamera gstreamer element.","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le jeudi 07 juillet 2022 à 15:13 +0530, Rishikesh Donadkar via libcamera-devel a\nécrit :\n> This series aims to add colorimetry support to the libcamera gstreamer\n> element.\n> \n> If colorimetry is specified by the user in the gstreamer pipeline, try to\n> apply the libcamera colorspace corresponding to the GStreamer colorimetry\n> to the camera if the colorspace passes the validation then push the\n> colorimetry corresponding to the valid colorspace in the caps.\n> If the colorimetry pushed into the caps is same as requested negotiation\n> will succeed, else negotiation will fail.\n> \n> If no colorimetry is specified by the user in the gstreamer pipeline,\n> push the GStreamer colorimetry corresponding to the current colorspace\n> applied to the camera into the caps and the negotiation will be take\n> care of by the gstreamer.\n\nNice to have, a little changelog would help your reviewer.\n\n> \n> \n> Rishikesh Donadkar (4):\n> gstreamer: convert from libcamera colorspace toGStreamer colorimetry.\n> gstreamer: Update the obtained colorimetry in caps.\n> gstreamer:Convert between requested colorimetry and libcamera\n> ColorSpace\n> gstreamer: Configure the colorSpace in the Stream configuration.\n> \n> src/gstreamer/gstlibcamera-utils.cpp | 69 ++++++++++++++++++++++++++++\n> 1 file changed, 69 insertions(+)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCE25BE173\n\tfor ;\n\tThu, 7 Jul 2022 13:55:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FB276330D;\n\tThu, 7 Jul 2022 15:55:18 +0200 (CEST)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[46.235.227.172])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19A1860400\n\tfor ;\n\tThu, 7 Jul 2022 15:55:16 +0200 (CEST)","from nicolas-tpx395.localdomain (mtl.collabora.ca [66.171.169.34])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id 3A41F66019AA;\n\tThu, 7 Jul 2022 14:55:16 +0100 (BST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657202118;\n\tbh=s9hyTIf2uw0is6fyZuvmWSdV5llGA4CXIAurMnuDZOc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dtFE2xycWaiEzHKZu7k6DttJYxJ9zYQuZ8QL/pf4Wu/J0iHKfTSHx5YIYAB3H+sZj\n\tOPsQq+ycAxmv0Oj594jiwgXRcH8brB4mHmB0lqSpP+HcYpVCRpIVafClYd87wqLoNH\n\tp2rwjbzZiytnV+o3eBYI7YybJeGNy/zRZQgj08WPxfwB2U8l7jer6U3qTaeX+/0Vc/\n\tUFLHXFXMTSTyLIGSIB2LH2ocgqyiVQzR1gCCC/zIFL/t8+JM4VpmbTMnYxcDW2QC4d\n\ti/bkOsyuqP5F1eN+ojCxunwDu1ys0A3Thpd6OAALHQzIlk4BC/6uz4VHOls3+WGfJv\n\tx/0gFAKLVoteg==","v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1657202116;\n\tbh=s9hyTIf2uw0is6fyZuvmWSdV5llGA4CXIAurMnuDZOc=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=eecA7fV0saFbBd/ucAleL0Uw+tzus2/2fAnQSjtQ6kDCb/LB0RdvqoG4XYg6NBArM\n\tZKn6KcWDEsde4vxz20+HXRH/3KAoEklzr7CMVRMhPRwNDCJWwZQuL/CFGfimyy2TRN\n\tG+rI6zXfMDrOu1eiNZ46+35eVqrfrZ0VQ6iF7e0R9hiyw/oSJVAU4te4Ds7g6sregD\n\taW+1np3eQZCQY7jzk0mqCwBo5GZ1J7cp4b49MItPdx5GCQqXDZFjz4IX3HtWQlrD/Q\n\tEUtEpUN8kez7/2qkomBQF5GU+nbXjcIZk2cNeN/2Es9tfJoYpqJKpj3lAOZZwfSN1Z\n\t9/EUipdJs0dkA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"eecA7fV0\"; dkim-atps=neutral","Message-ID":"<02c013d43141479e55ce277d5c3bc80a783208d5.camel@collabora.com>","To":"Rishikesh Donadkar , \n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 07 Jul 2022 09:55:07 -0400","In-Reply-To":"<20220707094402.28730-1-rishikeshdonadkar@gmail.com>","References":"<20220707094402.28730-1-rishikeshdonadkar@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.44.2 (3.44.2-1.fc36) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] Add colorimetry support to\n\tlibcamera gstreamer element.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicolas Dufresne via libcamera-devel\n\t","Reply-To":"Nicolas Dufresne ","Cc":"vedantparanjape160201@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]