[{"id":23656,"web_url":"https://patchwork.libcamera.org/comment/23656/","msgid":"<165650077633.1516045.5259671696499487952@Monstersaurus>","date":"2022-06-29T11:06:16","subject":"Re: [libcamera-devel] [PATCH v4 0/4] Add SensorTemperature control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-06-29 09:57:18)\n> Hi,\n> \n> The only change in this version is using the suggested std::optional::value_or()\n> function instead of the ternary operator in lux.cpp.\n\nAnd you've collected tags too, so all that makes it easier for me to\nmerge. I'll get to this next. Thanks.\n\n--\nKieran\n\n\n> \n> Thanks,\n> Naush\n> \n> Naushir Patuck (4):\n> libcamera: controls: Add SensorTemperature control\n> ipa: raspberrypi: Add sensor temperature to DeviceStatus\n> ipa: raspberrypi: imx477: Get sensor temperature from embedded data\n> ipa: raspberrypi: Use std::optional in DeviceStatus\n> \n> src/ipa/raspberrypi/cam_helper.cpp | 8 +++++---\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n> .../raspberrypi/controller/device_status.cpp | 17 +++++++++++++----\n> src/ipa/raspberrypi/controller/device_status.h | 12 +++++++-----\n> src/ipa/raspberrypi/controller/rpi/lux.cpp | 4 +---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> src/libcamera/control_ids.yaml | 10 ++++++++++\n> 7 files changed, 42 insertions(+), 16 deletions(-)\n> \n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAE41BD808\n\tfor ;\n\tWed, 29 Jun 2022 11:06:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A0EA65635;\n\tWed, 29 Jun 2022 13:06:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94AAE60412\n\tfor ;\n\tWed, 29 Jun 2022 13:06:19 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 293874A8;\n\tWed, 29 Jun 2022 13:06:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656500781;\n\tbh=+o7oQC2sk+ldVNo36dvKfNjMdOydH6rbwhqMG2vO84Q=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=cDBgbJ43nWBSvky2LjLx8S8Cd2eU1Ljj64SNF81Vz4Iecr2fioTahjsxAhekkYkBd\n\tmdAiwOffkzL3COffaHM8On/0G/Srw/1KIwrfv4VJlSjHIbm2PASj4NgIG88BBE0eXp\n\trU6QKlnYoNMgJRcNBF41VvXMqz7lbXQ6KW/qMQrdQGvcKhKCtcex1VL6RrG2FGJBg/\n\tEdmzd+SVtH39s79sAs9VMEK1hdNzyeCyPDl0O+QW8SejFmnOUVBAqUixtTsJGCri99\n\t0aRzimzaIXKK9xgpA2qghvsCo4c9+Lj/ErJFxSKNsknc9S9zZBEFYJfTzlkvxs9Ef/\n\t3QeDcWB41BqTA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656500779;\n\tbh=+o7oQC2sk+ldVNo36dvKfNjMdOydH6rbwhqMG2vO84Q=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=INb7wH1zU3b+u1DiTi1rBV55nzkD8P3JntTMFr1nkyWvJWnnNupXk/T4m7xMWMkaI\n\tARglAcJEPXjOoU8PADTA6SQUdo6vF96+iVxmlhtLXiawK7yG/gK46Oq2advA8N4LS3\n\tkd8w6t5l3EYkzwOB2k7fg8lQevU/2xz9Y/cVDtdo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"INb7wH1z\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220629085722.11786-1-naush@raspberrypi.com>","References":"<20220629085722.11786-1-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 29 Jun 2022 12:06:16 +0100","Message-ID":"<165650077633.1516045.5259671696499487952@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4 0/4] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23661,"web_url":"https://patchwork.libcamera.org/comment/23661/","msgid":"","date":"2022-06-29T11:56:15","subject":"Re: [libcamera-devel] [PATCH v4 0/4] Add SensorTemperature control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Wed, 29 Jun 2022 at 12:06, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Quoting Naushir Patuck via libcamera-devel (2022-06-29 09:57:18)\n> > Hi,\n> >\n> > The only change in this version is using the suggested\n> std::optional::value_or()\n> > function instead of the ternary operator in lux.cpp.\n>\n> And you've collected tags too, so all that makes it easier for me to\n> merge. I'll get to this next. Thanks.\n>\n\nThanks Kieran!\n\nPS the \"Correct ControlInfoMap from the IPA\" series needs only one more R-B\ntag for 3/3 if you are feeling bored ;-)\n\n\n\n>\n> --\n> Kieran\n>\n>\n> >\n> > Thanks,\n> > Naush\n> >\n> > Naushir Patuck (4):\n> > libcamera: controls: Add SensorTemperature control\n> > ipa: raspberrypi: Add sensor temperature to DeviceStatus\n> > ipa: raspberrypi: imx477: Get sensor temperature from embedded data\n> > ipa: raspberrypi: Use std::optional in DeviceStatus\n> >\n> > src/ipa/raspberrypi/cam_helper.cpp | 8 +++++---\n> > src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n> > .../raspberrypi/controller/device_status.cpp | 17 +++++++++++++----\n> > src/ipa/raspberrypi/controller/device_status.h | 12 +++++++-----\n> > src/ipa/raspberrypi/controller/rpi/lux.cpp | 4 +---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> > src/libcamera/control_ids.yaml | 10 ++++++++++\n> > 7 files changed, 42 insertions(+), 16 deletions(-)\n> >\n> > --\n> > 2.25.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B833BE173\n\tfor ;\n\tWed, 29 Jun 2022 11:56:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 587A565635;\n\tWed, 29 Jun 2022 13:56:32 +0200 (CEST)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8756160412\n\tfor ;\n\tWed, 29 Jun 2022 13:56:30 +0200 (CEST)","by mail-lf1-x12e.google.com with SMTP id a4so14024455lfm.0\n\tfor ;\n\tWed, 29 Jun 2022 04:56:30 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656503792;\n\tbh=fomwAJ6F/bSYnGizWCCwwy8uG7pKGZ69fbNbM+44we8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mL/JA6TE0WpkAyHeMnH20ZGlPQiWQEntwCfoNUq5RYlNZQuRMsopAZLB0DWGkk5dm\n\tM7bew/T4AKSt/DQIadMFN670q63AVE5fgEBDTgf6llZOOhv1lMfQoQWHCDEZCJA2mI\n\tJ8QwywwUT+Mv9tmEEBLCSwhBkAch1vq3eDDhleQwMATIQKSm7DB9jEa+QThRYCkm78\n\tyLp1YrlJQUu0LX3IGjtxAv+7LQplGaaHEeWwD6/yYzYzKVaFGRFyGENX1R+c+6xQGb\n\thIQDsGHPw0SqHUZev6T3fy6bq6/nhgPguS4N4VxyxtM1FPut3AvkG1SXK4MbLUePqO\n\tN3eHO5VNXQwIQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=RcwmSG0ejm//H8FH8iJX+NKeBvqtIaakNphU/0TsUEo=;\n\tb=nV4ZZW0+T9Xsy/m5hFqwqgrHbTLF/jd91VKlu7VpFu6DRq3OUBRJPM+UCyyphXmC/A\n\tFVLq8WqleYgkOztFA9y52EqiCIZFNwGgZ8c86jNdVSM1Eq+xlaU2yEErm5qQkLdTYR4y\n\tpizzAKXxwhE+yiSXj5bW581WOYpuclKfcD2VlUj5wiXZnCl1uLbFpfihkUQh/PGMgyy7\n\tAwQqTAYiQJkAbLYhUB/1s961JHn4UKdpmH65a7ckIqXAwEguigsqdFUl7Rd/u2D8mL+S\n\tDa9ejIJ1y8SOJsBic+aHX0M19ZnVW6N6Vef0C38CY+/ZftesS7V5OhgKnjsStmWAl+C6\n\t1Xvw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"nV4ZZW0+\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=RcwmSG0ejm//H8FH8iJX+NKeBvqtIaakNphU/0TsUEo=;\n\tb=o/Y88HY25FeSsJa3SMkpZDC1+vCbEPWFghz+MQFN87eufUh5z8othixdsYjqo5w/6e\n\tma94uXSEAR5l2bgNvqDmIykNk3vgYOT+ZkjwP1nraQRp84+d+Nf+rQ/i0qqmmI1WLLK8\n\tvx52geN2eaV/4I/Pb+kx9AJM5Zil0tBbHQx4vrXMvOQYHpQHx6NGfleyVuEtOFwK5/eY\n\tScQink3lXBg8GzlAuk0pkeXjytuKw14c4Nerqwdq0NTjabJSISDygcNwPHZMlJ8uerwa\n\tsowUlDK4//1lrsgYyh2JxP4MmNEN3pSm1GGMQkGkaf35VyXnZgc/p3OLBrq+jguY+QKH\n\tPpqQ==","X-Gm-Message-State":"AJIora9oSsf3xIJzolvk/Do6E+d9Nrf9Hhz12SJgUxAazUY9xTuczRhv\n\tk8n6YvKCcG6rR73wLo4TQJSKDsrsXLf3a0OT+PjvN1daWnilfw==","X-Google-Smtp-Source":"AGRyM1s2Nlo0ImzgkXtOWlLA9xf/nu05OOxTYNwbtKW3qkyezeYTDqMDmZSJ920yqMo/F/hert+d+HETVg60RJRCz4k=","X-Received":"by 2002:a05:6512:2289:b0:481:1d4f:ac9d with SMTP id\n\tf9-20020a056512228900b004811d4fac9dmr1880094lfu.510.1656503789844;\n\tWed, 29 Jun 2022 04:56:29 -0700 (PDT)","MIME-Version":"1.0","References":"<20220629085722.11786-1-naush@raspberrypi.com>\n\t<165650077633.1516045.5259671696499487952@Monstersaurus>","In-Reply-To":"<165650077633.1516045.5259671696499487952@Monstersaurus>","Date":"Wed, 29 Jun 2022 12:56:15 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"000000000000f6919a05e294d758\"","Subject":"Re: [libcamera-devel] [PATCH v4 0/4] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23663,"web_url":"https://patchwork.libcamera.org/comment/23663/","msgid":"<165650811752.1516045.4370046312314297116@Monstersaurus>","date":"2022-06-29T13:08:37","subject":"Re: [libcamera-devel] [PATCH v4 0/4] Add SensorTemperature control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2022-06-29 12:56:15)\n> On Wed, 29 Jun 2022 at 12:06, Kieran Bingham <\n> kieran.bingham@ideasonboard.com> wrote:\n> \n> > Quoting Naushir Patuck via libcamera-devel (2022-06-29 09:57:18)\n> > > Hi,\n> > >\n> > > The only change in this version is using the suggested\n> > std::optional::value_or()\n> > > function instead of the ternary operator in lux.cpp.\n> >\n> > And you've collected tags too, so all that makes it easier for me to\n> > merge. I'll get to this next. Thanks.\n> >\n> \n> Thanks Kieran!\n> \n> PS the \"Correct ControlInfoMap from the IPA\" series needs only one more R-B\n> tag for 3/3 if you are feeling bored ;-)\n\nDone, that's both of these merged now.\n--\nKieran\n\n\n> \n> \n> \n> >\n> > --\n> > Kieran\n> >\n> >\n> > >\n> > > Thanks,\n> > > Naush\n> > >\n> > > Naushir Patuck (4):\n> > > libcamera: controls: Add SensorTemperature control\n> > > ipa: raspberrypi: Add sensor temperature to DeviceStatus\n> > > ipa: raspberrypi: imx477: Get sensor temperature from embedded data\n> > > ipa: raspberrypi: Use std::optional in DeviceStatus\n> > >\n> > > src/ipa/raspberrypi/cam_helper.cpp | 8 +++++---\n> > > src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n> > > .../raspberrypi/controller/device_status.cpp | 17 +++++++++++++----\n> > > src/ipa/raspberrypi/controller/device_status.h | 12 +++++++-----\n> > > src/ipa/raspberrypi/controller/rpi/lux.cpp | 4 +---\n> > > src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> > > src/libcamera/control_ids.yaml | 10 ++++++++++\n> > > 7 files changed, 42 insertions(+), 16 deletions(-)\n> > >\n> > > --\n> > > 2.25.1\n> > >\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 089BBBD808\n\tfor ;\n\tWed, 29 Jun 2022 13:08:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 347BF65631;\n\tWed, 29 Jun 2022 15:08:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A11F860412\n\tfor ;\n\tWed, 29 Jun 2022 15:08:40 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 284454A8;\n\tWed, 29 Jun 2022 15:08:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656508122;\n\tbh=Ji4yDvdN91tTQftoCnKjG9iyrHZD8cEOj44bhWstaXs=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4IVyxXLa6Xs3pZVrSfRnZYcJS0SpfAZ1hXKWfOOu02dz1AMfIWTVoQFuJNPvxX2lh\n\tQyAgZ3Eks+d6k0tT6HjogT6AaApxt3kEa6nTXBGHiBukG03kTxRZh9U+tOjS78/Wxr\n\tjg+tWexjUtfv66IgKNXLktR8NG9CcCL8QWzyT/wOTM+8G+AF7bZsGPXBZru8T+tILP\n\t0O5nkHnAcuMB52wZQzKm9NDw+x+G4SULo6id0+OIdcXz0exf3V+fqGDs4fBv/mxVMv\n\t6FYima0pkpkBmmiRmDOjfpQKNxvJDf6/IrARVlYoA7+T8A7K5p0lgVAf+zmoGiExSn\n\tnAYgBsuvRHHdA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656508120;\n\tbh=Ji4yDvdN91tTQftoCnKjG9iyrHZD8cEOj44bhWstaXs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=X3QdhL9C3Skly5jRwLpZY0xJeESq+VBvgRJDNHFHs7w8DAt29XlOYuV/68b0wqUQu\n\tclrYFRxe3fpB5UiI8dwuPu/YHdz0Qx1TGbla7IF3GsL9zsUWZWfC6GMvTVH/I+Ew4d\n\t9B8baX6FTN0jsGl16cKW+ANztDtzWmzh69jw9cgg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X3QdhL9C\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220629085722.11786-1-naush@raspberrypi.com>\n\t<165650077633.1516045.5259671696499487952@Monstersaurus>\n\t","To":"Naushir Patuck ","Date":"Wed, 29 Jun 2022 14:08:37 +0100","Message-ID":"<165650811752.1516045.4370046312314297116@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4 0/4] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]