[{"id":23546,"web_url":"https://patchwork.libcamera.org/comment/23546/","msgid":"","date":"2022-06-23T14:50:36","subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","submitter":{"id":127,"url":"https://patchwork.libcamera.org/api/people/127/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@yoseli.org"},"content":"Hi Naushir,\n\nThanks for the series !\n\nOn 23/06/2022 16:44, Naushir Patuck via libcamera-devel wrote:\n> Hi,\n> \n> This series adds a sensor temperature metadata control to libcamera. This\n> control is returned out through Request metadata when available. There is an\n> open PR [1] to enable the temperature sensor on the imx477 on the Raspberry Pi\n> platforms.\n> \n> At present, there is no mechanism in V4L2 to return the temperature from the\n> sensor device driver, so we rely on the embedded data to fetch the values every\n> frame.\n\nI think this PR along with a V4L2 control introduction \n(V4L2_CID_TEMPERATURE :-) ?) could be interesting to be sent to the \nlinux-media ML at the same time ?\n\nJM\n\n> \n> Thanks,\n> Naush\n> \n> [1] https://github.com/raspberrypi/linux/pull/5067\n> \n> Naushir Patuck (3):\n> libcamera: controls: Add SensorTemperature control\n> ipa: raspberrypi: Add sensor temperature to DeviceStatus\n> ipa: raspberrypi: imx477: Get sensor temperature from embedded data\n> \n> src/ipa/raspberrypi/cam_helper.cpp | 7 ++++---\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n> src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n> src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> src/libcamera/control_ids.yaml | 10 ++++++++++\n> 6 files changed, 26 insertions(+), 5 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32213BD808\n\tfor ;\n\tThu, 23 Jun 2022 14:50:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDB2665632;\n\tThu, 23 Jun 2022 16:50:38 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 274176048F\n\tfor ;\n\tThu, 23 Jun 2022 16:50:37 +0200 (CEST)","(Authenticated sender: jeanmichel.hautbois@yoseli.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id C43CD40009;\n\tThu, 23 Jun 2022 14:50:36 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655995838;\n\tbh=gHljklKVtaDDqZUdn/g0jTyfTddL02R17W7QoRPQNrs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=rSUsxpqT2A4FT6VPEQYA/wOeoeFklVPtXRub19672KidTKrQhYoswVw7XP0OcoSL3\n\tl98jSAJDOY0pdejvN/vGH4hwuNBuNoFxFeEYwJENOSiZtdXhQ/BiwTsbeUXvlYVird\n\tq4ac4BDZI+g0JmUaYUfUc/oglcLq4yGzhEJdmvELgdx0bEDjabQVZ1yjUoSXS6BS8u\n\t9xPFbKPlS507oi5sW5g+EGhFfUMsv2X1kaTskIt0LD7YTXXffj4zLoXIWasQNJdY5U\n\tQsDgGJHoPhd/lT4cQQ7+uZR/JL2SdQkA7QNzdD9oCoQh9ToepnrkmeGinOyKtixSb2\n\tF6FUXWvQM3yzw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=yoseli.org; s=gm1;\n\tt=1655995837;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=GY72EiBhfbk5VTxAgBFFEDTBlJz4CZlzl2aSxsGa37w=;\n\tb=eYfLUOEU198GYAs2R7DiU5qanVGz6vZHhg21GQdrzy3YMPFQpuNCw9HeIvd628U4eaN+Cf\n\tm030Y8Hy8Ti2YRHBD5dWqXYWhuL8aVfvQQZ+HQ6+a7brtxWekRL8EoZI3kb30iJLyIldIO\n\tcXPMLAnZnQ/HSGyMmPiKNbOp5LSa0UbZSS/EcrZlRZCkyAVLVACf0aQu6XgNTEZ5GCAoGl\n\tkeAAOuPH/5JRownqnssfHMj/ZlknLNTpl2iRnEgQjbt4bvVNv2QOmUKn1RP7pLouFfcZr3\n\t6y2geO4+Ut1KQOZUpvDMON3NMjc5fSy/HNfnL5QHrqIkUcitOWlWiIZGIkJjUg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=yoseli.org\n\theader.i=@yoseli.org header.b=\"eYfLUOEU\"; \n\tdkim-atps=neutral","Message-ID":"","Date":"Thu, 23 Jun 2022 16:50:36 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.9.1","Content-Language":"en-US","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220623144410.20725-1-naush@raspberrypi.com>","In-Reply-To":"<20220623144410.20725-1-naush@raspberrypi.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23547,"web_url":"https://patchwork.libcamera.org/comment/23547/","msgid":"<2e5cc23b-8f40-5eec-01e8-ba3660ad9ff8@yoseli.org>","date":"2022-06-23T14:51:33","subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","submitter":{"id":127,"url":"https://patchwork.libcamera.org/api/people/127/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@yoseli.org"},"content":"On 23/06/2022 16:50, Jean-Michel Hautbois via libcamera-devel wrote:\n> Hi Naushir,\n> \n> Thanks for the series !\n> \n> On 23/06/2022 16:44, Naushir Patuck via libcamera-devel wrote:\n>> Hi,\n>>\n>> This series adds a sensor temperature metadata control to libcamera. \n>> This\n>> control is returned out through Request metadata when available. \n>> There is an\n>> open PR [1] to enable the temperature sensor on the imx477 on the \n>> Raspberry Pi\n>> platforms.\n>>\n>> At present, there is no mechanism in V4L2 to return the temperature \n>> from the\n>> sensor device driver, so we rely on the embedded data to fetch the \n>> values every\n>> frame.\n> \n> I think this PR along with a V4L2 control introduction \n> (V4L2_CID_TEMPERATURE :-) ?) could be interesting to be sent to the \n> linux-media ML at the same time ?\n\nI forgot to ask the use case though ? :-)\n\n> \n> JM\n> \n>>\n>> Thanks,\n>> Naush\n>>\n>> [1] https://github.com/raspberrypi/linux/pull/5067\n>>\n>> Naushir Patuck (3):\n>>    libcamera: controls: Add SensorTemperature control\n>>    ipa: raspberrypi: Add sensor temperature to DeviceStatus\n>>    ipa: raspberrypi: imx477: Get sensor temperature from embedded data\n>>\n>>   src/ipa/raspberrypi/cam_helper.cpp               |  7 ++++---\n>>   src/ipa/raspberrypi/cam_helper_imx477.cpp        |  5 ++++-\n>>   src/ipa/raspberrypi/controller/device_status.cpp |  3 +++\n>>   src/ipa/raspberrypi/controller/device_status.h   |  4 +++-\n>>   src/ipa/raspberrypi/raspberrypi.cpp              |  2 ++\n>>   src/libcamera/control_ids.yaml                   | 10 ++++++++++\n>>   6 files changed, 26 insertions(+), 5 deletions(-)\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DB11BD808\n\tfor ;\n\tThu, 23 Jun 2022 14:51:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 630DB65635;\n\tThu, 23 Jun 2022 16:51:35 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D13AD6048F\n\tfor ;\n\tThu, 23 Jun 2022 16:51:34 +0200 (CEST)","(Authenticated sender: jeanmichel.hautbois@yoseli.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 7E0ECFF806;\n\tThu, 23 Jun 2022 14:51:34 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655995895;\n\tbh=+s1GHIstVbOZKBBQqC8DfkeRDOqVXkLAl4spvltuHgA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=KvD3I7x1t1MX0nPipTMEV7ikMZhxKxey5qBQE9H3PlEh1BtHZdXtkkquI8+mvNzni\n\tG5AFD07SprX1bGwPsBVBojeL/4qZnTUw5zdY/SAIuXhrfFSUL8hR7wM0HnrMQ/5y3W\n\tJ4Zt3J9wxnXomTomDrs68KKCrkvF3+Anv90+Po/GJGsQyojY/AH86X+hLZBcL0aId1\n\tNjA8HMsPWzQfnQubTnixgEujMWl2g1TDihdXEl+j0LDDxZ2LoYeGoy1YU09sGs+6fe\n\tHVc/cS0kmFLXskahc3haYQ1bxLsK8IbRR8v4G8km95zgFHNb7yv9r1+ysJz6dlrfWv\n\t1ZBSBuYrzNzZg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=yoseli.org; s=gm1;\n\tt=1655995894;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=huSkoxt6zuhqTMpycxZn4CSfopBz8gKuYwkkzTozauQ=;\n\tb=JHbJUJhBS9l0L36PeEsRw8t1mv0HjUa9iO6JxV0HzwqHmbWhQuvHvs5EQO/V/dXhJOOqBu\n\twRVV7a77ZYyfUGWeO30GE0qQBM1TR+DASAZ0IXeH2NvGVA9d5e5DX81Olxk105KOLFoQgo\n\t3GPkrhFLp71mI7AGligzuSwRxALIcwxSAhwioSl4dpXCHiG9C3aGyKZ/DXh4RSXksdeOce\n\t0Qq69oLW5QvDbJ5i7haZzmLRpY0Ghqm/lckY78pB4sLvbknL7sl3N6ayugmMSwg6TmiyeE\n\tvrrZNkx/yD/FgCpJKCaj8HfrluXcz5st/c6jHUAvNO3JftJFs6ElGlvzAOS5Tg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=yoseli.org\n\theader.i=@yoseli.org header.b=\"JHbJUJhB\"; \n\tdkim-atps=neutral","Message-ID":"<2e5cc23b-8f40-5eec-01e8-ba3660ad9ff8@yoseli.org>","Date":"Thu, 23 Jun 2022 16:51:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.9.1","Content-Language":"en-US","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23548,"web_url":"https://patchwork.libcamera.org/comment/23548/","msgid":"","date":"2022-06-23T14:56:43","subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Jean-Michel,\n\nOn Thu, 23 Jun 2022 at 15:51, Jean-Michel Hautbois <\njeanmichel.hautbois@yoseli.org> wrote:\n\n>\n>\n> On 23/06/2022 16:50, Jean-Michel Hautbois via libcamera-devel wrote:\n> > Hi Naushir,\n> >\n> > Thanks for the series !\n> >\n> > On 23/06/2022 16:44, Naushir Patuck via libcamera-devel wrote:\n> >> Hi,\n> >>\n> >> This series adds a sensor temperature metadata control to libcamera.\n> >> This\n> >> control is returned out through Request metadata when available.\n> >> There is an\n> >> open PR [1] to enable the temperature sensor on the imx477 on the\n> >> Raspberry Pi\n> >> platforms.\n> >>\n> >> At present, there is no mechanism in V4L2 to return the temperature\n> >> from the\n> >> sensor device driver, so we rely on the embedded data to fetch the\n> >> values every\n> >> frame.\n> >\n> > I think this PR along with a V4L2 control introduction\n> > (V4L2_CID_TEMPERATURE :-) ?) could be interesting to be sent to the\n> > linux-media ML at the same time ?\n>\n\nI was hoping to decouple this with V4L2 changes for now. From what I can\ntell,\nthe topic of V4L2_CID_TEMPERATURE is a long ongoing discussion, and my\nchange here does not rely on it. So our users can get this feature earlier!\n\n\n>\n> I forgot to ask the use case though ? :-)\n>\n\nWe have had a few requests for this feature, see\nhttps://github.com/raspberrypi/libcamera-apps/issues/306\nfor the most recent one where the temperature value is useful for long\nexposures to\nhelp with dark frame subtraction in post processing for astrophotography.\n\nRegards,\nNaush\n\n\n>\n> >\n> > JM\n> >\n> >>\n> >> Thanks,\n> >> Naush\n> >>\n> >> [1] https://github.com/raspberrypi/linux/pull/5067\n> >>\n> >> Naushir Patuck (3):\n> >> libcamera: controls: Add SensorTemperature control\n> >> ipa: raspberrypi: Add sensor temperature to DeviceStatus\n> >> ipa: raspberrypi: imx477: Get sensor temperature from embedded data\n> >>\n> >> src/ipa/raspberrypi/cam_helper.cpp | 7 ++++---\n> >> src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n> >> src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n> >> src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n> >> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> >> src/libcamera/control_ids.yaml | 10 ++++++++++\n> >> 6 files changed, 26 insertions(+), 5 deletions(-)\n> >>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 479E3BE173\n\tfor ;\n\tThu, 23 Jun 2022 14:56:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 923A165632;\n\tThu, 23 Jun 2022 16:56:58 +0200 (CEST)","from mail-lf1-x130.google.com (mail-lf1-x130.google.com\n\t[IPv6:2a00:1450:4864:20::130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC6E56048F\n\tfor ;\n\tThu, 23 Jun 2022 16:56:56 +0200 (CEST)","by mail-lf1-x130.google.com with SMTP id c4so33772516lfj.12\n\tfor ;\n\tThu, 23 Jun 2022 07:56:56 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655996218;\n\tbh=bZSk7Q/8q388uZP1VmzxBCtmWIVgCdnAURyf2G9xTSk=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=y29sphOpEcdDaO8D5U8unR9AXuXi/ZqJrAmovXtiUDxbynmJ08BMpYD+n0lPJxwDS\n\t5g9NGJm/AO6ayf8nv3jDl0DQ3o+b/tKjXukgaH9+gUz+4oOPBLA15ZS6C7zrGvJNCe\n\tZ8Lh5Yo8v+2M0FvHyu7SdfUS+giKQ7VDDtY7Q7b5eSxUe28EOzNMw5MQc5u7C6qKGw\n\tHDog7pMEPzUL7pkAJr9g2zF9Rio+VN8kg+2TgHpVflU0aTZV6vEmaf4fBk0Gqx7eUA\n\tFdBfDFm55QJlD10oyeZ0KeoRMCmo7SFi4B9SNyNx0FGMyCJNIxhP+giJEatgffFWu/\n\tYIv3GW3mQNSfQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=4+St0ZdoHyeviSasj3Edv1feWeAcrNPHJtn5D6+xIYk=;\n\tb=DpFj22WbLXNbicFAVXvErKdxo6s4rpSTKwD47P/HniinGW+u7jxrHZ+aftnki1VWsd\n\tO8Ggu/NyZvECw/iYnooxNlXnkelp9pMy9484mQd9XVjsQSHL34UzixKbr7vvprnbIf6h\n\toJfc3yEHbsbHH+neLrzjR6yJu3sOolcr1AZ4sHtph/QdBjblSbrUNNDtcTVRxNGKm6NP\n\tZ6OO+W3BHs/Zc+k8RRsJWzAGyHpXYjNMs0NcLhZzHDjDNVTY8WmgL0X4m4TNmh+lgBnD\n\tjFZdb+D5oCqJpMd6KxxprWNCsgu0pHobJHOQ0JKu4imPtzP1bToPITBUrnBcZCVyXw1e\n\tQNmw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"DpFj22Wb\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=4+St0ZdoHyeviSasj3Edv1feWeAcrNPHJtn5D6+xIYk=;\n\tb=CTEeEPHItJDwLiIDwolekBSewJTry7pfdgYPGcNTmxWcrgBzJ4wHQmmH2rGwZp5SiC\n\tNJmk6NnGvD4AoteV8d36zK9X9Lmv9A3LpTgKte4c5ifA7StKrgpyhzGNp6ZMaM7HD/8k\n\tUzu2A3X2547byfw5ZFV2DiBkOzXLIpml6iOaehK/yxC+J34N590QdqxJrW29/R4TuMN8\n\t4Q9KSXe13QYDdLOExaUcgTp3p/q8EY467+8DD6mLuH8WTeR5m+3z7VC/CG1KgXNWDKwQ\n\tKPvANk3vPSRcH7lZg1AnWeSUbvtf1sivK5S9OT3LdIDScVPZBNs1jieLKni+hbjODd58\n\tq8LA==","X-Gm-Message-State":"AJIora8c8/Twpe7+eEc5OuJySyKXkakSPqI8wxDtj9S6UdRHQR49eny7\n\tIgGRybfFKb4D2ibFF0ShVxe0yhcgdvrl0SBEzGlnjA==","X-Google-Smtp-Source":"AGRyM1sBGkJQEueSqGNUJUksf1jbqKSJkVeORn7GnuXZwXduYvwMKkgkWio3s/wQfGna1+HsmjSCvgG96QanI8ZqQ7k=","X-Received":"by 2002:a05:6512:3581:b0:47f:6e4d:bf6a with SMTP id\n\tm1-20020a056512358100b0047f6e4dbf6amr5817473lfr.63.1655996215911;\n\tThu, 23 Jun 2022 07:56:55 -0700 (PDT)","MIME-Version":"1.0","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t\n\t<2e5cc23b-8f40-5eec-01e8-ba3660ad9ff8@yoseli.org>","In-Reply-To":"<2e5cc23b-8f40-5eec-01e8-ba3660ad9ff8@yoseli.org>","Date":"Thu, 23 Jun 2022 15:56:43 +0100","Message-ID":"","To":"Jean-Michel Hautbois ","Content-Type":"multipart/alternative; boundary=\"0000000000003301c405e21eaa46\"","Subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23549,"web_url":"https://patchwork.libcamera.org/comment/23549/","msgid":"","date":"2022-06-23T15:12:14","subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"Hi Naush and Jean-Michel\n\nOn Thu, 23 Jun 2022 at 15:56, Naushir Patuck via libcamera-devel\n wrote:\n>\n> Hi Jean-Michel,\n>\n> On Thu, 23 Jun 2022 at 15:51, Jean-Michel Hautbois wrote:\n>>\n>>\n>>\n>> On 23/06/2022 16:50, Jean-Michel Hautbois via libcamera-devel wrote:\n>> > Hi Naushir,\n>> >\n>> > Thanks for the series !\n>> >\n>> > On 23/06/2022 16:44, Naushir Patuck via libcamera-devel wrote:\n>> >> Hi,\n>> >>\n>> >> This series adds a sensor temperature metadata control to libcamera.\n>> >> This\n>> >> control is returned out through Request metadata when available.\n>> >> There is an\n>> >> open PR [1] to enable the temperature sensor on the imx477 on the\n>> >> Raspberry Pi\n>> >> platforms.\n>> >>\n>> >> At present, there is no mechanism in V4L2 to return the temperature\n>> >> from the\n>> >> sensor device driver, so we rely on the embedded data to fetch the\n>> >> values every\n>> >> frame.\n>> >\n>> > I think this PR along with a V4L2 control introduction\n>> > (V4L2_CID_TEMPERATURE :-) ?) could be interesting to be sent to the\n>> > linux-media ML at the same time ?\n>\n>\n> I was hoping to decouple this with V4L2 changes for now. From what I can tell,\n> the topic of V4L2_CID_TEMPERATURE is a long ongoing discussion, and my\n> change here does not rely on it. So our users can get this feature earlier!\n\nI've flagged it for discussion at the proposed Media Summit alongside\nELCE in September -\nhttps://www.spinics.net/lists/linux-media/msg212772.html\n\nLaurent has responded in support of V4L2_CID_TEMPERATURE in preference\nto hwmon API, but that still doesn't make it a done deal.\nWhen Benjamin brought it up in\nhttps://lore.kernel.org/linux-media/20220415111845.27130-3-benjamin.mugnier@foss.st.com/,\nit became quite a long debate with no resolution, leading to the patch\njust being dropped.\n\nAs Naush says, with imx477 (and others) carrying this value in\nembedded metadata, we may as well extract it from there and avoid the\ncomplication. It'll actually be a more up to date value than reading\nit on demand over I2C.\n\n Dave\n\n>>\n>>\n>> I forgot to ask the use case though ? :-)\n>\n>\n> We have had a few requests for this feature, see https://github.com/raspberrypi/libcamera-apps/issues/306\n> for the most recent one where the temperature value is useful for long exposures to\n> help with dark frame subtraction in post processing for astrophotography.\n>\n> Regards,\n> Naush\n>\n>>\n>>\n>> >\n>> > JM\n>> >\n>> >>\n>> >> Thanks,\n>> >> Naush\n>> >>\n>> >> [1] https://github.com/raspberrypi/linux/pull/5067\n>> >>\n>> >> Naushir Patuck (3):\n>> >> libcamera: controls: Add SensorTemperature control\n>> >> ipa: raspberrypi: Add sensor temperature to DeviceStatus\n>> >> ipa: raspberrypi: imx477: Get sensor temperature from embedded data\n>> >>\n>> >> src/ipa/raspberrypi/cam_helper.cpp | 7 ++++---\n>> >> src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n>> >> src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n>> >> src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n>> >> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n>> >> src/libcamera/control_ids.yaml | 10 ++++++++++\n>> >> 6 files changed, 26 insertions(+), 5 deletions(-)\n>> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD0E3BD808\n\tfor ;\n\tThu, 23 Jun 2022 15:12:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41A7565637;\n\tThu, 23 Jun 2022 17:12:32 +0200 (CEST)","from mail-ej1-x631.google.com (mail-ej1-x631.google.com\n\t[IPv6:2a00:1450:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46B4E6048F\n\tfor ;\n\tThu, 23 Jun 2022 17:12:31 +0200 (CEST)","by mail-ej1-x631.google.com with SMTP id mf9so21410713ejb.0\n\tfor ;\n\tThu, 23 Jun 2022 08:12:31 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655997152;\n\tbh=03Vvj21Zlf44dM/F0NMKNNV+JYjOEBJ09/r9qKDu78I=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Yj5UXdDCNx0pcxD4ZYdfy5u3R35X6GkKNttG8jkUvxTyQzHJgdwxbiVIS0QC0Jhhy\n\tQ5k+nFTnF76S5Mk6vte54Gqq0FMx5zgeyhKp7iyjKpfmt9RuJYpEDZ9eTiwhhf6G5t\n\tgT+6K7JujrrjcygukRPa16kzCjONKkU1qtabh0yFB8XYpAn5OrU3+q9B19HBWJ+hZA\n\tsW+ZHg5R1U+Mh3XEy9WFBm2O2xGqMqxHRt/n+h+dS5+An1RY9kD/BkWhe+jMymwwd2\n\tkaClfwTKMJCZc/2a+YbXDtOkSP7nu1+/g1xFG64Ifb6qQHFjb9OT3JpO7ADwVHIMGg\n\tR2NTM7pWJKNyw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=0I50uUkB61LmHJHA+JqL0GGLpBgb6Vxq9ek7ueITSpM=;\n\tb=pajtJ5NaLfeQavwVhC8sj1aho9REsICIJzqc6nxS7CW396IzE9Ky9qCwMN7RdG4aXE\n\t1of0WFsudOLdaxBXyakMMSHupSOvdNNLC9msgi9cE66kdFX/nXvJX53htlKAE1JRL1mu\n\tvxj3q1Bs8HEe0eQFhVH2eWVF39wpvvUZASsZVlwYq7godOyfLAGB6JaDeya1Z6O1NRlI\n\td/2KuUXu63v59/ZJJ2g4TVELmfQqCHj6FRHH9SHu/PCD2OBIngjy0+1p2AdPmGofPnJC\n\tm4ex2sDaLtCkFjzuj5WVr2qlLtvkm1s6sBVhVRoob1OuIimfzTFZQV/RMY4D5u/18rkK\n\tIcGg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"pajtJ5Na\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=0I50uUkB61LmHJHA+JqL0GGLpBgb6Vxq9ek7ueITSpM=;\n\tb=3bWyxf74fQZJywbY1yWuEGeEsbCTgqaKGm2E0ixHhDvXDdXJB35BZz9P29ry/4yFb5\n\tzFVoxFQq/Tz2Fn/yAXiGiqR6nLu0FCLUhMbGwv3JoZ1iViILVZpMu85kmtrA3fiTdo3e\n\tXB/3ViN5TNqqyo3j1aY+CxbHKobwzCnyJKK2op9zVmgN1hIlhNYl0XsVu2d2Y4dUazf4\n\tCfU8ETW7QalbCfDE4nsI7spW1zUAyALpDvITn/bjPKUcEghEpaoXXKeh5eEMA/uzbB6+\n\tDRjYLVRox+5dvSWstAbiBGk8bUpedQrOuNBKn3yglyHuUXdyoTMd1wp/ubBPfFvcNXhN\n\tDImw==","X-Gm-Message-State":"AJIora8meK6mUgRTMILo/ghnBil2OveoLOMzPZD1kwdpViV7fq9yRiOh\n\t67G9sacOOfcYF2GUSr6pnIGT4qQU8P8jODy5Sg47NjonFcVMSb3Q","X-Google-Smtp-Source":"AGRyM1vOuYbWmAIny8demzkCQSDXpYniZBWOIpJW7tPVjsauSJBqNwPEcc4ohEdwabbWyfZs8K3GriLv8D+NMTS8vAI=","X-Received":"by 2002:a17:906:2756:b0:718:d986:d3e3 with SMTP id\n\ta22-20020a170906275600b00718d986d3e3mr8606107ejd.425.1655997150744;\n\tThu, 23 Jun 2022 08:12:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t\n\t<2e5cc23b-8f40-5eec-01e8-ba3660ad9ff8@yoseli.org>\n\t","In-Reply-To":"","Date":"Thu, 23 Jun 2022 16:12:14 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Dave Stevenson via libcamera-devel\n\t","Reply-To":"Dave Stevenson ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23550,"web_url":"https://patchwork.libcamera.org/comment/23550/","msgid":"","date":"2022-06-23T15:16:12","subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Thu, 23 Jun 2022 at 16:12, Dave Stevenson \nwrote:\n\n> Hi Naush and Jean-Michel\n>\n> On Thu, 23 Jun 2022 at 15:56, Naushir Patuck via libcamera-devel\n> wrote:\n> >\n> > Hi Jean-Michel,\n> >\n> > On Thu, 23 Jun 2022 at 15:51, Jean-Michel Hautbois <\n> jeanmichel.hautbois@yoseli.org> wrote:\n> >>\n> >>\n> >>\n> >> On 23/06/2022 16:50, Jean-Michel Hautbois via libcamera-devel wrote:\n> >> > Hi Naushir,\n> >> >\n> >> > Thanks for the series !\n> >> >\n> >> > On 23/06/2022 16:44, Naushir Patuck via libcamera-devel wrote:\n> >> >> Hi,\n> >> >>\n> >> >> This series adds a sensor temperature metadata control to libcamera.\n> >> >> This\n> >> >> control is returned out through Request metadata when available.\n> >> >> There is an\n> >> >> open PR [1] to enable the temperature sensor on the imx477 on the\n> >> >> Raspberry Pi\n> >> >> platforms.\n> >> >>\n> >> >> At present, there is no mechanism in V4L2 to return the temperature\n> >> >> from the\n> >> >> sensor device driver, so we rely on the embedded data to fetch the\n> >> >> values every\n> >> >> frame.\n> >> >\n> >> > I think this PR along with a V4L2 control introduction\n> >> > (V4L2_CID_TEMPERATURE :-) ?) could be interesting to be sent to the\n> >> > linux-media ML at the same time ?\n> >\n> >\n> > I was hoping to decouple this with V4L2 changes for now. From what I\n> can tell,\n> > the topic of V4L2_CID_TEMPERATURE is a long ongoing discussion, and my\n> > change here does not rely on it. So our users can get this feature\n> earlier!\n>\n> I've flagged it for discussion at the proposed Media Summit alongside\n> ELCE in September -\n> https://www.spinics.net/lists/linux-media/msg212772.html\n>\n> Laurent has responded in support of V4L2_CID_TEMPERATURE in preference\n> to hwmon API, but that still doesn't make it a done deal.\n> When Benjamin brought it up in\n>\n> https://lore.kernel.org/linux-media/20220415111845.27130-3-benjamin.mugnier@foss.st.com/\n> ,\n> it became quite a long debate with no resolution, leading to the patch\n> just being dropped.\n>\n> As Naush says, with imx477 (and others) carrying this value in\n> embedded metadata, we may as well extract it from there and avoid the\n> complication. It'll actually be a more up to date value than reading\n> it on demand over I2C.\n>\n\nThat's a good point - embedded data values will always be guaranteed to be\nsynced with the\nframe in question. But sync granularity might not be such a big deal for a\ntemperature measurement...\n\nNaush\n\n\n\n>\n> Dave\n>\n> >>\n> >>\n> >> I forgot to ask the use case though ? :-)\n> >\n> >\n> > We have had a few requests for this feature, see\n> https://github.com/raspberrypi/libcamera-apps/issues/306\n> > for the most recent one where the temperature value is useful for long\n> exposures to\n> > help with dark frame subtraction in post processing for astrophotography.\n> >\n> > Regards,\n> > Naush\n> >\n> >>\n> >>\n> >> >\n> >> > JM\n> >> >\n> >> >>\n> >> >> Thanks,\n> >> >> Naush\n> >> >>\n> >> >> [1] https://github.com/raspberrypi/linux/pull/5067\n> >> >>\n> >> >> Naushir Patuck (3):\n> >> >> libcamera: controls: Add SensorTemperature control\n> >> >> ipa: raspberrypi: Add sensor temperature to DeviceStatus\n> >> >> ipa: raspberrypi: imx477: Get sensor temperature from embedded\n> data\n> >> >>\n> >> >> src/ipa/raspberrypi/cam_helper.cpp | 7 ++++---\n> >> >> src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n> >> >> src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n> >> >> src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n> >> >> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> >> >> src/libcamera/control_ids.yaml | 10 ++++++++++\n> >> >> 6 files changed, 26 insertions(+), 5 deletions(-)\n> >> >>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B0D3BD808\n\tfor ;\n\tThu, 23 Jun 2022 15:16:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 594AE65635;\n\tThu, 23 Jun 2022 17:16:27 +0200 (CEST)","from mail-lj1-x232.google.com (mail-lj1-x232.google.com\n\t[IPv6:2a00:1450:4864:20::232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED30B6048F\n\tfor ;\n\tThu, 23 Jun 2022 17:16:25 +0200 (CEST)","by mail-lj1-x232.google.com with SMTP id n15so12078183ljg.8\n\tfor ;\n\tThu, 23 Jun 2022 08:16:25 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655997387;\n\tbh=RbAlnIVjBmOhYoi/6sULZG09rh9ipMsML8HUoFECKA8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SYyywSQ5FC8F6Snz3QmzU8Gvix98ocDaHHlaGkq8ASXD5xCpDrKNo/2KxYeFfeROo\n\tWGeKOFTeFfgUscQTeayZNjUQRU+KxajeF1lKcK4DF2W0A65jnLJTPF2vdmrarjzUec\n\t5B1Nhs1lgZhv3On5FSfXuDel6SLfO6GN2PLjcsHI31663Cv1eLaJDPkptgtsO7/eNc\n\tBs34aQ5qCGv4ae9yO+oVbtkQo4u+p6+VrES7YbdEKqB7hQ2mQqQUvEvX8/2LKne/EG\n\t/1y+fwbuumd1B7t/JI26Ijy4OxsnyuBdcZTRmMV24O7niKuplXAuHiFN0fPa9PdPQk\n\tX9zYxYN948HLA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Bry8aHeSjba6LOUoPKo5CyNrKBquhu5Q4LCj2MOGEko=;\n\tb=KPsSNetfnIdiglcsGx+Y8QSxFF/PGAMcnR/cTgy+/PyZ9wH43TAU7J8cXIbbJ0lHTX\n\tJpjb27f7ue3YxSoFSSDMO/pJRqS3N+5g/Wu/a6etM5TepQGgX/1yAlS8t3uMOIzYFpoq\n\tWUvr6adHeGuCRQGS+h13AFenC2WNZ9XD63U8zwSlF6w69fFikBeQwrI4Q+nbEJyjcSAw\n\tjZjYZndkZ8s9JpaCEzpdLgUCiPjfBsOqI5DcPdhJRww3l3oAZsopcgpNB4TwwM4tDVTA\n\tKdKcP4DPHx+Q/cVA32ZOxaofe/n5+sWXuEO040LQgxlN4ct/0hnM9+WLa4j0pFbzxSPk\n\tcckA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"KPsSNetf\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Bry8aHeSjba6LOUoPKo5CyNrKBquhu5Q4LCj2MOGEko=;\n\tb=hfp+6SRccW3Nz/uF4q52AU2SWyYXUrzpBfNWN6JUZWYwxmjAfGZGrRlZnPGDgya6Xg\n\t1V3TWvSSelpnOx59mwZGIP5jZhJOinSHNkbVa9p2Ud/4+cu0pmx6/4y8NXceZ0Wjm+XL\n\tOy2b4rQmvk5xWBS0l1VvQZ9sbD6Q+J8HTn45FNw4JYpswrJRB+h0AxEgS1Qq5k0atrzN\n\tzywlDtuKdVTIneuzCnwkP3yQj/sfHFMnmivgiatB98jstjkX6iQ25W5L6mtMbD4o00aK\n\tIQROW7bKy2n59nBnIigdRHHX+cVAd2HhjXfb6ljSe3jEQd9zIFOXajAJOjD3eQG5d61M\n\tlGEg==","X-Gm-Message-State":"AJIora/R7gyEl2sjG9WqUpBmv9CCTOToBO3VmwBo3BoFOnaC5d5nBBAV\n\tuvyslaoVB2ZMS47ac28lHAf5BvRW3DVYe9iDzKg5wKoeGfqaEQ==","X-Google-Smtp-Source":"AGRyM1vOWF6a7nlNez0pqPBe3tkLZYcwQ6sP8uh7KLljKbpFMpNgdNONJ8NIFV40WFTzkU5Erlya6FsU3Y3WlfGZT0U=","X-Received":"by 2002:a2e:b713:0:b0:25a:90bd:cb6b with SMTP id\n\tj19-20020a2eb713000000b0025a90bdcb6bmr2607437ljo.380.1655997385152;\n\tThu, 23 Jun 2022 08:16:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t\n\t<2e5cc23b-8f40-5eec-01e8-ba3660ad9ff8@yoseli.org>\n\t\n\t","In-Reply-To":"","Date":"Thu, 23 Jun 2022 16:16:12 +0100","Message-ID":"","To":"Dave Stevenson ","Content-Type":"multipart/alternative; boundary=\"000000000000e43b4805e21eef5b\"","Subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23551,"web_url":"https://patchwork.libcamera.org/comment/23551/","msgid":"<165600078266.1149771.782293290134078796@Monstersaurus>","date":"2022-06-23T16:13:02","subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-06-23 16:16:12)\n> On Thu, 23 Jun 2022 at 16:12, Dave Stevenson \n> wrote:\n> \n> > Hi Naush and Jean-Michel\n> >\n> > On Thu, 23 Jun 2022 at 15:56, Naushir Patuck via libcamera-devel\n> > wrote:\n> > >\n> > > Hi Jean-Michel,\n> > >\n> > > On Thu, 23 Jun 2022 at 15:51, Jean-Michel Hautbois <\n> > jeanmichel.hautbois@yoseli.org> wrote:\n> > >>\n> > >>\n> > >>\n> > >> On 23/06/2022 16:50, Jean-Michel Hautbois via libcamera-devel wrote:\n> > >> > Hi Naushir,\n> > >> >\n> > >> > Thanks for the series !\n> > >> >\n> > >> > On 23/06/2022 16:44, Naushir Patuck via libcamera-devel wrote:\n> > >> >> Hi,\n> > >> >>\n> > >> >> This series adds a sensor temperature metadata control to libcamera.\n> > >> >> This\n> > >> >> control is returned out through Request metadata when available.\n> > >> >> There is an\n> > >> >> open PR [1] to enable the temperature sensor on the imx477 on the\n> > >> >> Raspberry Pi\n> > >> >> platforms.\n> > >> >>\n> > >> >> At present, there is no mechanism in V4L2 to return the temperature\n> > >> >> from the\n> > >> >> sensor device driver, so we rely on the embedded data to fetch the\n> > >> >> values every\n> > >> >> frame.\n> > >> >\n> > >> > I think this PR along with a V4L2 control introduction\n> > >> > (V4L2_CID_TEMPERATURE :-) ?) could be interesting to be sent to the\n> > >> > linux-media ML at the same time ?\n> > >\n> > >\n> > > I was hoping to decouple this with V4L2 changes for now. From what I\n> > can tell,\n> > > the topic of V4L2_CID_TEMPERATURE is a long ongoing discussion, and my\n> > > change here does not rely on it. So our users can get this feature\n> > earlier!\n> >\n> > I've flagged it for discussion at the proposed Media Summit alongside\n> > ELCE in September -\n> > https://www.spinics.net/lists/linux-media/msg212772.html\n> >\n> > Laurent has responded in support of V4L2_CID_TEMPERATURE in preference\n> > to hwmon API, but that still doesn't make it a done deal.\n> > When Benjamin brought it up in\n> >\n> > https://lore.kernel.org/linux-media/20220415111845.27130-3-benjamin.mugnier@foss.st.com/\n> > ,\n> > it became quite a long debate with no resolution, leading to the patch\n> > just being dropped.\n> >\n> > As Naush says, with imx477 (and others) carrying this value in\n> > embedded metadata, we may as well extract it from there and avoid the\n> > complication. It'll actually be a more up to date value than reading\n> > it on demand over I2C.\n> >\n> \n> That's a good point - embedded data values will always be guaranteed to be\n> synced with the\n> frame in question. But sync granularity might not be such a big deal for a\n> temperature measurement...\n\nNot critical no, - but it helps to know that it's at the right frame.\n\nTo me - reading this from the embedded metadata is 'more' correct\nanyway. (At least from our libcamera perspective where we can access\nthat data). If we need a V4L2 control to be able to provide arbitrary\nreads of the value - perhaps there's merit in still exposing it as a\ncontrol - but to me - having this available in the metadata is entirely\nsuitable for use.\n\nAnd we don't have to wait for any kernel interface updates!\n\nPerhaps there might be sensors that don't send the temperature value in\nthe embedded metadata, which might need the v4l2 control interface - but\nthat's not the case here so to me this seems like the right approach\noverall.\n\nNow to the details in the patches ...\n--\nKieran\n\n\n> Naush\n> \n> \n> \n> >\n> > Dave\n> >\n> > >>\n> > >>\n> > >> I forgot to ask the use case though ? :-)\n> > >\n> > >\n> > > We have had a few requests for this feature, see\n> > https://github.com/raspberrypi/libcamera-apps/issues/306\n> > > for the most recent one where the temperature value is useful for long\n> > exposures to\n> > > help with dark frame subtraction in post processing for astrophotography.\n> > >\n> > > Regards,\n> > > Naush\n> > >\n> > >>\n> > >>\n> > >> >\n> > >> > JM\n> > >> >\n> > >> >>\n> > >> >> Thanks,\n> > >> >> Naush\n> > >> >>\n> > >> >> [1] https://github.com/raspberrypi/linux/pull/5067\n> > >> >>\n> > >> >> Naushir Patuck (3):\n> > >> >> libcamera: controls: Add SensorTemperature control\n> > >> >> ipa: raspberrypi: Add sensor temperature to DeviceStatus\n> > >> >> ipa: raspberrypi: imx477: Get sensor temperature from embedded\n> > data\n> > >> >>\n> > >> >> src/ipa/raspberrypi/cam_helper.cpp | 7 ++++---\n> > >> >> src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n> > >> >> src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n> > >> >> src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n> > >> >> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> > >> >> src/libcamera/control_ids.yaml | 10 ++++++++++\n> > >> >> 6 files changed, 26 insertions(+), 5 deletions(-)\n> > >> >>\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 435F8BE173\n\tfor ;\n\tThu, 23 Jun 2022 16:13:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6554B65635;\n\tThu, 23 Jun 2022 18:13:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C50106048F\n\tfor ;\n\tThu, 23 Jun 2022 18:13:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 642346BB;\n\tThu, 23 Jun 2022 18:13:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656000787;\n\tbh=XfR0DonuxGoh3+Iu7/088F/M2wG/wtlh2avhK1tItDY=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=U5bXfCyNrKOSd0oU64hXZ65K/pi4YfVB4VD/AzEYAy6CKMI5MMwYAH83C45nnEzkl\n\tPgbOZELZsqOv+vkA3WJGp1VyG79kWFTBZB7eH/+Kd3EYcjvBsYODQKEZzCmpb0x3x8\n\tl9Gp44oHBX967AXoF+mFhGsh8RG19julQD3s7wQB/yChtdKGnDEIe/GtS5pvuW7OE2\n\tow8ru/RWQMbXIdT/vYBWo03ScRtQYq9QlutFUZ+Bv/1s49pEOn2R9E6kiWPRGGndM+\n\tKWqBK0ptMV1tOoTZgaxPJBxywBzFs5TeghulxjnISFy/8Uh4grjwLv3UVzMHo34wUo\n\tYPvv/UixQ78Gg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656000785;\n\tbh=XfR0DonuxGoh3+Iu7/088F/M2wG/wtlh2avhK1tItDY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=F+l41wXXernNWjYHMCPdoSrpWAs1LsjSaMv6o146ll5WfnJ/NoGkczfHFQr2T90zF\n\tT/hzDSLU3JDpF9QJoYECiu+MVJNp7Q+1wBy1ueveWbBut+wmSYrxeDhV9lwqpqSFZZ\n\tioGj9aKEqyJFL06O7PJfljlr67rAsFu535SieMJw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"F+l41wXX\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t\n\t<2e5cc23b-8f40-5eec-01e8-ba3660ad9ff8@yoseli.org>\n\t\n\t\n\t","To":"Dave Stevenson ,\n\tNaushir Patuck ,\n\tNaushir Patuck via libcamera-devel ","Date":"Thu, 23 Jun 2022 17:13:02 +0100","Message-ID":"<165600078266.1149771.782293290134078796@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23552,"web_url":"https://patchwork.libcamera.org/comment/23552/","msgid":"","date":"2022-06-23T16:13:44","subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","submitter":{"id":127,"url":"https://patchwork.libcamera.org/api/people/127/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@yoseli.org"},"content":"Hi Dave !\n\nOn 23/06/2022 17:12, Dave Stevenson wrote:\n> Hi Naush and Jean-Michel\n> \n> On Thu, 23 Jun 2022 at 15:56, Naushir Patuck via libcamera-devel\n> wrote:\n>>\n>> Hi Jean-Michel,\n>>\n>> On Thu, 23 Jun 2022 at 15:51, Jean-Michel Hautbois wrote:\n>>>\n>>>\n>>>\n>>> On 23/06/2022 16:50, Jean-Michel Hautbois via libcamera-devel wrote:\n>>>> Hi Naushir,\n>>>>\n>>>> Thanks for the series !\n>>>>\n>>>> On 23/06/2022 16:44, Naushir Patuck via libcamera-devel wrote:\n>>>>> Hi,\n>>>>>\n>>>>> This series adds a sensor temperature metadata control to libcamera.\n>>>>> This\n>>>>> control is returned out through Request metadata when available.\n>>>>> There is an\n>>>>> open PR [1] to enable the temperature sensor on the imx477 on the\n>>>>> Raspberry Pi\n>>>>> platforms.\n>>>>>\n>>>>> At present, there is no mechanism in V4L2 to return the temperature\n>>>>> from the\n>>>>> sensor device driver, so we rely on the embedded data to fetch the\n>>>>> values every\n>>>>> frame.\n>>>>\n>>>> I think this PR along with a V4L2 control introduction\n>>>> (V4L2_CID_TEMPERATURE :-) ?) could be interesting to be sent to the\n>>>> linux-media ML at the same time ?\n>>\n>>\n>> I was hoping to decouple this with V4L2 changes for now. From what I can tell,\n>> the topic of V4L2_CID_TEMPERATURE is a long ongoing discussion, and my\n>> change here does not rely on it. So our users can get this feature earlier!\n> \n> I've flagged it for discussion at the proposed Media Summit alongside\n> ELCE in September -\n> https://www.spinics.net/lists/linux-media/msg212772.html\n> \n> Laurent has responded in support of V4L2_CID_TEMPERATURE in preference\n> to hwmon API, but that still doesn't make it a done deal.\n> When Benjamin brought it up in\n> https://lore.kernel.org/linux-media/20220415111845.27130-3-benjamin.mugnier@foss.st.com/,\n> it became quite a long debate with no resolution, leading to the patch\n> just being dropped.\n\nThanks for the discussion :-) !\n\n> \n> As Naush says, with imx477 (and others) carrying this value in\n> embedded metadata, we may as well extract it from there and avoid the\n> complication. It'll actually be a more up to date value than reading\n> it on demand over I2C.\n\nYep, I get the point ;-).\n\n> \n> Dave\n> \n>>>\n>>>\n>>> I forgot to ask the use case though ? :-)\n>>\n>>\n>> We have had a few requests for this feature, see https://github.com/raspberrypi/libcamera-apps/issues/306\n>> for the most recent one where the temperature value is useful for long exposures to\n>> help with dark frame subtraction in post processing for astrophotography.\n\nThanks for the reference :-).\n\nJM\n\n>>\n>> Regards,\n>> Naush\n>>\n>>>\n>>>\n>>>>\n>>>> JM\n>>>>\n>>>>>\n>>>>> Thanks,\n>>>>> Naush\n>>>>>\n>>>>> [1] https://github.com/raspberrypi/linux/pull/5067\n>>>>>\n>>>>> Naushir Patuck (3):\n>>>>> libcamera: controls: Add SensorTemperature control\n>>>>> ipa: raspberrypi: Add sensor temperature to DeviceStatus\n>>>>> ipa: raspberrypi: imx477: Get sensor temperature from embedded data\n>>>>>\n>>>>> src/ipa/raspberrypi/cam_helper.cpp | 7 ++++---\n>>>>> src/ipa/raspberrypi/cam_helper_imx477.cpp | 5 ++++-\n>>>>> src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n>>>>> src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n>>>>> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n>>>>> src/libcamera/control_ids.yaml | 10 ++++++++++\n>>>>> 6 files changed, 26 insertions(+), 5 deletions(-)\n>>>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46A2CBE173\n\tfor ;\n\tThu, 23 Jun 2022 16:13:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E960265635;\n\tThu, 23 Jun 2022 18:13:46 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::223])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAC8C6048F\n\tfor ;\n\tThu, 23 Jun 2022 18:13:45 +0200 (CEST)","(Authenticated sender: jeanmichel.hautbois@yoseli.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 3308060004;\n\tThu, 23 Jun 2022 16:13:44 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656000826;\n\tbh=rGBQXtH1uXnnbZ/8K9mMi1lC9q6g6tLFgbrDGPkLvXo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3u34YG3SssMCPMy8BYKLdAJKYsMQXvi9Sq1lqQd7tX/dUcrVEAjhxXxZwwGlgualy\n\tMS4adZidHmXZP48KOOpfnTYywyjfte0sGtE+ZXSkova0QnDy/9pgyJ261YUMBrBKDw\n\tIGimb1KmuKGxc+fezFDNRcMlAAbbK94mAK6J/kJbAej3y74Yqc+u61JE3KB7BxpiFh\n\t7iguuUZTAlud5x4w2PMoAyQ/Os1YBDm0fKlDxKgY9VAwlsKfmrqggw+IzB+KzeGL8L\n\tRBQ+K43x6OHMs7nSyLXU453ubEX8lD9xZ/Sa2Eeux0IlL7GuM1BUD371Ux4JQ2WaV8\n\tytj9zePcMFeUw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=yoseli.org; s=gm1;\n\tt=1656000825;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=nhwAVhf0D29fey76W3NunSxbe0sVJrRcWjetIfStFCM=;\n\tb=T1xU+wp+koey5CTsIp9J7kF48COWYT77CRVVv1OXY4qDe0RSI2CC26YQPGiV5pWWKXG1Fm\n\tJmSRZsCPbOsNy05NCcJKk88pGj3LIf1cSJzh3PviU4UU/XOLItg5FnGxahRc2t0aDayxZg\n\tHphlgCtynSLqIceWGF7Vy8WXWxg08PxgTBiXdVtMCniFoL2iVX5I5zzqXCDJEUUZs9/dSV\n\tcn9hR1YFWuuN9dr/tiFOp2jmsqJtpJGrnUTMvuJKtljd2nfNMun41Eur1xzJ7fb3eLDeNz\n\t0JcDUSgrKhzjX5Y0n/nCuig78PzRvFe309QPFSnTqnfDCoSnOdZAfqtkENwoPA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=yoseli.org\n\theader.i=@yoseli.org header.b=\"T1xU+wp+\"; \n\tdkim-atps=neutral","Message-ID":"","Date":"Thu, 23 Jun 2022 18:13:44 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.9.1","Content-Language":"en-US","To":"Dave Stevenson ,\n\tNaushir Patuck ","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t\n\t<2e5cc23b-8f40-5eec-01e8-ba3660ad9ff8@yoseli.org>\n\t\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/3] Add SensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]