[{"id":23603,"web_url":"https://patchwork.libcamera.org/comment/23603/","msgid":"","date":"2022-06-27T11:32:24","subject":"Re: [libcamera-devel] [PATCH v3 0/3] Correct ControlInfoMap from\n\tthe IPA","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nAny other takers for a review on this series? The patches need one more\nR-B tag.\n\nRegards,\nNaush\n\nOn Wed, 22 Jun 2022 at 11:20, Naushir Patuck wrote:\n\n> Hi,\n>\n> In v3 of this series, I've made the following changes:\n> - Added the Bug tag in patch 1/3.\n> - Fix typo in commit message in patch 2/3.\n> - Patch 2/3 also keeps some default values for ExposureTime, AnalogeGain\n> and\n> FrameDuration controls during the ipa::init() as requested.\n> - Use the frame duration to calculate the correct exposure time limit in\n> patch 2/3.\n>\n> I've left the code using the ControlInfoMap::Map mechanism to add values\n> to a\n> ControlInfoMap container. At a later date, I may attempt to change this by\n> adding a ControlInfoMap::add() member function. But if this API is to be\n> replaced\n> by something else, it may not be worth it...?\n>\n> Regards,\n> Naush\n>\n> Naushir Patuck (3):\n> pipeline: ipa: raspberrypi: Move ControlInfoMap to the IPA\n> pipeline: ipa: raspberrypi: Correctly report available control limits\n> pipeline: raspberrypi: Advertise ScalerCrop from the pipeline handler\n>\n> include/libcamera/ipa/raspberrypi.h | 55 ----------------\n> include/libcamera/ipa/raspberrypi.mojom | 8 ++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 66 +++++++++++++++++--\n> .../pipeline/raspberrypi/raspberrypi.cpp | 41 +++++++-----\n> .../pipeline/raspberrypi/rpi_stream.h | 1 -\n> 5 files changed, 92 insertions(+), 79 deletions(-)\n> delete mode 100644 include/libcamera/ipa/raspberrypi.h\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF8BFBE173\n\tfor ;\n\tMon, 27 Jun 2022 11:32:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F25F765635;\n\tMon, 27 Jun 2022 13:32:42 +0200 (CEST)","from mail-lf1-x132.google.com (mail-lf1-x132.google.com\n\t[IPv6:2a00:1450:4864:20::132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FE546059B\n\tfor ;\n\tMon, 27 Jun 2022 13:32:41 +0200 (CEST)","by mail-lf1-x132.google.com with SMTP id x3so16113172lfd.2\n\tfor ;\n\tMon, 27 Jun 2022 04:32:41 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656329563;\n\tbh=OhNWVKxgjrbqUgawVQDXW19fsP1uYNogKG6n22ECvS0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1qv2tBGaywb5uU4CrBucI8xkaeTcy2QGSZ5+EpxthX+XyuvT8y2mL1TNuxR3VDAIv\n\tjqhEIEVo3Dc93rI4cKghJ7z5HEyZDjU9+qJgiOhC9ZWDbVvem41elKfTORn3nQOQiw\n\tB42mUFQacOXJT0s3ZwhFEV9G5yBnoK1FsecuUg/DIPw1G+Jq6X/2Hsa0L05lq2Rdmw\n\tN8xsHMqvh38C/cZjJZsZnTvGO85rHNN1MfRS8YV8In1B6//uIPQ6nhPIEZGise/6U5\n\t2TglchzQiP6hieZTbyzJNzRNxs0oTIfquLC0upT+oSs2Pu6GBUq2YJLWbwlqLaJxXl\n\tjzkOoIVKDbD3Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=oqHHikloH+SLkvziaFMo1tDTes01l0zH4KlH5EVQkV0=;\n\tb=olaCzI+i/ZNGKOvzAiBVriJJJAlO1hBQNAxlUEB+WDgaTASRUtTBoLYK7w3BnXb3Ca\n\tNZH6YzbSMFQGdgvrVug9xCVttdzTEfy2NZCHHe0YPzgcKxqv5+zWpfzXOovGBt1Q49sP\n\tfQ/PxGEtGG0BlCjlC32Fc30kdnBw0FjPHQgBguHGyT0PLa6jVZDiDJVKShhSueH3YNz8\n\tCtZG1ftby5mzYH0ozdQDd9tWtzzbDdCbNtgXSl21Q309ViNmNaNJuWFTKo3MhYunfdsa\n\tzvZhiMjreZTrTQ2MDhbabjzbStJXENT4WsQyo7rNcVuaHYQ8pkULpVuZpwVbpauglMz2\n\tNv1A=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"olaCzI+i\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=oqHHikloH+SLkvziaFMo1tDTes01l0zH4KlH5EVQkV0=;\n\tb=WRLsaOhDxv9LxQgfSiGtJhX77S7IaE1+awHqLZSCFpiH4JimkIVYDuRcrlvs4MU+eF\n\tVZ8XxJstbm2GswofMoMi7AkP4J/Q0yFfZbINO547pF5Kh6nGd1Qx1VOOYluKPkRPVjNY\n\t4yFd7uiWvggp2IKf5NLM3zizuewIcYR/tbHIA7/h6ED2z3dIwM4rX1WEi4qqUYHCpeDp\n\ttfXnetcH9CNQnATRaXbYG+MgruEvIvyH/8IoN3YzYQr71rkuIhaNmpsirUjqgadIGStE\n\tLIjY6SoazAfS6W3LhIqz97n3q0YByhYlO/rdixvxZT8hXZtEvVKX5bXIRMLvv/0zXLPF\n\tXe1Q==","X-Gm-Message-State":"AJIora/n9X7Iy3/5zqFh51/di++Dqy1QFr4eCbMUK/Dad4cX/rE6c/G8\n\tK64rlrDQbjbrkd2lKiac9HYPc8Ds0dWR/VialNdmzYfzi//b0A==","X-Google-Smtp-Source":"AGRyM1syfci8BcmpPsZM539X9vw2PmV+DJvu3iole/rpkk2V0aX/oIasS36EAP0TN3zsvhXEfYK86U8JMiKsRYEfeCk=","X-Received":"by 2002:a05:6512:3d08:b0:47f:6efa:4965 with SMTP id\n\td8-20020a0565123d0800b0047f6efa4965mr7812805lfv.363.1656329560184;\n\tMon, 27 Jun 2022 04:32:40 -0700 (PDT)","MIME-Version":"1.0","References":"<20220622102047.22492-1-naush@raspberrypi.com>","In-Reply-To":"<20220622102047.22492-1-naush@raspberrypi.com>","Date":"Mon, 27 Jun 2022 12:32:24 +0100","Message-ID":"","To":"libcamera devel ","Content-Type":"multipart/alternative; boundary=\"00000000000010ea4a05e26c473b\"","Subject":"Re: [libcamera-devel] [PATCH v3 0/3] Correct ControlInfoMap from\n\tthe IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23605,"web_url":"https://patchwork.libcamera.org/comment/23605/","msgid":"<165633040747.69174.12101614969357631716@Monstersaurus>","date":"2022-06-27T11:46:47","subject":"Re: [libcamera-devel] [PATCH v3 0/3] Correct ControlInfoMap from\n\tthe IPA","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-06-27 12:32:24)\n> Hi all,\n> \n> Any other takers for a review on this series? The patches need one more\n> R-B tag.\n\nDavid, have you tested these patches already as well?\n--\nKieran\n\n> \n> Regards,\n> Naush\n> \n> On Wed, 22 Jun 2022 at 11:20, Naushir Patuck wrote:\n> \n> > Hi,\n> >\n> > In v3 of this series, I've made the following changes:\n> > - Added the Bug tag in patch 1/3.\n> > - Fix typo in commit message in patch 2/3.\n> > - Patch 2/3 also keeps some default values for ExposureTime, AnalogeGain\n> > and\n> > FrameDuration controls during the ipa::init() as requested.\n> > - Use the frame duration to calculate the correct exposure time limit in\n> > patch 2/3.\n> >\n> > I've left the code using the ControlInfoMap::Map mechanism to add values\n> > to a\n> > ControlInfoMap container. At a later date, I may attempt to change this by\n> > adding a ControlInfoMap::add() member function. But if this API is to be\n> > replaced\n> > by something else, it may not be worth it...?\n> >\n> > Regards,\n> > Naush\n> >\n> > Naushir Patuck (3):\n> > pipeline: ipa: raspberrypi: Move ControlInfoMap to the IPA\n> > pipeline: ipa: raspberrypi: Correctly report available control limits\n> > pipeline: raspberrypi: Advertise ScalerCrop from the pipeline handler\n> >\n> > include/libcamera/ipa/raspberrypi.h | 55 ----------------\n> > include/libcamera/ipa/raspberrypi.mojom | 8 ++-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 66 +++++++++++++++++--\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 41 +++++++-----\n> > .../pipeline/raspberrypi/rpi_stream.h | 1 -\n> > 5 files changed, 92 insertions(+), 79 deletions(-)\n> > delete mode 100644 include/libcamera/ipa/raspberrypi.h\n> >\n> > --\n> > 2.25.1\n> >\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CCB0BE173\n\tfor ;\n\tMon, 27 Jun 2022 11:46:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70E3765635;\n\tMon, 27 Jun 2022 13:46:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13EF56059B\n\tfor ;\n\tMon, 27 Jun 2022 13:46:50 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9BD281C82;\n\tMon, 27 Jun 2022 13:46:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656330411;\n\tbh=bxUM7yRrX1ifES9heMjjWojQTIxpp+tA5UqshOtM0PY=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IGenmR9llCyAeFlzWhbKQWKeRh5YOUf9/NNpdB/S2M1sEgBVoKdITbMOYWyExCbTc\n\tru3Fs5+FXmTkAYcGZK/vNHJdxdvzKU0s+RXO5GuOhJnnEf3Fv3BWTNqPpyx48nJQBU\n\tk7+zHUO0zuOClxMT68KFXsFt4KV9u0fAdeAPALJRG5OZBLPgrJ9Ly2avYtt4yoDWi6\n\tICtfcwedHjD3OfftKDHbv0+ra9MROqu/SuUg3gj+W1bXOachtAdLpdRqJD4kUljZWH\n\tT4HJDliIUsGtnPqvCjkdLz2zdQEDWTzh/hLxMZ9Rpj1Caj/Bwh3kEWETUUTfe9HMl7\n\tE6MsYxtCZs4xA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656330409;\n\tbh=bxUM7yRrX1ifES9heMjjWojQTIxpp+tA5UqshOtM0PY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=F1GKfChG7Gzf5DavUjpq6i+ZQu2r1xzDWcqH3a2QyymuoW1OXZMvvgo3U+iRjRuLY\n\tlKVWeFewb7XH5oOTD9MAJBmfb/qakNUphkHvuNn6W5ZSV161APkENMTdkj3Rt55SbL\n\tG0hYRbuKWdLHNXNwBIOvu/jxO02L8hzeMFBGJK60="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"F1GKfChG\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220622102047.22492-1-naush@raspberrypi.com>\n\t","To":"Naushir Patuck ,\n\tlibcamera devel ,\n\tDavid Plowman , ","Date":"Mon, 27 Jun 2022 12:46:47 +0100","Message-ID":"<165633040747.69174.12101614969357631716@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 0/3] Correct ControlInfoMap from\n\tthe IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]