[{"id":23434,"web_url":"https://patchwork.libcamera.org/comment/23434/","msgid":"","date":"2022-06-17T06:58:36","subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi, JM,\n\nFor BNR parameters WB gain factor for the three channels [Ggr, Ggb, Gb, Gr].\nTheir precision is U3.13 and the range is (0, 8) and the actual gain is\nGx + 1, it is typically Gx = 1.\n\nPout = {Pin * (1 + Gx)}.\n\nSo that means for wb_gains.Ggr/gb/g/r = 0.5, the actual gain is 1.5.\n\nIt seems not correct to changing ratio from 8192 to 4096 as its\nprecision is U3.13. I am not familiar with ipa implementation in\nlibcamera, not sure other details.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8144BD808\n\tfor ;\n\tFri, 17 Jun 2022 07:32:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E70C065635;\n\tFri, 17 Jun 2022 09:32:56 +0200 (CEST)","from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3657260471\n\tfor ;\n\tFri, 17 Jun 2022 08:58:43 +0200 (CEST)","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t16 Jun 2022 23:58:41 -0700","from orsmsx606.amr.corp.intel.com ([10.22.229.19])\n\tby orsmga003.jf.intel.com with ESMTP; 16 Jun 2022 23:58:41 -0700","from orsmsx609.amr.corp.intel.com (10.22.229.22) by\n\tORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27; Thu, 16 Jun 2022 23:58:40 -0700","from orsmsx609.amr.corp.intel.com (10.22.229.22) by\n\tORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27; Thu, 16 Jun 2022 23:58:40 -0700","from orsedg603.ED.cps.intel.com (10.7.248.4) by\n\torsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27 via Frontend Transport; Thu, 16 Jun 2022 23:58:40 -0700","from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42)\n\tby\n\tedgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.1.2308.27; Thu, 16 Jun 2022 23:58:39 -0700","from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by\n\tBY5PR11MB4483.namprd11.prod.outlook.com (2603:10b6:a03:1bc::15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15;\n\tFri, 17 Jun 2022 06:58:36 +0000","from DM8PR11MB5653.namprd11.prod.outlook.com\n\t([fe80::81de:d29e:a239:f5c]) by\n\tDM8PR11MB5653.namprd11.prod.outlook.com\n\t([fe80::81de:d29e:a239:f5c%7]) with mapi id 15.20.5353.018;\n\tFri, 17 Jun 2022 06:58:36 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655451176;\n\tbh=jvTUVca+6/9Iq/mIiBk+/MIpYMGeVmR56q+Y6dJcYqY=;\n\th=To:Date:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MdITy7ljI7sBEYAaT6qf0KUuNJI7LxZUfo2NgmCVGMKfPU2PnfI36s3q46me5nqRJ\n\tBGSw0Az6h7Cpl1A3z6/lSDIUnzqbH0gZFEfGe17DACwr7fJENV+q6Jz6HpKcOlTfsF\n\tvxKsDqWG/WDOk6jlKB0eW0/Wp9m8Iz1XrytjtshnE23nvYVg8r7af2FXrR+1fI8E1N\n\t546BcAZmPBAIkbGn9h7/HdJ+aJxmuSsPv/4WjhMAC1bsSUPF/zTj/QsSMW4kGb/l1l\n\tGcYrZNVebqEnR5v8PWP7S76HDSIo2sHlX6H1T0+Fko0c+xWJVcfSMzx1N3lsHq+ZOn\n\tkaRR/BEXLCjPw==","v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1655449123; x=1686985123;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=jvTUVca+6/9Iq/mIiBk+/MIpYMGeVmR56q+Y6dJcYqY=;\n\tb=eDwkvUsowSf9sbsdNxeCjNLuwwQxqeIS6G8vu0FtP3uCP2/bt3BWjKFC\n\tJmcq5po+u+uswRr64fQVTGRjnsXC8qmff1yNdTvJcsc+L+dLnzfUWkIm/\n\tnht0UAlNKvhlZKfeLTOFi5dJkWteZyFPbyW/Dc1VnHPOgWz+diWMsnXCh\n\tb8GZyNef7A36A3Ixoejs9eZfRjIsXPLY49/aKqmrPQ/qgNEdHXRMVtKi7\n\t2+PrK0/Jck7DUDxmuK78aUbgfnLIXNuunPTqPs8ohqe6n7+NasGjqO8tt\n\t9LuiMYFL1DgntDAKKCm4HX+QsDPztLfxY0fgrx+x5p9Vi/kW+PoidkXmV g==;"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"eDwkvUso\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=intel.com;"],"X-IronPort-AV":["E=McAfee;i=\"6400,9594,10380\"; a=\"304889167\"","E=Sophos;i=\"5.92,306,1650956400\"; d=\"scan'208\";a=\"304889167\"","E=Sophos;i=\"5.92,306,1650956400\"; d=\"scan'208\";a=\"536735957\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=Otvbra6vqNM3sa1jRVCpBqH2yPsTqipSipPbl5puzmo5yxdzVmcmneRDOb/hFOGAOPtY90lPXCJZiWTumGfOjxth7i1FtKHegTaFzbUqU8AHM+jZBEsTuk9OUtnAchElYCmRkT0d0u9Wtl3jTKFoSbn2C1av8+/pEZ1bHnLDLFjNL8Ji8eE+ZxqsHtwcMfNP4oMxH0ewBPzsdhkbXe+8nr0zxZRWiyhrkvm+76JMLQmaPXfBSlgcwgoCZT2P3/sCwC8IXUmWAxXe8l97W+2isgmmMOVHy9qleFxsRO4UdsaEJuufpTjQAzHGPQMJnGYM9qPV6Cs9H3pogJq4z42kAg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=/3DYhd9BcWRTJTG6o+UzOOSUyHdFZkJdBW4+qcUpSDU=;\n\tb=QiXk+pjnCpNtViwH8RCfqh5Vw26U97VQZxybMOx8mxqT9T4y8e+Eiwu1DLqVoeUnm9Nuue8cRsK6SNpZ/zMcNo1HFZEIZxiQrDXdRcr2Bj7Ny5QDfkyIZWo6JoVkWG5TsAsYS9FfcPixffEhEzjmr7ONQsjSFs/TpHNPP2VqF9bKoRGEFd/7LUzVxPVDHBNgHiXv+8W7qMq1+fnjwBUhSNxuQj1jDHsvCj5UWf2aAw8NN9Oem6jEQLB8I2hYOtqmfAk1wk9J2RelcrcKtPFG11fEz1OrVUfWl9nIBIqErH1AHOKnQiHZ4/NtenmitmVH6aTIKEPglnTXh7z2Ws5oAw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n\tdkim=pass header.d=intel.com; arc=none","To":"Jean-Michel Hautbois ,\n\t\"libcamera-devel@lists.libcamera.org\"\n\t","Thread-Topic":"[RFC PATCH 0/1] IPU3 AWB gains correction","Thread-Index":"AQHYgWE//6QkI2bzKU+Nd/p2Ip/2kK1TJ1+A","Date":"Fri, 17 Jun 2022 06:58:36 +0000","Message-ID":"","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>","In-Reply-To":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-reaction":"no-action","dlp-version":"11.6.500.17","authentication-results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"eDwkvUso\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=intel.com;"],"x-ms-publictraffictype":"Email","x-ms-office365-filtering-correlation-id":"e28aa74f-723f-4fc4-8525-08da502ecd10","x-ms-traffictypediagnostic":"BY5PR11MB4483:EE_","x-microsoft-antispam-prvs":"","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;","x-microsoft-antispam-message-info":"3/iInsU69o0VtUbRFk86OfByrs9Go4sdRMgzY+8ALUGQnNpFuIA2kVUMqcfRphStctyM3wKE36kQfuEV/OF0O1aeT+SfyFOrlG24msWSJ0y8QBAgSHwy/Cq/GoTNoIeDQGFkBAvMbqu4UAgd85+zYmhz2BuOgnpV+ekLAR0Y/bqydohARaPBkwgn/vdMg0K5xanU35TuhtfMxOjqjniY3cJjiCyT0otRbKds7/zSUKMHp4KafMFlkX0PFbuyGcK0021fOKKbXL0CWxU3bOE1BRf6PgditUbqyLJTBmocDcoLKp3kJ2Yvt8yzLHPggaWyFH0JMsOTxlRqArW4Vv+n+yONLu0j4qeFrLnzy6m++0IXheSenVKtGneaK56liVMS/sW8WtbwMCyGADI07JhnRTioggJcRXUZWwqi7u0RLMGACWC7u5X//n5CuAVncmGQBRFWITlGTCRbdZfigVmPMNQMOEc8KbP65CNN/8g5nF72aYaRAD4wNLV0JfJmBW1inGK2PvxyJXbN7lMFieTO3YSOVi/qRaYRP+HeVtQMvzGhkzjKo4y0FgDQzcLVQtOQbvHLeiCLYd4Y3edQ5jVoYRIpVOxs/IzWSRoQiHWPDQc9sJWQs/2DQfVCiXpof+tV0g35eykQ+guCmE/KuGq/Wb5jCDP5YkCwv3HpoWMKgNX2x2H/Lj6OErJffJkO3VRg9De58ayBAe8GItfpBoHE487kiIZBWkNxZyercLnClmyFHwmy7teJWnm9enMEbK4NQIyYZgiAE06EXNvFrNx2NrVjASlJGwaaq574tOlal0M=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230016)(366004)(38070700005)(186003)(2906002)(26005)(38100700002)(316002)(110136005)(4326008)(8676002)(66946007)(83380400001)(64756008)(76116006)(8936002)(66446008)(66476007)(66556008)(6506007)(7696005)(52536014)(53546011)(5660300002)(508600001)(33656002)(122000001)(55016003)(82960400001)(9686003)(86362001)(71200400001)(966005);\n\tDIR:OUT; SFP:1102; ","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"H/s5U615lv7VT7mWygooAAQSmkVhqTSSHzG2wOAQUPSdOaVcrym7pj3PEEmK3jn9NZNQgazLgNxxH7M+uyttUHbQghTGFDEPv/v8NnzwRdDTZCH8OiMhzYujTqkYa6AObaL4RpeJUDUuDIilfC0HC5qdnR2WeXr3mZo/fwOdel/gentEjFI7fU8ov3j2OGvUdf3sa8H/oV6L4xGTOrTPRJAY/Y+HDYpSmcN0sZV+/ObuflaDsTkRcct7f9UomesP6qH1UW41yO537gsxVEjJYdx4BFG6GVYXYbry+9s7wj08ka3AiVSQYZQABlbElsjPC45PfrypcGb4KsY7YqR5NHpUHdi0h4FTQ83dM1W2hLQygcee+UTJQAj0DYoLJ+MN+3ZC/thHEWnlCFjD1QXH6v6j663RS8zd/oeBrnmjP3idkfRh/fiZ0NjU40IUh8wtzHPVpoJDBJ/swLxcf9Q5zP7WLwfp1l/oEwnsyjaltUMizFI+brvbMv+K/JtDqndhG014c+zEtBveTCs7FDXOzHKp6t1tkwlH3VxQSCQjD6JJJDRRFzgVjmMQOG1oVnySdiaH8WEmUfuWdZsefISmnANE+aIfWbcheH3kGqJupeuI0DiXRHM32t2TN/4ON00ax+qAbiug8M5aeQqI6RtAiM7Q4Qhh+fc6aRJ37aLR4IC9+X3fcesJAyLfAPAVtDXrTliBIxWie7BD21Ca6r6sDUjOxjuRsZqFCGMAqwK0kJeNBGVzx8FRQid4Bobg2/uC7MutAswidqNqU348mqqU4hSC3S4xT+eZcm44knkuzSIb6HYrAAFL5nfUahn8PJ08nz7ghf8iir/CBhS1ARCjZ2R0iqcF533qCcglDLKg7DC3Yy7ZkMB9Rn0dCNQhgf25fr7dL/lc27tW+MlHA59t+eEtp2ZfjWQurOE9RcYqzHh9RbAtXRVXAcrSdRuD98EWkaGT807d5Ui5vnC18AHjv3wSIw/VEB6T8Cf78V5h7UNzENt3EBAm+v3ctXAR0ICHMLdafvXCtkafqHBD7LCJ6DQPalwRDH5iOFh0h2khn9xIq3/wIgDvBTJVfQ/GBi1cWtXAUMIeNq5/0Ye8+uAowNV9bIExKl129IAwKqnmL2cinRMimbGdCceKU2sXnC1MDLdx/qvGvKSEkldjHWiimBNkAzFMmbdLbhmkuW+U7S4Y0a0hG8i9Gee0+iaC08XHYMktOiY5pAUekWxf4ZWj083TqBTmiYGNmDiVMIxKncz/y1lUk87JKMd+bCi0qorkx+wE+uVdkr9LzaAOlcp4JTFoWCVL/ot8/M4IIl3Pk+IUAxGWRhCiS9DdaT/mzdC/j6NjyqlMJ9AwZvBvDQ45s0bRrZcBH4DbIsltG+68l4Sv/rxMShl9r+txJSD0CVRH9zEkzpX5OUfYOl8BUUl7pp3qXA6TdBqnOkiKGQD15xpBdsytYa0VEATXCuagw/uzAC052hRzc/5GJDQ2P0LWsdEmlzCOOSrt3z8Kc36MoUWwPnU4n08F+HRCbwFEzAcv5ok86QPzG6yA7H4wlryTuZxRk+Opx9CfXaJ8Y32ZMPir0m3XZDtfUPOtFv6CBtgrvsY/lJ7KBdD2xEQuZzmojEPFoZ/ju9ydKLPDHmjL85eeNNmacIIhFzkSUFHli47Cpbi4wNvNmDrMgwsli3u3VqpNiL32BNSv19ZAzOafoxPLlRTpXFTKyxQaiV3gRU17Uo3crbfs++PKGwVO5WtN/g==","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"DM8PR11MB5653.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"e28aa74f-723f-4fc4-8525-08da502ecd10","X-MS-Exchange-CrossTenant-originalarrivaltime":"17 Jun 2022 06:58:36.5164\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"snBU1WpoqX73bAeQ+UTeB/eIytqfeebaNO/L3xFu81CRTjlBmBoeogZ9HeMtXW8IlDlIog9nRt+Fnq0VsYsmQw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BY5PR11MB4483","X-OriginatorOrg":"intel.com","X-Mailman-Approved-At":"Fri, 17 Jun 2022 09:32:55 +0200","Subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"\"Cao, Bingbu via libcamera-devel\" ","Reply-To":"\"Cao, Bingbu\" ","Cc":"\"sakari.ailus@linux.intel.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23435,"web_url":"https://patchwork.libcamera.org/comment/23435/","msgid":"<0901a428-19ed-d81f-b6a1-48199a73ddbf@ideasonboard.com>","date":"2022-06-17T07:53:32","subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Bingbu,\n\nOn 17/06/2022 08:58, Cao, Bingbu wrote:\n> Hi, JM,\n> \n> For BNR parameters WB gain factor for the three channels [Ggr, Ggb, Gb, Gr].\n> Their precision is U3.13 and the range is (0, 8) and the actual gain is\n> Gx + 1, it is typically Gx = 1.\n> \n> Pout = {Pin * (1 + Gx)}.\n\nThat is very interesting, as I thought it would be Pout = {Pin * Gx} !\nIt means that, applying a gain of 1 for green channel is really forcing \nGgr and Ggb to be 0 !\n\n> \n> So that means for wb_gains.Ggr/gb/g/r = 0.5, the actual gain is 1.5.\n> \n> It seems not correct to changing ratio from 8192 to 4096 as its\n> precision is U3.13. I am not familiar with ipa implementation in\n> libcamera, not sure other details.\n\nNope, indeed, this is not the correct ratio !\nBut now I know what is expected, I think.\n\nThanks !\nJM\n\n> \n> \n> ________________________\n> BRs,\n> Bingbu Cao\n> \n>> -----Original Message-----\n>> From: Jean-Michel Hautbois \n>> Sent: Thursday, June 16, 2022 5:12 PM\n>> To: libcamera-devel@lists.libcamera.org\n>> Cc: Cao, Bingbu ; sakari.ailus@linux.intel.com;\n>> Jean-Michel Hautbois \n>> Subject: [RFC PATCH 0/1] IPU3 AWB gains correction\n>>\n>> Hi there,\n>>\n>> Bingbu, Sakari, I cc'ed you because this patch is not aligned with the\n>> current documentation in the intel-ipu3.h file, could you have a look\n>> please ?\n>>\n>> The part which worries me is that the green gains should be 0 for the\n>> white balance to be correct which is not stated in the documentation at\n>> all.\n>>\n>> In order to demonstrate it I captured two frames, [1] is the actual SGo2\n>> image quality, and [2] with this patch applied.\n>>\n>> [1]: https://pasteboard.co/hUcL4U6eyyAH.png\n>> [2]: https://pasteboard.co/2XIbkkL8kitl.png\n>>\n>> There is a very clear benefit, that's why I submit this RFC as I think it\n>> needs to be clarified :-).\n>>\n>> Thanks !\n>> JM\n>>\n>> Jean-Michel Hautbois (1):\n>> ipa: ipu3: awb: Correct the coefficient factor\n>>\n>> src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n>> 1 file changed, 4 insertions(+), 4 deletions(-)\n>>\n>> --\n>> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6F84BD161\n\tfor ;\n\tFri, 17 Jun 2022 07:53:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D794465635;\n\tFri, 17 Jun 2022 09:53:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0E8060471\n\tfor ;\n\tFri, 17 Jun 2022 09:53:34 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:28e5:dce:57ec:634e] (unknown\n\t[IPv6:2a01:e0a:169:7140:28e5:dce:57ec:634e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6020F268;\n\tFri, 17 Jun 2022 09:53:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655452415;\n\tbh=AN15Uef2+2Bz7mjwezWXKN/6c4jZJ2rTv3Yz9/02Toc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=D7VwalHd5Mzyn09NAleLbSD83tLwu6J3QQxH+tAQ+INEErmR9X6ZuwVPjlXLABss/\n\tpls08hFdhfqNnm1HwbIwhzxwJ6r3SzIyIzHt4Oj+gvgUNiBVSqKezMsgSSBq/z60AM\n\t16Rark+ZzagR6AVFx3J19aP6dqX1yaHU/gATclHuhQbJkDzQ8DiJ9swWrbMnrR3Wst\n\tEFmgo7UeQkpb7TFvQzw9HFyWmO5UFXvisP5DNKTFW2TiRopntJ/pFCi+fVtcnQBmz9\n\tSHfVqof+CZUxsG2uPtg91oF5JJ/We7riulXGuB/61IX/M2Blvb4sPp81ZYNOhupv/q\n\tbQmpZHnFqpaXw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655452414;\n\tbh=AN15Uef2+2Bz7mjwezWXKN/6c4jZJ2rTv3Yz9/02Toc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=jrn+Sfgy6YnNRcY2gqBwRZdTsFCMJ+sf1XWJrRhRRiO/aOnM8FOYrroaE14lyPx7D\n\t+Gc9KywFxaYynorzXIRLlDyCFuF4fJwelK+mNXIAwZEX9eEamuYxYRqiKivZHWViyZ\n\tSvwzxoqDEwmteLo2Py7SKz8cGsdauqnJECNn/o8E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jrn+Sfgy\"; dkim-atps=neutral","Message-ID":"<0901a428-19ed-d81f-b6a1-48199a73ddbf@ideasonboard.com>","Date":"Fri, 17 Jun 2022 09:53:32 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.9.1","Content-Language":"en-US","To":"\"Cao, Bingbu\" ,\n\t\"libcamera-devel@lists.libcamera.org\"\n\t","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Cc":"\"sakari.ailus@linux.intel.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23437,"web_url":"https://patchwork.libcamera.org/comment/23437/","msgid":"","date":"2022-06-17T08:07:56","subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Bingbu,\n\nThank you very much for your quick reply.\n\nOn Fri, Jun 17, 2022 at 06:58:36AM +0000, Cao, Bingbu via libcamera-devel wrote:\n> Hi, JM,\n> \n> For BNR parameters WB gain factor for the three channels [Ggr, Ggb, Gb, Gr].\n> Their precision is U3.13 and the range is (0, 8) and the actual gain is\n> Gx + 1, it is typically Gx = 1.\n> \n> Pout = {Pin * (1 + Gx)}.\n> \n> So that means for wb_gains.Ggr/gb/g/r = 0.5, the actual gain is 1.5.\n\nJust to make sure my understanding is correct, does this mean the\nfollowing ?\n\nwb_gains.gr = 0 -> actual gain = 1.0\nwb_gains.gr = 4096 -> actual gain = 1.5\nwb_gains.gr = 8192 -> actual gain = 2.0\n\n> It seems not correct to changing ratio from 8192 to 4096 as its\n> precision is U3.13. I am not familiar with ipa implementation in\n> libcamera, not sure other details.\n> \n> > -----Original Message-----\n> > From: Jean-Michel Hautbois \n> > Sent: Thursday, June 16, 2022 5:12 PM\n> > To: libcamera-devel@lists.libcamera.org\n> > Cc: Cao, Bingbu ; sakari.ailus@linux.intel.com;\n> > Jean-Michel Hautbois \n> > Subject: [RFC PATCH 0/1] IPU3 AWB gains correction\n> > \n> > Hi there,\n> > \n> > Bingbu, Sakari, I cc'ed you because this patch is not aligned with the\n> > current documentation in the intel-ipu3.h file, could you have a look\n> > please ?\n> > \n> > The part which worries me is that the green gains should be 0 for the\n> > white balance to be correct which is not stated in the documentation at\n> > all.\n> > \n> > In order to demonstrate it I captured two frames, [1] is the actual SGo2\n> > image quality, and [2] with this patch applied.\n> > \n> > [1]: https://pasteboard.co/hUcL4U6eyyAH.png\n> > [2]: https://pasteboard.co/2XIbkkL8kitl.png\n> > \n> > There is a very clear benefit, that's why I submit this RFC as I think it\n> > needs to be clarified :-).\n> > \n> > Thanks !\n> > JM\n> > \n> > Jean-Michel Hautbois (1):\n> > ipa: ipu3: awb: Correct the coefficient factor\n> > \n> > src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n> > 1 file changed, 4 insertions(+), 4 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DFADBD161\n\tfor ;\n\tFri, 17 Jun 2022 08:08:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C509B65635;\n\tFri, 17 Jun 2022 10:08:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D47B60471\n\tfor ;\n\tFri, 17 Jun 2022 10:08:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE80FE5;\n\tFri, 17 Jun 2022 10:08:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655453289;\n\tbh=30tB4oWK7TsGNgKqOHhsaN8K0AkG9OXVks9IoAbv6CU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=y0NIxIe3d1z/JfClVZF0GhRgPSh8kwRgaUxEjcHbjTnXzUPuXIyD4P7kjO5hNKdhM\n\t1o9QnxYdW/6Kwk5MN/5b7LZ3TWCDts0J6uOpEdS5j+LnY0iz9ZaFI14DiVcWQpfXRh\n\teKdKuv4AUrTdNHFF+o7OQ9SDk+4FFvyU/9rQpBCxgKzbHhWfbBElNz8JT2cOQf6KlC\n\tzSFMsyE0Tts0fhToe07M/JA093BX0vRRjem11JgV5vKzEkpmg5AUr/fPtIsh6/hZWP\n\tIW3Z/N2TNYEYFRS3HTZh2EYBjl8JzKa/469h7eAMMjaIIsPDTqq3fVORc08cuMRvM1\n\t1WNJrD8HuZaow==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655453287;\n\tbh=30tB4oWK7TsGNgKqOHhsaN8K0AkG9OXVks9IoAbv6CU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jOKYBXD4ZhyuRQOdg4NV7PiuZ3WHsG47NVMFUu1gWooOU3LF5sc1yNWveyFoWY+c2\n\tIJ1cFD/0wXXOms+q8mJlVsYX6HGLuFstrMx7becm1PiHZ4e6s8fxRUNdc0XsD5DO8B\n\toTmkWFMVZv/8ZQLBkwMkRIXRtBHrIZMygxQOe3ZM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jOKYBXD4\"; dkim-atps=neutral","Date":"Fri, 17 Jun 2022 11:07:56 +0300","To":"\"Cao, Bingbu\" ","Message-ID":"","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"\"libcamera-devel@lists.libcamera.org\"\n\t,\n\t\"sakari.ailus@linux.intel.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23446,"web_url":"https://patchwork.libcamera.org/comment/23446/","msgid":"","date":"2022-06-17T13:30:07","subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Laurent and JM,\n\nGive me some time, let me confirm with our algo team.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DCD4BD161\n\tfor ;\n\tFri, 17 Jun 2022 13:30:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBA1265633;\n\tFri, 17 Jun 2022 15:30:28 +0200 (CEST)","from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8451C65632\n\tfor ;\n\tFri, 17 Jun 2022 15:30:22 +0200 (CEST)","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t17 Jun 2022 06:30:09 -0700","from orsmsx601.amr.corp.intel.com ([10.22.229.14])\n\tby orsmga003.jf.intel.com with ESMTP; 17 Jun 2022 06:30:09 -0700","from orsmsx604.amr.corp.intel.com (10.22.229.17) by\n\tORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27; Fri, 17 Jun 2022 06:30:09 -0700","from ORSEDG601.ED.cps.intel.com (10.7.248.6) by\n\torsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27 via Frontend Transport; Fri, 17 Jun 2022 06:30:09 -0700","from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175)\n\tby edgegateway.intel.com (134.134.137.102) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.1.2308.27; Fri, 17 Jun 2022 06:30:09 -0700","from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by\n\tDM5PR11MB1324.namprd11.prod.outlook.com (2603:10b6:3:15::14) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.5353.15; Fri, 17 Jun 2022 13:30:07 +0000","from DM8PR11MB5653.namprd11.prod.outlook.com\n\t([fe80::81de:d29e:a239:f5c]) by\n\tDM8PR11MB5653.namprd11.prod.outlook.com\n\t([fe80::81de:d29e:a239:f5c%7]) with mapi id 15.20.5353.018;\n\tFri, 17 Jun 2022 13:30:07 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655472628;\n\tbh=QBdb+kW5iV05hrZb/lptznudjEPinkMCBJurwkn3Z00=;\n\th=To:Date:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yPEfsXhgWiwxJ52SZexDmgecd5Sc6mKMOaUAA0dpXl3WNWrimZlQ1jfPce2uEYkGL\n\tuTjenRXFnXKWjGPfplIhNa64XsTuIcjhDsgYy5RfEx+NjJrs7ca46fKYJWmszrZwN8\n\tASM5G25300x/mzcfUYJ+2ZK9tHij3S0iY+eGWut0NzJTesKjDclAR0IuMnQ8u0MRDP\n\tBi7dpUW0T+MjbyoSUd8srgRlpiEGDDoYaWEGIeu4PPd61ViQuKVxvqJWpayDHjM93Y\n\tOtLulPBIxJMLjjbaVC4VAV0+m4ZvCO3UpcBmdo3p5fCm+luzZWqU7gA1Cn0EF2kVoN\n\tbU/OJl/VjyBWg==","v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1655472623; x=1687008623;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=QBdb+kW5iV05hrZb/lptznudjEPinkMCBJurwkn3Z00=;\n\tb=euVWwWdIxgoyvLB7WPicH5g7epuQDJ7dJ1fKs/b1KHfpOV4o/4I/j8vV\n\tE0FUBX/XDc/qOpNRt/Qtxb+7mUUNH77CgHl1lQMoqoezCM1D7KQ16tO4v\n\tmSG3HpCGcLuMC+zecyb+rJXxOsoAezc/3/nHp2x94R81N2JL0+s/ghQPa\n\tbDG0aKSuhMNjhhrgcAoa5iVxXj6j9c9uUVnRtkgrBrZEooy9DUfLIL5NU\n\t3oakJfAutOQe4alYIRaRPFy9OVACKZo4YB+36l4zrPeDMF3xUhgG5J00i\n\tgTI6cHwU79TrVhmITvUCL5hvuBMuJFJaStiCezlaZcJC6Jdhdx1ZpbUFh A==;"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"euVWwWdI\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=intel.com;"],"X-IronPort-AV":["E=McAfee;i=\"6400,9594,10380\"; a=\"341174835\"","E=Sophos;i=\"5.92,306,1650956400\"; d=\"scan'208\";a=\"341174835\"","E=Sophos;i=\"5.92,306,1650956400\"; d=\"scan'208\";a=\"536822579\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=g7BuGQJGaCOkKF9eBnoZOZA+IJv0+bwt13M9WLuno1sVtYH8G8T97d/mU/8SaN9bmAXISyYjYyn2fq0Mt2gtb/F5PXeivADePic9N89IrFaLWdQE+/YaZCSdVlMuPgr6T7sN5BoZyScH5szYBmoduU6nz16ujPuoXpo5MBvVqbcsYesbFEvgp4LW0upHvlilSqDkDK6qg3X+vVlSeuiLdDZJNcjfVzD4qGCBjBMNLQGt4m/5/zf9oFPyEm2SsdXL8q//ym5/f+Jd80bCf7UMr/qdQjP7e0/ubHo6sxwLV/9hZgLz+KL+JO846bsviEXjzrGs8X3CeTNsQzl1wmZkUA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=QBdb+kW5iV05hrZb/lptznudjEPinkMCBJurwkn3Z00=;\n\tb=LTmvqX8GqHEzx57X1SSJxyHQbFaHyrKpeLTjyZbt++1kjHh3ivpO4YcYIAZz95nxR8qBwnUDi7lAOegO5e28s9whxfJteprxrljdLklRqFx0uXumPi/AmAoST0biKUBGGj07EykAGbNhzgBTY59zGLY2vC/ncAVi5Hbbv6hM4U5V20qXfd3DdPXEAsTzjxH9uFMUyMaI8KHaf85u/TDVqZT3Wp55BKJ/NN1i1WVfXttKpTQUmYd2r1s+1NHn0I+XN/EeE8a7kfakub3F9PafoFsVmo5TDdkHXlP3Lj0piQwNb2A1gdTd3tLlvkU/6W5em4dm2OpvYgurEdCbas+5lg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n\tdkim=pass header.d=intel.com; arc=none","To":"Laurent Pinchart ","Thread-Topic":"[libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","Thread-Index":"AQHYgWE//6QkI2bzKU+Nd/p2Ip/2kK1TJ1+AgAAYkgCAAFmkEA==","Date":"Fri, 17 Jun 2022 13:30:07 +0000","Message-ID":"","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-reaction":"no-action","dlp-version":"11.6.500.17","authentication-results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"euVWwWdI\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=intel.com;"],"x-ms-publictraffictype":"Email","x-ms-office365-filtering-correlation-id":"953b8c2b-73f6-4ad0-081c-08da50657ea8","x-ms-traffictypediagnostic":"DM5PR11MB1324:EE_","x-microsoft-antispam-prvs":"","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;","x-microsoft-antispam-message-info":"MXkw45PpTuaXkxQCGFZvg7PAZPfdDDi5RjP6ZyqV5yJsF9/VIv+JIc7jf9mZu9Ixg0f9dBb/ejJ2r/4pGFQ+SEkDwNbzY+0i6Ceh0rd+DsgSDrZj2pGx7hSABUxGx5uvwYJ42kRXfHFKDHjmI6PDOK+fXbwablRTfqAJeOVssCdLe4MfrAYATJ6SDtWWg3j1sZp2feqBvON/TN55MeM/mY+AX51wOru2PBFwlIVDlpaAW9n2Vul9vP1BaPOBbLbetdm9DtdFdeFbxYZbf43uD1YOFWJLw5Uv0L1TKv4Z1oJHP0/WVvt8H2ZH8Fsz4nKtnoENdzGIfM4svW527NbuLQmd333aZSAagLUD1RzW5mOwnIQfrAUiypKMAjJYz8jhjZHANMOEbQ/17gFs6vV+1QtsrsXGA36zy18EEOX6LWOi+CklqDDWdeM5ossy547Mj7RQdYS8z2LboHS6vlpHovHF0C6a3p/QgTsBflFeSKbBMXo3M7z0HnLzQTdAAOD0FaPdJRHwoiB1sBXJx719UUP1KKd3kW1T/Tmtd/G68ilge4igEOd9QKliMLaUo0Dc1D/WFN5QJJ1Z1W979z3ZkZC1oy4Axrfy2xjodO3mw11G8hY9baUiMsrDNfDnL1wRpSXdE2F5oj/FRuV7dzweIwQ1I0YbCCck7JO8MW3JZorPG8xZ3HO6HQoXYIpI6L4jyFwGTdKbXQ6rdg1nVHR0A5drHkbe7gntzN2VmOW9gNv81r+4Ip0cyNm85cFbO8NMUaSeQrORAUJCLGgzH/5o4c+5ktL3coe7q68e+4YslmI=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230016)(366004)(6916009)(2906002)(186003)(54906003)(122000001)(38100700002)(55016003)(38070700005)(26005)(52536014)(83380400001)(82960400001)(316002)(66446008)(66556008)(66946007)(76116006)(8676002)(498600001)(7696005)(86362001)(4326008)(64756008)(66476007)(71200400001)(6506007)(9686003)(53546011)(33656002)(966005)(8936002)(5660300002);\n\tDIR:OUT; SFP:1102; ","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?TLj9qmTBSa5eF9MWKF8I3j9Tt?=\n\t=?utf-8?q?sX5zRWFGCnluMbrU/P1uJV/FTMpssmQvzg7TVZymdF4ev0lNZdQD96h+?=\n\t=?utf-8?q?V1HfTZYb1snuLtnADOp/iJrDR6WgLSjbdvXLQvX1Tr7GNL918e8TcTFp?=\n\t=?utf-8?q?FW/3pqTTIzi3QgEeOgl/HRAE/EzvIhhnhXOTYQshD8QlgpOIXw7TK3af?=\n\t=?utf-8?q?cuxo5Mmrjhxlu5kZMpla1wTRNnI4R2wmqVrwcHK/N8CqTTTMowUNLzyg?=\n\t=?utf-8?q?khv/HzUYAbLdSeUentfvoLrecILPQ0/CA+yv+s617DJlP/YCy1y6jSID?=\n\t=?utf-8?q?LGY+5pPwoyU9v4mAVE4KSSQmICOoOQhFxgLTlgiTX+cZ5M1Pv1W+RLyZ?=\n\t=?utf-8?q?8QSGIIsB6SvDa2Zw3iUlQmfK2UtleV1txjCYhtsKcx4prtvzJea2q9Cu?=\n\t=?utf-8?q?CoQHeqx8CcgHpUT4dM6fSs1dpBbwDqcwdsCzXVZqm642DFkynETH3HET?=\n\t=?utf-8?q?0fKeFACoAsPmhMFvH0xICOFYpwNnzslC4lOwZRpNbFyvUXxu4ur+J8iu?=\n\t=?utf-8?q?4r2m/dDgLei0pFiqPHwJpJPrYrNqPLto4Kfx/3gufRoFOqghqdMg3llO?=\n\t=?utf-8?q?+FHUTWjRBmLNwo77Tm6LfCk9ssafkM2tDwk3klWekIri8rSKtWIfQRex?=\n\t=?utf-8?q?i0QWkwJrcVIkUlF1Ukt2IxNkLUKcQknKFga8kaEJSKs8ZdzeC9rKyC5L?=\n\t=?utf-8?q?n9Zj9ctAihdUfWlPbO7fkAozl1H105iWm6TUjMQrQCSG2lkJ6IFoQJZ8?=\n\t=?utf-8?q?PoLdOLyfCTSfkMbUIZwOXfYKXgA2xb5FXSgNhJJ1zZjHGz5ZSlE/eUvd?=\n\t=?utf-8?q?nyuzyqhywDT1Q9dN42AkI+FUfAxxYlK924n6zWKl1OO+dtkeCVR8PXcO?=\n\t=?utf-8?q?ukrxEGwELZfUOTVormn5vFXgWuuR/nT3WkAS144hhvkNr49cgx7xmD5H?=\n\t=?utf-8?q?PZW0t7KQf7VybLI3cLbwglWSXKhK6EZCdp3iG5SXPWqu2v5SrqMbf0Wc?=\n\t=?utf-8?q?PMsDu5anaWLNlw//symwgcU5K5cvWkJnAfvGcZ5biXxuHDmDNEy89sZ5?=\n\t=?utf-8?q?cM+bc5memlMTWkb2Skp2arzi1PI8sFrZHz9aXkmhYBaj6vKhGmZAI92f?=\n\t=?utf-8?q?ZOUGZ5CXCbmi5plWKU40K5pBDk653DCCVk2STb5fG/aLMyAn7Yfh+6xN?=\n\t=?utf-8?q?vhd6T4P7ly++rc229zRzXWr+KdzCMiFTnjHlqNkPkHw5Dro5kc/5pfdt?=\n\t=?utf-8?q?tjSQHk4BV2R0Nv+45XYy2W7ZiZa1HB1VvhenuzN9L+7zuX+Bjs8OmvQ5?=\n\t=?utf-8?q?YI5C3afQMrdJdj6ji4KhXl2D8ylkqlO3KbQ6Mh5NbuXfCN3trCYwb77D?=\n\t=?utf-8?q?K/NVsxWp1ahvILq0pzuYNO30+7CABClqED7PQxNA9JYQNNmy3BLbXdPW?=\n\t=?utf-8?q?lBHffvkBa/RiBOxohLxieb2eMUJ4H7AO71R4A84Yh4Tjj9QbujofjDkA?=\n\t=?utf-8?q?vTXbrgjYoByafQelqwdT3UJnkwz8abNubXArg4JjMB6xHXE497qtknkx?=\n\t=?utf-8?q?9f61sr4XtZadTrI4y4Eyl8LWvrjL3+Xjy2wJFu+dwpdKV5DSPC+sEmSa?=\n\t=?utf-8?q?t8/fHyTWr9Ocy0KRMuPpP9Wl60V5UuHD3aGtM3F//SnT5PRfgPR50YuA?=\n\t=?utf-8?q?zUcDATaNIEoGGJomzGhBYvdM1YJy69eDl0atSm0UNWN+yJJTDHZA5GQL?=\n\t=?utf-8?q?bUpcQ/6blLMImmmuFz5igNbuVc2z29cy5oDx9oZOP3dZVfis5OoAYCyp?=\n\t=?utf-8?q?FZ+vW7Ht6vfpL1We7/HUrIPPbBSxXcw/hNSBYftyLqRQA=3D=3D?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"DM8PR11MB5653.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"953b8c2b-73f6-4ad0-081c-08da50657ea8","X-MS-Exchange-CrossTenant-originalarrivaltime":"17 Jun 2022 13:30:07.3050\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"J0VCO3KsXM6HsY4z+0anFfN9BCTVtxiDKFkbZme+YksmPxLU4O9sy0lKij3wOEjtiqv2cIIH4OLfMjfy+x1SgA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM5PR11MB1324","X-OriginatorOrg":"intel.com","Subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"\"Cao, Bingbu via libcamera-devel\" ","Reply-To":"\"Cao, Bingbu\" ","Cc":"\"libcamera-devel@lists.libcamera.org\"\n\t,\n\t\"sakari.ailus@linux.intel.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23458,"web_url":"https://patchwork.libcamera.org/comment/23458/","msgid":"<5ea3b9e2-29cc-d185-9e51-ccb0438afe1d@ideasonboard.com>","date":"2022-06-17T14:39:37","subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Thank you.\nFYI, I tested the patch I sent with this fixed [1], and I obtain [2] \nwhile it is [3] on master.\n\n[1]: https://patchwork.libcamera.org/patch/16256/\n[2]: https://pasteboard.co/sPXz45GjbpAg.png\n[3]: https://pasteboard.co/DLfD69BzsFuu.png\n\nWaiting for your confirmation ;-).\nJM\n\nOn 17/06/2022 15:30, Cao, Bingbu via libcamera-devel wrote:\n> Laurent and JM,\n> \n> Give me some time, let me confirm with our algo team.\n> \n> ________________________\n> BRs,\n> Bingbu Cao\n> \n>> -----Original Message-----\n>> From: Laurent Pinchart \n>> Sent: Friday, June 17, 2022 4:08 PM\n>> To: Cao, Bingbu \n>> Cc: Jean-Michel Hautbois ;\n>> libcamera-devel@lists.libcamera.org; sakari.ailus@linux.intel.com\n>> Subject: Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction\n>>\n>> Hi Bingbu,\n>>\n>> Thank you very much for your quick reply.\n>>\n>> On Fri, Jun 17, 2022 at 06:58:36AM +0000, Cao, Bingbu via libcamera-devel\n>> wrote:\n>>> Hi, JM,\n>>>\n>>> For BNR parameters WB gain factor for the three channels [Ggr, Ggb, Gb,\n>> Gr].\n>>> Their precision is U3.13 and the range is (0, 8) and the actual gain\n>>> is Gx + 1, it is typically Gx = 1.\n>>>\n>>> Pout = {Pin * (1 + Gx)}.\n>>>\n>>> So that means for wb_gains.Ggr/gb/g/r = 0.5, the actual gain is 1.5.\n>>\n>> Just to make sure my understanding is correct, does this mean the\n>> following ?\n>>\n>> wb_gains.gr = 0 -> actual gain = 1.0\n>> wb_gains.gr = 4096 -> actual gain = 1.5\n>> wb_gains.gr = 8192 -> actual gain = 2.0\n>>\n>>> It seems not correct to changing ratio from 8192 to 4096 as its\n>>> precision is U3.13. I am not familiar with ipa implementation in\n>>> libcamera, not sure other details.\n>>>\n>>>> -----Original Message-----\n>>>> From: Jean-Michel Hautbois \n>>>> Sent: Thursday, June 16, 2022 5:12 PM\n>>>> To: libcamera-devel@lists.libcamera.org\n>>>> Cc: Cao, Bingbu ;\n>>>> sakari.ailus@linux.intel.com; Jean-Michel Hautbois\n>>>> \n>>>> Subject: [RFC PATCH 0/1] IPU3 AWB gains correction\n>>>>\n>>>> Hi there,\n>>>>\n>>>> Bingbu, Sakari, I cc'ed you because this patch is not aligned with\n>>>> the current documentation in the intel-ipu3.h file, could you have a\n>>>> look please ?\n>>>>\n>>>> The part which worries me is that the green gains should be 0 for\n>>>> the white balance to be correct which is not stated in the\n>>>> documentation at all.\n>>>>\n>>>> In order to demonstrate it I captured two frames, [1] is the actual\n>>>> SGo2 image quality, and [2] with this patch applied.\n>>>>\n>>>> [1]: https://pasteboard.co/hUcL4U6eyyAH.png\n>>>> [2]: https://pasteboard.co/2XIbkkL8kitl.png\n>>>>\n>>>> There is a very clear benefit, that's why I submit this RFC as I\n>>>> think it needs to be clarified :-).\n>>>>\n>>>> Thanks !\n>>>> JM\n>>>>\n>>>> Jean-Michel Hautbois (1):\n>>>> ipa: ipu3: awb: Correct the coefficient factor\n>>>>\n>>>> src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n>>>> 1 file changed, 4 insertions(+), 4 deletions(-)\n>>\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1561BD161\n\tfor ;\n\tFri, 17 Jun 2022 14:39:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B27B65632;\n\tFri, 17 Jun 2022 16:39:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C1B265632\n\tfor ;\n\tFri, 17 Jun 2022 16:39:41 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:cd44:4ab6:6ad5:9e60] (unknown\n\t[IPv6:2a01:e0a:169:7140:cd44:4ab6:6ad5:9e60])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9880B2A5;\n\tFri, 17 Jun 2022 16:39:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655476783;\n\tbh=HUzwkzOtJEIZPTMjopMjG3Y/hqdymtbfKGjd+CHdDzs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2/r9nrZUxIfbBU/V1v3+Ab6C1SVnijaInBA02wyFamgBS4yPatSNG3r8Aj2fToK1D\n\tWQC1pzDHApOjrJdR5hliHQchGmjNS4oZNmE3h/uHFt8AvWS4dB2vuukhmsXSHIxWRF\n\t3jpzRUUitt4tuD+9T8T9we16FKfeAH+mmbHZaS9vwRbpR5wrQhtJU8KLtZuuxuBvfJ\n\tkoHQ9R5s3k8S6PwahtGLKC4cEzMud3arS3tXLdT2tb5SxK0vYZpeA2DMNbxsmOoKlN\n\tzcopphks1OiOuLKNSHaW9r/znOTIIvV+l75ZG/ut7ZGpGCJMaEgCVNi5gQXjSWop7T\n\tRlp4/ceiEd/lw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655476780;\n\tbh=HUzwkzOtJEIZPTMjopMjG3Y/hqdymtbfKGjd+CHdDzs=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=rUyaR84xLon5/8QgRELtVkxr/wugWCB3uWJs2lzRCPWLQQzT+HCV1PTlsZHRWf1h9\n\tfbRPpPsRJN1bs7C62dNe809mWKi8kCBkEvBAdbF6OgRT4teY80c/1kuyvQihAfcS4n\n\tZLiHEHvT15m+yzdePqPpmj3Ij8k0PTYwhgA4KbpM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rUyaR84x\"; dkim-atps=neutral","Message-ID":"<5ea3b9e2-29cc-d185-9e51-ccb0438afe1d@ideasonboard.com>","Date":"Fri, 17 Jun 2022 16:39:37 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.9.1","Content-Language":"en-US","To":"\"Cao, Bingbu\" ,\n\tLaurent Pinchart ","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Cc":"\"libcamera-devel@lists.libcamera.org\"\n\t,\n\t\"sakari.ailus@linux.intel.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23484,"web_url":"https://patchwork.libcamera.org/comment/23484/","msgid":"","date":"2022-06-20T12:03:52","subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"JM and Laurent,\n\nI get some pseudo code from Algo which to calculate the gain\nsettings from awb results, I hope it can help you.\n\n--------------------------------------------------------\n\ninline int Real2fix(unsigned N, double x)\n{\n return static_cast(x * (1< 0 ? 0.5 : -0.5));\n}\n\nfinal_b_per_g=awb_results->final_b_per_g;\nfinal_r_per_g=awb_results->final_r_per_g;\n\nfloat max_ratio = MAX(MAX(final_b_per_g, final_r_per_g), \n\t\t\t1.0f);\n\nwb_gains->r = static_cast(\n\tClamp(Real2fix<13>(\n\tmax_ratio / final_r_per_g - 1)));\n\nwb_gains->b = static_cast(\n\tClamp(Real2fix<13>(\n\tmax_ratio / final_b_per_g - 1)));\n\nwb_gains->gr = wb_gains->gb = static_cast(\n\tClamp(Real2fix<13>(\n\tmax_ratio - 1)));\n\n--------------------------------------------------------\nBTW, I checked the 2nd picture, it is better than 3, but it is a\nlittle pinkish.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D847EBD808\n\tfor ;\n\tMon, 20 Jun 2022 12:04:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A594D65635;\n\tMon, 20 Jun 2022 14:04:01 +0200 (CEST)","from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30B6F60498\n\tfor ;\n\tMon, 20 Jun 2022 14:03:57 +0200 (CEST)","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t20 Jun 2022 05:03:55 -0700","from fmsmsx606.amr.corp.intel.com ([10.18.126.86])\n\tby fmsmga002.fm.intel.com with ESMTP; 20 Jun 2022 05:03:54 -0700","from fmsmsx610.amr.corp.intel.com (10.18.126.90) by\n\tfmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27; Mon, 20 Jun 2022 05:03:54 -0700","from fmsmsx603.amr.corp.intel.com (10.18.126.83) by\n\tfmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27; Mon, 20 Jun 2022 05:03:54 -0700","from fmsedg601.ED.cps.intel.com (10.1.192.135) by\n\tfmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27 via Frontend Transport; Mon, 20 Jun 2022 05:03:54 -0700","from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177)\n\tby edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.1.2308.27; Mon, 20 Jun 2022 05:03:53 -0700","from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by\n\tSA0PR11MB4687.namprd11.prod.outlook.com (2603:10b6:806:96::16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.5353.14; Mon, 20 Jun 2022 12:03:52 +0000","from DM8PR11MB5653.namprd11.prod.outlook.com\n\t([fe80::81de:d29e:a239:f5c]) by\n\tDM8PR11MB5653.namprd11.prod.outlook.com\n\t([fe80::81de:d29e:a239:f5c%7]) with mapi id 15.20.5353.021;\n\tMon, 20 Jun 2022 12:03:52 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655726641;\n\tbh=+8BQuhaN21Sr2rw5DcqfQYbR6TA/zRxMvmIjZRJqqtI=;\n\th=To:Date:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=k5PddCnYhpfvpAP1c4EI6so6L+5dDYbIfTsfczxMmEackAfvYLnolDqoar7XDHoB2\n\t0fhVEUbHMsAbODjuqjXZS9iCg3AOSnfGHqoN+eT9g39goHQBma1VJ+AoyrYPTlkrxY\n\thQijzWMjUyQKqL57Lf2PKd5kW6EVkGdO3zgzksSTC3iQmG9PTVH5itMjFCvxnS6dVY\n\tc2+tj3uEZHC0gaTvmBakxMUwXmNAB9LBMGiXam7GTdYREdJS/tfCnbQ4OsOTK5U0xF\n\tLHqrnWfE7tYDr4rxTxEoljXacoJ0zgfCjtXDqb3GnxCZ+UXfBbM3SXf8uCZSsmsTXX\n\teOGFBaz93zTFA==","v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1655726638; x=1687262638;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=+8BQuhaN21Sr2rw5DcqfQYbR6TA/zRxMvmIjZRJqqtI=;\n\tb=U7RXWgHMKiGoLMacOh1iSgpq4hwuKfU5AopGhGRmeC+T1b1xQbFv8u0K\n\tZILJZkIvsPplf1zoOF0yTPAPTk+QrlbWSNHMrv6llztdlAAWGAiRie8l5\n\tvfnjyKTNIfwTR6JaxwO2bp0+9BJSOuVVwOtWcPp9dSpWW1pRSahODyEPs\n\tWYc5c6+4voNFROchVvpAT49Wnkg5jCrm+7Z6V4+T5yBGdAAQxPLyU2W0A\n\tED6fwXMtOO7ngQWEygjrLdl2KW4T6M/OMF4ig1xqV4P2oKNQ/EQefMA6R\n\tZIcxYy+XDlQ3pNhW69MaIFMuL4q0bRlIsEmpMmm5XvVoz5s1xtAIpG+Pw g==;"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"U7RXWgHM\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=intel.com;"],"X-IronPort-AV":["E=McAfee;i=\"6400,9594,10380\"; a=\"280933888\"","E=Sophos;i=\"5.92,306,1650956400\"; d=\"scan'208\";a=\"280933888\"","E=Sophos;i=\"5.92,306,1650956400\"; d=\"scan'208\";a=\"689428754\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=d1SJpFj+tL+xhQNdD9uDL8qA91NSRYeAzrogD5nxjojTVrP99c3knH9RWNXewgk55AaZwfPKQbhvfXD+TgHptAGXiFrfzA53QHTFcCDDky2Wfi/WYcx3LqN1FrZNas6TTkT3+dvB3OabM7Usx3HgRKWbZZuCdtW81KiBkqbE/Njqg+r51KDOAlvuShIu0qLj+TL80OCQNpqZ8x9nNXLmHBTdvSh/a4Uft/aLYXsuZNy5jh8d5JCgu0Gg1BTUTCuYZxo1kdKKZgQglxjRuRs9o19CAbySCQqioU+dNjiz6JK6bjE8gG5H9QX6KHwPCZ41mOBzbU2S6EX2uj0LdDYP9w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=+8BQuhaN21Sr2rw5DcqfQYbR6TA/zRxMvmIjZRJqqtI=;\n\tb=N7EqOEZ8uapkp1omExaFAjJRtjK5XyVaMhJQt37zI2XV13LE1maniyCjyzLunN5ag2P6X44eaIF24raY+Jknh9Kfz2KRt0hmDSc6IZi4Smizv+wDOL7yoRLdclunsru2dMiOKLvu9DKAp9L4CKHMrcCOn/xQ51xqEKFtB6y94PWHRKRIIWQ8SoQ1G/56C9H6ntj42WR8+7XvwyczG+lk7nalBX8xV6YpJkX/ysDoTlLft65Fzi0PmrX7mWe3X2c51AHlxlDsqqonxibCSd/U6EpwHJWHJPM9s+3aidBiC1RcVbFTbsUg2dXLu7nK14J+oDzYgMb0kaJfmX6wA9t86Q==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n\tdkim=pass header.d=intel.com; arc=none","To":"Jean-Michel Hautbois , \"Laurent\n\tPinchart\" ","Thread-Topic":"[libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","Thread-Index":"AQHYgWE//6QkI2bzKU+Nd/p2Ip/2kK1TJ1+AgAAYkgCAAFmkEIAAE8uAgASH57A=","Date":"Mon, 20 Jun 2022 12:03:52 +0000","Message-ID":"","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t\n\t\n\t<5ea3b9e2-29cc-d185-9e51-ccb0438afe1d@ideasonboard.com>","In-Reply-To":"<5ea3b9e2-29cc-d185-9e51-ccb0438afe1d@ideasonboard.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-reaction":"no-action","dlp-version":"11.6.500.17","authentication-results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"U7RXWgHM\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=intel.com;"],"x-ms-publictraffictype":"Email","x-ms-office365-filtering-correlation-id":"22c3fbb0-b771-4e7d-c650-08da52b4f13b","x-ms-traffictypediagnostic":"SA0PR11MB4687:EE_","x-microsoft-antispam-prvs":"","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;","x-microsoft-antispam-message-info":"9mNZQZC0YnP9LRTcEk/V9az6e/qPvPhQ5hT/jMog7ncdvXXQTedGINrKvkX2bYwfC/K0P7SI8ZXTEnWm+uXN3U//PPlmdHC5g1M1V6Xu0tW7Nf389sPeuC271EyUsx+fFUS8SJ92yj83LTlQsH5eybSOOmvFfOS+YOOIJrS6GdluKxCKtJPpbTA+6g5XhF6uN1NuJlD3CsareTcK4XVtmOVhpZ2l9SfcpduVpvXlB2i8YaQxZ0DHNl2yXX9NyOzBCXn6e3THk1Mi5UnQMGJ9XrmD++K0LLZDrAyaKQ63GQ2nvFDYAcY2kl6IA7uWgORjhpLqqlikPtAITn6Oe5LoB9kKnxKpG3D5o1NSP0QcT2jJA5ibdXyN79aUnfCwvb619GJ0BIwtCvgiAdZ9O5Pm0wGMDUQizB/8gzoc9AIXghV/NmYOWHo+T/zKpalR7BvyH3o360r4d86Ab0EhXVptFbCAKJ/W/3avOzgGEl7n8vqQcA5drfN53PDe1gwJmTcL8h1PMqIJz59Fs09F9RbWnllTPlMHrv0SlpD5bxYsrL6N6vtA4DnZJ/iYhOKyGWVuU0MsXfDGIk/a2kIXRFMbYynNohWQ2l9BqfpKsSxrU1dyJQ/lkDJdQTtW3SIpnS0QFhYLrLOBPlA1Ezm8IqXXZq7hNyLmCfF83q/s8I+oALR8UNR54XExrRKVvHEIq4a92iQ1/N0co+KVvoKbC2i/rjL0KkwUnUSs+T5w5X4uow5+npLBly03OL1+zXxcM4Rgr0tM+XxAuLCG8fa6L00Mv1gSuF2PTTbtr7e5O2hLp+8=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230016)(366004)(7696005)(186003)(86362001)(83380400001)(82960400001)(122000001)(38070700005)(6506007)(38100700002)(66476007)(55016003)(53546011)(9686003)(33656002)(8936002)(71200400001)(966005)(498600001)(2906002)(316002)(110136005)(26005)(66446008)(64756008)(66556008)(5660300002)(54906003)(4326008)(52536014)(8676002)(66946007)(76116006);\n\tDIR:OUT; SFP:1102; ","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?BRKzc4AYupfDiB5eYQm7oIGJk?=\n\t=?utf-8?q?O6MnVGkTceBz5lyf9ZENw26ccrSzX519nUsC4x+gvxxoHt276FjkH6E7?=\n\t=?utf-8?q?oiWtFe1OdNPPDIuPjfDM4Mzj16m75vVS3hchfRJbO1CPs5IITI42VKLa?=\n\t=?utf-8?q?SnoOXjyBBiJsoDgqcKO18HzuePEAfmsLc/ZEIwooZk0Vx6Z05Zx7jpVc?=\n\t=?utf-8?q?2trU4f5KuN4vBp7603S7hPjOiyFoK3pTaH5o7M1zig06qSX9T3Vw3X3N?=\n\t=?utf-8?q?nKwIwhKCf4kB7ICM6V7QC3LhRohebGKuP18czIpfh2otv6R4+LnndeR3?=\n\t=?utf-8?q?JmmxSHfn9SCaHxUmUdFkKXNI9XuLhuIFtcFgUnM1YY6wz8o3qEv8INrn?=\n\t=?utf-8?q?S2dXkR8iSns2aQjYrFeb8Ug6eXoYeYWM35BJAgwNhcDDTTfqkl47nOu8?=\n\t=?utf-8?q?zOQXkYxSwf0ftf9e6zA90JMG2ulgJmlh42Ek0p49muGZA6RO4sxQp1d3?=\n\t=?utf-8?q?MyQDjwsiau9bUcam9uekjmgmLYryao23SpsYmiaYtwRmH5yCayEp5g9U?=\n\t=?utf-8?q?mCcXXYe3pEfDr579w0Z2vff7LehubpcInPJEFthISpay36lw/KmBfOAq?=\n\t=?utf-8?q?zYGcPvcWkGtYX9scMUlTW0l8ZXnS763bjYuOYOnP9+6wiA0Bnlt18GqC?=\n\t=?utf-8?q?OgGKxSUJruFdabhFX6Vw9pn5aPjGTJQNQZyX4LIky3WzIT9zma3RpzOr?=\n\t=?utf-8?q?b2YEJzNFOh9ElUYOwFwdGDRIZZPDZaey+ABI2iucCZgvK9WfvDzaofuS?=\n\t=?utf-8?q?i9o2t9gSlH9tXqqeZi98nZo8fDHhHjVPyPcI50kZ+UL5h03FhPhX7QLw?=\n\t=?utf-8?q?fcQuT6vW0gnL5TLUKJjW4hMPsPPKVcB7f+TBcRYRBtAMIpil69JO80rX?=\n\t=?utf-8?q?gji35GaWhhRpMuNfMDpWSZuGklGek7vGOHS0BsKCmZxEnjMsQk7b75nk?=\n\t=?utf-8?q?F4EzYAJDd4TZbnBdWl4ArNNbgDwbgs57TqD3nV2o82qF1zj0+OSj2uaa?=\n\t=?utf-8?q?17zwg//u8JyFH832p7Sb+ZM+2RQ++cjNBigg8sQWdXHu5FyHwP1GiPiu?=\n\t=?utf-8?q?DK2bWFpScaTlE+BkczQf9sd6gRVYm/vapPltIjgke2lVr7MURrkhAtH5?=\n\t=?utf-8?q?MCvtvbi0VxQogdkaIevSZE+mYThpY1zBweXwPKNar12iL6VDF3fz0pOq?=\n\t=?utf-8?q?f3RiQqTNLIhwL9Au3oWbV3VKtp1RFeiL/BPSzYdEWfTHlvadQSDx7z1I?=\n\t=?utf-8?q?RUrF3Y5ojE1JgR3t06opq9aLEPB6tCJU0JVSE2bxKCVK8OIoQ16PRrl+?=\n\t=?utf-8?q?kn1AdQ7No0avF6LLDjVN+Q2QhMTizWCGEh6A1zU0wOSHMHCBXIbtLVg9?=\n\t=?utf-8?q?N1raoOgSNnqQcP558wSckMa/CGHrk3E1ExCso+oFsewwyK2LubZhSKUb?=\n\t=?utf-8?q?VrfZ6zNV8fzkrhmePwV/akfjMVUKWczZkOv7zveyp/sAlerhvjoj+XOP?=\n\t=?utf-8?q?fGSemW/uAw7gRwPWh3wwvHZwToz8eDy8RjveVTgn8BwApZV/eYwhx0Ej?=\n\t=?utf-8?q?onv/LZyLYCbdVHRSG+t7gbCKKOZGBIZQyVj2khVcUvduNqQEncNbQKep?=\n\t=?utf-8?q?ZXLDPvucVYi2Y8oIoE82486dxBn66bpn5JKyMyHBiP2elujr21OoDV9m?=\n\t=?utf-8?q?biHivg/K14xXOakYIRiXT8VYoKSFLJsh+JXLK6ehhv4NIeX/5VQ0Ekkp?=\n\t=?utf-8?q?xV+nWk4e3rK1OtJ237CaPVfxw7JzHwnHoU9iJxF97obJt41C6xXbRsvv?=\n\t=?utf-8?q?WxlG6+M9mECGosol/4dUvA7qte0IdlDoYbBVrG0Bo13jA=3D=3D?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"DM8PR11MB5653.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"22c3fbb0-b771-4e7d-c650-08da52b4f13b","X-MS-Exchange-CrossTenant-originalarrivaltime":"20 Jun 2022 12:03:52.0851\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"j4ZrAObaKF9YTRPNgu3m76+6eE7zf2YGOEU+XSThWxLwx5AIFnqWXfVdjgXlv71BhbL4Yh3V0l7nYaQp+Yw/yQ==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SA0PR11MB4687","X-OriginatorOrg":"intel.com","Subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"\"Cao, Bingbu via libcamera-devel\" ","Reply-To":"\"Cao, Bingbu\" ","Cc":"\"libcamera-devel@lists.libcamera.org\"\n\t,\n\t\"sakari.ailus@linux.intel.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23491,"web_url":"https://patchwork.libcamera.org/comment/23491/","msgid":"","date":"2022-06-20T12:25:52","subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Bingbu,\n\nOn Mon, Jun 20, 2022 at 12:03:52PM +0000, Cao, Bingbu wrote:\n> JM and Laurent,\n> \n> I get some pseudo code from Algo which to calculate the gain\n> settings from awb results, I hope it can help you.\n> \n> --------------------------------------------------------\n> \n> inline int Real2fix(unsigned N, double x)\n\nI suppose this was meant to be\n\ntemplate\ninline int Real2fix(double x)\n\nbased on how it's called below.\n\n> {\n> return static_cast(x * (1< \t\t(x > 0 ? 0.5 : -0.5));\n> }\n> \n> final_b_per_g=awb_results->final_b_per_g;\n> final_r_per_g=awb_results->final_r_per_g;\n> \n> float max_ratio = MAX(MAX(final_b_per_g, final_r_per_g), \n> \t\t\t1.0f);\n> \n> wb_gains->r = static_cast(\n> \tClamp(Real2fix<13>(\n> \tmax_ratio / final_r_per_g - 1)));\n> \n> wb_gains->b = static_cast(\n> \tClamp(Real2fix<13>(\n> \tmax_ratio / final_b_per_g - 1)));\n> \n> wb_gains->gr = wb_gains->gb = static_cast(\n> \tClamp(Real2fix<13>(\n> \tmax_ratio - 1)));\n\nThank you, that clarifies it.\n\n> --------------------------------------------------------\n> BTW, I checked the 2nd picture, it is better than 3, but it is a\n> little pinkish.\n\nYes, further improvements are needed. The image is also a bit too dark\nnow. Still, it's much better than before :-)\n\n> > -----Original Message-----\n> > From: Jean-Michel Hautbois \n> > Sent: Friday, June 17, 2022 10:40 PM\n> > To: Cao, Bingbu ; Laurent Pinchart\n> > \n> > Cc: libcamera-devel@lists.libcamera.org; sakari.ailus@linux.intel.com\n> > Subject: Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction\n> > \n> > Thank you.\n> > FYI, I tested the patch I sent with this fixed [1], and I obtain [2]\n> > while it is [3] on master.\n> > \n> > [1]: https://patchwork.libcamera.org/patch/16256/\n> > [2]: https://pasteboard.co/sPXz45GjbpAg.png\n> > [3]: https://pasteboard.co/DLfD69BzsFuu.png\n> > \n> > Waiting for your confirmation ;-).\n> > JM\n> > \n> > On 17/06/2022 15:30, Cao, Bingbu via libcamera-devel wrote:\n> > > Laurent and JM,\n> > >\n> > > Give me some time, let me confirm with our algo team.\n> > >\n> > > ________________________\n> > > BRs,\n> > > Bingbu Cao\n> > >\n> > >> -----Original Message-----\n> > >> From: Laurent Pinchart \n> > >> Sent: Friday, June 17, 2022 4:08 PM\n> > >> To: Cao, Bingbu \n> > >> Cc: Jean-Michel Hautbois ;\n> > >> libcamera-devel@lists.libcamera.org; sakari.ailus@linux.intel.com\n> > >> Subject: Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains\n> > >> correction\n> > >>\n> > >> Hi Bingbu,\n> > >>\n> > >> Thank you very much for your quick reply.\n> > >>\n> > >> On Fri, Jun 17, 2022 at 06:58:36AM +0000, Cao, Bingbu via libcamera-devel wrote:\n> > >>> Hi, JM,\n> > >>>\n> > >>> For BNR parameters WB gain factor for the three channels [Ggr, Ggb, Gb, Gr].\n> > >>> Their precision is U3.13 and the range is (0, 8) and the actual gain\n> > >>> is Gx + 1, it is typically Gx = 1.\n> > >>>\n> > >>> Pout = {Pin * (1 + Gx)}.\n> > >>>\n> > >>> So that means for wb_gains.Ggr/gb/g/r = 0.5, the actual gain is 1.5.\n> > >>\n> > >> Just to make sure my understanding is correct, does this mean the\n> > >> following ?\n> > >>\n> > >> wb_gains.gr = 0 -> actual gain = 1.0\n> > >> wb_gains.gr = 4096 -> actual gain = 1.5 wb_gains.gr = 8192 -> actual\n> > >> gain = 2.0\n> > >>\n> > >>> It seems not correct to changing ratio from 8192 to 4096 as its\n> > >>> precision is U3.13. I am not familiar with ipa implementation in\n> > >>> libcamera, not sure other details.\n> > >>>\n> > >>>> -----Original Message-----\n> > >>>> From: Jean-Michel Hautbois \n> > >>>> Sent: Thursday, June 16, 2022 5:12 PM\n> > >>>> To: libcamera-devel@lists.libcamera.org\n> > >>>> Cc: Cao, Bingbu ;\n> > >>>> sakari.ailus@linux.intel.com; Jean-Michel Hautbois\n> > >>>> \n> > >>>> Subject: [RFC PATCH 0/1] IPU3 AWB gains correction\n> > >>>>\n> > >>>> Hi there,\n> > >>>>\n> > >>>> Bingbu, Sakari, I cc'ed you because this patch is not aligned with\n> > >>>> the current documentation in the intel-ipu3.h file, could you have\n> > >>>> a look please ?\n> > >>>>\n> > >>>> The part which worries me is that the green gains should be 0 for\n> > >>>> the white balance to be correct which is not stated in the\n> > >>>> documentation at all.\n> > >>>>\n> > >>>> In order to demonstrate it I captured two frames, [1] is the actual\n> > >>>> SGo2 image quality, and [2] with this patch applied.\n> > >>>>\n> > >>>> [1]: https://pasteboard.co/hUcL4U6eyyAH.png\n> > >>>> [2]: https://pasteboard.co/2XIbkkL8kitl.png\n> > >>>>\n> > >>>> There is a very clear benefit, that's why I submit this RFC as I\n> > >>>> think it needs to be clarified :-).\n> > >>>>\n> > >>>> Thanks !\n> > >>>> JM\n> > >>>>\n> > >>>> Jean-Michel Hautbois (1):\n> > >>>> ipa: ipu3: awb: Correct the coefficient factor\n> > >>>>\n> > >>>> src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n> > >>>> 1 file changed, 4 insertions(+), 4 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DF61BD808\n\tfor ;\n\tMon, 20 Jun 2022 12:26:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2953F65638;\n\tMon, 20 Jun 2022 14:26:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 824F965632\n\tfor ;\n\tMon, 20 Jun 2022 14:26:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 068D025B;\n\tMon, 20 Jun 2022 14:26:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655727969;\n\tbh=1sB9pQJr+lQOX4/IPYCZyl1WLzfsU6xjATtSk2Y8+b0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Qq5gBrekuBPtShSjZMrVc0cInE9hfsHeEoPspYuEhVthb+ow5A9xquyLSAliKiE8L\n\tUaAPKlEdxx3s3j/oWfcHc//iM7MJzEUylXQY6Tm4FbIzHdobCrwSHkvv73VuQh0JbC\n\tgSgzZzs9Whd6xoPuakz3MRfnLXbUN88stUEwzYjYtAFAuPRbbNQaYf9WNBw4rnZRQF\n\t9psO6ojEytFcYIFFcOCfnmW0xWAqr3k+2ObIFE5EzcP6EPBvhHuNz3YHYVAY0UZTyo\n\tjet1KBR1p5OPX1CLMXw3J7FtHd96uaEfaIj41tJG/z1y++V2NfCImxty7Yq7v5E9PI\n\tx3DjM2qJYmfEQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655727968;\n\tbh=1sB9pQJr+lQOX4/IPYCZyl1WLzfsU6xjATtSk2Y8+b0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l4B8sCxvqGJpkNDCAXAZpivauEnNhptG1JZEAO4/yxjO87uJlmuOKWxsKuWYlLWgg\n\t3ouJ276sqjhLAnzpsVuGMEVWQcl62UUHG0lTOuFUAx6Hz5yqZryuQnx1bamrnavjp0\n\tQgwy8kQRWOhFQSMOh2hQ09vTIgUd0EOhhUFCzfa0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"l4B8sCxv\"; dkim-atps=neutral","Date":"Mon, 20 Jun 2022 15:25:52 +0300","To":"\"Cao, Bingbu\" ","Message-ID":"","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t\n\t\n\t<5ea3b9e2-29cc-d185-9e51-ccb0438afe1d@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"\"libcamera-devel@lists.libcamera.org\"\n\t,\n\t\"sakari.ailus@linux.intel.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23498,"web_url":"https://patchwork.libcamera.org/comment/23498/","msgid":"","date":"2022-06-21T03:03:49","subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Laurent,\n\n> -----Original Message-----\n> From: Laurent Pinchart \n> Sent: Monday, June 20, 2022 8:26 PM\n> To: Cao, Bingbu \n> Cc: Jean-Michel Hautbois ;\n> libcamera-devel@lists.libcamera.org; sakari.ailus@linux.intel.com\n> Subject: Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction\n> \n> Hi Bingbu,\n> \n> On Mon, Jun 20, 2022 at 12:03:52PM +0000, Cao, Bingbu wrote:\n> > JM and Laurent,\n> >\n> > I get some pseudo code from Algo which to calculate the gain settings\n> > from awb results, I hope it can help you.\n> >\n> > --------------------------------------------------------\n> >\n> > inline int Real2fix(unsigned N, double x)\n> \n> I suppose this was meant to be\n> \n> template\n> inline int Real2fix(double x)\n> \n> based on how it's called below.\n\nYes, you are right, my bad.\n\n> \n> > {\n> > return static_cast(x * (1< > \t\t(x > 0 ? 0.5 : -0.5));\n> > }\n> >\n> > final_b_per_g=awb_results->final_b_per_g;\n> > final_r_per_g=awb_results->final_r_per_g;\n> >\n> > float max_ratio = MAX(MAX(final_b_per_g, final_r_per_g),\n> > \t\t\t1.0f);\n> >\n> > wb_gains->r = static_cast(\n> > \tClamp(Real2fix<13>(\n> > \tmax_ratio / final_r_per_g - 1)));\n> >\n> > wb_gains->b = static_cast(\n> > \tClamp(Real2fix<13>(\n> > \tmax_ratio / final_b_per_g - 1)));\n> >\n> > wb_gains->gr = wb_gains->gb = static_cast(\n> > \tClamp(Real2fix<13>(\n> > \tmax_ratio - 1)));\n> \n> Thank you, that clarifies it.\n\nGlad to see it can help you. 😊\n\n> \n> > --------------------------------------------------------\n> > BTW, I checked the 2nd picture, it is better than 3, but it is a\n> > little pinkish.\n> \n> Yes, further improvements are needed. The image is also a bit too dark\n> now. Still, it's much better than before :-)\n> \n> > > -----Original Message-----\n> > > From: Jean-Michel Hautbois \n> > > Sent: Friday, June 17, 2022 10:40 PM\n> > > To: Cao, Bingbu ; Laurent Pinchart\n> > > \n> > > Cc: libcamera-devel@lists.libcamera.org;\n> > > sakari.ailus@linux.intel.com\n> > > Subject: Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains\n> > > correction\n> > >\n> > > Thank you.\n> > > FYI, I tested the patch I sent with this fixed [1], and I obtain [2]\n> > > while it is [3] on master.\n> > >\n> > > [1]: https://patchwork.libcamera.org/patch/16256/\n> > > [2]: https://pasteboard.co/sPXz45GjbpAg.png\n> > > [3]: https://pasteboard.co/DLfD69BzsFuu.png\n> > >\n> > > Waiting for your confirmation ;-).\n> > > JM\n> > >\n> > > On 17/06/2022 15:30, Cao, Bingbu via libcamera-devel wrote:\n> > > > Laurent and JM,\n> > > >\n> > > > Give me some time, let me confirm with our algo team.\n> > > >\n> > > > ________________________\n> > > > BRs,\n> > > > Bingbu Cao\n> > > >\n> > > >> -----Original Message-----\n> > > >> From: Laurent Pinchart \n> > > >> Sent: Friday, June 17, 2022 4:08 PM\n> > > >> To: Cao, Bingbu \n> > > >> Cc: Jean-Michel Hautbois ;\n> > > >> libcamera-devel@lists.libcamera.org; sakari.ailus@linux.intel.com\n> > > >> Subject: Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains\n> > > >> correction\n> > > >>\n> > > >> Hi Bingbu,\n> > > >>\n> > > >> Thank you very much for your quick reply.\n> > > >>\n> > > >> On Fri, Jun 17, 2022 at 06:58:36AM +0000, Cao, Bingbu via\n> libcamera-devel wrote:\n> > > >>> Hi, JM,\n> > > >>>\n> > > >>> For BNR parameters WB gain factor for the three channels [Ggr,\n> Ggb, Gb, Gr].\n> > > >>> Their precision is U3.13 and the range is (0, 8) and the actual\n> > > >>> gain is Gx + 1, it is typically Gx = 1.\n> > > >>>\n> > > >>> Pout = {Pin * (1 + Gx)}.\n> > > >>>\n> > > >>> So that means for wb_gains.Ggr/gb/g/r = 0.5, the actual gain is\n> 1.5.\n> > > >>\n> > > >> Just to make sure my understanding is correct, does this mean the\n> > > >> following ?\n> > > >>\n> > > >> wb_gains.gr = 0 -> actual gain = 1.0\n> > > >> wb_gains.gr = 4096 -> actual gain = 1.5 wb_gains.gr = 8192 ->\n> > > >> actual gain = 2.0\n> > > >>\n> > > >>> It seems not correct to changing ratio from 8192 to 4096 as its\n> > > >>> precision is U3.13. I am not familiar with ipa implementation\n> > > >>> in libcamera, not sure other details.\n> > > >>>\n> > > >>>> -----Original Message-----\n> > > >>>> From: Jean-Michel Hautbois\n> > > >>>> \n> > > >>>> Sent: Thursday, June 16, 2022 5:12 PM\n> > > >>>> To: libcamera-devel@lists.libcamera.org\n> > > >>>> Cc: Cao, Bingbu ;\n> > > >>>> sakari.ailus@linux.intel.com; Jean-Michel Hautbois\n> > > >>>> \n> > > >>>> Subject: [RFC PATCH 0/1] IPU3 AWB gains correction\n> > > >>>>\n> > > >>>> Hi there,\n> > > >>>>\n> > > >>>> Bingbu, Sakari, I cc'ed you because this patch is not aligned\n> > > >>>> with the current documentation in the intel-ipu3.h file, could\n> > > >>>> you have a look please ?\n> > > >>>>\n> > > >>>> The part which worries me is that the green gains should be 0\n> > > >>>> for the white balance to be correct which is not stated in the\n> > > >>>> documentation at all.\n> > > >>>>\n> > > >>>> In order to demonstrate it I captured two frames, [1] is the\n> > > >>>> actual\n> > > >>>> SGo2 image quality, and [2] with this patch applied.\n> > > >>>>\n> > > >>>> [1]: https://pasteboard.co/hUcL4U6eyyAH.png\n> > > >>>> [2]: https://pasteboard.co/2XIbkkL8kitl.png\n> > > >>>>\n> > > >>>> There is a very clear benefit, that's why I submit this RFC as\n> > > >>>> I think it needs to be clarified :-).\n> > > >>>>\n> > > >>>> Thanks !\n> > > >>>> JM\n> > > >>>>\n> > > >>>> Jean-Michel Hautbois (1):\n> > > >>>> ipa: ipu3: awb: Correct the coefficient factor\n> > > >>>>\n> > > >>>> src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n> > > >>>> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> --\n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42D3ABE173\n\tfor ;\n\tTue, 21 Jun 2022 03:04:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4012965635;\n\tTue, 21 Jun 2022 05:04:04 +0200 (CEST)","from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94D0E600F3\n\tfor ;\n\tTue, 21 Jun 2022 05:04:01 +0200 (CEST)","from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t20 Jun 2022 20:03:57 -0700","from orsmsx605.amr.corp.intel.com ([10.22.229.18])\n\tby orsmga006.jf.intel.com with ESMTP; 20 Jun 2022 20:03:57 -0700","from orsmsx611.amr.corp.intel.com (10.22.229.24) by\n\tORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27; Mon, 20 Jun 2022 20:03:57 -0700","from orsmsx605.amr.corp.intel.com (10.22.229.18) by\n\tORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27; Mon, 20 Jun 2022 20:03:56 -0700","from ORSEDG601.ED.cps.intel.com (10.7.248.6) by\n\torsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n\t15.1.2308.27 via Frontend Transport; Mon, 20 Jun 2022 20:03:56 -0700","from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107)\n\tby edgegateway.intel.com (134.134.137.102) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.1.2308.27; Mon, 20 Jun 2022 20:03:56 -0700","from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by\n\tBN6PR11MB1940.namprd11.prod.outlook.com (2603:10b6:404:104::16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15;\n\tTue, 21 Jun 2022 03:03:49 +0000","from DM8PR11MB5653.namprd11.prod.outlook.com\n\t([fe80::81de:d29e:a239:f5c]) by\n\tDM8PR11MB5653.namprd11.prod.outlook.com\n\t([fe80::81de:d29e:a239:f5c%7]) with mapi id 15.20.5353.022;\n\tTue, 21 Jun 2022 03:03:49 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655780644;\n\tbh=phtZKF+G5T34raLtpmZuFpSNd5VRZbLdarNfe1W3y3c=;\n\th=To:Date:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MFZ/AJORo5s4wM01A4iGX9aOXJbYzFKwOOjspBqrnKSO+DNGVIhKDZgnNCIvvmUbn\n\tjt6LLl6zsQAKRoVPlV3GkcKLLsKNA96r5tiVyH21dgMt7DZemlfJiv84pir7NL5zUx\n\tTyRYEjfOghC4V+1c1ytgM0ZUhR/2VeNdJcjB6SiV2MF2sVbHIwkIN/YK4GhO09fpeU\n\tgvXdO6DjC+ZRM9poJ4bTyvkyrfgSpUzE6Ba8EQU4kglZEvGpqqOrVJ1oH4ly6mBVtp\n\tsnIbcSOwj4IKmAogxuPYwMe9P7NQSS/GX0BK6cowU7u478cqzE1qt+o7cxvCs0WNSf\n\thaY9fqzp+nkSQ==","v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1655780641; x=1687316641;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=phtZKF+G5T34raLtpmZuFpSNd5VRZbLdarNfe1W3y3c=;\n\tb=RLC8aZzYZ9ZU6mN2zmx0UUJRtT4hGJoQ+7zT3vZ7hJyZ766+eYyG27vT\n\tZTn7iEUKIcYe0Ljn5M4HM1s/C0Pl//vq+qHnf0yXNrrMtCe70irqVLLFU\n\tMsS6DAtyeA75TQsIww2594nxtRgIDctj3M4ryzFHsxKqn1wd2LUjgLR6x\n\tLO0tW7iU9uahM0kfuvX/T6i2MQmN+vPtzf7dt5sZOBFRRESkECZ+3kDoJ\n\tW+D8yUtEVoQEJD/6FrKh+AoIsPKp+bAmPV5lYMIAW9oJ86N5E/g4cVBIc\n\tv2ub+3pAgaFFzzZUJ7Vy2dDq9/CO69LM7jcsixbwkRYfN1bP1pszFX5E5 Q==;"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"RLC8aZzY\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=intel.com;"],"X-IronPort-AV":["E=McAfee;i=\"6400,9594,10384\"; a=\"260445929\"","E=Sophos;i=\"5.92,207,1650956400\"; d=\"scan'208\";a=\"260445929\"","E=Sophos;i=\"5.92,207,1650956400\"; d=\"scan'208\";a=\"562175966\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=D8zH/Ue8GllfVj4GSTCElJV3c0bcTvlPGczbHRhSWEnr6PrdUb26oDIdocJi628EDStNjBz09wTpMwZHMUzYpmEh+esGKX9oeUm24hHRPMHZzlnNEksrlH8cYc+vAMPJVZw2njB/ka187XYaYV0HOQcM98whcC3bjxXbCWa6InCDB5rZ1t3IeJkxTTAEDgUJyjJvfLHj7QfzNcEkNF7mZP5TrRlfIu4lRAg2Cc+eg/NE7cCeJ+yNkKImgVAy/HmitJWaHQO5Jo5uIrQyNneBq5fkc4k4nVoSA3VCMolmvmStE6egyskCdAaT20kRZTBaepG1hc7Uk8E6GSuNqtFu8g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=phtZKF+G5T34raLtpmZuFpSNd5VRZbLdarNfe1W3y3c=;\n\tb=oa0iWqCtRMW6oJsclAaDo4fE/VilsufwBtN2zpiYug/zhFweDT4Ri6BIVUjtr/wCg57HBuiVjCwrIGH+mbz9ldo/59C3UCy2t7KFy6H0czXaKnGqMHmw+OUBC26PnKRgbhyexihAyWB+vwkYMEnxAN/Jc1s3HENwCdsUGrCZWqs4M7D6j2JRy+tvQHAaCEX2dELzWjupsF7rrEa558gUzhSOvHe9VRxnK229OPEnlI8OtlSifxKu+jpNkklkz910HX9BUAMTt8qVp9vWHro9NP3fIjcqmQqESF29iZbqLgsUMp39r+aq8hXh/JR6F7A93B17mmuWNTrKyazSuQi1xw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n\tdkim=pass header.d=intel.com; arc=none","To":"Laurent Pinchart ","Thread-Topic":"[libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","Thread-Index":"AQHYgWE//6QkI2bzKU+Nd/p2Ip/2kK1TJ1+AgAAYkgCAAFmkEIAAE8uAgASH57CAAAm5AIAA9Nxg","Date":"Tue, 21 Jun 2022 03:03:49 +0000","Message-ID":"","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t\n\t\n\t<5ea3b9e2-29cc-d185-9e51-ccb0438afe1d@ideasonboard.com>\n\t\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-reaction":"no-action","dlp-version":"11.6.500.17","authentication-results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"RLC8aZzY\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=intel.com;"],"x-ms-publictraffictype":"Email","x-ms-office365-filtering-correlation-id":"992e154f-0d2b-4dc7-5317-08da5332aa2e","x-ms-traffictypediagnostic":"BN6PR11MB1940:EE_","x-microsoft-antispam-prvs":"","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;","x-microsoft-antispam-message-info":"wcJwEHkvmjsEw6PiaLaBHxWP7Ri1ph+TcOHomK1YX1WDRSzfoN1fmw3KQZYGqOyTiABUibIdBAh5cMmj5P9Kf3Uiw0VeLOElCHXnJ2LK30jTyoG5IapRGmZeBON2+b+M65xP3AJk87TDE9em0vPjE+MDjljJqXwKQ1p3v876BiTNQFaYy6Q/cgCaLudLAGtgHJUFJnEP6LNLYrhsMPnMADnuXYGLv79DfaEZmfS0BahiiGadyI1/z58d/xvsTtmu5bfwopXniFZzHBvyQsbjktScyctLGJIW5a0+adfrmPyapVRaAauLblFCl1ZDUjCcRW8DqgJ6BoRgp9nT85JxHpdrdTc/nk2ByfnHbirGoDqPUsYFtuNojAdjK7agPSFOIQ9UhKiDP/HSAul4kuJg1aVSAXXLgQbWGdYS38Dcvfad4goAdvDwJoqo5tYhBumuA+/Qa4UlzYhxabcz09UdpeuHV7FTrar9tJ5J9XXYACaN+8e0EunLq57N/fv8XnbEFmzwvvMKlQZGEDRjMOkcBaXuP/EwBCZwwFNucHY9k9xycNDlxn8BglcVjYRSN/vAVEE/3Ih9EAkb7rl64a709JxYngqnE8MmwihLbDFY7xKtA+74ISB0KDBYJs6AFzia4Q7os4LPhZBo+ZPw5aYivo76+9F3/mrlWljjhf6460BCplWOlu+jIyzOsvyyXOaaNNAIL2u8ysDO22Cdgfnk9XTSo5Idvo6k4wCW9iUOG8OwsIGxjxJ2a7NjmcpxZ6uQkL3hOagQXRdP4QoZK57clEjqKM5i5z9ftvT9Xnpr+nc=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230016)(366004)(39860400002)(396003)(376002)(136003)(346002)(186003)(83380400001)(86362001)(64756008)(66476007)(52536014)(76116006)(66556008)(4326008)(66946007)(38100700002)(2906002)(66446008)(5660300002)(41300700001)(55016003)(9686003)(478600001)(82960400001)(71200400001)(8676002)(8936002)(33656002)(7696005)(54906003)(26005)(6506007)(38070700005)(966005)(6916009)(53546011)(316002)(122000001);\n\tDIR:OUT; SFP:1102; ","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?5vBceYAexDqwBcsgIgvqLJvi5?=\n\t=?utf-8?q?fznggEILO6hg9vFp9cWPsm7Qy6HNk8PQZLrigDJyJJzRmOcxeF6qZfmD?=\n\t=?utf-8?q?Q7kp0/JLvudrZBIVAR8rRlOWAPTCJOem+OmCQlsrD/J44WDpgHUWm4o4?=\n\t=?utf-8?q?TmBv4yFRpzYnY5fgOcVPWLkkgxhyZ0BmuUKTfCcWapt8sQlg7FXjg5r9?=\n\t=?utf-8?q?CvASaQ0m+kGOPUw1RGj7wBJYr1iooPId/m94U0Po1/3N25HcVCgaa2r9?=\n\t=?utf-8?q?5NLjMVgPxcJDN69/7wgQv1e6cjMNJCiQc6L5wchmuGb4QAHbd97xlQq6?=\n\t=?utf-8?q?nmYbk9UjUb62jBruHXAlish3QQWRmK5DmNoSexkkbl5jIQXB9UZnMz62?=\n\t=?utf-8?q?ckPREg7SpX1ig9ssOefkykemPIcUTCFmWRaoQRV8kWbVM1/gyWLG2TxF?=\n\t=?utf-8?q?A0hUatXhvGwOwwrBeskvmW0hAmKlwNSmrCllXP2I0xS4T5ZP1DlX1vSg?=\n\t=?utf-8?q?pfYOovFYZBHeTJPPXCfC5SAObDpI10DRJQZ17gMYuiUWpKDpg2DcT6Yv?=\n\t=?utf-8?q?2G3z1/XrCasVXhqJwzyGFFEyZidY0QSQr1S3VHMDYAylzi64Zpw46opQ?=\n\t=?utf-8?q?3RSU44ecGoDXbzfm4IQ1nY93oWq4rfd3PAbbX0tjHiaH1RFz5Cp9PHOQ?=\n\t=?utf-8?q?W7iFDDLwWPydKWQA0ntuOHSe94tyIq166TIpUsV+eR3vqIrdpP/SxpOe?=\n\t=?utf-8?q?vkhkmEu61gD4Vn+BqjoJxoeSWtwuHmQUSq0q5/4xhBLF0x8uEi4hGrRE?=\n\t=?utf-8?q?9irO9Y2O2BG5wWT51Wx5L9RRKrV/GaLJm1VqFjzNa5psWHDswCWwB2GW?=\n\t=?utf-8?q?8hZF+x4ac+vQP9EQrdViDqeN6slf6AaEFtpxyMuRC29BnoBHp5qoaVAS?=\n\t=?utf-8?q?MEnHlboMQJRvrMDiMqHwiOcXAUfaPztPpVzna2lcrbyWFfPmyLLPgAxs?=\n\t=?utf-8?q?GWFzefc7kK88Z/TbEBGytzHRKCQoMD+S7ujn3kDPPFvcklaFmf8P9q6j?=\n\t=?utf-8?q?QGJK2RJ6pcwzT/1Dnjmyvb2te8CxOfeWteEMf5QkgphJDCPgsy2RwSWJ?=\n\t=?utf-8?q?5widPhWcigL90ZUGAX266qbIL7PeWfyWHPBhkdN/6hpMZBS0U4Xm/9jn?=\n\t=?utf-8?q?A/RO5C7zc/qJlKvmjBuGaumVgDg5eZztzyAB499QOrOF9H0T6dpAwCo/?=\n\t=?utf-8?q?VEv0ovsancwuyZG3kASahTCVcyZdJhPkj0fZa3AUsX4P/x0r+sw7bKpX?=\n\t=?utf-8?q?EduPUyUWCbigwHuKOgqcZRDdOAe+40u+t8nemoDU72dWyRzH95jxo1uR?=\n\t=?utf-8?q?OLr68sNCE6nnjUAP9jyCw2q/E64wimhtZbYayes6WWcohN3gWQVuMbK8?=\n\t=?utf-8?q?9Jtn+AAE600amDvo040xNCi+cREx1d3lSIbFKsjMXfg8y2ruVHWOWcVV?=\n\t=?utf-8?q?SdoufnrbAottCGG/VugThKyXWu9bNTIK+vD+LJ6/H3kqmgABgVVVuncY?=\n\t=?utf-8?q?9BN93/yfyDT7/fk8UFkdPUR38SJjDLHDtRXO8HnqVXNaGysOD7LINI8f?=\n\t=?utf-8?q?LeOWcUoCzyQ3CXhVhh9JfpONbzjSTUZpkSnITu4QwfBllwByMD0fmZgG?=\n\t=?utf-8?q?KqMvXjFMWNVAGNbhVWusSVGzJ4oncoi26vbKyohJ7O4SJ9iggVg29LWc?=\n\t=?utf-8?q?T7qnSXOcZVrtnFH6ReDIBYu3ZLGxIQTJHboBnA26YeWunQyj/5s908Wu?=\n\t=?utf-8?q?W7DdFykSNnbzQbgCEk1Icx+FmMvzzmczBKodlHYLWc82Wuk168dVCbG9?=\n\t=?utf-8?q?lg7RB4cT4j/DS8IwcXVpoaudlQ9ukubAQAMwnKd8a0x1Q=3D=3D?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"DM8PR11MB5653.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"992e154f-0d2b-4dc7-5317-08da5332aa2e","X-MS-Exchange-CrossTenant-originalarrivaltime":"21 Jun 2022 03:03:49.4666\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"SFREkp53ZwSsTs56BpKbeHvKbZNb3yw5/2idhhx9HABod/TwoxHGKbCtI3+O/9uvT9dylNdigQo4Gh/8XYyVhg==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BN6PR11MB1940","X-OriginatorOrg":"intel.com","Subject":"Re: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"\"Cao, Bingbu via libcamera-devel\" ","Reply-To":"\"Cao, Bingbu\" ","Cc":"\"libcamera-devel@lists.libcamera.org\"\n\t,\n\t\"sakari.ailus@linux.intel.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]