{"id":16234,"url":"https://patchwork.libcamera.org/api/covers/16234/?format=json","web_url":"https://patchwork.libcamera.org/cover/16234/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>","date":"2022-06-16T09:11:48","name":"[libcamera-devel,RFC,0/1] IPU3 AWB gains correction","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/16234/mbox/","series":[{"id":3180,"url":"https://patchwork.libcamera.org/api/series/3180/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3180","date":"2022-06-16T09:11:48","name":"IPU3 AWB gains correction","version":1,"mbox":"https://patchwork.libcamera.org/series/3180/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/16234/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F490BD808\n\tfor ;\n\tThu, 16 Jun 2022 09:12:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8690665631;\n\tThu, 16 Jun 2022 11:12:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71112601F1\n\tfor ;\n\tThu, 16 Jun 2022 11:12:26 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:64d1:a349:8ac7:1dd0])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA65C898;\n\tThu, 16 Jun 2022 11:12:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655370748;\n\tbh=HDHtbipgyaUsta40ua6BKVoLPyrZROMGccS+EOl+WQQ=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=bF0N0dzh5BzHQyAkHov6crGoTE6yq/AjzIIiAfpBmAB3wBM6XZdiOMyGVfPJL4+Bf\n\tXAM4H22Zxqfe5WSRQcSrAKBxsFi7mn8Hv5hmFXkbtfP1gleLAWSzwlF4o2VfKnz1zL\n\tr3QYry/jnb3UgoV5u/q1PLN5x6u9BJmZTtfQIm6SasHWSio6T8hPiALUveBRNoJkHB\n\tdiWX7rychg5NVApxeFUIVbyJGJIzaPrv6JpnhYxKu2fG2sol9x/uK6/7DtTnbnnU4B\n\t2DjI7dTDIN3fKTg4PJ+/sfLqTIAeKFa4RiAKBDAw7asqgk37h+P77WuYHJetLDQT7T\n\tqRRtWV4q3LZaQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655370745;\n\tbh=HDHtbipgyaUsta40ua6BKVoLPyrZROMGccS+EOl+WQQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=YeduVW5wj7XDdMFdRYYgGEl5lPs9IWM6vyjdBJhp9qxKqSlf0lXaoq5KpgP2IzQ0F\n\t/KaZnaAuhSgT00xsWd1yhJ5GAwK2zfqN7Rt11r7tpioT+DGzbYkK4O8l06EBABe3yk\n\tXvMUiMN0B3AA3QBiDEKauwPYKI/S9cS0O0cJDX4c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YeduVW5w\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 16 Jun 2022 11:11:48 +0200","Message-Id":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Cc":"bingbu.cao@intel.com, sakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi there,\n\nBingbu, Sakari, I cc'ed you because this patch is not aligned with the\ncurrent documentation in the intel-ipu3.h file, could you have a look\nplease ?\n\nThe part which worries me is that the green gains should be 0 for the\nwhite balance to be correct which is not stated in the documentation at\nall.\n\nIn order to demonstrate it I captured two frames, [1] is the actual SGo2\nimage quality, and [2] with this patch applied.\n\n[1]: https://pasteboard.co/hUcL4U6eyyAH.png\n[2]: https://pasteboard.co/2XIbkkL8kitl.png\n\nThere is a very clear benefit, that's why I submit this RFC as I think\nit needs to be clarified :-).\n\nThanks !\nJM\n\nJean-Michel Hautbois (1):\n ipa: ipu3: awb: Correct the coefficient factor\n\n src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)"}