[{"id":23397,"web_url":"https://patchwork.libcamera.org/comment/23397/","msgid":"<20220613111100.0f41c227.dorota.czaplejewicz@puri.sm>","date":"2022-06-13T09:11:00","subject":"Re: [libcamera-devel] [PATCH v2 0/5] libcamera: pipeline: simple:\n\tSupport scaling on the camea sensor","submitter":{"id":96,"url":"https://patchwork.libcamera.org/api/people/96/","name":"Dorota Czaplejewicz","email":"dorota.czaplejewicz@puri.sm"},"content":"On Sun, 12 Jun 2022 18:23:06 +0300\nLaurent Pinchart wrote:\n\n> Hello,\n> \n> This patch series improves the simple pipeline handler to support\n> scaling (in the generic sense, this can be binning/skipping or real\n> scaling) on the camera sensor in addition to the converter. This is\n> useful on platforms that don't have a converter, but also on platforms\n> where the SoC camera pipeline has limitations on resolution and/or\n> bandwidth.\n> \n> Patches 1/5 and 2/5 are small drive-by improvements, patches 3/5 and 4/5\n> prepare for sensor scaling support with some code refactoring, and patch\n> 5/5 then performs the bulk of the work, with an explanation of the\n> heuristics used to configure scaling.\n> \n> Laurent Pinchart (5):\n> libcamera: pipeline: simple: Improve debug message on config failure\n> libcamera: pipeline: simple: Document the pipeline traversal algorithm\n> libcamera: pipeline: simple: Factor out format test to separate\n> function\n> libcamera: pipeline: simple: Store sensor resolution in configuration\n> libcamera: pipeline: simple: Support scaling on the sensor\n> \n> src/libcamera/pipeline/simple/simple.cpp | 270 ++++++++++++++++-------\n> 1 file changed, 190 insertions(+), 80 deletions(-)\n> \n> \n> base-commit: b4d4b78c82a23de3c6dd1676bf43bba1d6043652\n\nTested-by: Dorota Czaplejewicz \nReviewed-by: Dorota Czaplejewicz ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23B9ABD808\n\tfor ;\n\tMon, 13 Jun 2022 09:12:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66F8E65631;\n\tMon, 13 Jun 2022 11:12:42 +0200 (CEST)","from comms.puri.sm (comms.puri.sm [159.203.221.185])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9851B601F0\n\tfor ;\n\tMon, 13 Jun 2022 11:12:40 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n\tby comms.puri.sm (Postfix) with ESMTP id C6B7EDFEC5;\n\tMon, 13 Jun 2022 02:12:08 -0700 (PDT)","from comms.puri.sm ([127.0.0.1])\n\tby localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FwtjGGXz5Vp1; Mon, 13 Jun 2022 02:12:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655111562;\n\tbh=2krSKKt31k+r4yiKZV8P7F0NlgW4dyN9NwQ5Z6W+vz4=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Tqavp83Si4yDiZu8QcVI31MnN05CelnAiNG7UE7FX4yzG9aSjKn5haEKAALSTduq1\n\tdcJcERKIdl7G7J/XdlzRILp0SKGe478NQ0SXNdGW2IDFL3L+gPR3HY0A/a5yeQ/Vvo\n\tJSJoWnmWSnBMqvwGR2qYRXSt6eji/H7gdBr/ubJjZ+tsE7Ghr/AeteEmFXMakonrjp\n\txp9aJF2j7aL7f6NIUHnfiK7mCa9s8WQiLIDJX/VLU6SoJiHRP1iE8gn1YoxUFpsZuN\n\tNkWOgtbw2EjVvcYhG7i2ZlwVKcth/CuBjdrDJsfLFWw6vnhWgflW7Ni1XSFTZ7kCKz\n\t5/3InM1oLFqlw==","v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms;\n\tt=1655111528; bh=2krSKKt31k+r4yiKZV8P7F0NlgW4dyN9NwQ5Z6W+vz4=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=NsXPGttNY7Npxx1oCnOnhDP0sDvdt75PYcHaSe+gq2I0qpERUprs36q43A2w4KaXD\n\tjUtSH5qw/AysqZRg7WXPpI4K05TCKhN6caiwSyIhspt/sCwH+pM1OpoqhQ7wV8wjsE\n\tONfNJsZPWzhr4OevZ1oE+euaGfFrBrKS1lexBryMCPv5CV48VusxNh6TXyMdRCRiF7\n\tV6s/Lx4CxfelUrQhmBjNXQaqLAHGB7wnLkxJewHaPAh9ZfDBV7opsYSgBUhOIz1hKb\n\tsqUa+Q30SwAtHjntJdpG4tpuLfG0yn2ZMX/RnBs+ANU/QVWGXppAI8pHwEkWt9FLql\n\tLn0rR4lADfWuA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=puri.sm header.i=@puri.sm\n\theader.b=\"NsXPGttN\"; dkim-atps=neutral","Date":"Mon, 13 Jun 2022 11:11:00 +0200","To":"Laurent Pinchart ","Message-ID":"<20220613111100.0f41c227.dorota.czaplejewicz@puri.sm>","In-Reply-To":"<20220612152311.8408-1-laurent.pinchart@ideasonboard.com>","References":"<20220612152311.8408-1-laurent.pinchart@ideasonboard.com>","Organization":"Purism","MIME-Version":"1.0","Content-Type":"multipart/signed; boundary=\"Sig_/qm.spqe0ijCakC/_tLXUfWs\";\n\tprotocol=\"application/pgp-signature\"; micalg=pgp-sha256","Subject":"Re: [libcamera-devel] [PATCH v2 0/5] libcamera: pipeline: simple:\n\tSupport scaling on the camea sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Dorota Czaplejewicz via libcamera-devel\n\t","Reply-To":"Dorota Czaplejewicz ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBenjamin Schaaf ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]