[{"id":23480,"web_url":"https://patchwork.libcamera.org/comment/23480/","msgid":"<960d79ae-b876-4aa9-93ef-19b8c6718854@gmx.de>","date":"2022-06-20T09:37:27","subject":"[libcamera-devel] Fwd: [PATCH v8 0/4] generate and use fixed-sized\n\tSpan Control types","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi,\n\nRegarding my \"std::optional\" changes, I haven't received new feedback on\ncompilation issues. The \"std::optional\" change compiles correctly on a\nvariety of compilers and CPU architectures (see CI workflows).\n\nCan you let me know what is missing to go on with this and get it merged\neventually?\n\nThanks,\nChristian\n\n\n-------- Weitergeleitete Nachricht --------\nBetreff: [PATCH v8 0/4] generate and use fixed-sized Span Control types\nDatum: Fri, 10 Jun 2022 13:03:34 +0100\nVon: Christian Rauch \nAn: libcamera-devel@lists.libcamera.org\nKopie (CC): Christian Rauch \n\nHello,\n\nIn the latest version of this, I am just rebasing on master. This\nessentially removes one already merged commit from this patch set.\n\nDue to previous reports on compilation issues, I set up a CI\nworkflow/pipeline for native amd64 and arm64 builds, and an arm64\ncross-compilation build [1]. Those three workflows pass for the full set\nof libcamera features as well as for gcc and clang [2], [3], [4]. The\nworkflow configurations are not included in this patch set. Please see\nthe GitHub link if you want to fork and modify them.\n\nIf you encounter further compilation issues, then please let me know how\nto reproduce them, e.g. provide a CI configuration or docker image.\n\n\n[1] https://github.com/christianrauch/libcamera-ci/tree/ci/.github/workflows\n\n[2] https://github.com/christianrauch/libcamera-ci/actions/runs/2474771137\n[3] https://github.com/christianrauch/libcamera-ci/actions/runs/2474771142\n[4] https://github.com/christianrauch/libcamera-ci/actions/runs/2474771143\n\nChristian Rauch (4):\n libcamera: controls: Use std::optional to handle invalid control\n values\n libcamera: controls: Define size of array controls as a shape vector\n libcamera: controls: Generate fixed- and variable-sized Span Controls\n libcamera: controls: Apply explicit fixed-sized Span type casts\n\n include/libcamera/controls.h | 7 ++--\n src/android/camera_capabilities.cpp | 12 +++----\n src/android/camera_device.cpp | 21 ++++++------\n src/android/camera_hal_manager.cpp | 2 +-\n src/cam/main.cpp | 4 +--\n src/ipa/raspberrypi/raspberrypi.cpp | 21 ++++++------\n src/libcamera/control_ids.yaml | 4 +--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +++---\n .../pipeline/raspberrypi/raspberrypi.cpp | 9 +++---\n src/libcamera/property_ids.yaml | 4 +--\n src/qcam/dng_writer.cpp | 22 ++++++-------\n utils/gen-controls.py | 32 +++++++++++++------\n 12 files changed, 80 insertions(+), 67 deletions(-)\n\n--\n2.34.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA77DBE173\n\tfor ;\n\tMon, 20 Jun 2022 09:37:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24DDB65635;\n\tMon, 20 Jun 2022 11:37:30 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4992960473\n\tfor ;\n\tMon, 20 Jun 2022 11:37:29 +0200 (CEST)","from [192.168.1.209] ([92.18.80.244]) by mail.gmx.net (mrgmx005\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MsHs0-1noZH82i4o-00tii9\n\tfor\n\t; Mon, 20 Jun 2022 11:37:28 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655717850;\n\tbh=sp3oft0P+wkN/DyyrleAav5dsv95OW+56tUT49eLgFk=;\n\th=Date:References:To:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=mbthNqJ8c+Q9znNwLr6hIpHxnN5G1JDSn6tfKDOopsmFNk1smcFp5rfHABEoLM7/P\n\t06ULGAILXNz/lWHhuwm4VJb+5UodVkGA6xJXQXzygQyx4Oo7apgYZdswhnJLUYOqiL\n\tJfNCFlk3x5Bb0yELQF/Z7tp9FCxOL+Bskkc5F9dhN+H9G4dClE8Wj0CxT+7Ulz9M7T\n\tdMOP3d00Vs5w9dnjCifMT0KJv1kQiwDynMDXpP4JMcNeQD5FNFL/8vNoRVwTQxV7Cj\n\tj8WJJx6AnfUKNfCKJhQzhLBPp/sSavuIBHeslKZNy+SuqjEnKox6/IKB99OU2TOGB9\n\t813OV4PFaUXbQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1655717848;\n\tbh=sp3oft0P+wkN/DyyrleAav5dsv95OW+56tUT49eLgFk=;\n\th=X-UI-Sender-Class:Date:Subject:References:To:From:In-Reply-To;\n\tb=D3n6DPqhaC+FCTWnD0TA01RgDGVPhlYe2syt/sYH06WZuSE/AVllTsl0m8V8q/P+d\n\tOy64kLwIZXDrhZKBSaNa5C81PN9Poebwpp8L5lQua0apwjt01ZbLgOJ79ZK8hA0zPr\n\tDlEqlBPgOHqwu8WEuw8zjKZZPuVsoGGhF4l2Uf8g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"D3n6DPqh\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Message-ID":"<960d79ae-b876-4aa9-93ef-19b8c6718854@gmx.de>","Date":"Mon, 20 Jun 2022 10:37:27 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.9.1","References":"<20220610120338.96883-1-Rauch.Christian@gmx.de>","Content-Language":"en-GB","To":"libcamera devel ","In-Reply-To":"<20220610120338.96883-1-Rauch.Christian@gmx.de>","X-Forwarded-Message-Id":"<20220610120338.96883-1-Rauch.Christian@gmx.de>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Provags-ID":"V03:K1:ojhWBsr4/c7pz7jYhAuox2WG/Vw5PPqZG07yMae9a9Zrj8xCzYT\n\tBaojVffoVFcqnRqtWGl9xkZe1MJM7iYGRMf5NIDwJDZ47NagJKZurU605Vd529M4zwfE/qy\n\tkH4CnAvtiFuugLBzjzBBjloM37LqCLZ40kM3MxdQxxHQdcYnEaxfm5o5TmfFpcWfAoMeETi\n\te65hv/BNy2v/GQSHuHK8Q==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:m+2HYuuGY4g=:nN3PMReC+Uw7jdYvR8InNB\n\teAJcGxaD6Uc1V66xyLmXZlYQ5fDzBJwwAbH6fKxH/xpED/rSKSlYyzes3ERQERHhfFxSpEkfw\n\tFWe+4TZEoCa6l9Z9xMV8oR+uoO2D8mu11QFX9HbdtwCg7vg45ID61AC9HjASLdf1CucTvn1Pt\n\tx27FybIMwstHgZKDznZP/AX3OAv92qX4MCPdfm/wRt4+ORuR1nZylxxz1Y3JXn5pnb0YDHh0G\n\t1aZ27LayN1mfDiTFMgnCVdioKIdltLSldjwNjV3ERKiwkZ66xpbDDH/KRI3DDpQvDcbx82ecN\n\t/r742kUizkevAAoKXuegAWJru78kouZVxe3h0ZTOWwDQeAmyATJ9Hv6T3Hcj4G2kdDpbhrWLQ\n\t/ezekmHXLRUrgrwX9J2DwPHo5X9I30xOuu1U+QexOUoRT4/+bEjvF+rGHXNvI/XouhGMjtfOQ\n\tfZyJoQt3fNthhIj9Vz+XQn1RlWpJfUoGWwKMw8pQ7dUZCKJ1UivyN81nLD2OMfy24p9Ceomax\n\tKHFIEJH2W32xddKPtv8rSz3QT0fQHM+yxdSfmpWK+xmM4X2S0dz9HcK4A894XeIh9/qHhrOyR\n\tt8ZY8eipgr/9sjIsR2AjYO3DQal/7EGsscuHDKDFmsrdgLcwG+OmS0aeP6m+wBgSEHU9A8Ze9\n\tTBr8bq3q6uv8qZqJBtrMO4OgASkLTdVvT0PxoTkTJ1ZhaMe8HxUDKMBMF8nKUCjr+sL66pkki\n\tvst2kQ69V7wpWSd4NOLcBtfUa6ToLpv5BFFywBUO5kEF/9Yxly6UTh1YZtgjvS9K90lMD+194\n\toE5PxQw4IoYfcBkGYoiL1PclqG5yv70cCtkc3Bwue/LIXXDj9JS4ytCotS4qkavMaSBZ+aqsA\n\t9e2+CS/U2jQMDdSkHUrF8z0ACY4EuocqkzfVnuKIWjWid9NkJttG5DiZ4nFjs5siELkkfr80b\n\tUgBY1iXUtVb67TvVYOWnRxbSId4iCArNpoWR1fw8AbkNcIDvnbcI9m7fqxvslfKvkihOjbPj8\n\tXjCKivpSArUuFnnxptfXd9IDm4lKHLyDZyc0u7hbnVcMaycnMJ5g3AQ8X9BZWOqWSo2PkAJEJ\n\tdYXM2+sW+th7Re0XVF/xhXPxRzXD1j+s6WOzDxZ+17xpKQTLKvhMWs4PQ==","Subject":"[libcamera-devel] Fwd: [PATCH v8 0/4] generate and use fixed-sized\n\tSpan Control types","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]