{"id":16149,"url":"https://patchwork.libcamera.org/api/covers/16149/?format=json","web_url":"https://patchwork.libcamera.org/cover/16149/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220604093025.77737-1-jacopo@jmondi.org>","date":"2022-06-04T09:30:20","name":"[libcamera-devel,v3,0/5] Plumb the YUV processor in","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/16149/mbox/","series":[{"id":3160,"url":"https://patchwork.libcamera.org/api/series/3160/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3160","date":"2022-06-04T09:30:20","name":"Plumb the YUV processor in","version":3,"mbox":"https://patchwork.libcamera.org/series/3160/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/16149/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57DB7BD161\n\tfor ;\n\tSat, 4 Jun 2022 09:30:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7441C65635;\n\tSat, 4 Jun 2022 11:30:33 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 957C96559A\n\tfor ;\n\tSat, 4 Jun 2022 11:30:32 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 0FF9CE0005;\n\tSat, 4 Jun 2022 09:30:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654335033;\n\tbh=BrUs/DolxG8gz8hDdEvURQzA1piOrCOPic6gUiaRAJs=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=NerktYyQGXbexBYaKDDAplt2i42l2leo2wNl7/1T263Zep9r+ovVUKxwVq1SwHOom\n\tJnmH6akr4rCCzRn9+XPhFqlqbNfjMJNyebQBDcWa6tErJsDFpaGGUik9U82P3iHKP3\n\t7y5oLHHeGwzBr+lBmG7v93IFSFCHp4011P4TgfND1tclxihpKKRL/0RlxZrp/GoygK\n\ti+i9P5rjDGNwHHdi9DfqP6CaynALILYCKlp+ZrENtxqz1RlsZJ5Evc9TdBotUktxSt\n\t+pJkUh/s6W9sOa/5u8h1mO2tpxKVKLi6DS/KicahBRknH4fNjvK7lM89CYfAP61osY\n\tFpJQvKbSLanwg==","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jun 2022 11:30:20 +0200","Message-Id":"<20220604093025.77737-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Subject":"[libcamera-devel] [PATCH v3 0/5] Plumb the YUV processor in","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v3:\n- Add comments as suggested by Laurent and Umang\n- Assert sourceStream != nullptr\n- Rework requestedStream handling to simplify it\n\nThis change allows to include 13 more tests from the Camera CTS test.\n\nandroid.hardware.camera2.cts.SurfaceViewPreviewTest#testDeferredSurfaces\nandroid.hardware.cts.CameraGLTest#testSetPreviewTextureBothCallbacks\nandroid.hardware.cts.CameraGLTest#testSetPreviewTexturePreviewCallback\nandroid.hardware.cts.CameraTest#testPreviewCallback\nandroid.hardware.cts.CameraTest#testSetOneShotPreviewCallback\nandroid.hardware.cts.CameraTest#testPreviewCallbackWithBuffer\nandroid.hardware.cts.CameraTest#testFocusDistances\nandroid.hardware.cts.CameraTest#testPreviewFormats\nandroid.hardware.cts.CameraTest#testSetPreviewDisplay\nandroid.hardware.cts.CameraTest#testImmediateZoom\nandroid.hardware.cts.CameraTest#testPreviewFpsRange\nandroid.hardware.cts.CameraTest#testPreviewCallbackWithPicture\nandroid.hardware.cts.CameraTest#testPreviewPictureSizesCombination\n\nResult from running the now 244 CTS tests report 5 failures (3 straight runs out\nfrom an hard reboot with the same result)\n\n=============== Summary ===============\nTotal Run time: 20m 3s\n1/1 modules completed\nTotal Tests : 244\nPASSED : 239\nFAILED : 5\n============== End of Results ==============\n\n-------------------------------------------------------------------------------\nandroid.hardware.camera2.cts.CameraDeviceTest#testPrepare\njunit.framework.AssertionFailedError: Preparing surface used in previous session must throw IllegalArgumentException\n\nandroid.hardware.cts.CameraTest#testImmediateZoom\njunit.framework.AssertionFailedError\n\nandroid.hardware.cts.CameraTest#testLockUnlock\njava.lang.RuntimeException: start failed\n\nandroid.hardware.cts.CameraTest#testPreviewPictureSizesCombination\njunit.framework.AssertionFailedError: expected:<1> but was:<0>\n\nandroid.hardware.cts.CameraTest#testRecordingHint\njava.lang.RuntimeException: start failed.\n-------------------------------------------------------------------------------\n\nOnly 2 of them are newly enabled tests:\n\nandroid.hardware.cts.CameraTest#testImmediateZoom\nandroid.hardware.cts.CameraTest#testPreviewPictureSizesCombination\n\nwhich does not seem to fail because of failures in handling 3 streams (actual\nresons to be investigated).\n\nRunning the current CTS plan which does not require YUV duplications results in\n\n=============== Summary ===============\nTotal Run time: 18m 32s\n1/1 modules completed\nTotal Tests : 231\nPASSED : 228\nFAILED : 3\n============== End of Results ==============\n\nandroid.hardware.camera2.cts.CameraDeviceTest#testPrepare\njunit.framework.AssertionFailedError: Preparing surface used in previous session must throw IllegalArgumentException\n\nandroid.hardware.cts.CameraTest#testLockUnlock\njava.lang.RuntimeException: start failed.\n\nandroid.hardware.cts.CameraTest#testRecordingHint\njava.lang.RuntimeException: start failed.\n\nThe same tests fail on current master, with some more flukes.\n\nThere are no evident regression as far as I can tell. It's hard to estimate the\nexact number of failures as there are flukes and results are not consistent, but\nin the last run of CTS on plain master I got 7 and 5 failures, which is\ncomparable to the number of failures with the series applied and the new test\nplan.\n\nThanks\n j\n\nHirokazu Honda (2):\n android: camera_stream: Add sourceStream\n android: camera_device: Use YUV post-processor\n\nJacopo Mondi (3):\n android: camera_stream: Create allocator unconditionally\n android: camera_device: Postpone mapped streams handling\n android: camera_device: Print the correct number of completed streams\n\n src/android/camera_device.cpp | 112 ++++++++++++++++++++++++++++++----\n src/android/camera_stream.cpp | 12 ++--\n src/android/camera_stream.h | 6 +-\n 3 files changed, 110 insertions(+), 20 deletions(-)\n\n--\n2.35.1"}