{"id":16131,"url":"https://patchwork.libcamera.org/api/covers/16131/?format=json","web_url":"https://patchwork.libcamera.org/cover/16131/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220602073405.28168-1-laurent.pinchart@ideasonboard.com>","date":"2022-06-02T07:34:03","name":"[libcamera-devel,v2,0/2] libcamera: Add colors to the log","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/16131/mbox/","series":[{"id":3153,"url":"https://patchwork.libcamera.org/api/series/3153/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3153","date":"2022-06-02T07:34:03","name":"libcamera: Add colors to the log","version":2,"mbox":"https://patchwork.libcamera.org/series/3153/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/16131/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB752BD160\n\tfor ;\n\tThu, 2 Jun 2022 07:34:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 206BB6563A;\n\tThu, 2 Jun 2022 09:34:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F32D96040E\n\tfor ;\n\tThu, 2 Jun 2022 09:34:12 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(lmontsouris-659-1-41-236.w92-154.abo.wanadoo.fr [92.154.76.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA7866BD\n\tfor ;\n\tThu, 2 Jun 2022 09:34:12 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654155254;\n\tbh=qxBEWvky3It78t0jnk2tx+cvpoQ1vq5ATuk60hzgJqc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=BBmfiqcnGWvaDP6aU/yAXmkTt8yeXK4tyKBhqE5jT0NudKYx7sZerpeG36l18vDdT\n\t5qyyZ3zXosm9h1fwYvl1Ca+J3GJKoZqicQ5ZFy27Tr/6UaWX6Ax7gtwGAisUyAX4NJ\n\teJgxSOtWsWTt0l5wMpMA6YcB86nHK6VAOClTH4nLJ4nc9zh+OzgGKSBtH86JbGINkv\n\tIzLX7XzpVpIGWMzCsDsQcQZk5I47aK4ZprGKrNutOr5BfsTSnYECrF3mGPd1pYehEn\n\tdD1VpFRZjbzU3JlAL2E2C6LFEg6iJ7cqaFEs3r2zCsiz4qXZf//ixZODbaPhsgQB9o\n\tNE8B+jhXEJxUQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654155252;\n\tbh=qxBEWvky3It78t0jnk2tx+cvpoQ1vq5ATuk60hzgJqc=;\n\th=From:To:Subject:Date:From;\n\tb=lTmXUkAXsdzL3glcpCkor9xOoyGXKk0MYp4Tmi3pMLATvvaK1nCtdbPTzNA9xMQPw\n\tbj8K8jA8aNxI0/qaHZ7fU/mmSjJ9Hi2s74v8f06JKKOwHL3AebcZpUehQZLNqSf9Sg\n\tEQhp2HwynGMnsgXvp/+Kmbc6kbCx1767xkCEyWMk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lTmXUkAX\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 2 Jun 2022 10:34:03 +0300","Message-Id":"<20220602073405.28168-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/2] libcamera: Add colors to the log","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series addresses a shortcoming of libcamera compared to\nGStreamer or PipeWire, namely colored logs.\n\nThis was attempted by Marco Felsch in \"[PATCH] libcamera: log: add\ncolors to log levels\" but suffered from coloring message\nunconditionally for streams, regardless of whether the stream was backed\nby a TTY, a file or something else.\n\nThis turned out impossible to solve automatically (as far as I can tell)\nas the C++ stream API doesn't expose the underlying file descriptor.\nI've thus taken another approach, by exposing coloring through the\nlibcamera logger API and only enabling it automatically when logging to\nstd::cerr. This can be disabled with the new LIBCAMERA_LOG_NO_COLOR\nenvironment variable.\n\nCompared to v1, the first 3 patch have already been merged and are thus\nnot included in this version. The most notable other change is in patch\n1/2, where the escape codes used for bright colors have changed to work\nwith minicom.\n\nLaurent Pinchart (2):\n libcamera: base: log: Add coloring to the log output\n libcamera: base: log: Color the log prefix\n\n Documentation/environment_variables.rst | 21 +++-\n include/libcamera/base/log.h | 5 +-\n include/libcamera/logging.h | 4 +-\n src/libcamera/base/log.cpp | 144 ++++++++++++++++++------\n 4 files changed, 131 insertions(+), 43 deletions(-)\n\n\nbase-commit: dfcf638a0a6d26dbfab5348e646e5cb3c45ec51e"}