[{"id":23138,"web_url":"https://patchwork.libcamera.org/comment/23138/","msgid":"","date":"2022-05-23T10:17:21","subject":"Re: [libcamera-devel] [PATCH v9 0/4] Add SDL Sink","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Eric,\n\nSeries pushed, thank you.\n\nOn Fri, May 20, 2022 at 08:01:02PM +0100, Eric Curtin wrote:\n> Changes in v9:\n> - Added some todo's\n> - Changed includes, options, etc. to be in alphabetical order\n> - Fixed meson build file to identify SDL and SDL_image dependancies\n> correctly\n> - Some commit message changes\n> - chrono usage changes\n> - clear events on EventLoop::exit\n> - Function rename from addFDEvent -> addFdEvent\n> - SDLTexture::destroy() is now moved to destructor\n> - Removed sdl prefix from various variables\n> - Added SPDX and copyright\n> - Made ptr protected and added get\n> - A NULL to nullptr change\n> \n> Eric Curtin (4):\n> cam: event_loop: Rename addEvent to addFdEvent\n> cam: event_loop: Add timer events to event loop\n> cam: sdl_sink: Add SDL sink with initial YUYV support\n> cam: sdl_sink: Add MJPG support to SDL sink\n> \n> src/cam/camera_session.cpp | 8 ++\n> src/cam/drm.cpp | 4 +-\n> src/cam/event_loop.cpp | 31 +++++-\n> src/cam/event_loop.h | 11 +-\n> src/cam/main.cpp | 4 +\n> src/cam/main.h | 1 +\n> src/cam/meson.build | 21 ++++\n> src/cam/sdl_sink.cpp | 202 +++++++++++++++++++++++++++++++++++\n> src/cam/sdl_sink.h | 49 +++++++++\n> src/cam/sdl_texture.cpp | 37 +++++++\n> src/cam/sdl_texture.h | 29 +++++\n> src/cam/sdl_texture_mjpg.cpp | 25 +++++\n> src/cam/sdl_texture_mjpg.h | 17 +++\n> src/cam/sdl_texture_yuyv.cpp | 20 ++++\n> src/cam/sdl_texture_yuyv.h | 17 +++\n> 15 files changed, 469 insertions(+), 7 deletions(-)\n> create mode 100644 src/cam/sdl_sink.cpp\n> create mode 100644 src/cam/sdl_sink.h\n> create mode 100644 src/cam/sdl_texture.cpp\n> create mode 100644 src/cam/sdl_texture.h\n> create mode 100644 src/cam/sdl_texture_mjpg.cpp\n> create mode 100644 src/cam/sdl_texture_mjpg.h\n> create mode 100644 src/cam/sdl_texture_yuyv.cpp\n> create mode 100644 src/cam/sdl_texture_yuyv.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 267B8BD161\n\tfor ;\n\tMon, 23 May 2022 10:17:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8548A65661;\n\tMon, 23 May 2022 12:17:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 391C960416\n\tfor ;\n\tMon, 23 May 2022 12:17:27 +0200 (CEST)","from pendragon.ideasonboard.com (ip-109-40-241-50.web.vodafone.de\n\t[109.40.241.50])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C6503E4;\n\tMon, 23 May 2022 12:17:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653301048;\n\tbh=S0IqeqUDR8hMUzUGM8tkzk2lW6+2VQLpGvfaQeNEXu4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kV74WHRba+Hjr/GsOOyhUA9VMULPtP+ZvUbOQ/LHuS8Ys/4brb+4pSZkRXKiacm6T\n\txE3SVuBHXipLFbMUpeXbBWOdZOx7N2k0R7K1PSPHQPX08/mahZCIzt4ZO2BRC4UXEw\n\t1p3NYj7Htq7+FT0IwhZeWBk4K+M0XEXJ2rj4DFVFT00C1FC/dEKfzhwjklhuZZaDCC\n\tIdCgrHHkQSbeJUubV/+/XTo2C69RQMywN9UjOgpN76uL0W0YVJ01VTzx2PV074rI37\n\tPeG/Mks3dRNG92yPRPBE5v2wjzqgTmk24uYWmpnJ/T/i5Z/nV4BdnvngyVzybup8CC\n\ttX2XC7vn2oCuA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653301046;\n\tbh=S0IqeqUDR8hMUzUGM8tkzk2lW6+2VQLpGvfaQeNEXu4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=esUP+Q2QBxMZbu+Z6m5Y+gMWj9sOBlYnio81CeWFyvhtIb78b5+nhS5JgfacklylI\n\td36KXaYSZPGfVydToW5D/Fs3VyGvq3L7/i9GzTLjoTrIjFiVIMYYOiDG0ir7QAqLJZ\n\tTuLGGYx6omP/bsf3OkSlhMnZi20714sXjGXCnnUw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"esUP+Q2Q\"; dkim-atps=neutral","Date":"Mon, 23 May 2022 13:17:21 +0300","To":"Eric Curtin ","Message-ID":"","References":"<20220520190106.425386-1-ecurtin@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220520190106.425386-1-ecurtin@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH v9 0/4] Add SDL Sink","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]