[{"id":22958,"web_url":"https://patchwork.libcamera.org/comment/22958/","msgid":"<210f0e07-4b6a-2968-4f97-84665ca75181@ideasonboard.com>","date":"2022-05-16T15:48:02","subject":"Re: [libcamera-devel] [PATCH 00/14] Misc Python bindings patches","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 16/05/2022 17:10, Tomi Valkeinen wrote:\n> Hi,\n> \n> Smallish Python bindings patches doing cleanups, fixes and a few small\n> features.\n\nThis seems to be missing meson changes to install the new files. I'll \nadd that to v2.\n\n Tomi\n\n> Tomi\n> \n> Tomi Valkeinen (14):\n> py: meson: fix comment about stubs\n> py: meson: add pystubs build target\n> py: pymain: fix indent\n> py: unittests: fix selector fd use\n> py: unittests: verify that cam and cm are freed\n> py: unittests: make typechecker happy\n> py: cam.py: exit on exception\n> py: move conversion funcs to libcamera.utils\n> py: conv.py: minor cleanups\n> py: implement PixelFormat class\n> py: add geometry classes\n> py: use geometry classes\n> py: cam_kms: support multiplanar formats\n> py: cam_kms: fix multistream display\n> \n> src/py/cam/cam.py | 34 +++--\n> src/py/cam/cam_kms.py | 31 ++---\n> src/py/cam/cam_qt.py | 200 +----------------------------\n> src/py/cam/cam_qtgl.py | 20 +--\n> src/py/cam/gl_helpers.py | 8 --\n> src/py/libcamera/meson.build | 22 +++-\n> src/py/libcamera/pygeometry.cpp | 104 +++++++++++++++\n> src/py/libcamera/pymain.cpp | 90 ++++++-------\n> src/py/libcamera/utils/__init__.py | 4 +\n> src/py/libcamera/utils/conv.py | 160 +++++++++++++++++++++++\n> test/py/unittests.py | 28 ++--\n> 11 files changed, 392 insertions(+), 309 deletions(-)\n> create mode 100644 src/py/libcamera/pygeometry.cpp\n> create mode 100644 src/py/libcamera/utils/__init__.py\n> create mode 100644 src/py/libcamera/utils/conv.py\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4428EC3256\n\tfor ;\n\tMon, 16 May 2022 15:48:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C65F6565A;\n\tMon, 16 May 2022 17:48:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 380EF61FB8\n\tfor ;\n\tMon, 16 May 2022 17:48:06 +0200 (CEST)","from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6849848F;\n\tMon, 16 May 2022 17:48:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652716090;\n\tbh=PCFqa++GNqbRP4H/j4KDFxXClr5gG9lrJEuRojblFB8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QENuDAwUPMYAcRmOB9TBk4G+zX0bxF9aBBkgawW5Xzng2QW8/1VAcuUaPRqAPabKX\n\tWPyKK07b8kTJBL4KV1oMEPvuZ3CAokdwVC2PC32LDdcbPaDm77dtvz28GYYgGEJ+fx\n\tnZkTtBTeyeLHwRmRGrD2yB7VaZYACe5SDWx8wWx4nms7mzLjmlmrlvVzAzjpKX61Wv\n\tGMV/Xrcdfckj8j29hI/AJNU1bPPSC5s62MRERA+3tNnTHF1ijVKYLChG8hUaHVd6eQ\n\t3cTm+U8rbwsu/qb77CJ+fG2BHbW6QfT6mY2/B/aKYCD2E0fyfFXo/YlaTN2RucG6Cq\n\tsmWc4Dg9YuuBQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652716085;\n\tbh=PCFqa++GNqbRP4H/j4KDFxXClr5gG9lrJEuRojblFB8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=o3R1plqI3VtWJ+bKRRWD510YhwgV4MmFDMRPuXfi48bsvUlrrDJQ27FIARkC1+WhH\n\tq/2N5WSPPMIxPRwzPqSb8Pl2yXSUMUNj7cBI6L4xrgWwOOysDqQm1igcr05MTMCkon\n\tpWPciVof2xOrJePLbesgs5zpnRIypilR85HPUZzQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o3R1plqI\"; dkim-atps=neutral","Message-ID":"<210f0e07-4b6a-2968-4f97-84665ca75181@ideasonboard.com>","Date":"Mon, 16 May 2022 18:48:02 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>","In-Reply-To":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 00/14] Misc Python bindings patches","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22979,"web_url":"https://patchwork.libcamera.org/comment/22979/","msgid":"","date":"2022-05-17T08:45:47","subject":"Re: [libcamera-devel] [PATCH 00/14] Misc Python bindings patches","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the series.\n\nOn Mon, May 16, 2022 at 06:48:02PM +0300, Tomi Valkeinen wrote:\n> On 16/05/2022 17:10, Tomi Valkeinen wrote:\n> > Hi,\n> > \n> > Smallish Python bindings patches doing cleanups, fixes and a few small\n> > features.\n> \n> This seems to be missing meson changes to install the new files. I'll \n> add that to v2.\n\nThe series looks quite good overall. If more discussions are needed for\npatch 08/14, could you move it and 09/14 to the end of the series in v2\nso that the rest can be merged already ?\n\n> > Tomi Valkeinen (14):\n> > py: meson: fix comment about stubs\n> > py: meson: add pystubs build target\n> > py: pymain: fix indent\n> > py: unittests: fix selector fd use\n> > py: unittests: verify that cam and cm are freed\n> > py: unittests: make typechecker happy\n> > py: cam.py: exit on exception\n> > py: move conversion funcs to libcamera.utils\n> > py: conv.py: minor cleanups\n> > py: implement PixelFormat class\n> > py: add geometry classes\n> > py: use geometry classes\n> > py: cam_kms: support multiplanar formats\n> > py: cam_kms: fix multistream display\n> > \n> > src/py/cam/cam.py | 34 +++--\n> > src/py/cam/cam_kms.py | 31 ++---\n> > src/py/cam/cam_qt.py | 200 +----------------------------\n> > src/py/cam/cam_qtgl.py | 20 +--\n> > src/py/cam/gl_helpers.py | 8 --\n> > src/py/libcamera/meson.build | 22 +++-\n> > src/py/libcamera/pygeometry.cpp | 104 +++++++++++++++\n> > src/py/libcamera/pymain.cpp | 90 ++++++-------\n> > src/py/libcamera/utils/__init__.py | 4 +\n> > src/py/libcamera/utils/conv.py | 160 +++++++++++++++++++++++\n> > test/py/unittests.py | 28 ++--\n> > 11 files changed, 392 insertions(+), 309 deletions(-)\n> > create mode 100644 src/py/libcamera/pygeometry.cpp\n> > create mode 100644 src/py/libcamera/utils/__init__.py\n> > create mode 100644 src/py/libcamera/utils/conv.py","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A142C3256\n\tfor ;\n\tTue, 17 May 2022 08:45:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D6826565C;\n\tTue, 17 May 2022 10:45:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 02D5460420\n\tfor ;\n\tTue, 17 May 2022 10:45:54 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64B1F48F;\n\tTue, 17 May 2022 10:45:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652777156;\n\tbh=5YhmSJUKUQ2DQGBcejzo3UDWo5egg9Uv8cJLUqNMMgc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qYMKJ2hB45TXnGzmQIE6RhLAn3lwhmJkJC4U3tRwfCms/aVLaJ0FCPQmsUBjshxiE\n\tTgEmvitsaByMm7SA4hY2BZ/tBMvmA5i5o8+0LpuABRCP7j3icUnsgTciSZXP3+jzgi\n\tKgOk1UprsH/oMuiWdpCXzhnG3adCYtCjIbna4oMg1hLCk+UFsyGHxTru6Q8qeStayl\n\t5V2bvJHRfmdxDL5nRY23DePNCKclnYKkzcdyq+vxQzvB157pwW0TixRavssvYJeE7i\n\tBBodtE4qxco7EH+sE0lux8KGwLEGaGapakcGJJ7/LZGfJUVcAm+x7QfDWwWYD+uLO2\n\tUFu2m4eleLPxw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652777154;\n\tbh=5YhmSJUKUQ2DQGBcejzo3UDWo5egg9Uv8cJLUqNMMgc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=v0a5NVFSxjkwR+QLmoLKcoK/bELL5AcWcZifxj2vHOded1AG3HPLjtkXtP+8o2VbC\n\thWw2S4UXjOVRtbsFUtHuTaIBdaYZ+jku/KjWWNdZ1vXKSYRXsOJhiDXlZVDyD8NnX0\n\tUSVuvThJRlPs9Pfu6t1aaeLyvLDftMMgo2sCmXmI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"v0a5NVFS\"; dkim-atps=neutral","Date":"Tue, 17 May 2022 11:45:47 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>\n\t<210f0e07-4b6a-2968-4f97-84665ca75181@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<210f0e07-4b6a-2968-4f97-84665ca75181@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 00/14] Misc Python bindings patches","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]