[{"id":22923,"web_url":"https://patchwork.libcamera.org/comment/22923/","msgid":"","date":"2022-05-10T07:59:35","subject":"Re: [libcamera-devel] [PATCH v3 0/2] Application support for\n\tper-mode sensitivities","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nOn Thu, 21 Apr 2022 at 16:11, Naushir Patuck wrote:\n\n> Hi,\n>\n> This is a continuation of David's work. As per the discussion on the v2\n> patch\n> set, I've changed things around to use the camera properties to pass out\n> the\n> sensitivities to the application instead of a new field in\n> CameraConfiguration.\n>\n> I've also removed all R-B tags to allow a fresh review.\n>\n> Regards,\n> Naush\n>\n> David Plowman (1):\n> libcamera: raspberrypi: Fetch correct value for SensorSensitivity\n>\n> Naushir Patuck (1):\n> libcamera: Add a SensorSensitivity property\n>\n> include/libcamera/ipa/raspberrypi.mojom | 7 ++++++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 7 +++++--\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++++----\n> src/libcamera/property_ids.yaml | 12 ++++++++++++\n> 4 files changed, 31 insertions(+), 7 deletions(-)\n>\n\nGentle ping. This series needs one more R-B tag.\n\nRegards,\nNaush\n\n\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2071FC3256\n\tfor ;\n\tTue, 10 May 2022 07:59:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6A1B65646;\n\tTue, 10 May 2022 09:59:53 +0200 (CEST)","from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E89ED6563E\n\tfor ;\n\tTue, 10 May 2022 09:59:52 +0200 (CEST)","by mail-lj1-x234.google.com with SMTP id m23so19884528ljb.8\n\tfor ;\n\tTue, 10 May 2022 00:59:52 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652169593;\n\tbh=zFSlLYEq+b023Cid1M8+w4szLiTyuLjz1Ybe/g+LQQk=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qYysFemOuPa4aTx+GZqYNH+7Rss5WsFOHQoQvQ9p4FOzLqbjFL3AZ+Hnl2NbyOGrB\n\tBvyj1jDVYhlh0Zv3mECiJxegQJWBgyIiFXw8Ns2uY4Ycn0YsoocuTLIQM2GXCzdthK\n\tiOG+pDLyI7bdUwGQF57FQw8hQ6xdeToZauJ+2/hI283/EEKLSbz5Dcq47gVqvic0Lo\n\tc3NngSBWj7nfVKRV2rZzc5R1mSfvj56+Th9GYQbN5NJWUlETZKuhpa4ed5XfOQucVy\n\tTre7ZQuqnvWBJkGsDNa3EEJ9v1gtmDxkOQ3gjddfQFM54j+5F9E+nbrbJclecZk7sO\n\t7B1OXKyp4Z3yw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=mFa6CyUVUvsOXE1UxL7xrqeBiKFJv/ZrORpphxoyWLo=;\n\tb=K++wNkpYoNlBe2di64NOShRVt5wsAyTt20sHnVMajEUL5r1Iy+cuNMj+WOgrr1aXS7\n\t6S2CgDsZzQgsxmOzKnY6x3xL7N7zkZ1ZJRLz0+g/20zzhXfABvJP2AJkHNRdlSvvIodb\n\ty+soRl4/S452C9HgtYfXmd2Alp/6dF5qxNcW5Pa+gL6IDWLQAPJk+qTKnen2DNJmYUQs\n\tSkI5j3iHcrJBs4cyF+VUFtP2ZVvkq/Hr4Q47CKdgAuHBhemKv0LJoHaxFGPKvLx8vD9E\n\tTWcSXH2ojq2KnGWGNoz5faiMXhjUnQl/anHo1rEO6vunaju+LrXJnug5BrF2fk2U9rcR\n\tjRAw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"K++wNkpY\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=mFa6CyUVUvsOXE1UxL7xrqeBiKFJv/ZrORpphxoyWLo=;\n\tb=A+LlRZHvEOEHINSYhByu1svmajSRgx2VfUVjzjr1maGB731Uj9hWpcNrcz9vM8KAzU\n\tL+i4k6aHxLe3d3In07W8a5/ENGPvx5kkWROrRirWmZFCeO90QVh2VPmRE+d9vyrqEaMD\n\t32TkWjdYXS3cqd7bysLMqSY1AyR37sDB6jRW/M4vMUIUHvkw6ntOdn5VT7hnVjLN38kP\n\t0SCEXmItD4W8f0N2RAcDWEYJMGo3T1G3+NxENEFM748BWsonCS8bMt3wdfQSnddr/X+V\n\t0ZZhA+mG4P5laRBv2DPBlC7QJrPoUj3y/QIjFvirntXnHsWB1KEDLhDusb/m7CHGcC7v\n\tGbxw==","X-Gm-Message-State":"AOAM533nCjTsQy/bGjkREs2rynFbaoYcfcgCHaSP5SQNQwlKK8FjAWdC\n\tU9e4XOe7c4ECtgqLxdLCQp6DzHUb2AhrskMfwM86oswTDoY=","X-Google-Smtp-Source":"ABdhPJy5H473Xf/RCQww3h5xWohHcpZizjGbHgxlfu0nJyLXjRMlVUxw7YIP1SMhIRUcuxNfegyFo9A7GHZ9H54NbwM=","X-Received":"by 2002:a2e:3c0e:0:b0:24f:25ff:659f with SMTP id\n\tj14-20020a2e3c0e000000b0024f25ff659fmr13236833lja.426.1652169592167;\n\tTue, 10 May 2022 00:59:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20220421151117.703956-1-naush@raspberrypi.com>","In-Reply-To":"<20220421151117.703956-1-naush@raspberrypi.com>","Date":"Tue, 10 May 2022 08:59:35 +0100","Message-ID":"","To":"libcamera devel ","Content-Type":"multipart/alternative; boundary=\"000000000000a6716905dea3b54c\"","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] Application support for\n\tper-mode sensitivities","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22928,"web_url":"https://patchwork.libcamera.org/comment/22928/","msgid":"<20220510094055.wkw5nnwrevtw6mtb@uno.localdomain>","date":"2022-05-10T09:40:55","subject":"Re: [libcamera-devel] [PATCH v3 0/2] Application support for\n\tper-mode sensitivities","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Naush, Kieran,\n\nOn Tue, May 10, 2022 at 08:59:35AM +0100, Naushir Patuck via libcamera-devel wrote:\n> Hi,\n>\n> On Thu, 21 Apr 2022 at 16:11, Naushir Patuck wrote:\n>\n> > Hi,\n> >\n> > This is a continuation of David's work. As per the discussion on the v2\n> > patch\n> > set, I've changed things around to use the camera properties to pass out\n> > the\n> > sensitivities to the application instead of a new field in\n> > CameraConfiguration.\n> >\n> > I've also removed all R-B tags to allow a fresh review.\n> >\n> > Regards,\n> > Naush\n> >\n> > David Plowman (1):\n> > libcamera: raspberrypi: Fetch correct value for SensorSensitivity\n> >\n> > Naushir Patuck (1):\n> > libcamera: Add a SensorSensitivity property\n> >\n> > include/libcamera/ipa/raspberrypi.mojom | 7 ++++++-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 7 +++++--\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++++----\n> > src/libcamera/property_ids.yaml | 12 ++++++++++++\n> > 4 files changed, 31 insertions(+), 7 deletions(-)\n> >\n>\n> Gentle ping. This series needs one more R-B tag.\n\nI haven't followed the discussion in detail, but the patches look sane\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Regards,\n> Naush\n>\n>\n> >\n> > --\n> > 2.25.1\n> >\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAB27C0F2A\n\tfor ;\n\tTue, 10 May 2022 09:40:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E24F65641;\n\tTue, 10 May 2022 11:40:59 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61FDA6563E\n\tfor ;\n\tTue, 10 May 2022 11:40:57 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id DBC33FF811;\n\tTue, 10 May 2022 09:40:56 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652175659;\n\tbh=z6if/3DssWoEgnQrY7V0jVIjsplKEIG5xC88RFsg1mk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=AtSB9hGFg7Csae+FNNNzhXalu3s4Fk4bZIpBu69mF0cgkoLWb7QipLT1vygy4YDNc\n\tLOCViSmubEH749cye/xXradksCW5gHDiPjh+gF8H3SmM2soXXCHu6cEVLoNpc089oW\n\tmYhrApMPJ+WFR6os5aI3V7oJmifiYRG7fMSR2kz3wQNCEcsLz5OdfL7hPqLqD1feoK\n\t5mBaYaCezfHwk8iQHRrxqMhL2JjWROEfDbw2JuxNKViJHgWKoico6IW1hkDBTUu1+l\n\t1C43cGk25xu6XO33+Uhp8NrHj/7NZGds9amJp07Q/yW7s7MxalU1EDJtCqGH0ZY7lo\n\tIDIMeUH/b/18Q==","Date":"Tue, 10 May 2022 11:40:55 +0200","To":"Naushir Patuck ","Message-ID":"<20220510094055.wkw5nnwrevtw6mtb@uno.localdomain>","References":"<20220421151117.703956-1-naush@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] Application support for\n\tper-mode sensitivities","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]