[{"id":22763,"web_url":"https://patchwork.libcamera.org/comment/22763/","msgid":"<20220421093054.cpxpchjumgslomyt@uno.localdomain>","date":"2022-04-21T09:30:54","subject":"Re: [libcamera-devel] [PATCH v3 0/1] AF controls","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Wed, Apr 20, 2022 at 05:26:21PM +0100, David Plowman wrote:\n> Hi everyone\n>\n> Changes in v3:\n>\n> * The controls have all been \"un-draft-ified\". I've moved them all up\n> the file to the non-draft section.\n>\n> * We had a discussion about having a \"custom\" range, but I think the\n> conclusion for the moment was not to add it. Please correct me if\n> I'm wrong there.\n\nI think it's fine for now. we can add it on top and leave it out to\nreduce the discussions and fast track this version.\n\n>\n> * The AfLensPosition control has gone. Instead LensPosition is defined\n> to use a scaled \"dioptre-like\" kind of unit (hyperfocal distance\n> divided by focal distance), so that 0 = infinity, 1 = hyperfocal,\n> bigger numbers = closer.\n>\n> * The AfState has been reduced to just\n> reset/scanning/focused/failed. It is expected that AfMode will be\n> reported on every frame, and also the new AfPauseState which says\n> whether CAF is running/pausing/paused.\n>\n> * I note that there's still some discussion elsewhere about the units\n> for defining AF regions, and whether they need to have associated\n> weights.\n>\n> * I haven't carried any tags over for now, I think things are still at\n> a stage where everyone needs to review the changes, if that's OK!\n>\n> The state transition diagram is cosmetically updated, but not\n> materially different. It should be in the same place, but in case\n> you've lost the link:\n> https://docs.google.com/drawings/d/1rU2nS82dEC8Y2eY0lKPkQQhd67gKLOl7PvSeUcL1j_E/edit?usp=sharing\n>\n> Thanks!\n> David\n>\n> David Plowman (1):\n> libcamera: controls: Controls for driving AF (autofocus) algorithms\n>\n> src/libcamera/control_ids.yaml | 318 ++++++++++++++++++++++++++-------\n> 1 file changed, 258 insertions(+), 60 deletions(-)\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7654C3256\n\tfor ;\n\tThu, 21 Apr 2022 09:30:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1714C65644;\n\tThu, 21 Apr 2022 11:30:59 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D981604AD\n\tfor ;\n\tThu, 21 Apr 2022 11:30:57 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id E0B1BE0009;\n\tThu, 21 Apr 2022 09:30:55 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650533459;\n\tbh=ePSDphXYZMggtDNVDIlM2q3NOSe09BVpCieLyCdR4j4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VAt9+WKNdmlU3TNowWKe+cMnpxuzK9NfNfBxbGt9p2TITXKIHDOV4awetZeMjABSa\n\tQ8AYNYsdi6MlTJvI+hvCQp1UKlXNAoSmwP/7Vtj7yjaUz9pqY9S9TRA4hYqPPCCykM\n\toe+NrrV8ljYmaSNVx4qZQJReZi4hxXiVL7RdGa3GoBpeBCbYnhg9rzeKTtTKdvZuBQ\n\taPcqsaxjrhxh1giMSEGVv7+BezjbmUrM5PwAaKEvXcDpjJtErkOEsjx1UuIAd8Xl+v\n\tLQPoJxSNPdzs+6VKeCRZq0AZOiu0BTgMH6cY2dyh6fYLTa48bTLcTcfy0tqzt1nMr1\n\t6N+0K4xaKFAsQ==","Date":"Thu, 21 Apr 2022 11:30:54 +0200","To":"David Plowman ","Message-ID":"<20220421093054.cpxpchjumgslomyt@uno.localdomain>","References":"<20220420162622.16521-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220420162622.16521-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 0/1] AF controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]