[{"id":22757,"web_url":"https://patchwork.libcamera.org/comment/22757/","msgid":"","date":"2022-04-20T08:12:24","subject":"Re: [libcamera-devel] [PATCH v3 0/2] Introduce YamlParser YAML files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Han-Lin,\n\nOn Mon, Apr 18, 2022 at 08:09:21PM +0800, Han-Lin Chen via libcamera-devel wrote:\n> Hi,\n> The series is a subset of the previous series for configuration files,\n> which moves the YamlParser related patches as the separate series.\n> \n> Many thanks for previous comments.\n> \n> Comparing to V2:\n> 1. Correct the error handling for strtol, strtod and strtoul.\n> \n> Han-Lin Chen (2):\n> libcamera: Introduce YamlParser as a helper to parse yaml files\n> android: camera_hal_config: Use YamlParser to parse android HAL config\n\nSomething I forgot to mention, a unit test would be good :-) Code\nwithout unit tests is bound to get broken quickly.\n\n> README.rst | 4 +-\n> include/libcamera/internal/meson.build | 1 +\n> include/libcamera/internal/yaml_parser.h | 86 +++\n> src/android/camera_hal_config.cpp | 334 +++-------\n> src/android/meson.build | 1 -\n> src/libcamera/meson.build | 3 +\n> src/libcamera/yaml_parser.cpp | 802 +++++++++++++++++++++++\n> 7 files changed, 968 insertions(+), 263 deletions(-)\n> create mode 100644 include/libcamera/internal/yaml_parser.h\n> create mode 100644 src/libcamera/yaml_parser.cpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19AA9C3256\n\tfor ;\n\tWed, 20 Apr 2022 08:12:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6272565645;\n\tWed, 20 Apr 2022 10:12:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0124F604AE\n\tfor ;\n\tWed, 20 Apr 2022 10:12:22 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61DAD5D;\n\tWed, 20 Apr 2022 10:12:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650442344;\n\tbh=pyVEwhE12RLwRTCAEvFIo0cqvJCByAca4oNweZvuTT4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=btuHNog7BkcpV5fWSqYFPmGwhkzp7JsFZs6G4r9rI+76cxSUp/wb+2QpkDwVR/Ccs\n\tzQaHRLRC0eV1oNXj3mpeGr4lpTYAz/Dp5TKuSH8V1o3ITAyUUefaEBdBF1cY469LV9\n\tcZbuIXJPiP0du6X6U28Y5gk5tOm/5Bx9GOuLUEqKPJAtDjFrFfhEl7Z7LyfaMp78Xc\n\tqUH/egzgy6tpdmVQkqAsElpMag1e2hMEA0xbReMYHtDQP7tKVmkb7gWlK3HCLbP9E5\n\tpbaEoFMCWrjWOpgKuHWRzaz/NNbBkwGTElCwqHJuHPW2V4vYmYhLRfW8J9K2FxTpfY\n\tqblDR5XoawJrA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650442342;\n\tbh=pyVEwhE12RLwRTCAEvFIo0cqvJCByAca4oNweZvuTT4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KwAzDo77MhfDETWgw+uLMfxShCmtTkqqSjG787pE3N3U+UVJ8VMGafGg8sN46PoyJ\n\tWGs5Jw7NHQf4ub53sY6wI4tQMiCZzmWyAD8a8JIucFCZvUf1vB9+DGkSgqrbUO+aa2\n\tQS1G0rMx8dEP0h9tqj9oHNDzhcJSCFX2hjVdhefs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KwAzDo77\"; dkim-atps=neutral","Date":"Wed, 20 Apr 2022 11:12:24 +0300","To":"Han-Lin Chen ","Message-ID":"","References":"<20220418120923.453131-1-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220418120923.453131-1-hanlinchen@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] Introduce YamlParser YAML files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]