[{"id":22474,"web_url":"https://patchwork.libcamera.org/comment/22474/","msgid":"","date":"2022-03-27T23:13:36","subject":"Re: [libcamera-devel] [PATCH v5 0/8] Raspberry Pi: Efficient\n\tstart/stop/start sequences","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Fri, Mar 25, 2022 at 09:08:55AM +0000, Naushir Patuck via libcamera-devel wrote:\n> Hi,\n> \n> Version 5 of this series changes the following:\n> \n> - In patch 6/8 use -ESHUTDOWN instead of -EPERM.\n> - In patch 6/8 reference the function directly in the doxygen comments.\n> \n> Patch 6/8 needs one more R-B tag, then this series should be ready for merging.\n\nThe series is now fully reviewed. If you agree with my review of 5/8 I\ncan update that patch when applying.\n\n> Naushir Patuck (8):\n> pipeline: raspberrypi: Avoid over-allocation for ISP Output 1\n> pipeline: raspberrypi: Move freeBuffers() to the RPiCameraData class\n> pipeline: raspberrypi: Free buffers in the RPiCamera destructor and\n> re-configure\n> pipeline: raspberrypi: Repurpose RPi::Stream::reset()\n> libcamera: v4l2_videodevice: Better tracking of the device state\n> libcamera: v4l2_videodevice: Do not allow buffer queueing in stopping\n> state\n> libcamera: v4l2_videodevice: Empty the V4L2 buffer cache on\n> streamOff()\n> test: Test V4L2BufferCache::isEmpty() member function\n> \n> include/libcamera/internal/v4l2_videodevice.h | 4 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 56 ++++++++++++-------\n> .../pipeline/raspberrypi/rpi_stream.cpp | 13 ++---\n> .../pipeline/raspberrypi/rpi_stream.h | 2 +-\n> src/libcamera/v4l2_videodevice.cpp | 34 +++++++++--\n> test/v4l2_videodevice/buffer_cache.cpp | 36 ++++++++++++\n> 6 files changed, 112 insertions(+), 33 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A73A9C0F1B\n\tfor ;\n\tSun, 27 Mar 2022 23:13:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5BE3165631;\n\tMon, 28 Mar 2022 01:13:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 468F3600B0\n\tfor ;\n\tMon, 28 Mar 2022 01:13:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1E7C2F7;\n\tMon, 28 Mar 2022 01:13:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648422819;\n\tbh=FbtIZKgguJZn0iztwvCVMpq85iMnFmfgwS/n8D4mw2Y=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PTPyoLGqYPuVcrru1kEt2F4HOBQ3+5RpH84Pfh9Rwaf8sZAMBg0MJic2D4L0aA6td\n\t+mkzx7j3bfa82VzcAr1GEaCk+8uQfbSFjXqabvVBMRksTSkxxqFgXRK1jh3Ni/BdiC\n\tUwdDa8UzrXuMbpEdD6Fec3ozNDuv5KAz3rI+H2QLfIy9a/47hkQwwvf63/RxjAfh0J\n\tKjZnOQMhELbJw4T6RaDc1puwQIS/oYUtOl89SFwsThdO3FkD413gvf6fozdmY/nVCP\n\tcaR4tv9e4quxUC4JId97TTY6vgqxzhCQhqbrqtThJ3W+tOjLD23l+phn24OXe6xqRO\n\tZxFoBhiJs+IcA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648422818;\n\tbh=FbtIZKgguJZn0iztwvCVMpq85iMnFmfgwS/n8D4mw2Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hGGxrlItnyZFexeze1Do8BVgHcRWm++aZGJElNkABnFJ+kQ8aAE20WdgE4WOhBBHC\n\tMi09FhZwWDrH//5odmem3TSyiFoO+msoZvRXIS0w3Gqn3cDmmC+r8qdb8WksATr4fE\n\toBbRibiwcVamnr4h5WJvkZVWZL37vqFbzQRQqOUQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hGGxrlIt\"; dkim-atps=neutral","Date":"Mon, 28 Mar 2022 02:13:36 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220325090903.880311-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220325090903.880311-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 0/8] Raspberry Pi: Efficient\n\tstart/stop/start sequences","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22475,"web_url":"https://patchwork.libcamera.org/comment/22475/","msgid":"","date":"2022-03-28T07:22:42","subject":"Re: [libcamera-devel] [PATCH v5 0/8] Raspberry Pi: Efficient\n\tstart/stop/start sequences","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThanks for the feedback!\n\nOn Mon, 28 Mar 2022 at 00:13, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> On Fri, Mar 25, 2022 at 09:08:55AM +0000, Naushir Patuck via\n> libcamera-devel wrote:\n> > Hi,\n> >\n> > Version 5 of this series changes the following:\n> >\n> > - In patch 6/8 use -ESHUTDOWN instead of -EPERM.\n> > - In patch 6/8 reference the function directly in the doxygen comments.\n> >\n> > Patch 6/8 needs one more R-B tag, then this series should be ready for\n> merging.\n>\n> The series is now fully reviewed. If you agree with my review of 5/8 I\n> can update that patch when applying.\n>\n\nOops, sorry I forgot to add those changes to my last revision.\nI'm happy with your suggestions, so feel free to update when applying :-)\n\nRegards,\nNaush\n\n\n>\n> > Naushir Patuck (8):\n> > pipeline: raspberrypi: Avoid over-allocation for ISP Output 1\n> > pipeline: raspberrypi: Move freeBuffers() to the RPiCameraData class\n> > pipeline: raspberrypi: Free buffers in the RPiCamera destructor and\n> > re-configure\n> > pipeline: raspberrypi: Repurpose RPi::Stream::reset()\n> > libcamera: v4l2_videodevice: Better tracking of the device state\n> > libcamera: v4l2_videodevice: Do not allow buffer queueing in stopping\n> > state\n> > libcamera: v4l2_videodevice: Empty the V4L2 buffer cache on\n> > streamOff()\n> > test: Test V4L2BufferCache::isEmpty() member function\n> >\n> > include/libcamera/internal/v4l2_videodevice.h | 4 +-\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 56 ++++++++++++-------\n> > .../pipeline/raspberrypi/rpi_stream.cpp | 13 ++---\n> > .../pipeline/raspberrypi/rpi_stream.h | 2 +-\n> > src/libcamera/v4l2_videodevice.cpp | 34 +++++++++--\n> > test/v4l2_videodevice/buffer_cache.cpp | 36 ++++++++++++\n> > 6 files changed, 112 insertions(+), 33 deletions(-)\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4C72C3256\n\tfor ;\n\tMon, 28 Mar 2022 07:23:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 329456559A;\n\tMon, 28 Mar 2022 09:23:01 +0200 (CEST)","from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com\n\t[IPv6:2a00:1450:4864:20::12a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 432B5604BF\n\tfor ;\n\tMon, 28 Mar 2022 09:22:59 +0200 (CEST)","by mail-lf1-x12a.google.com with SMTP id h7so23153815lfl.2\n\tfor ;\n\tMon, 28 Mar 2022 00:22:59 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648452181;\n\tbh=y2rSXnk6mDw5UbEA+Y7wAJyFTaaBuUmG2vXd0ROeWBc=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mX58Bpe6R61CTKJcF4qe0S6RbHstuXO0XBwIiI+fHxBj921PDmyS330daIIpzNWOz\n\tbZIqbLo+V3JQQNeLP4RIZZT5FU8w0bLCB0+BgkQ0mOv6zJCFyhhtoEetDb9MowUtCc\n\tOLtaG5l25SVaZKOaoexjeuHCpWxTNMC9kPnP+YYU2nFJc0lAA1B2vAMIryVWSeqyS8\n\tM4UcwFlFFYYHAzS3UijTRQAx92rPcwX4AZLkPdUKJ1F/QVR5aJyBlm4aENZd+MWNuk\n\t4RGGOKMYjFqGvGM6X5fGhL2Few+OMPzHDAchod+ks0Ui1SRvzhIByXJHa4Jox9ZFhQ\n\t3JMXOelpkmi1Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=df5Su7Wm/vM4H5f25MHKgh7nmTh9gwxpBeuBOzutV3Y=;\n\tb=OPQaQmXyD6sp/GLMlcAR3XDMfik/S5NXzK9TvnIl58UfBwLmUjA4VWHdFUpPXRqZ9S\n\tiAhcvfkVbhlgtRzVDh4IPf8JHtwu9RkqU8W1tpcfPtz1yTTGJbGlo8VLmwJjDHYO8JIy\n\tFmYUk6gqSzzbcJzjSl8NG/C/7UhMK+8xjAm+1xPVIJTEQrRaDUa3qe0KO2P1ikqqlGvN\n\tz9sK48oOGbDjcRScTpUjPkigOjCLkN7WXJUpYlOLBh+5JbNjUV7B4FrNr3mnmrcT0AA1\n\tuR31fDMCPCCGgigha8tVhpdOXjYmeqv30Ic6702XSIYFOSDZQZ2o935QEADgQYL1iwze\n\tSWqw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"OPQaQmXy\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=df5Su7Wm/vM4H5f25MHKgh7nmTh9gwxpBeuBOzutV3Y=;\n\tb=gMNY3ohIuqF2KGiSDZ5Ri3qUROWcsb+sTFb/kqCVCKktgSNMQnYOfRc3ynzIs3PSBq\n\ttxHiLGKxiMPmIyeST778P0nmVAkDXk0ug2e5EayC+6e2Qx3ftJnmjH046+Y0IPbabQ+o\n\t5n+8M/9q7t0QxuDw0UOi+XEBV17koGracHHGXE8WM0eozwBvX+yV11f475EgU9BXhdtA\n\tkswLJUVW3ibXmaBUfpjEEO7RONJq07onqMa4e/5IcZAn33XyDf3hpEeGHckEMYBy3a92\n\tDIu8YJvc3Go538eP0LZC+19vRnzo//gqc3MRr3aPAexNcgHiVC0sbu1VSARgDNlYhUJO\n\tno6w==","X-Gm-Message-State":"AOAM531+Ls9+EXcQ69Mq6mp87O/PKXdqxSrRSy+RbAy8wsHMPUIAh/6b\n\tSznRvqoOA4nbXffEYng6DTus+n1IokaWjSNf5hyt9x35K3k=","X-Google-Smtp-Source":"ABdhPJw/pOpzluaClDr0KqCGu6pMOdn23mnG4GDkjrdIiLBPQ9nHyHiP6c3tgzVeaboAG0GsoREdRBu4RJ0tSPj8okg=","X-Received":"by 2002:a05:6512:1585:b0:448:3936:a5a0 with SMTP id\n\tbp5-20020a056512158500b004483936a5a0mr18314389lfb.108.1648452178415;\n\tMon, 28 Mar 2022 00:22:58 -0700 (PDT)","MIME-Version":"1.0","References":"<20220325090903.880311-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Mon, 28 Mar 2022 07:22:42 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"00000000000086202405db422e65\"","Subject":"Re: [libcamera-devel] [PATCH v5 0/8] Raspberry Pi: Efficient\n\tstart/stop/start sequences","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22476,"web_url":"https://patchwork.libcamera.org/comment/22476/","msgid":"","date":"2022-03-28T07:30:41","subject":"Re: [libcamera-devel] [PATCH v5 0/8] Raspberry Pi: Efficient\n\tstart/stop/start sequences","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Mon, Mar 28, 2022 at 07:22:42AM +0000, Naushir Patuck wrote:\n> On Mon, 28 Mar 2022 at 00:13, Laurent Pinchart wrote:\n> > On Fri, Mar 25, 2022 at 09:08:55AM +0000, Naushir Patuck via\n> > libcamera-devel wrote:\n> > > Hi,\n> > >\n> > > Version 5 of this series changes the following:\n> > >\n> > > - In patch 6/8 use -ESHUTDOWN instead of -EPERM.\n> > > - In patch 6/8 reference the function directly in the doxygen comments.\n> > >\n> > > Patch 6/8 needs one more R-B tag, then this series should be ready for merging.\n> >\n> > The series is now fully reviewed. If you agree with my review of 5/8 I\n> > can update that patch when applying.\n> \n> Oops, sorry I forgot to add those changes to my last revision.\n> I'm happy with your suggestions, so feel free to update when applying :-)\n\nDone, and pushed.\n\n> > > Naushir Patuck (8):\n> > > pipeline: raspberrypi: Avoid over-allocation for ISP Output 1\n> > > pipeline: raspberrypi: Move freeBuffers() to the RPiCameraData class\n> > > pipeline: raspberrypi: Free buffers in the RPiCamera destructor and\n> > > re-configure\n> > > pipeline: raspberrypi: Repurpose RPi::Stream::reset()\n> > > libcamera: v4l2_videodevice: Better tracking of the device state\n> > > libcamera: v4l2_videodevice: Do not allow buffer queueing in stopping\n> > > state\n> > > libcamera: v4l2_videodevice: Empty the V4L2 buffer cache on\n> > > streamOff()\n> > > test: Test V4L2BufferCache::isEmpty() member function\n> > >\n> > > include/libcamera/internal/v4l2_videodevice.h | 4 +-\n> > > .../pipeline/raspberrypi/raspberrypi.cpp | 56 ++++++++++++-------\n> > > .../pipeline/raspberrypi/rpi_stream.cpp | 13 ++---\n> > > .../pipeline/raspberrypi/rpi_stream.h | 2 +-\n> > > src/libcamera/v4l2_videodevice.cpp | 34 +++++++++--\n> > > test/v4l2_videodevice/buffer_cache.cpp | 36 ++++++++++++\n> > > 6 files changed, 112 insertions(+), 33 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F36A0C0F1B\n\tfor ;\n\tMon, 28 Mar 2022 07:30:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A35865631;\n\tMon, 28 Mar 2022 09:30:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6C0E604BF\n\tfor ;\n\tMon, 28 Mar 2022 09:30:43 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23AB92F7;\n\tMon, 28 Mar 2022 09:30:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648452645;\n\tbh=WWNvzOeywfSEtYCrhUMcm5n8/5tNnEmzF+b6TlBZ9l8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XEtRCRnz9ntjUj6smV2AsW5y8pjak+s84l65Nn9DSKgeLudUHsqlgD0QtigUviis1\n\tYF09NplReTj1ONAy5n2LcVuUYj14eAI1OMMZEjTfwJuwIQCoeqk8GAfsFvp4AORtOJ\n\tGtp0yIWm5EISpkG+CgQSaLg5RvvsDzPNGn6GH+0ob0GfZZFdzFZQkwLsQW/M6Dw7wG\n\t52dM6ZDzPRnANVZIOsoNb0QaEzOROgHicZ7iXS8cCCOlciyxNd/xm/O+pgO6HBzTyi\n\tIDJM58rg3kA9xZkEzrrLEeSJtcJWTGEJy1ICgJwqjvK4xAdWzh6gs+kCnWtsp9sYtG\n\tnrcyziMmbE41A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648452643;\n\tbh=WWNvzOeywfSEtYCrhUMcm5n8/5tNnEmzF+b6TlBZ9l8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r/5OduAcCpd6q/xavqmshWuO9nAE4S6KS7pbj0ZJX52jR6vG+GEINTyy4MEnJ1KP9\n\tqpK+jiUoDEcCDJTtZXDNXpwS6eBu8y1YzNcziIkyDDKGD7Eq/s2beXBk6y8J+6nNty\n\tTZ3EFnXhCGhD+5SLMTGDUkZpdbY4m+u7LP6jfa1Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r/5OduAc\"; dkim-atps=neutral","Date":"Mon, 28 Mar 2022 10:30:41 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220325090903.880311-1-naush@raspberrypi.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v5 0/8] Raspberry Pi: Efficient\n\tstart/stop/start sequences","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]