[{"id":22529,"web_url":"https://patchwork.libcamera.org/comment/22529/","msgid":"","date":"2022-03-30T09:10:48","subject":"Re: [libcamera-devel] [PATCH 0/1] AF controls","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi David !\n\nOn 10/03/2022 13:05, David Plowman via libcamera-devel wrote:\n> Hi everyone\n> \n> Here is a first non-RFC version of the proposed AF (autofocus)\n> controls.\n> \n> There's been quite a bit of discussion already at the RFC stage, most\n> notably the introduction of a manual mode, aimed at making integration\n> with Android easier, and an explicit control for pausing CAF\n> (continuous autofocus). I also removed the AfMethod control as it\n> seems redundant, though I still wonder slightly if some platforms\n> might have alterative ways of handling multi-spot AF.\n> \n> It's quite possible that I've forgotten to incorporate some\n> suggestions that were made previously in which case I apologise -\n> please point them out to me again!\n> \n> Further suggestions and discussion are of course most welcome!\n\nDo you know when you may be able to send a v2 ?\nI really would like to see it integrated quickly now, and I am sure we \nare not very far from it :-).\n\nThanks !\nJM\n\n> \n> Thanks and best best regards\n> \n> David\n> \n> David Plowman (1):\n> libcamera: controls: Controls for driving AF (autofocus) algorithms\n> \n> src/libcamera/control_ids.yaml | 271 +++++++++++++++++++++++++--------\n> 1 file changed, 211 insertions(+), 60 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 052DCC3256\n\tfor ;\n\tWed, 30 Mar 2022 09:10:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4053F65634;\n\tWed, 30 Mar 2022 11:10:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 715D960397\n\tfor ;\n\tWed, 30 Mar 2022 11:10:52 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:7546:d5f3:89b2:3025] (unknown\n\t[IPv6:2a01:e0a:169:7140:7546:d5f3:89b2:3025])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0794659D;\n\tWed, 30 Mar 2022 11:10:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648631454;\n\tbh=swXXXRFj8cq58ZZ30a4gHMAC5StwbLpBkLBz+UTp+jA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=4I6JebC2PmfGgoVf1jk83hohSK/DaVpFq8DgAQbNXsBstvLMRY2sh6/LMKs6KBQR7\n\t4w52LwIkIw42Hus20u5hf+DG3NxmT8BbL+bLqTmBtSvstE9ejXP4xn0GHaokLDDK9S\n\tAUoTjkWSwEZNgYX5FAGe21aSOOJlunStsMSrGe8e2LlDWUsyKZIlrOfZ3pCsshg/y3\n\tq34jOHwZhVnwgJ5NgyLQDPNRn6ntEunDPtSpx6K5XoVhilHgA7M8LQ/98lJ7YdrsVW\n\tA9Ow/DVZJ5iUhnSIea5gn59lvxRurf3w2XlDeZrjebbP4nuLdOMMZiX8WBfU/yQuqu\n\tve3EEp9jRvOfA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648631452;\n\tbh=swXXXRFj8cq58ZZ30a4gHMAC5StwbLpBkLBz+UTp+jA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=PxVgWLQLm6NSNOfteZYZfbC9RPF0t1KzVBi7xaOCDVeqgzSuPNnOV0XZexwzuqn9X\n\tlZTB9mdg8Rd7oi9ZI7WUYhGEUwSaKxOg0Xf1kE6BDx51piErQ1BK5RRDbmXPi4IHUs\n\tBY6X/yYE/KYt+KvnU+CBFs5VR0YstFmKN4l04Bn8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PxVgWLQL\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 30 Mar 2022 11:10:48 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.7.0","Content-Language":"en-US","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org, hanlinchen@chromium.org,\n\thpa@redhat.com","References":"<20220310120540.15296-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20220310120540.15296-1-david.plowman@raspberrypi.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/1] AF controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22530,"web_url":"https://patchwork.libcamera.org/comment/22530/","msgid":"","date":"2022-03-30T12:50:10","subject":"Re: [libcamera-devel] [PATCH 0/1] AF controls","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Jean-Michel\n\nThanks for the prod! Yes, I'll get on with this. One of the main\nthings was to produce a state transition diagram, so I'll do that too.\n\nPreviously the AfState merely reported reset/scanning/failed/focused\nwithout saying what the AfMode was, but I'm thinking I might change\nthis so that the mode is included as well. The Android version is like\nthis, and whilst it seems like it might be unnecessary, at least\nyou're sure if the algorithm has seen any new AfMode that you might\nhave set (given how asynchronous things can be). But I'll put all this\nin version 2.\n\nThanks!\nDavid\n\nOn Wed, 30 Mar 2022 at 10:10, Jean-Michel Hautbois\n wrote:\n>\n> Hi David !\n>\n> On 10/03/2022 13:05, David Plowman via libcamera-devel wrote:\n> > Hi everyone\n> >\n> > Here is a first non-RFC version of the proposed AF (autofocus)\n> > controls.\n> >\n> > There's been quite a bit of discussion already at the RFC stage, most\n> > notably the introduction of a manual mode, aimed at making integration\n> > with Android easier, and an explicit control for pausing CAF\n> > (continuous autofocus). I also removed the AfMethod control as it\n> > seems redundant, though I still wonder slightly if some platforms\n> > might have alterative ways of handling multi-spot AF.\n> >\n> > It's quite possible that I've forgotten to incorporate some\n> > suggestions that were made previously in which case I apologise -\n> > please point them out to me again!\n> >\n> > Further suggestions and discussion are of course most welcome!\n>\n> Do you know when you may be able to send a v2 ?\n> I really would like to see it integrated quickly now, and I am sure we\n> are not very far from it :-).\n>\n> Thanks !\n> JM\n>\n> >\n> > Thanks and best best regards\n> >\n> > David\n> >\n> > David Plowman (1):\n> > libcamera: controls: Controls for driving AF (autofocus) algorithms\n> >\n> > src/libcamera/control_ids.yaml | 271 +++++++++++++++++++++++++--------\n> > 1 file changed, 211 insertions(+), 60 deletions(-)\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 619DAC0F1B\n\tfor ;\n\tWed, 30 Mar 2022 12:50:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73B3B6559A;\n\tWed, 30 Mar 2022 14:50:23 +0200 (CEST)","from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCD9960135\n\tfor ;\n\tWed, 30 Mar 2022 14:50:21 +0200 (CEST)","by mail-wr1-x430.google.com with SMTP id c7so2555442wrd.0\n\tfor ;\n\tWed, 30 Mar 2022 05:50:21 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648644623;\n\tbh=aD9PB/PmSP3x6+RMqfDfJ67xGQAqeLgOukXbRAsm1mM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=l8lCrg1uqVYOm1hmh7AuAHlvjZNVuo5pHMGwSF1CrI8KL7jDo99ntrxewqgmzDne9\n\tbKKHbW8+ln95YJHPVSTR9pIHOekfObXRlczf4ee9jwrx0Nd5xZ/9erau/z0h2uLleB\n\tCTnvWYTlN6gETvZLNBB+5zgazGK7LEXUWTrCgjPXlnKk940VjYmOj9Ibz0wQy8HfdQ\n\txtcrmfGlG7thwgS8JSd/YJmoRi64mxdtmgHAj1vAX/UZA0N8xveT/Yxa+YjwXrfjH8\n\tkAo4+wvlm6+bF5AH1QvWI/X9oCySAsemXZLLO8rAKaWsLcCVD2jMY1Dkmo1+cO+MvO\n\tgOtMV/Iutko9A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=dySdkTZGkSwRzrPRdTnkU48hlGAQIqvHJZeOZtieGhU=;\n\tb=GKUzDHl9QLiOsh6qI/Xgmz7Nxg4uK5bc8zeUblhl97qORZ+xkcbQbgsXEv9hIWLoLY\n\tSjNSAWHoAqED1QTgChTxSGJmO1D/2LlTyDGPPX0JeLtL5uw0izi5lnsXVI1i7BX/bbkC\n\tkPfIoAJks8XmwuIs3IwzH1RcWMT0CyZp5fbwUzcoFD8ETz1ZF+zyk7ODVcEic/najVQN\n\tGvUzodVac1XCvW9wxo5zvpLyhB9BpCn1aYo4UxM/zrADhGISXpiLg1L8/N1f5q06YDuY\n\tRcGNqOG3YwjM8g0F2o+7uOOBkbrjeq7Z+zTXGzjBgjRnsuzY+PwnAjR+riN3dA06Inmw\n\tgQ4w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"GKUzDHl9\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=dySdkTZGkSwRzrPRdTnkU48hlGAQIqvHJZeOZtieGhU=;\n\tb=ZARis9kPwdHicPDgp1dXxHfkIcHxjkO9yENj4OrcuYad5B6I+IIEOQ0WpeDoPWqa0C\n\tJpA9uglh7SvrEjvJfGx3XFlZ97G+CPMptdq8396Ly5nOL3lryC2QpdgpCUGRXnDGuSu1\n\toHJo8O11t/SPxVrjVFcDOn/t2RgXMhonVf9I6IC5sjDrV7M0ZqxLgOvzsk/kt4E+8Toq\n\tshNE+JD+qexPQpFd6w7ooJviVoWWRusY/altv65qcKhPiCICqqUY9gACiPjCO26vSyGQ\n\tHg8XpYxM+qhXEFJCMGfZrHNaXnN24bV2BglkreerBUd2Vj6E3cjYPCog+YubGgdwxD3e\n\t6FDw==","X-Gm-Message-State":"AOAM531EOBlk5pMwX0VCC7M0og7OWY0dFuaZF1QG69+EP8SlRY0LJc4t\n\ttMsR8ZhVJf2ybpthRcj8o9HXrBjj6r46nsmURtGbnw==","X-Google-Smtp-Source":"ABdhPJwDAKFpLvGz7U8uJ+4oj6CsX10qroYYk8NFtybcVl+gFmtOlUJs8StlQ/HxUXZZ4kPrR1lT30V96E1+W9cnfvY=","X-Received":"by 2002:a5d:6c6f:0:b0:204:555:73cf with SMTP id\n\tr15-20020a5d6c6f000000b00204055573cfmr34670783wrz.24.1648644621446;\n\tWed, 30 Mar 2022 05:50:21 -0700 (PDT)","MIME-Version":"1.0","References":"<20220310120540.15296-1-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Wed, 30 Mar 2022 13:50:10 +0100","Message-ID":"","To":"Jean-Michel Hautbois ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 0/1] AF controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]