[{"id":22275,"web_url":"https://patchwork.libcamera.org/comment/22275/","msgid":"<20220315094923.GB3212506@pyrite.rasen.tech>","date":"2022-03-15T09:49:23","subject":"Re: [libcamera-devel] [PATCH 0/2] ipa: rkisp1: Replace event-based\n\tops with dedicated functions","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Umang,\n\nOn Tue, Mar 08, 2022 at 02:45:18PM +0530, Umang Jain via libcamera-devel wrote:\n> 1/1 is a cleanup patch.\n> 2/2 is the patch which removes the Actions/operation mechanics from the\n> interface.\n> \n> Patches are smoke-tested by Paul on rkisp1 hardware.\n\nFor both,\n\nTested-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> \n> Umang Jain (2):\n>   ipa: rkisp1: Drop private exposure and gain limits\n>   ipa: rkisp1: Replace event-based ops with dedicated functions\n> \n>  include/libcamera/ipa/rkisp1.mojom       |  31 ++-----\n>  src/ipa/rkisp1/rkisp1.cpp                | 106 +++++++----------------\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp |  71 ++++++---------\n>  3 files changed, 66 insertions(+), 142 deletions(-)\n> \n> -- \n> 2.31.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CD30BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Mar 2022 09:49:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0869B610F8;\n\tTue, 15 Mar 2022 10:49:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6689B601F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Mar 2022 10:49:32 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17BA210DD;\n\tTue, 15 Mar 2022 10:49:30 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647337774;\n\tbh=gUs2UTgzJXEcGjd0fH3GhZmB87vgkTdMk7oRsAMl+wQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=IZfKrJjgxEeJFeXUIujXbk5mnP2dws8ByaMiRCH5hZdtp/PbCZBCIfyLarxgAqBVd\n\tSXrqn+aDv+jGfSlZVm3J7QVLBew4jeOXHLuQ3A+IRIl5Ef9DBaMoKQjy5OMVgXs4fu\n\t0GhgPKZtpCQJuR2WjFVie7hRk7SUXDLFxQQVhtr7gTxgn5iV/iRuIc5/G6QuvyyZZv\n\tEZidpvJ6c+OcRdS/7lI7/rrnJhSpAuGn5gfXNTMxwGnrQOTDwQpDOtDGC/+zRhplVV\n\t0tRTJuzPW6dOnJK3Usm6MZ6LrBSFOM1YM9q7NTMyqIcYmr8YSgENGeBGeyVw1PiKik\n\t39kJG23GXYZ9Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647337772;\n\tbh=gUs2UTgzJXEcGjd0fH3GhZmB87vgkTdMk7oRsAMl+wQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Bjhr+bmrCf95qeLUzh2WOqPQPCVv2Q9elpso+UMSlOTNr+21M+5hSwR5QWfe3AoYX\n\tGCEyTqZWMfGUeuTZpn+9sc+eiz9qs5Lr5dwDxH7fmXDCWNbxSuMqpGnKrgOJVKd8Yk\n\te+fFuZcG8a37yt3EeDyMmpFAfAWzcHynrf5jz3oU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Bjhr+bmr\"; dkim-atps=neutral","Date":"Tue, 15 Mar 2022 18:49:23 +0900","To":"Umang Jain <umang.jain@ideasonboard.com>","Message-ID":"<20220315094923.GB3212506@pyrite.rasen.tech>","References":"<20220308091520.34607-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220308091520.34607-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] ipa: rkisp1: Replace event-based\n\tops with dedicated functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]