[{"id":22017,"web_url":"https://patchwork.libcamera.org/comment/22017/","msgid":"","date":"2022-01-12T07:33:58","subject":"Re: [libcamera-devel] [PATCH 0/5] android: Plumb the YUV processor\n\tin","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Thanks Jacopo for sorting out, splitting and testing!\n\nOn Tue, Jan 11, 2022 at 1:54 AM Jacopo Mondi wrote:\n>\n> Hello\n> I've started this series by reviewing Hiro's\n> \"[PATCH 1/1] android: camera_device: Configure one stream for identical stream requests\"\n> https://patchwork.libcamera.org/project/libcamera/list/?series=2880\n>\n> In order to validate my review comments I had to find tests which exercized the\n> YUV post-processor, and that's the result of the testing process.\n>\n> I broke Hiro's series in 4 patches and addded one small fix on top.\n>\n> Tested by running 12 of the tests currently excluded from the libcamera\n> subplan.\n>\n> These tests require 3 YUV streams to be supported and where so far excluded for\n> this reason:\n>\n> [1/12] android.hardware.camera2.cts.RobustnessTest#testMandatoryOutputCombinations pass\n> [2/12] android.hardware.cts.CameraTest#testFocusDistances pass\n> [3/12] android.hardware.cts.CameraTest#testPreviewCallback pass\n> [4/12] android.hardware.cts.CameraTest#testPreviewCallbackWithBuffer pass\n> [5/12] android.hardware.cts.CameraTest#testPreviewCallbackWithPicture pass\n> [6/12] android.hardware.cts.CameraTest#testPreviewFormats pass\n> [7/12] android.hardware.cts.CameraTest#testPreviewFpsRange pass\n> [8/12] android.hardware.cts.CameraTest#testSetOneShotPreviewCallback pass\n> [9/12] android.hardware.cts.CameraTest#testSetPreviewDisplay pass\n> [10/12] android.hardware.cts.CameraGLTest#testSetPreviewTextureBothCallbacks pass\n> [11/12] android.hardware.cts.CameraGLTest#testSetPreviewTexturePreviewCallback pass\n> [12/12] android.hardware.camera2.cts.SurfaceViewPreviewTest#testDeferredSurfaces pass\n>\n> As an example output from a test run:\n>\n> -------------------------------------------------------------------------------\n> INFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #0, direction: Output, width: 1920, height: 1080, format: 0x00000022, rotation: 0, crop_rotate_scale_degrees: 0 (NV12)\n> INFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #1, direction: Output, width: 1920, height: 1080, format: 0x00000022, rotation: 0, crop_rotate_scale_degrees: 0 (NV12)\n> INFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #2, direction: Output, width: 2560, height: 1920, format: 0x00000021, rotation: 0, crop_rotate_scale_degrees: 0 (MJPEG)\n> INFO HAL camera_device.cpp:694 '\\_SB_.PCI0.I2C4.CAM1': Adding 2560x1920-NV12 for MJPEG support\n> DEBUG HAL camera_device.cpp:121 Insert 2560x1920-NV12\n> DEBUG HAL camera_device.cpp:127 Insert 1920x1080-NV12\n> INFO Camera camera.cpp:1028 configuring streams: (0) 2560x1920-NV12 (1) 1920x1080-NV12\n>\n> ...\n>\n> DEBUG HAL camera_device.cpp:951 '\\_SB_.PCI0.I2C4.CAM1': Queueing request 138253722276496 with 3 streams\n> DEBUG HAL camera_device.cpp:1017 '\\_SB_.PCI0.I2C4.CAM1': 1 - (1920x1080)[0x00000022] -> (1920x1080)[NV12] (direct)\n> DEBUG HAL camera_device.cpp:1030 '\\_SB_.PCI0.I2C4.CAM1': 2 - (2560x1920)[0x00000021] -> (2560x1920)[NV12] (internal)\n> DEBUG HAL camera_device.cpp:1063 '\\_SB_.PCI0.I2C4.CAM1': 0 - (1920x1080)[0x00000022] -> (1920x1080)[NV12] (mapped)\n> DEBUG HAL camera_device.cpp:1198 '\\_SB_.PCI0.I2C4.CAM1': Request 138253722217920 completed with 2 streams\n> -------------------------------------------------------------------------------\n>\n> No regression with the ordinary CTS libcamera plan\n>\n> =============== Summary ===============\n> Total Run time: 19m 51s\n> 1/1 modules completed\n> Total Tests : 231\n> PASSED : 231\n> FAILED : 0\n> ============== End of Results ==============\n>\n> Thanks\n> j\n>\n>\n> Hirokazu Honda (2):\n> android: camera_stream: Add sourceStream\n> android: camera_device: Use YUV post-processor\n>\n> Jacopo Mondi (3):\n> android: camera_stream: Create allocator unconditionally\n> android: camera_device: Post-pone mapped streams handling\n> android: camera_device: Print the correct number of completed streams\n>\n> src/android/camera_device.cpp | 124 ++++++++++++++++++++++++++++++----\n> src/android/camera_stream.cpp | 12 ++--\n> src/android/camera_stream.h | 6 +-\n> 3 files changed, 122 insertions(+), 20 deletions(-)\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FBC8BF415\n\tfor ;\n\tWed, 12 Jan 2022 07:34:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC7A96021A;\n\tWed, 12 Jan 2022 08:34:10 +0100 (CET)","from mail-ed1-x536.google.com (mail-ed1-x536.google.com\n\t[IPv6:2a00:1450:4864:20::536])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E5B260217\n\tfor ;\n\tWed, 12 Jan 2022 08:34:09 +0100 (CET)","by mail-ed1-x536.google.com with SMTP id w16so6173867edc.11\n\tfor ;\n\tTue, 11 Jan 2022 23:34:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"AZW6n+iB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=adoeI3N0PzYOmRYpmifLGd+b/HGRPh04Pok14WjGvt0=;\n\tb=AZW6n+iBzsYb7o9nKTsSOxnE0Jx0ZgytnvotZlPGPLkH366R8mYVzAmrZYWM1aUmFX\n\tRfNGrFDmWm5iOckTfLllBdfNxOh+SltejJdY4vEcN8/h6DBGdEqTEbm4DexJhiJmMtR5\n\tGNCUf59CRow5RIGr9pcL6YDnhJZBH1AHrjPNU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=adoeI3N0PzYOmRYpmifLGd+b/HGRPh04Pok14WjGvt0=;\n\tb=Hzloz9ZuOrXQ62bA5SYJ7gMf3rCHMvmM2xMq73qksmuY+f4V3uKftRcLk3vFSfme7Z\n\ts2S5EZ41HID6nCJz/tKeowCpIJD5SG8NyAf1BP638epOOC6lzVvmmmaEOpvtJnaKnuK+\n\timLlSnm0o6FxAgoHItVjfo5eaTDTxOy9ja0x1oKFp7oSvtkTKjRaiivnjwfj+0cipsjf\n\tvH4bt/R5fHZG5C8LRCV088x+AxT+stEQBmK91FZxUPUWP1Cfl9masgVu4gtl4Mmp8Lpp\n\tCM34AcK5PnSLBinX0PwdkBFzxn/IvE9fU572bXJzruauiG/MctOrV6sxwXTcC/2U52nx\n\t75QQ==","X-Gm-Message-State":"AOAM533lJtFhZXLarvAPIoFnt7iAWSZO0IR7HhfOPgKGHQbKCfPGD/mb\n\txWfFAVSy+7h4H7A2wcEXY1dGU0EN+RtLCaU038XK1kZ2HmI=","X-Google-Smtp-Source":"ABdhPJwnnVKT//VM3hGIDbpPYgrBQVghSrS5vkrOM1ZOOiM6pft31MxQcDcieOBqXCrbB9h0yA37BcwW93X+l1vrOOg=","X-Received":"by 2002:a17:907:9618:: with SMTP id\n\tgb24mr6684233ejc.385.1641972848785; \n\tTue, 11 Jan 2022 23:34:08 -0800 (PST)","MIME-Version":"1.0","References":"<20220110165524.72978-1-jacopo@jmondi.org>","In-Reply-To":"<20220110165524.72978-1-jacopo@jmondi.org>","From":"Hirokazu Honda ","Date":"Wed, 12 Jan 2022 16:33:58 +0900","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 0/5] android: Plumb the YUV processor\n\tin","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22701,"web_url":"https://patchwork.libcamera.org/comment/22701/","msgid":"","date":"2022-04-13T11:04:56","subject":"Re: [libcamera-devel] [PATCH 0/5] android: Plumb the YUV processor\n\tin","submitter":{"id":9,"url":"https://patchwork.libcamera.org/api/people/9/","name":"Tomasz Figa","email":"tfiga@chromium.org"},"content":"Hi Jacopo, Laurent,\n\nOn Tue, Jan 11, 2022 at 1:54 AM Jacopo Mondi wrote:\n>\n> Hello\n> I've started this series by reviewing Hiro's\n> \"[PATCH 1/1] android: camera_device: Configure one stream for identical stream requests\"\n> https://patchwork.libcamera.org/project/libcamera/list/?series=2880\n>\n> In order to validate my review comments I had to find tests which exercized the\n> YUV post-processor, and that's the result of the testing process.\n>\n> I broke Hiro's series in 4 patches and addded one small fix on top.\n>\n> Tested by running 12 of the tests currently excluded from the libcamera\n> subplan.\n>\n> These tests require 3 YUV streams to be supported and where so far excluded for\n> this reason:\n>\n> [1/12] android.hardware.camera2.cts.RobustnessTest#testMandatoryOutputCombinations pass\n> [2/12] android.hardware.cts.CameraTest#testFocusDistances pass\n> [3/12] android.hardware.cts.CameraTest#testPreviewCallback pass\n> [4/12] android.hardware.cts.CameraTest#testPreviewCallbackWithBuffer pass\n> [5/12] android.hardware.cts.CameraTest#testPreviewCallbackWithPicture pass\n> [6/12] android.hardware.cts.CameraTest#testPreviewFormats pass\n> [7/12] android.hardware.cts.CameraTest#testPreviewFpsRange pass\n> [8/12] android.hardware.cts.CameraTest#testSetOneShotPreviewCallback pass\n> [9/12] android.hardware.cts.CameraTest#testSetPreviewDisplay pass\n> [10/12] android.hardware.cts.CameraGLTest#testSetPreviewTextureBothCallbacks pass\n> [11/12] android.hardware.cts.CameraGLTest#testSetPreviewTexturePreviewCallback pass\n> [12/12] android.hardware.camera2.cts.SurfaceViewPreviewTest#testDeferredSurfaces pass\n>\n> As an example output from a test run:\n>\n> -------------------------------------------------------------------------------\n> INFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #0, direction: Output, width: 1920, height: 1080, format: 0x00000022, rotation: 0, crop_rotate_scale_degrees: 0 (NV12)\n> INFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #1, direction: Output, width: 1920, height: 1080, format: 0x00000022, rotation: 0, crop_rotate_scale_degrees: 0 (NV12)\n> INFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #2, direction: Output, width: 2560, height: 1920, format: 0x00000021, rotation: 0, crop_rotate_scale_degrees: 0 (MJPEG)\n> INFO HAL camera_device.cpp:694 '\\_SB_.PCI0.I2C4.CAM1': Adding 2560x1920-NV12 for MJPEG support\n> DEBUG HAL camera_device.cpp:121 Insert 2560x1920-NV12\n> DEBUG HAL camera_device.cpp:127 Insert 1920x1080-NV12\n> INFO Camera camera.cpp:1028 configuring streams: (0) 2560x1920-NV12 (1) 1920x1080-NV12\n>\n> ...\n>\n> DEBUG HAL camera_device.cpp:951 '\\_SB_.PCI0.I2C4.CAM1': Queueing request 138253722276496 with 3 streams\n> DEBUG HAL camera_device.cpp:1017 '\\_SB_.PCI0.I2C4.CAM1': 1 - (1920x1080)[0x00000022] -> (1920x1080)[NV12] (direct)\n> DEBUG HAL camera_device.cpp:1030 '\\_SB_.PCI0.I2C4.CAM1': 2 - (2560x1920)[0x00000021] -> (2560x1920)[NV12] (internal)\n> DEBUG HAL camera_device.cpp:1063 '\\_SB_.PCI0.I2C4.CAM1': 0 - (1920x1080)[0x00000022] -> (1920x1080)[NV12] (mapped)\n> DEBUG HAL camera_device.cpp:1198 '\\_SB_.PCI0.I2C4.CAM1': Request 138253722217920 completed with 2 streams\n> -------------------------------------------------------------------------------\n>\n> No regression with the ordinary CTS libcamera plan\n>\n> =============== Summary ===============\n> Total Run time: 19m 51s\n> 1/1 modules completed\n> Total Tests : 231\n> PASSED : 231\n> FAILED : 0\n> ============== End of Results ==============\n>\n> Thanks\n> j\n>\n>\n> Hirokazu Honda (2):\n> android: camera_stream: Add sourceStream\n> android: camera_device: Use YUV post-processor\n>\n> Jacopo Mondi (3):\n> android: camera_stream: Create allocator unconditionally\n> android: camera_device: Post-pone mapped streams handling\n> android: camera_device: Print the correct number of completed streams\n>\n> src/android/camera_device.cpp | 124 ++++++++++++++++++++++++++++++----\n> src/android/camera_stream.cpp | 12 ++--\n> src/android/camera_stream.h | 6 +-\n> 3 files changed, 122 insertions(+), 20 deletions(-)\n\nThanks for helping with Hiro's series. Is this something we could merge?\n\nBest regards,\nTomasz","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00CAFC0F1B\n\tfor ;\n\tWed, 13 Apr 2022 11:05:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 153C165644;\n\tWed, 13 Apr 2022 13:05:14 +0200 (CEST)","from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com\n\t[IPv6:2607:f8b0:4864:20::f33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3900F604B4\n\tfor ;\n\tWed, 13 Apr 2022 13:05:12 +0200 (CEST)","by mail-qv1-xf33.google.com with SMTP id c1so1309067qvl.3\n\tfor ;\n\tWed, 13 Apr 2022 04:05:12 -0700 (PDT)","from mail-yw1-f178.google.com (mail-yw1-f178.google.com.\n\t[209.85.128.178]) by smtp.gmail.com with ESMTPSA id\n\tk20-20020a05622a03d400b002ec16d2694fsm14344489qtx.39.2022.04.13.04.05.08\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 13 Apr 2022 04:05:08 -0700 (PDT)","by mail-yw1-f178.google.com with SMTP id\n\t00721157ae682-2ebebe631ccso17944077b3.4\n\tfor ;\n\tWed, 13 Apr 2022 04:05:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649847914;\n\tbh=s4tbfk90rd304+aDd6TgDCTJ2ePrBtKeT5uf2G9sqb0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=LvbfPD7QfyqtjoTaXtkHgFW3oXA7qObbVISbbKSr89Y2ZiR1xu+cLzfmzyVRRHm89\n\t6Zrp5TR6Ff3BdSxQI9mX3PW/tdpv0ePQT2fzREfcWFMHnB9rXXBPfcNhp1hh+KMZDg\n\th4R6t7TTzz3oU6rKBtI6rX3SA5bGcZYAKv7YpjbzTMqYd7no+kQLuVbNMz8lZBzuPm\n\tk6nF4K0Jb/wi/4+hUlcqKlWtPw6llkp2RXCpY6NPiUDICg0uHa+4J83dkwWPUtQjGt\n\tm02TKbRwfIjKp1VXXNKcOFZzR/5C6kF2hhWUvG5eXcc2dy7i1kEigYQr6Lj/3Wggqn\n\tva+XRpWmlkGFw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=RrY+ZUUnIwlo32/f5JvFext/+VxBJgoopZCo8v9l018=;\n\tb=ZhBI44RAbdlieV9cdTOBzI+4DInz623zuQznSGAhs+Xjyq6IXewqnIiy/ExSVqdxgU\n\tuY0B+ODwRatOsKAbTybUOO/AumfTw1Osh3QN/M+L2ASVeTJ1QgswKt8+qtVFBxg7zcYY\n\tkXkI72jaRFfgx9X1mZNQCAG0BiZ3J6cRujZIY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"ZhBI44RA\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=RrY+ZUUnIwlo32/f5JvFext/+VxBJgoopZCo8v9l018=;\n\tb=UjqLAFMl9ZcIvKifeGA4cAW+/2nS8Tg11/vmCbBG9qdJxTqxok3p41mzac4sD3qxiN\n\tnW2Tj+DvQye4YijI9TuMY/x7lxKhKLt6hk04J7XmMitMBJGei954dzY/bdfG0kECFG2G\n\tZF+scDGv8my/bb5InI/Qb/PiDp5UJ/FdvRK8QBehqY/NM+icihXsviLpi90ZAyvbiJGO\n\t6ZJROxhhLyD6KZvy8+JTqR3aQEM4QN6cEZABwerZywLXzkeBvcirGFAsVtValaJAH99L\n\tEfx9zQhnBbL7Zu/zAdSYjse/97VSgyIyu+zrwEm6DT+yEMtCk2N3+C8aQvbrZ2jDATbl\n\tuk+A==","X-Gm-Message-State":"AOAM532Zc1UiYHC5fgMK45Ijsrjat6MOOOTPTwe8C7SnySNpADOSZ3CF\n\tOc1aJlZFAtXFqbmV09SNSuiazSd15z0Zng==","X-Google-Smtp-Source":"ABdhPJyz7Bm1MarONwpEIZFNeyFS1iuNqMFYNVIzU1dmA/EKE5hOpb7zXdBls/W7gimVoirh68WpQQ==","X-Received":["by 2002:a05:6214:2a49:b0:441:69b0:84c7 with SMTP id\n\tjf9-20020a0562142a4900b0044169b084c7mr35024771qvb.122.1649847910114; \n\tWed, 13 Apr 2022 04:05:10 -0700 (PDT)","by 2002:a81:7b56:0:b0:2ec:2d65:7ccf with SMTP id\n\tw83-20020a817b56000000b002ec2d657ccfmr11351973ywc.208.1649847908095;\n\tWed, 13 Apr 2022 04:05:08 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20220110165524.72978-1-jacopo@jmondi.org>","In-Reply-To":"<20220110165524.72978-1-jacopo@jmondi.org>","Date":"Wed, 13 Apr 2022 20:04:56 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 0/5] android: Plumb the YUV processor\n\tin","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomasz Figa via libcamera-devel ","Reply-To":"Tomasz Figa ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]