[{"id":21742,"web_url":"https://patchwork.libcamera.org/comment/21742/","msgid":"","date":"2021-12-10T12:36:43","subject":"Re: [libcamera-devel] [PATCH v11 0/8] Colour spaces","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Fri, Dec 10, 2021 at 11:21:34AM +0000, David Plowman wrote:\n> Hi again\n> \n> So here now is v11, which has just hoovered up those mostly minor\n> items from Laurent, so thank you very much for those.\n> \n> The only point of note is that I made the to/fromColorSpace methods\n> protected, only to discover that I then couldn't move the logging\n> messages in there because they're static member functions. Is there\n> some cunning workaround for this?\n\nI haven't been able to find a good way to handle logging in static\nfunctions of a class that the inherits from Loggable completely\ntransparently. It can be worked around by using libcamera::LOG() instead\nof LOG().\n\n> Other than that, I think we're getting pretty close!\n> \n> Thanks again and best regards\n> \n> David\n> \n> David Plowman (8):\n> libcamera: Add ColorSpace class\n> libcamera: stream: Add ColorSpace fields to StreamConfiguration\n> libcamera: video_device: Convert between ColorSpace class and V4L2\n> formats\n> libcamera: video_device: Support passing ColorSpaces to V4L2 video\n> devices\n> libcamera: v4l2_subdevice: Add colorSpace field to V4L2SubdeviceFormat\n> libcamera: v4l2_subdevice: Support passing ColorSpaces to V4L2\n> subdevices\n> libcamera: Add validateColorSpaces to CameraConfiguration class\n> libcamera: pipeline: raspberrypi: Support color spaces\n> \n> include/libcamera/camera.h | 10 +\n> include/libcamera/color_space.h | 70 ++++\n> include/libcamera/internal/v4l2_device.h | 8 +\n> include/libcamera/internal/v4l2_subdevice.h | 3 +\n> include/libcamera/internal/v4l2_videodevice.h | 3 +\n> include/libcamera/meson.build | 1 +\n> include/libcamera/stream.h | 3 +\n> src/libcamera/camera.cpp | 80 +++++\n> src/libcamera/camera_sensor.cpp | 1 +\n> src/libcamera/color_space.cpp | 317 ++++++++++++++++++\n> src/libcamera/meson.build | 1 +\n> src/libcamera/pipeline/ipu3/cio2.cpp | 7 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 40 +++\n> src/libcamera/pipeline/simple/simple.cpp | 8 +-\n> src/libcamera/stream.cpp | 20 ++\n> src/libcamera/v4l2_device.cpp | 194 +++++++++++\n> src/libcamera/v4l2_subdevice.cpp | 25 +-\n> src/libcamera/v4l2_videodevice.cpp | 32 ++\n> 18 files changed, 816 insertions(+), 7 deletions(-)\n> create mode 100644 include/libcamera/color_space.h\n> create mode 100644 src/libcamera/color_space.cpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60F16BDB13\n\tfor ;\n\tFri, 10 Dec 2021 12:37:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD97960890;\n\tFri, 10 Dec 2021 13:37:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C364560868\n\tfor ;\n\tFri, 10 Dec 2021 13:37:12 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2AA45F84;\n\tFri, 10 Dec 2021 13:37:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dff+DrWs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639139832;\n\tbh=3BQz0FV5NQcVRyJryz/578CMP8W1qVfMjence4D4X/4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dff+DrWs7nkzMlG7v90vAuYgxbc64B3PfU4wGo5bU8z+z7bkpCpNDEJA9WH1NAKrn\n\tA/tNZD5C3E1vJg82vSbzZAiTag6MMiLLeR4RX4rRI4o9eMeztroide3IcavMBHt47Y\n\t0b/6eq7KALgX8PSyI5Db++KJpui2Zj44kykVfFS4=","Date":"Fri, 10 Dec 2021 14:36:43 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20211210112142.18441-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211210112142.18441-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v11 0/8] Colour spaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomasz Figa , libcamera-devel@lists.libcamera.org,\n\tHans Verkuil ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]