{"id":15051,"url":"https://patchwork.libcamera.org/api/covers/15051/?format=json","web_url":"https://patchwork.libcamera.org/cover/15051/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211206152644.4863-1-laurent.pinchart@ideasonboard.com>","date":"2021-12-06T15:26:42","name":"[libcamera-devel,0/2] libcamera: Introduce utils::abs_diff()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/15051/mbox/","series":[{"id":2819,"url":"https://patchwork.libcamera.org/api/series/2819/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2819","date":"2021-12-06T15:26:42","name":"libcamera: Introduce utils::abs_diff()","version":1,"mbox":"https://patchwork.libcamera.org/series/2819/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/15051/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16438BDB13\n\tfor ;\n\tMon, 6 Dec 2021 15:27:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6FED60876;\n\tMon, 6 Dec 2021 16:27:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F0C160725\n\tfor ;\n\tMon, 6 Dec 2021 16:27:16 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 487A0EE\n\tfor ;\n\tMon, 6 Dec 2021 16:27:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HuOlJK5Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638804436;\n\tbh=gVWCZydDSa/HjS8e+cxfkNjG9UHqytMMcAacRLITPcg=;\n\th=From:To:Subject:Date:From;\n\tb=HuOlJK5ZWR/So8YdGbx05vgxkg/SuRBCKBd6zMksw7QXb19l5lcmf0vq1al0t/RFJ\n\t+JEHYYsq8QT8JRmQfLnAV35jK18qA6N8LWlPgIomhG6SYI8thE1z8ZmlfvNDfiY10/\n\tN6dMvNygRVKzkdSQUCxzygQbPExhZuvljFex8W9A=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 6 Dec 2021 17:26:42 +0200","Message-Id":"<20211206152644.4863-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/2] libcamera: Introduce utils::abs_diff()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThe utils::abs_diff() function fixes integer overflow issues when\ncomputing the absolute difference of two values. See patch 1/2 for\ndetails, patch 2/2 then uses the function through the code base.\n\nLaurent Pinchart (2):\n libcamera: base: utils: Add abs_diff() utility function\n libcamera: Use utils::abs_diff()\n\n include/libcamera/base/utils.h | 9 +++++++++\n src/ipa/ipu3/algorithms/agc.cpp | 3 ++-\n src/ipa/ipu3/ipu3.cpp | 4 ++--\n src/ipa/rkisp1/algorithms/agc.cpp | 3 ++-\n src/libcamera/base/utils.cpp | 17 +++++++++++++++++\n src/libcamera/pipeline/ipu3/imgu.cpp | 4 ++--\n .../pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n 7 files changed, 36 insertions(+), 9 deletions(-)\n\n\nbase-commit: f8d2f17a3db5ac490d7b505253a98d6795c2b630"}