{"id":14960,"url":"https://patchwork.libcamera.org/api/covers/14960/?format=json","web_url":"https://patchwork.libcamera.org/cover/14960/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211201142936.107405-1-jacopo@jmondi.org>","date":"2021-12-01T14:29:25","name":"[libcamera-devel,v4,00/11] libcamera: Add support for Fence","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/14960/mbox/","series":[{"id":2795,"url":"https://patchwork.libcamera.org/api/series/2795/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2795","date":"2021-12-01T14:29:25","name":"libcamera: Add support for Fence","version":4,"mbox":"https://patchwork.libcamera.org/series/2795/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/14960/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD229BDB13\n\tfor ;\n\tWed, 1 Dec 2021 14:28:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 110176073D;\n\tWed, 1 Dec 2021 15:28:50 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD18F604FC\n\tfor ;\n\tWed, 1 Dec 2021 15:28:48 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id EEAC2C0008;\n\tWed, 1 Dec 2021 14:28:47 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 1 Dec 2021 15:29:25 +0100","Message-Id":"<20211201142936.107405-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.33.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 00/11] libcamera: Add support for Fence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Take into account Laurent's comments on V3\n\nv3->v4\n- Documentation fixes\n- Rationalize reset()/release() function naming\n- Call Request::Private::cancel() in Request::Private::timeout() and simplify\n PipelineHandlers::doQueueRequest()\n- Fix Camera HAL requestComplete() fences handling\n\nv2->v3\n- Documentation\n\n- Fence:\n - use UniqueFD\n - drop Extensible\n\n- Framebuffer:\n - Add FrameBuffer::resetFence\n\n- Request:\n - do not overload addBuffer but use optional argument\n - Remove Private::Status\n - simplify prepare() by using a map of buffers to notifiers\n - Add the prepared_ flag\n\n- PipelineHandler:\n - Simplify request preparation\n\n- Android\n - Use UniqueFD\n\nv1->v2:\nMajor changes:\n- removed notifiers and timers from Fence. A Fence is now an wrapper that owns\n a file descriptor\n- Add timers and notifiers to Request::Private and add the\n Request::Private::prepare interface\n\nSmaller changes:\n- Expand Request::Private to move all internal fields\n- Remove Fence move semantic. A Fence lives in a Framebuffer.\n- A few minor patches on top\n\nJacopo Mondi (10):\n libcamera: Print Timer identifier\n libcamera: fence: Introduce Fence\n libcamera: framebuffer: Add Fence to FrameBuffer\n libcamera: request: Add Fence to Request::addBuffer()\n test: fence: Add test for the Fence class\n libcamera: pipeline_handler: Split request queueing\n libcamera: pipeline: Introduce stopDevice()\n libcamera: request: Add Request::Private::prepare()\n libcamera: pipeline_handler: Prepare Request\n android: Remove CameraWorker\n\nLaurent Pinchart (1):\n libcamera: request: Make Request class Extensible\n\n include/libcamera/fence.h | 31 ++\n include/libcamera/framebuffer.h | 4 +\n include/libcamera/internal/framebuffer.h | 8 +\n include/libcamera/internal/meson.build | 1 +\n include/libcamera/internal/pipeline_handler.h | 9 +-\n include/libcamera/internal/request.h | 64 +++\n .../libcamera/internal/tracepoints/request.tp | 22 +-\n include/libcamera/meson.build | 1 +\n include/libcamera/request.h | 23 +-\n src/android/camera_device.cpp | 39 +-\n src/android/camera_device.h | 3 -\n src/android/camera_request.cpp | 8 +-\n src/android/camera_request.h | 6 +-\n src/android/camera_stream.cpp | 10 +-\n src/android/camera_worker.cpp | 129 ------\n src/android/camera_worker.h | 70 ----\n src/android/meson.build | 1 -\n src/libcamera/base/event_dispatcher_poll.cpp | 9 +-\n src/libcamera/base/timer.cpp | 4 +-\n src/libcamera/fence.cpp | 113 +++++\n src/libcamera/framebuffer.cpp | 58 +++\n src/libcamera/meson.build | 1 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 4 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +-\n src/libcamera/pipeline/simple/simple.cpp | 4 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 4 +-\n src/libcamera/pipeline_handler.cpp | 101 ++++-\n src/libcamera/request.cpp | 386 ++++++++++++++----\n test/fence.cpp | 340 +++++++++++++++\n test/meson.build | 1 +\n 32 files changed, 1094 insertions(+), 372 deletions(-)\n create mode 100644 include/libcamera/fence.h\n create mode 100644 include/libcamera/internal/request.h\n delete mode 100644 src/android/camera_worker.cpp\n delete mode 100644 src/android/camera_worker.h\n create mode 100644 src/libcamera/fence.cpp\n create mode 100644 test/fence.cpp\n\n--\n2.33.1"}