[{"id":21514,"web_url":"https://patchwork.libcamera.org/comment/21514/","msgid":"","date":"2021-12-01T11:47:46","subject":"Re: [libcamera-devel] [PATCH v5 00/12] Introduce clang thread\n\tsafety annotations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Dec 01, 2021 at 04:53:36PM +0900, Hirokazu Honda wrote:\n> This introduces clang thread safety annotations and applies it\n> to libcamera Android HAL adaptation layer. It is necessary to add\n> new classes that wrap std::mutex, std::unique_lock and\n> std::condition_variable with the annotations. It is because no\n> C++ standard library annotates all the mutex classes today.\n> libstdc++ doesn't annotate any classes. libc++ annotates for\n> std::mutex, std::lock_guard and std::scoped_lock, but doesn't for\n> std::unique_lock.\n> \n> Therefore it is possible to use std::mutex if libc++ is used.\n> Althoug I don't do so In this patch series because the existing\n> code using std::mutex is not annotated yet.\n> \n> Document: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html\n> \n> Change in v5:\n> * 05/12: Address comments from Laurent\n\nThere were only a few very minor comments for v5, I'll address them when\napplying.\n\n> Hirokazu Honda (12):\n> libcamera: base: Introduce ConditionVariable\n> android: Consolidate mutex classes to Mutex and MutexLocker\n> v4l2: Consolidate mutex classes to Mutex and MutexLocker\n> libcamera: base: Add thread safety annotation macros\n> libcamera: base: Add mutex classes with thread safety annotations\n> libcamera: Correct include headers for Mutex classes\n> android: camera_hal_manager: Add thread safety annotation\n> android: camera_stream: Protect buffers initialization by mutex_\n> android: camera_stream: Add thread safety annotation\n> android: camera_device: Fix variables access without protection\n> android: camera_device: Add thread safety annotation\n> android: camera_request: Add thread safety annotation\n> \n> include/libcamera/base/meson.build | 2 +\n> include/libcamera/base/mutex.h | 132 ++++++++++++++++++++\n> include/libcamera/base/semaphore.h | 7 +-\n> include/libcamera/base/thread.h | 4 -\n> include/libcamera/base/thread_annotations.h | 80 ++++++++++++\n> meson.build | 1 +\n> src/android/camera_device.cpp | 10 +-\n> src/android/camera_device.h | 17 +--\n> src/android/camera_hal_manager.h | 13 +-\n> src/android/camera_request.h | 7 +-\n> src/android/camera_stream.cpp | 15 +--\n> src/android/camera_stream.h | 15 +--\n> src/libcamera/base/meson.build | 1 +\n> src/libcamera/base/mutex.cpp | 56 +++++++++\n> src/libcamera/base/semaphore.cpp | 1 -\n> src/libcamera/base/signal.cpp | 2 +-\n> src/libcamera/base/thread.cpp | 14 +--\n> src/libcamera/camera_manager.cpp | 4 +-\n> src/v4l2/v4l2_camera.h | 6 +-\n> src/v4l2/v4l2_camera_proxy.cpp | 8 +-\n> src/v4l2/v4l2_camera_proxy.h | 4 +-\n> 21 files changed, 332 insertions(+), 67 deletions(-)\n> create mode 100644 include/libcamera/base/mutex.h\n> create mode 100644 include/libcamera/base/thread_annotations.h\n> create mode 100644 src/libcamera/base/mutex.cpp\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A548CBDB13\n\tfor ;\n\tWed, 1 Dec 2021 11:48:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4E0D6071A;\n\tWed, 1 Dec 2021 12:48:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A421D6011A\n\tfor ;\n\tWed, 1 Dec 2021 12:48:11 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21894A15;\n\tWed, 1 Dec 2021 12:48:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t7HU/T//\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638359291;\n\tbh=NLyj/kGQlV8Gtngff1ACWEfqyzr+DOfWL0XEC3T43W0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=t7HU/T//hRJdSXUUzUKLxMZJFgFJMQUmUJb8RdCTt0uNSUd7AZSF3K7vZu6cZhj9n\n\trDvEN8pDlPjUoaFtBpuVscCcW0VEYuE2zQZmLlR8GhtALL2jXTgHq2Yh4KF855E8Gy\n\tLygEPsiUcsGw1tp6m1GGcpodR276ltkdfDropTMk=","Date":"Wed, 1 Dec 2021 13:47:46 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20211201075348.3121186-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211201075348.3121186-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v5 00/12] Introduce clang thread\n\tsafety annotations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]