{"id":14855,"url":"https://patchwork.libcamera.org/api/covers/14855/?format=json","web_url":"https://patchwork.libcamera.org/cover/14855/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211130033820.18235-1-laurent.pinchart@ideasonboard.com>","date":"2021-11-30T03:37:58","name":"[libcamera-devel,v4,00/22] libcamera: Introduce UniqueFD","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/14855/mbox/","series":[{"id":2776,"url":"https://patchwork.libcamera.org/api/series/2776/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2776","date":"2021-11-30T03:37:58","name":"libcamera: Introduce UniqueFD","version":4,"mbox":"https://patchwork.libcamera.org/series/2776/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/14855/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DA6ABF415\n\tfor ;\n\tTue, 30 Nov 2021 03:38:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21AA3605B9;\n\tTue, 30 Nov 2021 04:38:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FA0C604FC\n\tfor ;\n\tTue, 30 Nov 2021 04:38:48 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE3248F0\n\tfor ;\n\tTue, 30 Nov 2021 04:38:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V3zf7/s2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638243528;\n\tbh=G6Z/DeAZ6uWYI/Qoj53JWz5E2QZ7ejH0S2eFOUXkW0s=;\n\th=From:To:Subject:Date:From;\n\tb=V3zf7/s2aMFSSbCpKotSjr1/JnhlU8+2DDd/JbVgk5BQMiGefcJPHpcpovEkBPX1j\n\tH/Sbv0UJNK0mcfKyjKmHHxqqCKgiznhemupjmemqJqEki4c6HqtFK0vqI61JoIVGQe\n\t7XD5wuOvXRHPgjAZWUKzQFkGT9GjgnWN1nOgK/FQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Nov 2021 05:37:58 +0200","Message-Id":"<20211130033820.18235-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 00/22] libcamera: Introduce UniqueFD","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series is a continuation of Hiro's work on the ScopedFD class\n([1]). The class is a std::unique_ptr<>-like wrapper around file\ndescriptors, which complements the existing shared-ownership\nFileDescriptor.\n\nCompared to v2, the main changes are a rename of ScopedFD to UniqueFD,\nand to match that, of FileDescriptor to SharedFD, as well as a new unit\ntest.\n\nCompared to v3, review comments have been take into account, and five\npatches have been added:\n\n- Patch 11/22 fixes an fd leak\n- Patch 16/22 uses SharedFD in V4L2VideoDevice::open()\n- Patch 20/22 improves SharedFD with comparison operators\n- Patch 21/22 renames SharedFD::fd() to get() for consistency with\n UniqueFD\n- Patch 22/22 passes fds by rvalue reference to the UniqueFD constructor\n and reset() function\n\nAs indicated in patch 22/22, if rvalue references are preferred, the\npatch will be squashed with 04/22.\n\n[1] https://patchwork.libcamera.org/project/libcamera/list/?series=2115\n\nHirokazu Honda (11):\n libcamera: base: Introduce UniqueFD\n libcamera: base: file_descriptor: Add constructor from UniqueFD\n libcamera: event_dispatcher_poll: Manage fd by UniqueFD\n libcamera: file: Manage fd by UniqueFD\n libcamera: ipc_unixsocket: Use UniqueFD for a file descriptor\n libcamera: process: Manage pipe fds by UniqueFD\n libcamera: media_device: Manage fd by UniqueFD\n libcamera: v4l2_device: Use UniqueFD for a file descriptor\n libcamera: v4l2_videodevice: Use fd for a file descriptor\n libcamera: pipeline: raspberrypi: DmaHeaps: Use UniqueFD for a file\n descriptor\n v4l2: v4l2_camera: Return int in getBufferFd()\n\nLaurent Pinchart (11):\n libcamera: Move compiler.h to base/\n libcamera: Move file_descriptor.h to base/\n libcamera: base: file_descriptor: Move inode() function to\n frame_buffer.cpp\n test: Add UniqueFD test\n libcamera: base: file_descriptor: Return UniqueFD from dup()\n libcamera: ipc_unixsocket: Fix file descriptor leak\n libcamera: v4l2_videodevice: Pass SharedFD to open()\n libcamera: base: Rename FileDescriptor to SharedFD\n libcamera: base: shared_fd: Add comparison operators\n libcamera: base: shared_fd: Rename fd() to get()\n libcamera: base: unique_fd: Pass rvalue reference to constructor and\n reset()\n\n include/libcamera/{ => base}/compiler.h | 0\n .../libcamera/base/event_dispatcher_poll.h | 3 +-\n include/libcamera/base/file.h | 7 +-\n include/libcamera/base/meson.build | 3 +\n include/libcamera/base/shared_fd.h | 59 ++++\n include/libcamera/base/unique_fd.h | 70 +++++\n include/libcamera/file_descriptor.h | 49 ---\n include/libcamera/framebuffer.h | 5 +-\n include/libcamera/geometry.h | 2 +-\n .../libcamera/internal/ipa_data_serializer.h | 40 +--\n include/libcamera/internal/ipc_pipe.h | 9 +-\n include/libcamera/internal/ipc_unixsocket.h | 7 +-\n include/libcamera/internal/media_device.h | 3 +-\n include/libcamera/internal/process.h | 4 +-\n include/libcamera/internal/v4l2_device.h | 9 +-\n include/libcamera/internal/v4l2_videodevice.h | 8 +-\n include/libcamera/ipa/core.mojom | 6 +-\n include/libcamera/ipa/raspberrypi.mojom | 2 +-\n include/libcamera/meson.build | 2 -\n src/android/camera_device.cpp | 2 +-\n src/cam/drm.cpp | 4 +-\n src/cam/image.cpp | 4 +-\n src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 6 +-\n src/libcamera/base/event_dispatcher_poll.cpp | 11 +-\n src/libcamera/base/file.cpp | 26 +-\n src/libcamera/base/meson.build | 2 +\n src/libcamera/base/shared_fd.cpp | 288 ++++++++++++++++++\n src/libcamera/base/unique_fd.cpp | 129 ++++++++\n src/libcamera/file_descriptor.cpp | 272 -----------------\n src/libcamera/framebuffer.cpp | 36 ++-\n src/libcamera/ipa_data_serializer.cpp | 100 +++---\n src/libcamera/ipc_pipe.cpp | 6 +-\n src/libcamera/ipc_pipe_unixsocket.cpp | 8 +-\n src/libcamera/ipc_unixsocket.cpp | 43 +--\n src/libcamera/mapped_framebuffer.cpp | 4 +-\n src/libcamera/media_device.cpp | 36 +--\n src/libcamera/meson.build | 1 -\n .../pipeline/raspberrypi/dma_heaps.cpp | 41 +--\n .../pipeline/raspberrypi/dma_heaps.h | 10 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 13 +-\n src/libcamera/process.cpp | 16 +-\n src/libcamera/v4l2_device.cpp | 23 +-\n src/libcamera/v4l2_videodevice.cpp | 65 ++--\n src/v4l2/v4l2_camera.cpp | 6 +-\n src/v4l2/v4l2_camera.h | 4 +-\n src/v4l2/v4l2_camera_proxy.cpp | 6 +-\n test/ipc/unixsocket.cpp | 14 +-\n test/ipc/unixsocket_ipc.cpp | 8 +-\n test/meson.build | 3 +-\n .../ipa_data_serializer_test.cpp | 14 +-\n test/{file-descriptor.cpp => shared-fd.cpp} | 86 +++---\n test/unique-fd.cpp | 222 ++++++++++++++\n .../module_ipa_proxy.cpp.tmpl | 2 +-\n .../module_ipa_proxy.h.tmpl | 2 +-\n .../module_ipa_proxy_worker.cpp.tmpl | 13 +-\n .../libcamera_templates/proxy_functions.tmpl | 2 +-\n .../libcamera_templates/serializer.tmpl | 22 +-\n .../generators/mojom_libcamera_generator.py | 6 +-\n 59 files changed, 1154 insertions(+), 692 deletions(-)\n rename include/libcamera/{ => base}/compiler.h (100%)\n create mode 100644 include/libcamera/base/shared_fd.h\n create mode 100644 include/libcamera/base/unique_fd.h\n delete mode 100644 include/libcamera/file_descriptor.h\n create mode 100644 src/libcamera/base/shared_fd.cpp\n create mode 100644 src/libcamera/base/unique_fd.cpp\n delete mode 100644 src/libcamera/file_descriptor.cpp\n rename test/{file-descriptor.cpp => shared-fd.cpp} (65%)\n create mode 100644 test/unique-fd.cpp\n\n\nbase-commit: 8178e01b36d767e05d7bbb9dd1f752f7ede0db3d"}