[{"id":21391,"web_url":"https://patchwork.libcamera.org/comment/21391/","msgid":"","date":"2021-11-30T04:02:55","subject":"Re: [libcamera-devel] [PATCH v5 0/4] Introduce Lens class and apply\n\tauto focus on ipu3","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Han-lin,\n\nOn Fri, Nov 26, 2021 at 07:28:59PM +0800, Han-Lin Chen wrote:\n> Hello,\n> The v5 series address further kind comments, moving model() into V4L2Subdevice\n> instead of an extra file, typos and styles.\n\nI've reviewed the first three patches and have only small comments. For\n4/4, should it be rebased on top of Dan's work adding support for\nancillary links ?\n\n> Han-Lin Chen (4):\n> ipa: ipu3: Extend ipu3 ipa interface for lens controls\n> libcamera: add model() for retriving model name in V4L2Subdevice\n> libcamera: camera_lens: Add a new class to model a camera lens\n> ipu3: ipa: Allow IPA to apply controls to the lens device\n> \n> Documentation/index.rst | 1 +\n> Documentation/lens_driver_requirements.rst | 27 ++++\n> Documentation/meson.build | 1 +\n> include/libcamera/internal/camera_lens.h | 48 +++++++\n> include/libcamera/internal/meson.build | 1 +\n> include/libcamera/internal/v4l2_subdevice.h | 5 +\n> include/libcamera/ipa/ipu3.mojom | 2 +\n> src/libcamera/camera_lens.cpp | 142 ++++++++++++++++++++\n> src/libcamera/camera_sensor.cpp | 13 +-\n> src/libcamera/meson.build | 1 +\n> src/libcamera/pipeline/ipu3/cio2.cpp | 29 ++++\n> src/libcamera/pipeline/ipu3/cio2.h | 3 +\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +-\n> src/libcamera/v4l2_subdevice.cpp | 40 ++++++\n> 14 files changed, 312 insertions(+), 13 deletions(-)\n> create mode 100644 Documentation/lens_driver_requirements.rst\n> create mode 100644 include/libcamera/internal/camera_lens.h\n> create mode 100644 src/libcamera/camera_lens.cpp\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A011DBDB13\n\tfor ;\n\tTue, 30 Nov 2021 04:03:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53F59605B4;\n\tTue, 30 Nov 2021 05:03:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FC9E604FC\n\tfor ;\n\tTue, 30 Nov 2021 05:03:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A03E8F0;\n\tTue, 30 Nov 2021 05:03:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mbQAY5b8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638244999;\n\tbh=8NOofZ5IpC7Q+EbSEaU4wMWdbHkR+u8si6hXyVY4qxo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mbQAY5b8MSD1/TCWHvDTRRB62qwmjVImNMw5vWCPvNkufW/KSo/znTYygeMuGIoJy\n\t8GP0rcbIiExd7OrmnxBAudqhmwtiCQPFhIb21vQaJlqKb3PKimW6LQHDGdosMDkBjQ\n\trhGYB7oQ7jUKRUp8tYidvgB+eFIuVDSlV9jYS/ro=","Date":"Tue, 30 Nov 2021 06:02:55 +0200","From":"Laurent Pinchart ","To":"Han-Lin Chen ","Message-ID":"","References":"<20211126112903.3276056-1-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211126112903.3276056-1-hanlinchen@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v5 0/4] Introduce Lens class and apply\n\tauto focus on ipu3","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21434,"web_url":"https://patchwork.libcamera.org/comment/21434/","msgid":"","date":"2021-11-30T10:02:14","subject":"Re: [libcamera-devel] [PATCH v5 0/4] Introduce Lens class and apply\n\tauto focus on ipu3","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"content":"Hi Laurent,\n\nOn Tue, Nov 30, 2021 at 12:03 PM Laurent Pinchart\n wrote:\n>\n> Hi Han-lin,\n>\n> On Fri, Nov 26, 2021 at 07:28:59PM +0800, Han-Lin Chen wrote:\n> > Hello,\n> > The v5 series address further kind comments, moving model() into V4L2Subdevice\n> > instead of an extra file, typos and styles.\n>\n> I've reviewed the first three patches and have only small comments. For\n> 4/4, should it be rebased on top of Dan's work adding support for\n> ancillary links ?\nYes, I think I can remove the lens mapping part and it can be placed\nbetween Daniel's patches 3/5 and 4/5:\n[libcamera-devel,3/5] libcamera: ipu3-cio2: Discover VCMs through\nancillary links.\n[libcamera-devel,4/5] ipa: ipu3: Send lens controls to pipeline handler\nIf Daniel doesn't mind cherry-pick it to that series.\n>\n> > Han-Lin Chen (4):\n> > ipa: ipu3: Extend ipu3 ipa interface for lens controls\n> > libcamera: add model() for retriving model name in V4L2Subdevice\n> > libcamera: camera_lens: Add a new class to model a camera lens\n> > ipu3: ipa: Allow IPA to apply controls to the lens device\n> >\n> > Documentation/index.rst | 1 +\n> > Documentation/lens_driver_requirements.rst | 27 ++++\n> > Documentation/meson.build | 1 +\n> > include/libcamera/internal/camera_lens.h | 48 +++++++\n> > include/libcamera/internal/meson.build | 1 +\n> > include/libcamera/internal/v4l2_subdevice.h | 5 +\n> > include/libcamera/ipa/ipu3.mojom | 2 +\n> > src/libcamera/camera_lens.cpp | 142 ++++++++++++++++++++\n> > src/libcamera/camera_sensor.cpp | 13 +-\n> > src/libcamera/meson.build | 1 +\n> > src/libcamera/pipeline/ipu3/cio2.cpp | 29 ++++\n> > src/libcamera/pipeline/ipu3/cio2.h | 3 +\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +-\n> > src/libcamera/v4l2_subdevice.cpp | 40 ++++++\n> > 14 files changed, 312 insertions(+), 13 deletions(-)\n> > create mode 100644 Documentation/lens_driver_requirements.rst\n> > create mode 100644 include/libcamera/internal/camera_lens.h\n> > create mode 100644 src/libcamera/camera_lens.cpp\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3A20BF415\n\tfor ;\n\tTue, 30 Nov 2021 10:02:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9444605B4;\n\tTue, 30 Nov 2021 11:02:27 +0100 (CET)","from mail-ot1-x336.google.com (mail-ot1-x336.google.com\n\t[IPv6:2607:f8b0:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16A2A60230\n\tfor ;\n\tTue, 30 Nov 2021 11:02:26 +0100 (CET)","by mail-ot1-x336.google.com with SMTP id\n\tu18-20020a9d7212000000b00560cb1dc10bso29478401otj.11\n\tfor ;\n\tTue, 30 Nov 2021 02:02:25 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"GZY9JMpo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=0VvDSCFRmaHWBd+9Q+Uzd6XZYN+MAGnlEsEvbqsCp5I=;\n\tb=GZY9JMpoULvTd8LdxNmESP9ySdVMFM4lB1f241NnFZEW/H6Q4wn0JJkEuTG+ObEJqR\n\tgsLbmJhvB9kr+SFPUDnAyWtgZUs/5atAL6jHYs0DwRRhbNtI2eJ0Y14b200obdmyAHIt\n\tMkhLxES8djZ2rVSSQRF4rhAhdRMvgPyRUOMik=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=0VvDSCFRmaHWBd+9Q+Uzd6XZYN+MAGnlEsEvbqsCp5I=;\n\tb=CmO4S6YcqYA6tyZc2ozfNF2YXZ3sYvC+WezSWOBbDS8kKEAEa7a9esmMbP2rVRqrAX\n\tRliAxZ1FrNZSpzyQc6Vhkj68HnaglSOrf8iS+PbmtBwPbsWJ2XCnNwyrtTNAkHPhVfRL\n\tvJA0nSccwvOI8BSpDnSFtV+J+c0TQC0JW40Wl+ENnt0CPVoS/fT3qfURNL7SYMuWhArO\n\tFeiGZKqMNcYbnA49RS6UADGtW5g4XKyN7AEU/a+ZcjQ6/OKUb6O8D3LvQqgT3G7lG6CG\n\t9jvak1nVsgaE8mWS+ItzT2qBB2jLhilPnfm+iDsx8tSULlnwsUAah7UU0d7Z2z7yWfN+\n\tfneA==","X-Gm-Message-State":"AOAM530D/ia9Ql7G3PtHOw5oyoazdvS+LNjWczIrTRW35i5hTmDYhEnp\n\tZO9+ozkj9lUjvhTSFvaYl1UQeC5Fcif7ymiYv/jaJ+8llPCiwg==","X-Google-Smtp-Source":"ABdhPJxkJEHiXFhfnRxy/iw65oZWW5EfbWLVX5u08WF1QPCXipumvWEZC5ysSxTOTSsk35ViuhQCa75EI0VIpjLQ3Xw=","X-Received":"by 2002:a9d:2605:: with SMTP id\n\ta5mr32251510otb.217.1638266544843; \n\tTue, 30 Nov 2021 02:02:24 -0800 (PST)","MIME-Version":"1.0","References":"<20211126112903.3276056-1-hanlinchen@chromium.org>\n\t","In-Reply-To":"","From":"Hanlin Chen ","Date":"Tue, 30 Nov 2021 18:02:14 +0800","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v5 0/4] Introduce Lens class and apply\n\tauto focus on ipu3","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21435,"web_url":"https://patchwork.libcamera.org/comment/21435/","msgid":"<23c2e4fd-7423-d0fc-8783-b3ae8af477eb@gmail.com>","date":"2021-11-30T10:04:03","subject":"Re: [libcamera-devel] [PATCH v5 0/4] Introduce Lens class and apply\n\tauto focus on ipu3","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/people/90/","name":"Daniel Scally","email":"djrscally@gmail.com"},"content":"Hello\n\nOn 30/11/2021 10:02, Hanlin Chen wrote:\n> Hi Laurent,\n>\n> On Tue, Nov 30, 2021 at 12:03 PM Laurent Pinchart\n> wrote:\n>> Hi Han-lin,\n>>\n>> On Fri, Nov 26, 2021 at 07:28:59PM +0800, Han-Lin Chen wrote:\n>>> Hello,\n>>> The v5 series address further kind comments, moving model() into V4L2Subdevice\n>>> instead of an extra file, typos and styles.\n>> I've reviewed the first three patches and have only small comments. For\n>> 4/4, should it be rebased on top of Dan's work adding support for\n>> ancillary links ?\n> Yes, I think I can remove the lens mapping part and it can be placed\n> between Daniel's patches 3/5 and 4/5:\n> [libcamera-devel,3/5] libcamera: ipu3-cio2: Discover VCMs through\n> ancillary links.\n> [libcamera-devel,4/5] ipa: ipu3: Send lens controls to pipeline handler\n> If Daniel doesn't mind cherry-pick it to that series.\n\n\nNo problem at all\n\n>>> Han-Lin Chen (4):\n>>> ipa: ipu3: Extend ipu3 ipa interface for lens controls\n>>> libcamera: add model() for retriving model name in V4L2Subdevice\n>>> libcamera: camera_lens: Add a new class to model a camera lens\n>>> ipu3: ipa: Allow IPA to apply controls to the lens device\n>>>\n>>> Documentation/index.rst | 1 +\n>>> Documentation/lens_driver_requirements.rst | 27 ++++\n>>> Documentation/meson.build | 1 +\n>>> include/libcamera/internal/camera_lens.h | 48 +++++++\n>>> include/libcamera/internal/meson.build | 1 +\n>>> include/libcamera/internal/v4l2_subdevice.h | 5 +\n>>> include/libcamera/ipa/ipu3.mojom | 2 +\n>>> src/libcamera/camera_lens.cpp | 142 ++++++++++++++++++++\n>>> src/libcamera/camera_sensor.cpp | 13 +-\n>>> src/libcamera/meson.build | 1 +\n>>> src/libcamera/pipeline/ipu3/cio2.cpp | 29 ++++\n>>> src/libcamera/pipeline/ipu3/cio2.h | 3 +\n>>> src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +-\n>>> src/libcamera/v4l2_subdevice.cpp | 40 ++++++\n>>> 14 files changed, 312 insertions(+), 13 deletions(-)\n>>> create mode 100644 Documentation/lens_driver_requirements.rst\n>>> create mode 100644 include/libcamera/internal/camera_lens.h\n>>> create mode 100644 src/libcamera/camera_lens.cpp\n>>>\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 167A2BDB13\n\tfor ;\n\tTue, 30 Nov 2021 10:04:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB1F9605B4;\n\tTue, 30 Nov 2021 11:04:06 +0100 (CET)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFC3660230\n\tfor ;\n\tTue, 30 Nov 2021 11:04:04 +0100 (CET)","by mail-wr1-x433.google.com with SMTP id a9so43135756wrr.8\n\tfor ;\n\tTue, 30 Nov 2021 02:04:04 -0800 (PST)","from [192.168.0.14]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tk37sm2132983wms.21.2021.11.30.02.04.04\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 30 Nov 2021 02:04:04 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"NvY+NIZn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-transfer-encoding:content-language;\n\tbh=IGn6mAX3Ml8b1PCL/wfiRDjMuLqJXGhoSUDERG25jFM=;\n\tb=NvY+NIZnNBmp2ISb+9P3X6ECDLLafYYd8QZaz1RbldfMnnbdoPOgN0K93cOcHI3MW7\n\taaTklOsvLWz9qtC1cCFbFODbgn09OmoqYqulTut/p5yEKfQCkdqrKIlq21li/84nbM+N\n\tCtA1UEQX28u8tPi3wEvUJO2brflT3oitzBLe0sP+i4zHhSTQTBLUsbwVADu+yK4aGAKb\n\tbEwDJh/KCjaqVxhl6+/REAKZxECgqjanrb8e5mvq3JL2Plx4H3zNF0mknHEvkYinuaWL\n\tRIij5bA+kBAQMbeWcdvBnuADl1w5ExR88deFzpuZKrtiB+1aqWtQ12GLXE9LaKfWQreZ\n\tZDHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding\n\t:content-language;\n\tbh=IGn6mAX3Ml8b1PCL/wfiRDjMuLqJXGhoSUDERG25jFM=;\n\tb=C/2YjVik6kw2OOC/7hjbK19AabjSBmQM4wsCbiydmwfeDMZcjVd9NQqATGPUMKlK4T\n\tGU+4t36YAvWZsy5jsfHlWzjkYIVoczcGAvUi5Uoagpct9pUTtH0ID4+RmqwgwbiMmdso\n\tctWmLDR+2DfOWEgBtLSC1UyLTT3KY9kcHMDngy6SVhaauo8hGCcRLE5g2GgltTm2gf73\n\tVfj0OBjZKwWzMjdMf8CUcbwmvZzyw2wjHGnyC2XELUkapOdyTpcEmbJfL6h+UAqVDGCZ\n\tCsTM6S+8hnusOmPSzGCPoRSjgj+3f157Z71fcHYS3x/s902qG4ADW68bYCOD+6PbSSx3\n\tAYQA==","X-Gm-Message-State":"AOAM533JiADXn+FKAHmmLW+dH9cEKCg9FcHGq09urUwxHa/KsQnJdyJQ\n\tHbPuaTxcigbxtZkX/yJSLViyQ+Utfu4=","X-Google-Smtp-Source":"ABdhPJwjhtwvvQtEyVFc8p6pGMjdIhlO6kKGnHN5zVriwUYYjlBGC/HukiD03P3NMdA25i1mkl+PIw==","X-Received":"by 2002:adf:f749:: with SMTP id\n\tz9mr40417621wrp.379.1638266644627; \n\tTue, 30 Nov 2021 02:04:04 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","References":"<20211126112903.3276056-1-hanlinchen@chromium.org>\n\t\n\t","From":"Daniel Scally ","Message-ID":"<23c2e4fd-7423-d0fc-8783-b3ae8af477eb@gmail.com>","Date":"Tue, 30 Nov 2021 10:04:03 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.14.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v5 0/4] Introduce Lens class and apply\n\tauto focus on ipu3","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]