[{"id":21189,"web_url":"https://patchwork.libcamera.org/comment/21189/","msgid":"<163775209584.2984710.3560723041868159124@Monstersaurus>","date":"2021-11-24T11:08:15","subject":"Re: [libcamera-devel] [RFC v2 0/1] ipa: ipu3: af: Auto focus for\n\tdw9719 Surface Go2 VCM","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kate Hsuan (2021-11-24 10:34:46)\n> The v1 patch provides a POC implementation of the IPU3 auto focus\n> algorithm. In this v2 patch, the grid configuration interface and IPU3\n> AF accelerator configuration are also added into the AF class. Also, the\n> default AF area is moved from the top left corner of the sensor to the\n> center of the sensor and can be configured in configure(). Documents of\n> the class and variable are also added.\n> \n> For the hardcoded VCM control, I'm still trying to understand the\n> control architecture. Please allow me more time to move them to the\n> correct place.\n\nSure, it's fine to work with this as you have it to get the algorithm\nrunning.\n\nYou could likely apply Han-Lin's CameraLens series [0] and work on top of\nthat to see how we might set the controls through the pipeline handler,\nrather than the IPA. He sets the control for the lens position through\nthe extended IPA interface with [1].\n\nSome of this may still be subject to change, but it might help\nvisualising how the controls would be passed and set from the pipeline\nhandler rather than the IPA directly.\n\n[0] https://patchwork.libcamera.org/project/libcamera/list/?series=2743\n[1] https://patchwork.libcamera.org/project/libcamera/list/?series=2744\n\n--\nKieran\n\n\n> \n> Kate Hsuan (1):\n> ipa: ipu3: af: Auto focus for dw9719 Surface Go2 VCM\n> \n> src/ipa/ipu3/algorithms/af.cpp | 284 ++++++++++++++++++++++++++++\n> src/ipa/ipu3/algorithms/af.h | 54 ++++++\n> src/ipa/ipu3/algorithms/agc.cpp | 2 +-\n> src/ipa/ipu3/algorithms/meson.build | 3 +-\n> src/ipa/ipu3/ipa_context.cpp | 26 +++\n> src/ipa/ipu3/ipa_context.h | 11 ++\n> src/ipa/ipu3/ipu3.cpp | 2 +\n> 7 files changed, 380 insertions(+), 2 deletions(-)\n> create mode 100644 src/ipa/ipu3/algorithms/af.cpp\n> create mode 100644 src/ipa/ipu3/algorithms/af.h\n> \n> -- \n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B187BF415\n\tfor ;\n\tWed, 24 Nov 2021 11:08:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6252F60371;\n\tWed, 24 Nov 2021 12:08:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3962E60128\n\tfor ;\n\tWed, 24 Nov 2021 12:08:18 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CEA6E993;\n\tWed, 24 Nov 2021 12:08:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XctRDy2q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637752097;\n\tbh=3aqwJPa0u45XWKjqgKvNReepjRDY05PCeJG+11fwSsA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=XctRDy2qWSGpUQtmD0u/3/Trd6aTBi8Vi3Ado0sVdutc/qooR3AHYwAetE49xuyNp\n\tDmzwAXscWxryQfrCpNP3YK8iF9KrVnLOInYeJI/5PoKYvYdgOGFlOk0uO4cJPmOuTP\n\ttlpqot9je9FqzuStVGiMo3e5bhSMuXTPb2fXv7WE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211124103447.102069-1-hpa@redhat.com>","References":"<20211124103447.102069-1-hpa@redhat.com>","From":"Kieran Bingham ","To":"Kate Hsuan ,\n\tlibcamera devel ","Date":"Wed, 24 Nov 2021 11:08:15 +0000","Message-ID":"<163775209584.2984710.3560723041868159124@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [RFC v2 0/1] ipa: ipu3: af: Auto focus for\n\tdw9719 Surface Go2 VCM","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]