{"id":14625,"url":"https://patchwork.libcamera.org/api/covers/14625/?format=json","web_url":"https://patchwork.libcamera.org/cover/14625/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211118151933.15627-1-david.plowman@raspberrypi.com>","date":"2021-11-18T15:19:26","name":"[libcamera-devel,v6,0/7] Colour spaces","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/14625/mbox/","series":[{"id":2726,"url":"https://patchwork.libcamera.org/api/series/2726/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2726","date":"2021-11-18T15:19:26","name":"Colour spaces","version":6,"mbox":"https://patchwork.libcamera.org/series/2726/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/14625/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 315ADBF415\n\tfor ;\n\tThu, 18 Nov 2021 15:20:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAD716038C;\n\tThu, 18 Nov 2021 16:20:27 +0100 (CET)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E91760231\n\tfor ;\n\tThu, 18 Nov 2021 16:20:25 +0100 (CET)","by mail-wr1-x42e.google.com with SMTP id i5so12303216wrb.2\n\tfor ;\n\tThu, 18 Nov 2021 07:20:25 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm147367wro.33.2021.11.18.07.20.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Nov 2021 07:20:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"LrZAlxjN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=R4/p7uP0QJqxjLfDeo8xd5JBqwpPtnwHa8VtEFPdRzc=;\n\tb=LrZAlxjNWuBmKkCBUWIobhT9qhKqmCBO3NeyDDfzFHbUF23gyIw5UPwLASyNGjL1vU\n\t/7gpygMJgdoBtOufunwq8UP87NRsuSU79vul2TG+9Q604tT/vaOWuqO35b9q76wEcdsv\n\tRdOYuyvC7q6oYqTPO2Zcp/Tm6edL3VJaq0aF0CwR8JT7Hjfwo6mlUsIPkNYgi1fWPURn\n\tixMyPke6gj5XOJZ1AE2K0tonp0sSTF4FVC/YljW0+dwkN09Q2D38mbIP+KT5uPe6Jkgm\n\tjMYKp/LhUV8/QNMBVOvYCtFaa48KkNYh+4D1YBAJWSiZD2POC99xr3HeGBVBX89rWfNC\n\tH5Dw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=R4/p7uP0QJqxjLfDeo8xd5JBqwpPtnwHa8VtEFPdRzc=;\n\tb=zWF+w+SCMcn2Ikj5+xwWZp9lBz6C2X1T+xXgU+NAtpHwEWMC4TaGtp9h1rt2IDH2bi\n\tgcLhlvxBfqT3SWSbCMw1w75bIxBHdSjB/BeaQ0r59wklTS6mwnGpDMweHbP9UTZ1uVtO\n\tsSuSWOysB4C6yhNSxyF9C3Gj9kFbBqxdapJ4Jl7wl2KSzW/EsWFln8geYI6fkQcGxFk9\n\tDCyP+aStZLIJxXf24vK7PpFQzG3BwT9Upjbe20uckbKDZpx6R9e/7Kn9oAioJYRINkmQ\n\tiwEx+QOIu92PhRmzygfVoGLulM/1GFyX5P4gokRGAc6qw/v/+4QGDyMrIxzkQtvaa+1t\n\toLIQ==","X-Gm-Message-State":"AOAM532jMyiTmNUBf1kvTasjK8NOwqb8eHZBi+a5nZ3eAxFP9OXYct3X\n\tAyNp8Tz4AZuc9XHeT294PbCYJw==","X-Google-Smtp-Source":"ABdhPJwZSsF90BNZ6iwtwBZpFe4D6Cw40CpPHzLQ6AP+9WwfpFZIyKmfpMBCd+PVB0vjqSeb7/G5Cg==","X-Received":"by 2002:a05:6000:2a2:: with SMTP id\n\tl2mr31378747wry.110.1637248825090; \n\tThu, 18 Nov 2021 07:20:25 -0800 (PST)","From":"David Plowman ","To":"laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com,\n\thverkuil-cisco@xs4all.nl, tfiga@google.com, jacopo@jmondi.org,\n\tnaush@raspberrypi.com, libcamera-devel@lists.libcamera.org","Date":"Thu, 18 Nov 2021 15:19:26 +0000","Message-Id":"<20211118151933.15627-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 0/7] Colour spaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi everyone\n\nThanks very much to everyone who took part in the call the other day,\nI think it's a big help in trying to get important topics unblocked!\n\nFollowing on from that, here's a v6 version of this patch set. There\nare a few things to point out:\n\n* std::optional has reappeared, so you can now avoid saying what\n colour space you want. std::optional percolates all the way down to\n our V4L2 interface where an unset colour space will result in\n passing \"all default\" to the actual driver.\n\n* The set of colour spaces I've defined for the ColorSpace class is\n pretty minimal, though it includes, I expect, the vast majority of\n real use cases. But we should add others that folks expect to use.\n\n* If a device uses a colour space that isn't included in the\n ColorSpace class list, then an error message will be output though\n the program will continue. This indicates that you really ought to\n take a look and consider adding the missing ColorSpace.\n\n* Actually, given that we use std::optional, if a device's colour\n space doesn't have a matching ColorSpace, then it will return an\n \"unset\" value. (Whenever you get \"unset\" back as the colour space,\n then that's definitely a warning sign.)\n\n* There's a corner case about metadata pads - unsurprisingly we can't\n find a matching ColorSpace so you get a warning printed out. Is\n there a \"proper\" way to detect that it's a metadata pad in that bit\n of code?\n\n* We did talk about having the StreamConfiguration contain a list of\n the acceptable colour spaces. I haven't added that yet, do we want\n to? We could do so as an extra patch.\n\nI'm sorry if it feels a bit like we're starting again here, but\nhopefully we're now moving forwards rather than round in circles, with\nminimal risk of completely changing our minds!\n\nThanks again\nDavid\n\n\nDavid Plowman (7):\n libcamera: Add ColorSpace class\n libcamera: Add ColorSpace fields to StreamConfiguration\n libcamera: Convert between ColorSpace class and V4L2 formats\n libcamera: Support passing ColorSpaces to V4L2 video devices\n libcamera: Support passing ColorSpaces to V4L2 subdevices\n libcamera: Add validateColorSpaces to CameraConfiguration class\n libcamera: pipeline: raspberrypi: Support color spaces\n\n include/libcamera/camera.h | 2 +\n include/libcamera/color_space.h | 79 ++++++\n include/libcamera/internal/v4l2_device.h | 7 +\n include/libcamera/internal/v4l2_subdevice.h | 2 +\n include/libcamera/internal/v4l2_videodevice.h | 2 +\n include/libcamera/meson.build | 1 +\n include/libcamera/stream.h | 3 +\n src/libcamera/camera.cpp | 51 ++++\n src/libcamera/camera_sensor.cpp | 1 +\n src/libcamera/color_space.cpp | 243 ++++++++++++++++++\n src/libcamera/meson.build | 1 +\n .../pipeline/raspberrypi/raspberrypi.cpp | 42 +++\n src/libcamera/stream.cpp | 14 +\n src/libcamera/v4l2_device.cpp | 190 ++++++++++++++\n src/libcamera/v4l2_subdevice.cpp | 35 ++-\n src/libcamera/v4l2_videodevice.cpp | 53 +++-\n 16 files changed, 721 insertions(+), 5 deletions(-)\n create mode 100644 include/libcamera/color_space.h\n create mode 100644 src/libcamera/color_space.cpp"}