[{"id":20985,"web_url":"https://patchwork.libcamera.org/comment/20985/","msgid":"<163716761834.420308.3685945789530020350@Monstersaurus>","date":"2021-11-17T16:46:58","subject":"Re: [libcamera-devel] [PATCH v2 0/3] raspberrypi: Rework the\n\tinternal buffer allocation scheme","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2021-11-12 10:03:02)\n> Hi,\n> \n> The second version of this series changes the following over v1:\n> \n> - Apply Laurent's suggestions in patch 2/3.\n> - Allocate 2 internal buffers for Unicam instead of one in patch 2/3.\n\nI'm getting curious about that VIDEO_MAX_FRAME and whether we should\njust always allocate that in the V4L2VideoDevice class, and then do away\nwith the importBuffers(count); function altogether, as it would be\nredundant ... But that's not necessarily a requriement for this series -\njust thinking out loud.\n\nWould you like this series merged? Or are we waiting on confirmation of\nthe symptoms/issues from Roman before we commit to these patches?\n\n--\nKieran\n\n\n> \n> Thanks,\n> Naush\n> \n> Naushir Patuck (3):\n> pipeline: raspberrypi: Add const qualifer in isRaw()\n> pipeline: raspberrypi: Rework the internal buffer allocation scheme\n> pipeline: raspberrypi: Increase the V4L2BufferCache slot allocations\n> \n> .../pipeline/raspberrypi/raspberrypi.cpp | 45 ++++++++++++++-----\n> .../pipeline/raspberrypi/rpi_stream.cpp | 8 ++++\n> 2 files changed, 41 insertions(+), 12 deletions(-)\n> \n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20BA2BDB1C\n\tfor ;\n\tWed, 17 Nov 2021 16:47:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F16A60376;\n\tWed, 17 Nov 2021 17:47:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E72960121\n\tfor ;\n\tWed, 17 Nov 2021 17:47:01 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B94BEE7;\n\tWed, 17 Nov 2021 17:47:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r57KJso4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637167620;\n\tbh=El2+m5ptoyGxX+at78icNFPsusSvPKvkVVdJdAMfdKg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=r57KJso4m+iM1D2xQ/X8cxf7Ug4Tsm7Fiutm5f9j88arZAA+FhZ8/O5QhsqG4dbbq\n\tRNOFKYpXGg+OK21U9/11CO9LJYvW1AkfbnY6lkIpF4BWLJpbnU/8OAussYX13FYISu\n\t9y+7HO62ejBA/OPcpSOm/kLPZqOcDUJvQfj/nTtY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211112100305.2217099-1-naush@raspberrypi.com>","References":"<20211112100305.2217099-1-naush@raspberrypi.com>","From":"Kieran Bingham ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 17 Nov 2021 16:46:58 +0000","Message-ID":"<163716761834.420308.3685945789530020350@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] raspberrypi: Rework the\n\tinternal buffer allocation scheme","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Roman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20990,"web_url":"https://patchwork.libcamera.org/comment/20990/","msgid":"","date":"2021-11-17T21:50:30","subject":"Re: [libcamera-devel] [PATCH v2 0/3] raspberrypi: Rework the\n\tinternal buffer allocation scheme","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nOn Wed, 17 Nov 2021 at 16:47, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Quoting Naushir Patuck (2021-11-12 10:03:02)\n> > Hi,\n> >\n> > The second version of this series changes the following over v1:\n> >\n> > - Apply Laurent's suggestions in patch 2/3.\n> > - Allocate 2 internal buffers for Unicam instead of one in patch 2/3.\n>\n> I'm getting curious about that VIDEO_MAX_FRAME and whether we should\n> just always allocate that in the V4L2VideoDevice class, and then do away\n> with the importBuffers(count); function altogether, as it would be\n> redundant ... But that's not necessarily a requriement for this series -\n> just thinking out loud.\n>\n\nYes, that could be an option, buffer slots are fairly small storage\nelements,\nso it should not increase the memory footprint too much.\n\n\n>\n> Would you like this series merged? Or are we waiting on confirmation of\n> the symptoms/issues from Roman before we commit to these patches?\n>\n\nI'm inclined to say we merge this series now, as it does fix\noverallocations.\nGiven we don't know exactly what the cause of Roman's issues are, I would\nprefer to fix time on top of these patches.\n\nRegards,\nNaush\n\n\n>\n> --\n> Kieran\n>\n>\n> >\n> > Thanks,\n> > Naush\n> >\n> > Naushir Patuck (3):\n> > pipeline: raspberrypi: Add const qualifer in isRaw()\n> > pipeline: raspberrypi: Rework the internal buffer allocation scheme\n> > pipeline: raspberrypi: Increase the V4L2BufferCache slot allocations\n> >\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 45 ++++++++++++++-----\n> > .../pipeline/raspberrypi/rpi_stream.cpp | 8 ++++\n> > 2 files changed, 41 insertions(+), 12 deletions(-)\n> >\n> > --\n> > 2.25.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD1DCBDB1C\n\tfor ;\n\tWed, 17 Nov 2021 21:50:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2648360376;\n\tWed, 17 Nov 2021 22:50:51 +0100 (CET)","from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5198D60121\n\tfor ;\n\tWed, 17 Nov 2021 22:50:49 +0100 (CET)","by mail-lf1-x135.google.com with SMTP id f18so15385259lfv.6\n\tfor ;\n\tWed, 17 Nov 2021 13:50:49 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"p4Ir3yk/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=R6wxD5SCyJ24CywUuGDffWM11rVPkp2tHJM/o10kSuE=;\n\tb=p4Ir3yk/CsFo2U0z+PqQYqxwQdf6Somfy/2PA8zanKz/KQJAEL3UEX8KyqQ9XeDMO8\n\tud4Yn6mrKEDjXGyJ3Jsq/pzjHDP6R2istPXOcncmI42WC+vLf8wN1vP5qzmxXHyDzkY3\n\teONey31PoZfgWJo4JOiivzLczoqp5Jn7S1kqSNYZAj/jyfLl6FFX/n/lMlINDvJIivH5\n\tgU6cUTylKCtJbaoYCv3cge3BbU0RGBPuzb/9WbFnhv3WJBUhNYSo2hpTDCMr8pMWRZjt\n\thr6xh5i6gcBbycKiTm4uomlsbGo0Pdkw0xfPu96I2jQPrrFKZLguoV82nERei/BMiGEa\n\tzuSg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=R6wxD5SCyJ24CywUuGDffWM11rVPkp2tHJM/o10kSuE=;\n\tb=Yb5D8l2yeMw2muKWXVVloVyHckqKSmM+h6TFb7Im+AW2susLVCsDfL7LpcREJAG2fp\n\tT/yxGLtGOxgCtavi50GriiPfdfeZjVlvZ+qsptzjTMHgGlblj1zpAIP5Taj1aUZMZMsM\n\tN2iw4KbjRPdeJn8j65mMMhyYYcyADCeQfq54VzHnkckOq3KjpuswwNsxqRbJ/KSBj1A4\n\tbiveNmNqak+/C/l8la7vxs6q8IhXkpKf1lvSEgyZxc4O3UJPTWMFyznPPDKo8ZfUpU6o\n\tvhYDglixRYkkA0zL8w3PNenoSJdIp5VBZbklElRY9rsyBEq7/U9LfLiY35RKxa/OnAvD\n\tbxjA==","X-Gm-Message-State":"AOAM531dC5QsMJqeK3ihkEqBMGifqDde+EVKrEsK3Vah/MnhbeEoAD/P\n\t//053QDpp2b6putWKu5Gi5stw0K7WBEk/zcp3XU3/Q==","X-Google-Smtp-Source":"ABdhPJw8+WEMBliehe3H5UtZkqNlax9Y1nN6FQeasWiCRaGNuwYAVG3Oe3p4V//prEQ1U3ieHNeAGfBvIUlj4HtNeGg=","X-Received":"by 2002:a19:6754:: with SMTP id\n\te20mr17655918lfj.122.1637185848219; \n\tWed, 17 Nov 2021 13:50:48 -0800 (PST)","MIME-Version":"1.0","References":"<20211112100305.2217099-1-naush@raspberrypi.com>\n\t<163716761834.420308.3685945789530020350@Monstersaurus>","In-Reply-To":"<163716761834.420308.3685945789530020350@Monstersaurus>","From":"Naushir Patuck ","Date":"Wed, 17 Nov 2021 21:50:30 +0000","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"000000000000ea2fbd05d10308ef\"","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] raspberrypi: Rework the\n\tinternal buffer allocation scheme","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tRoman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]