{"id":14409,"url":"https://patchwork.libcamera.org/api/covers/14409/?format=json","web_url":"https://patchwork.libcamera.org/cover/14409/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211029041424.1430886-1-hiroh@chromium.org>","date":"2021-10-29T04:14:18","name":"[libcamera-devel,RFC,0/6] Introduce clang thread safety annotations","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/14409/mbox/","series":[{"id":2678,"url":"https://patchwork.libcamera.org/api/series/2678/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2678","date":"2021-10-29T04:14:18","name":"Introduce clang thread safety annotations","version":1,"mbox":"https://patchwork.libcamera.org/series/2678/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/14409/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5742ABF415\n\tfor ;\n\tFri, 29 Oct 2021 04:14:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6AA7C600BC;\n\tFri, 29 Oct 2021 06:14:33 +0200 (CEST)","from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n\t[IPv6:2607:f8b0:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D2E1600B6\n\tfor ;\n\tFri, 29 Oct 2021 06:14:31 +0200 (CEST)","by mail-pl1-x62d.google.com with SMTP id s24so6016877plp.0\n\tfor ;\n\tThu, 28 Oct 2021 21:14:31 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:fd56:8786:5663:b946])\n\tby smtp.gmail.com with ESMTPSA id\n\t11sm4826714pfl.41.2021.10.28.21.14.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 Oct 2021 21:14:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"eLCuAr9n\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Woryt8aUa1wgVOZkhHxuRkU1lMs91m3QSybI0HiLwhc=;\n\tb=eLCuAr9nHhFKhBPcKzxx5KtGWYtKr5P6PJCNKeJUTKWXYEndqPYzs5UpEI6WmOC0wC\n\tvk6a+HM/tNLi+qSWve8HMzLmLMInHeYEdUJKUbDb/wYay0RIpsfGyD0fAYbVvyUq2770\n\tZ1cXpdbXr8gvupYD8syMumpM5N/rmHLywWT4w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Woryt8aUa1wgVOZkhHxuRkU1lMs91m3QSybI0HiLwhc=;\n\tb=1WlCiE+sswq9gAtLzjNRW4l82rSGlX9eET8fafx9FqOFM0icvHBF7tOp3R044NMV9d\n\tziHjbXE8bTFaYFaWHzTKgZOFFTFQQJB1L6wasdMz8EU/1fqodY1haWYEb9ohJ0UgHC7T\n\teZjrR1wwd00mLd+gqHJ5HmLFPK2TzAyFYTnyi/8pTZ4lAV5EIS/YtmWWDMB04DTbMxeS\n\tn7JmXZsYDJq3j3DJJhSCsSLZljRfgBHYgOrFihOcN8+65Dj3Th3VgfEke7TvKjkoIIa8\n\tB/X6XyipVq3uEZF2EZejv9OUIZtXQNBSkm25688QLxt6i8GHAGeqI8xtdTzpOASW+M6t\n\tGcrg==","X-Gm-Message-State":"AOAM533Lfmkk9RfaKtbWMvTd685dNS4GZixPLyd5eH3zz9U7CFS8+UFI\n\tVt8UN5PVY0LDAVs/mK15HI60TxtcuTcsmg==","X-Google-Smtp-Source":"ABdhPJxXgyCAnNvA0DLphQfwnAeVNyI8F/GVYlVt3JSSkMKi73/6vXT+FnBlAj3UUIBq6FUaFnd72A==","X-Received":"by 2002:a17:902:aa08:b0:13f:eb2e:8ce8 with SMTP id\n\tbe8-20020a170902aa0800b0013feb2e8ce8mr7767148plb.0.1635480869621; \n\tThu, 28 Oct 2021 21:14:29 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 29 Oct 2021 13:14:18 +0900","Message-Id":"<20211029041424.1430886-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.33.1.1089.g2158813163f-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 0/6] Introduce clang thread safety\n\tannotations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This introduces clang thread safety annotations and applies it\nto libcamera Android HAL adaptation layer. It is necessary to add\nnew classes that wrap std::mutex and std::unique_lock with the\nannotations. It is because no C++ standard library annotates all\nthe mutex classes today. libstdc++ doesn't annotate any classes.\nlibc++ annotates for std::mutex, std::lock_guard and\nstd::scoped_lock, but doesn't for std::unique_lock.\n\nDocument: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html\n\nHirokazu Honda (6):\n libcamera: base: Add thread safety annotation macros\n libcamera: base: Add mutex classes with thread safety annotations\n android: camera_hal_manager: Add thread safety annotation\n android: camera_stream: Add thread safety annotation\n android: camera_device: Add thread safety annotation\n android: camera_request: Add thread safety annotation\n\n include/libcamera/base/meson.build | 2 +\n include/libcamera/base/mutex.h | 66 +++++++++\n include/libcamera/base/thread.h | 5 +-\n include/libcamera/base/thread_annotations.h | 151 ++++++++++++++++++++\n meson.build | 1 +\n src/android/camera_device.cpp | 26 ++--\n src/android/camera_device.h | 18 +--\n src/android/camera_hal_manager.cpp | 10 +-\n src/android/camera_hal_manager.h | 14 +-\n src/android/camera_request.h | 7 +-\n src/android/camera_stream.cpp | 22 +--\n src/android/camera_stream.h | 13 +-\n 12 files changed, 278 insertions(+), 57 deletions(-)\n create mode 100644 include/libcamera/base/mutex.h\n create mode 100644 include/libcamera/base/thread_annotations.h\n\n--\n2.33.1.1089.g2158813163f-goog"}