{"id":14302,"url":"https://patchwork.libcamera.org/api/covers/14302/?format=json","web_url":"https://patchwork.libcamera.org/cover/14302/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211026072148.164831-1-umang.jain@ideasonboard.com>","date":"2021-10-26T07:21:41","name":"[libcamera-devel,v8,0/7] Async Post Processor","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/14302/mbox/","series":[{"id":2654,"url":"https://patchwork.libcamera.org/api/series/2654/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2654","date":"2021-10-26T07:21:41","name":"Async Post Processor","version":8,"mbox":"https://patchwork.libcamera.org/series/2654/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/14302/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7BA9BF415\n\tfor ;\n\tTue, 26 Oct 2021 07:21:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3E1E64878;\n\tTue, 26 Oct 2021 09:21:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FD7E60123\n\tfor ;\n\tTue, 26 Oct 2021 09:21:55 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFFD43F0;\n\tTue, 26 Oct 2021 09:21:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZpcC8VAa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635232915;\n\tbh=PRcPuPi8CwiSZIlBFtl2hH9vxwH8UhgKXE0u/lZvqls=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ZpcC8VAaI+HEDig3sCCFey5Ap8TPHtBZF0ikzJcQwEPRQ0PNL0jEfObhFrXBSqRWu\n\ttE3VgQoIhQX8YIHSNJ6xmr9h8vhvCWUS3EeBIg4gZG7soxBh+M6rGW2hukjrOW2A1Y\n\t8Iqpv9bKabdShOZUlCgt0CMbMJYTfYLREY7m0fAY=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Oct 2021 12:51:41 +0530","Message-Id":"<20211026072148.164831-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 0/7] Async Post Processor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series primarily introduces a Thread worker class along\nwith a queue, in which request for post-process of streams\nare queued and processed ansychronously. All the context information\nis carried via Camera3RequestDescriptor.\n\n1/7 and 2/7 are improved !nullptr checks that were spotted in previous\nreview.\n\n3/7 under takes a refactor of splitting Camera3RequestDescriptor::Status\nto denote only status(success/error). The \"pending\" status is de-coupled\ninto a separate variable now.\n\n4/7 Consolidates all the information we need to run the post-processor\ninto Camera3RequestDescriptor::Stream. Now use this structure only and\nupdate signature of PostProcessor::process() vfunc.\n\n5/7 Introduces a post-processing request tracking std::map and a signal\nof completion. The tracking map will help us to know if there are\nmultiple post-processing streams per descriptor (i.e. capture request).\nIf so, we need to wait, track until all streams are processed. Only\nthen we can mark descriptor for completion.\n\n6/7 is a small inherent patch based on 5/7's change \n\n7/7 is where a post-processor's worker class is introduced. At this\npoint, the post-processor will run asynchronously.\n\n---------------------------------------------------------------------\n\nChanges v7 -> v8:\n- No functionality/logic change from v7\n- Fix few typos in commit & \\todo message on streamsProcessMutex_\n- Forward declare alphabetical order fix\n- Use { } in 7/7 for streamProcessMutex_ instead of calling .unlock()\n\nChanges v6 -> v7:\n- Remove all local boolean flags, hasPostProcessingErrors and\n needPostProcessing.\n- Code out internal buffer placing back into camera-stream from\n setBufferStatus\n- Use map.empty() instead of map.size() == 0\n- Make CameraStream::process() and PostProcessor::process() coherent\n- Few minor code migration from patch 5/7 to 7/7.\n\nUmang Jain (7):\n android: camera_stream: Replace post-processor nullptr check\n android: post_processor_jpeg: Replace encoder_ nullptr check\n android: camera_device: Refactor descriptor status and\n sendCaptureResults()\n android: post_processor: Consolidate contextual information\n android: Track and notify post processing of streams\n android: post_processor: Drop return value for process()\n android: post_processor: Make post processing async\n\n src/android/camera_device.cpp | 143 +++++++++++++---------\n src/android/camera_device.h | 5 +\n src/android/camera_request.cpp | 5 +-\n src/android/camera_request.h | 17 ++-\n src/android/camera_stream.cpp | 144 ++++++++++++++++++++---\n src/android/camera_stream.h | 42 ++++++-\n src/android/jpeg/post_processor_jpeg.cpp | 20 ++--\n src/android/jpeg/post_processor_jpeg.h | 4 +-\n src/android/post_processor.h | 16 ++-\n src/android/yuv/post_processor_yuv.cpp | 21 ++--\n src/android/yuv/post_processor_yuv.h | 4 +-\n 11 files changed, 310 insertions(+), 111 deletions(-)"}