[{"id":20378,"web_url":"https://patchwork.libcamera.org/comment/20378/","msgid":"<20211022100210.GH2066071@pyrite.rasen.tech>","date":"2021-10-22T10:02:10","subject":"Re: [libcamera-devel] [PATCH v3 0/2] Camera Control Validator","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Oct 20, 2021 at 02:33:51PM +0100, Kieran Bingham wrote:\n> These patches were part of an earlier series, which was partially\n> merged.\n> \n> As part of cleaning up the request prior to making it use the D-Pointer\n> implementation, clean up the todo and use a CameraControlValidator\n> provided by the Camera instead of creating a new one for each request.\n\nLooks good to me.\n\nFor both,\nReviewed-by: Paul Elder \n\n> \n> \n> Kieran Bingham (2):\n> libcamera: camera: Create a CameraControlValidator\n> libcamera: request: Use external CameraControlValidator\n> \n> include/libcamera/internal/camera.h | 6 ++++++\n> include/libcamera/request.h | 1 -\n> src/libcamera/camera.cpp | 7 +++++++\n> src/libcamera/request.cpp | 10 +++-------\n> 4 files changed, 16 insertions(+), 8 deletions(-)\n> \n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86D0EBF415\n\tfor ;\n\tFri, 22 Oct 2021 10:02:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4697B6023B;\n\tFri, 22 Oct 2021 12:02:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55A586012A\n\tfor ;\n\tFri, 22 Oct 2021 12:02:17 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BE3151D;\n\tFri, 22 Oct 2021 12:02:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sa+YGgTI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634896937;\n\tbh=FETSBpBrd0j0cLikDiU5uI8BVC+w624CFHx9DoZfG7E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sa+YGgTIzlTt30BNazDn5jmAZlM5XxvHjEvPmYvpbD6WeJUTG6FrKP82Muxrlpbeg\n\tA8DJtxR49LvGTxvMr0PgLmCIqShBWNAFm+Wp1Z0y5AtXTLOjYTxNbWWm8bZNZrgZxC\n\t6+rgIXAG+fLcnAwa1ybkqB6cbekQF5mJaBN+RM+0=","Date":"Fri, 22 Oct 2021 19:02:10 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20211022100210.GH2066071@pyrite.rasen.tech>","References":"<20211020133353.2500082-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211020133353.2500082-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] Camera Control Validator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]