[{"id":20054,"web_url":"https://patchwork.libcamera.org/comment/20054/","msgid":"","date":"2021-10-05T09:29:35","subject":"Re: [libcamera-devel] [PATCH v2 0/1] Raspberry Pi: Create empty\n\tcontrol lists correctly","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Tue, Oct 05, 2021 at 09:56:59AM +0100, David Plowman wrote:\n> Hi Laurent, everyone\n> \n> Here's the v2 of this that I had promised, which patches another\n> identical problem that occurs only when you stop and restart the\n> camera (actually passing a ControlList back from the IPA).\n> \n> I took your suggestion, Laurent, as it was closer to the original, and\n> also your \"reviewed-by\" tag in spite of the extra change, but\n> obviously please still comment if necessary!\n\nI've reviewed v2 and it looks good to me.\n\n> As regards the ControlLists, it would be nice if the non-isolated\n> \"thread\" version of the IPAProxy could complain in the same\n> circumstances as the IPC version. Not sure what the best way is to\n> ensure that, calling the serializer \"just for fun\" sounds a bit like\n> overkill. Maybe only for start/configure methods that don't run\n> repeatedly? Or only in debug builds? Or something else more cunning?\n> Perhaps a question for another time...\n\nI see your point, increasing test coverage is always good. Wouldn't this\nhowever be better handled by running a tool such as lc-compliance in\nisolated mode, as part of the overall test strategy ?\n\n> David Plowman (1):\n> pipeline: raspberrypi: Create empty control lists correctly\n> \n> src/ipa/raspberrypi/raspberrypi.cpp | 13 +++++++++----\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> 2 files changed, 11 insertions(+), 5 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 366A3BDC71\n\tfor ;\n\tTue, 5 Oct 2021 09:29:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0842D691B9;\n\tTue, 5 Oct 2021 11:29:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3BB6684C6\n\tfor ;\n\tTue, 5 Oct 2021 11:29:42 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A4AE25B;\n\tTue, 5 Oct 2021 11:29:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OXn0Dqdt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633426182;\n\tbh=YOgQHxGHI8ZTSeyebvKB7IIdX/qd986yBvebLjTmUVM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OXn0Dqdt1Gq33RHArP8xaXkAHoj+Z3DCwRqKQojW9h1PCju0fBtQW1B9iQWZeVgOA\n\texS1AuE/8c/g7deQjXK2RM6o556g0x6+0z0Xfm3W2ZuSi8GpTHtg1c92TQT2cBpl3H\n\tBOjRl3PjBFzoe7nI3xexmxqoZ9+3UbVvRvgQM8QQ=","Date":"Tue, 5 Oct 2021 12:29:35 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20211005085700.16708-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211005085700.16708-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/1] Raspberry Pi: Create empty\n\tcontrol lists correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20067,"web_url":"https://patchwork.libcamera.org/comment/20067/","msgid":"","date":"2021-10-05T10:32:44","subject":"Re: [libcamera-devel] [PATCH v2 0/1] Raspberry Pi: Create empty\n\tcontrol lists correctly","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nOn Tue, 5 Oct 2021 at 10:29, Laurent Pinchart\n wrote:\n>\n> Hi David,\n>\n> On Tue, Oct 05, 2021 at 09:56:59AM +0100, David Plowman wrote:\n> > Hi Laurent, everyone\n> >\n> > Here's the v2 of this that I had promised, which patches another\n> > identical problem that occurs only when you stop and restart the\n> > camera (actually passing a ControlList back from the IPA).\n> >\n> > I took your suggestion, Laurent, as it was closer to the original, and\n> > also your \"reviewed-by\" tag in spite of the extra change, but\n> > obviously please still comment if necessary!\n>\n> I've reviewed v2 and it looks good to me.\n>\n> > As regards the ControlLists, it would be nice if the non-isolated\n> > \"thread\" version of the IPAProxy could complain in the same\n> > circumstances as the IPC version. Not sure what the best way is to\n> > ensure that, calling the serializer \"just for fun\" sounds a bit like\n> > overkill. Maybe only for start/configure methods that don't run\n> > repeatedly? Or only in debug builds? Or something else more cunning?\n> > Perhaps a question for another time...\n>\n> I see your point, increasing test coverage is always good. Wouldn't this\n> however be better handled by running a tool such as lc-compliance in\n> isolated mode, as part of the overall test strategy ?\n\nYes, that sounds fair to me. I see it's easy enough to force isolation\nmode with that environment variable, so maybe I shall add something to\nour own testing too.\n\nDavid\n\n>\n> > David Plowman (1):\n> > pipeline: raspberrypi: Create empty control lists correctly\n> >\n> > src/ipa/raspberrypi/raspberrypi.cpp | 13 +++++++++----\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> > 2 files changed, 11 insertions(+), 5 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D91B8BDC71\n\tfor ;\n\tTue, 5 Oct 2021 10:32:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FA58691BA;\n\tTue, 5 Oct 2021 12:32:57 +0200 (CEST)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DBB7684C6\n\tfor ;\n\tTue, 5 Oct 2021 12:32:55 +0200 (CEST)","by mail-wr1-x42b.google.com with SMTP id k7so36307962wrd.13\n\tfor ;\n\tTue, 05 Oct 2021 03:32:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RKjwwItg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=N1WDtnroTzOSXuumK3MP5UFsGCIqGKXFTqykPF7oLqU=;\n\tb=RKjwwItg8DZJgfmMeq4mKX3Z4AjxgA5sVzmhgBbNFsloY7qPKMirU67Ivd6Aog7gMp\n\tc3b5tjFZ0yBzRVu5KcMLRdKv8lHXAooy5DhRgQkWb+piI4OO207IeuNSexU8ATEhk5qk\n\tlXA2q50Op0DK8l5rBE4guUYGMWHBjREx0wxrocWzlhtsoPEK/DIfA+yPGtkMevyLTPaa\n\t0VHVM5VHadP4Z09MmXRR6NFWKxziGz8VnbnBMFADMc77XFic176iahvA0sVFcX4diyMn\n\tNg4mFt3+K/hYi9l/5briZwpANCSa6Ix3fzSbzLIgTuizxweQKKorQ9i/1KMQlLgHntV9\n\tbDnw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=N1WDtnroTzOSXuumK3MP5UFsGCIqGKXFTqykPF7oLqU=;\n\tb=wOSRCIgO8ieQJilS9fM7WuFssdUNhg1oAOcFIy7YDTsFiOCs8ZziOP4Jrc4GE8ENFW\n\tv61QrSGLNUMf2JKeRjMP/z6zQTKne4nR6rkeKGSqctpt3LI4Nm65VbH7jboxaeRAYpzr\n\tq3deh2A+Tt63IYdgZwKdNT0UFjdBOqEtiH8PANwJm/uWw709hFvhE94OcG7Gbx8zv+Oj\n\tjZMyH1shR/v+K8eY1G4zN5e8Ga2dNMc1jvy0QeMCqu8cbKsgI91aeDr2Muo+zHgQLbr7\n\tiZB10blGtyGq6zFLT52Uw9v/6okgfRFo+rPBcQQp6HUCP2EQGGlrgCeXnRhURijoLFC0\n\t1DlQ==","X-Gm-Message-State":"AOAM532a05o3XZFDYlQYZEfr3MvTzOfTE0xprsrsVk2zB+amvkMCLbFi\n\tE0PWG9e85CSA1k3lEcxA6ROpzrnLir363Ps3sooLRAWtslfLAg==","X-Google-Smtp-Source":"ABdhPJzxFV+tYFtrvAKEkqYPNtWzzLXn/f+BoLOnGKdnbrCskCarSZXUGEhdXO0EE3mdrl2NvYWStTx+G/C1GKYzzpg=","X-Received":"by 2002:a5d:4212:: with SMTP id\n\tn18mr20070641wrq.162.1633429974938; \n\tTue, 05 Oct 2021 03:32:54 -0700 (PDT)","MIME-Version":"1.0","References":"<20211005085700.16708-1-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Tue, 5 Oct 2021 11:32:44 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 0/1] Raspberry Pi: Create empty\n\tcontrol lists correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]