[{"id":20625,"web_url":"https://patchwork.libcamera.org/comment/20625/","msgid":"<163549645140.12048.3562194971070222424@Monstersaurus>","date":"2021-10-29T08:34:11","subject":"Re: [libcamera-devel] [PATCH v2 0/7] The Great AE Changes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2021-10-01 11:33:18)\n> This patch series aims to solve all our AE problems.\n> \n> The most important patches are 1/7, 6/7, and 7/7.\n> \n> 1/7 defines the new AE controls, and replaces the old ones. This will\n> not compile without 2/7 to 5/7. 1/7 did not have any reviews so I'm\n> putting it in this series.\n\nAh, ok - so you know about the breakage ;-)\n\n> 6/7 plumbs the AE controls through the HAL layer. It is fairly large and\n> complex.\n> \n> 7/7 plumbs the sensitivity-related controls, which are also related to\n> the AE controls, which is why it is included in this series. It also did\n> not have any reviews, so it's being grouped with this series.\n> \n> These have yet to be tested against CTS, but the theory should be\n> correct.\n\nI can run an integration test on a branch if you like.\n\n> Paul Elder (7):\n> controls: Reorganize the AE-related controls\n> libcamera: pipeline: uvcvideo: Support the new AE controls\n> libcamera: pipeline: raspberrypi: Support the new AE controls\n> test: ipa_data_serializer: Remove controls::AeEnable\n> libcamera: pipeline: rkisp1: Support the new AE controls\n> android: Plumb all AE-related controls\n> android: Plumb all sensitivity-related controls\n> \n> include/libcamera/ipa/raspberrypi.h | 3 +-\n> src/android/camera_capabilities.cpp | 124 ++++++++--\n> src/android/camera_capabilities.h | 3 +-\n> src/android/camera_device.cpp | 174 +++++++++++++-\n> src/android/camera_device.h | 17 ++\n> src/android/camera_hal_config.cpp | 10 +-\n> src/android/camera_hal_config.h | 1 +\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 18 +-\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 5 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 42 +++-\n> src/ipa/rkisp1/rkisp1.cpp | 18 +-\n> src/libcamera/control_ids.yaml | 215 ++++++++++++------\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +-\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 36 ++-\n> .../ipa_data_serializer_test.cpp | 1 -\n> 15 files changed, 559 insertions(+), 112 deletions(-)\n> \n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D54BBDB1C\n\tfor ;\n\tFri, 29 Oct 2021 08:34:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A05B3600BB;\n\tFri, 29 Oct 2021 10:34:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EAA0600B4\n\tfor ;\n\tFri, 29 Oct 2021 10:34:14 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EBD443E5;\n\tFri, 29 Oct 2021 10:34:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hc+PSFg5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635496454;\n\tbh=0i6+vMPXSXSuAkrgpKe9yHFVCFCsZo1e1aic7uZcao0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=hc+PSFg5m2OOcb5qJtACRJG+2aps1Jyf7FxdkcgQ7ncKS5Rm3vx5m9YE8g68U4Bfg\n\thYLKQ+UsFkRYDNEeoNrVcEfz/4fV3Xs4pCwwMN6C86qCs3A+pvPlW323mw6kuhwD9G\n\typbWFX5d7WUdUN+SBokJAfZm38Opeb2BWSXoPYF4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211001103325.1077590-1-paul.elder@ideasonboard.com>","References":"<20211001103325.1077590-1-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 29 Oct 2021 09:34:11 +0100","Message-ID":"<163549645140.12048.3562194971070222424@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v2 0/7] The Great AE Changes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]