[{"id":12,"web_url":"https://patchwork.libcamera.org/comment/12/","msgid":"<20181126161846.GP1158@bigcity.dyn.berto.se>","date":"2018-11-26T16:18:46","subject":"Re: [libcamera-devel] [PATCH 0/2] library install targets","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nNice work.\n\nOn 2018-11-26 14:01:09 +0000, Kieran Bingham wrote:\n> The initial framework doesn't install the library when the builder\n> invokes 'ninja install'. Fix this and update the installation of\n> headers.\n\nFor the whole series:\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> \n> Kieran Bingham (2):\n>   lib: Include library in the install target\n>   include: Install include files\n> \n>  include/{ => libcamera}/libcamera.h | 0\n>  include/libcamera/meson.build       | 6 ++++++\n>  include/meson.build                 | 1 +\n>  lib/meson.build                     | 1 +\n>  meson.build                         | 1 +\n>  test/init.cpp                       | 2 +-\n>  6 files changed, 10 insertions(+), 1 deletion(-)\n>  rename include/{ => libcamera}/libcamera.h (100%)\n>  create mode 100644 include/libcamera/meson.build\n>  create mode 100644 include/meson.build\n> \n> -- \n> 2.17.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D47A60B0B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Nov 2018 17:19:18 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id b20so13968705lfa.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Nov 2018 08:19:18 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tp19-v6sm123632ljb.47.2018.11.26.08.18.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 26 Nov 2018 08:19:05 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=hPpqmbd+VVSp9AfmQaeKUQ62z1gWadne+yBFg/WHU+A=;\n\tb=tmt3pQ4drUeAdl3m8hV28GGabUhquAo32SIzeupEMzKbBTdd26l8G08F4OVDEcmEjp\n\txOuRKiCcuZ77CbGC4teDvzOc/w3bLwlUrFDyYQ8kJS+R5DtV+SPH+o9GXmuqx4lT0x5i\n\t/SsB9SmjDsTHDVgu/PyHEzauNxG8g2e57tCj6CSl2l221zz1HL1vOIVjXcBuEBbbZrO8\n\tn6dJZDIcTF/I48I+U3zK5VmKsQWppD+CkuAOLBMrObMwnFrBaeKbNOozk1717AuPuahZ\n\tgWk14x9BHm33xcDsUYveJqqZ+CN2iZJj8EXbIG5g2uLCXEbwzYl7OYuPfo9W6peGoANS\n\tj1Sg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=hPpqmbd+VVSp9AfmQaeKUQ62z1gWadne+yBFg/WHU+A=;\n\tb=RNPgc6ItbgsAp9mUUd6k42BCTsUbZWO5b6YjbQtySxSUtRig9UKHgRgXh2FYsOzCmN\n\tq0YYUyb6Frwlf5G45s5QFFY8KoMQ5tAQAlz/3+J7Q9MXQnRAbVBF6s4HVMon55BDVlrk\n\tNo0IVY2dCZmE5FsbbFcqCazpyebw63Y158emUjQC7HtBFH9pW7GwKULjcfX1aK4MN9fT\n\tvQYSDOnXuXo8Kg/NTOu+k1t/plFw8g42PQ1/BzjRAMvdtQDfWj4IEgAndcgDuAbSV5ap\n\tCBssatU/Zmk/9p+fUm0bUy5TJTsNv52UaoBpO61mGTaKkSTgDojRHtjXorKvesXpK4sW\n\tk3Bw==","X-Gm-Message-State":"AGRZ1gKN0i8FTT0HFumQ0BYMkg7GUu7+KA0xYKJ8THxgMrjcL1ifUJ1h\n\tztI6O78O0XktIDMzfQZPmOeJ4hQJtEc=","X-Google-Smtp-Source":"AJdET5elWR+sg72JgoxNEmCLSl7MV6krqdHAxTA4f+5ajMxWVCDhowE/rS0IhnKteMl92jh5r7NhUA==","X-Received":"by 2002:a19:59c2:: with SMTP id\n\tn185mr15488912lfb.118.1543249157484; \n\tMon, 26 Nov 2018 08:19:17 -0800 (PST)","Date":"Mon, 26 Nov 2018 17:18:46 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20181126161846.GP1158@bigcity.dyn.berto.se>","References":"<20181126140111.13255-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20181126140111.13255-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/2] library install targets","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 26 Nov 2018 16:19:18 -0000"}}]