{"id":13973,"url":"https://patchwork.libcamera.org/api/covers/13973/?format=json","web_url":"https://patchwork.libcamera.org/cover/13973/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210929071708.299946-1-umang.jain@ideasonboard.com>","date":"2021-09-29T07:17:05","name":"[libcamera-devel,v3,0/3] Camera3RequestDescriptors std::map => std::queue","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13973/mbox/","series":[{"id":2584,"url":"https://patchwork.libcamera.org/api/series/2584/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2584","date":"2021-09-29T07:17:05","name":"Camera3RequestDescriptors std::map => std::queue","version":3,"mbox":"https://patchwork.libcamera.org/series/2584/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13973/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 464CFBDC71\n\tfor ;\n\tWed, 29 Sep 2021 07:17:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87E3969191;\n\tWed, 29 Sep 2021 09:17:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08D846918A\n\tfor ;\n\tWed, 29 Sep 2021 09:17:16 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D535E3F0;\n\tWed, 29 Sep 2021 09:17:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wm3rW1G2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632899835;\n\tbh=Jv8MKs+S3xorRQndzIkgEcNnwZzRh+U7RBePwGmOfcc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=wm3rW1G2TygRI6PaqSTC3CyfP2ahzZzpEAOGJ2F2VaFniq6gOHqlKYlFFFI7J5BTD\n\tsl8ActGOkDWUrWTx33XD0GxQNxcq098tjZH9JZl++7UVsMbj2KTKe39QsQLmGgrBvw\n\tozljvFtAAQYjpXUjB8F8kYZ5Nv+8HPb8to3e2pKE=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 29 Sep 2021 12:47:05 +0530","Message-Id":"<20210929071708.299946-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 0/3] Camera3RequestDescriptors std::map\n\t=> std::queue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"As per the extended design discussion for libcamera HAL, this series\naddresses the part I of the design that will lead to new iterations\nfor async post-processor eventually.\n\nThe series mainly ports storage of Camera3RequestDescriptor from\nstd::map => queue while fixing out-of-order request completion from\nabortRequest(). The series also accounts for a singular location to\nsend back capture results to the framework (find sendCaptureResults()).\n\nThe series has been validated on CTS: 229 / 231\n(carrying [PATCH v3 0/1] android: Wait on acquisition fences in\nCameraStream)\n\n\\wip: Checkstyle isn't happy with 2/3's camera_device.h, not sure why! \n\nChanges in v3:\n- Change abortRequest to accept a descriptor only, in 3/3\n- Fix wrong logic around abortRequest() descriptor selection\n - Last request descriptor was selected instead of current one\n- Use of `auto` whereever applicable\n- simplify descriptors_ clearance on stop()\n\nChanges in v2:\n- Use queue instead of deque\n- Fix a race between abortRequest() and queuing a descriptor in 2/3\n- address general comments in v1 review.\n\nUmang Jain (3):\n android: camera_worker: Use Camera3RequestDescriptor as cookie\n android: camera_device: Transform descriptors_ map to queue\n android: camera_device: Send capture results by inspecting the queue\n\n src/android/camera_device.cpp | 140 ++++++++++++++++++++--------------\n src/android/camera_device.h | 17 ++++-\n src/android/camera_worker.cpp | 4 +-\n src/android/camera_worker.h | 3 +-\n 4 files changed, 102 insertions(+), 62 deletions(-)"}