[{"id":19293,"web_url":"https://patchwork.libcamera.org/comment/19293/","msgid":"<87580ae0-b9a4-1b43-791b-25d0831cc36a@ideasonboard.com>","date":"2021-09-02T13:46:28","subject":"Re: [libcamera-devel] [PATCH v2 3/4] ipa: ipu3: Replace\n\tAccumulator::uncounted to Accumulator::total","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 02/09/2021 14:43, Jean-Michel Hautbois wrote:\n> Replace uncounted by total as it is clearer on what it contains. It is\n> always possible to know how many pixels are not relevant for the\n> algorithm by calculating total-counted. The uncounted field was only\n> declared and not used.\n\nWhy aren't we removing this entirely ?\n\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 6 +++---\n> src/ipa/ipu3/algorithms/awb.h | 2 +-\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index c5c04a32..061b3610 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -42,8 +42,8 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;\n> * \\var Accumulator::counted\n> * \\brief Number of relevant regions used to calculate the sums\n> *\n> - * \\var Accumulator::uncounted\n> - * \\brief Remaining number of regions in the zone\n> + * \\var Accumulator::total\n> + * \\brief Total number of regions in the zone\n> *\n> * \\var Accumulator::rSum\n> * \\brief Sum of the red values in the zone\n> @@ -227,7 +227,7 @@ void Awb::clearAwbStats()\n> \t\tawbStats_[i].rSum = 0;\n> \t\tawbStats_[i].gSum = 0;\n> \t\tawbStats_[i].counted = 0;\n> -\t\tawbStats_[i].uncounted = 0;\n> +\t\tawbStats_[i].total = 0;\n> \t}\n> }\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\n> index 6ae934fc..13490b07 100644\n> --- a/src/ipa/ipu3/algorithms/awb.h\n> +++ b/src/ipa/ipu3/algorithms/awb.h\n> @@ -35,7 +35,7 @@ struct Ipu3AwbCell {\n> \n> struct Accumulator {\n> \tunsigned int counted;\n> -\tunsigned int uncounted;\n> +\tunsigned int total;\n> \tunsigned long long rSum;\n> \tunsigned long long gSum;\n> \tunsigned long long bSum;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2CF6BDC71\n\tfor ;\n\tThu, 2 Sep 2021 13:46:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A5816916A;\n\tThu, 2 Sep 2021 15:46:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D825F60255\n\tfor ;\n\tThu, 2 Sep 2021 15:46:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 698C58F;\n\tThu, 2 Sep 2021 15:46:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v3rZxTjS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630590391;\n\tbh=XNyqnbeb7ZBumuo9TRp/g1SIraWll6PmkOvG+AjB7fM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=v3rZxTjSbOEL6hqyOF3XgOZvjLX8BgOz9oBO71DoYyBFDXZIC01MBBFNX5H5uOY3h\n\tReYhiJOrbEQ9Y5Ag2wgfCELmZQboNL/NJffXC+K8lQJOw2QtAHDvwp7fPMRtRTQYH0\n\t1nWXVSI8Z/0i06/vKaR9covvDoVJ9cR6LS/xJ03M=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210902134353.80920-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210902134353.80920-4-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<87580ae0-b9a4-1b43-791b-25d0831cc36a@ideasonboard.com>","Date":"Thu, 2 Sep 2021 14:46:28 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210902134353.80920-4-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] ipa: ipu3: Replace\n\tAccumulator::uncounted to Accumulator::total","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]